- 06 Aug, 2018 38 commits
-
-
Matt Falkenhagen authored
This test has flaky timeouts on Fuchsia bots. Bug: 862294 Change-Id: I19e164ecbac86347b9756e55c92e7a59da05dddd Reviewed-on: https://chromium-review.googlesource.com/1163046Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#580825}
-
Tetsui Ohkubo authored
According to UX spec, notifications scroll behind SystemTray part of UnifiedSystemTray. Technically it is hard to implement this naively, because ARC++ notifications use NativeViewHost which ignores views layer hierarchy. In this CL, we just paint the background of SystemTray corners with the same color as notification's. It looks natural to users while avoiding complexity other hacks to fix the issue would add. TEST=manual BUG=863494 Change-Id: I65147a0b8fd9bb2400f79b6bb6cbfea4fb13db33 Reviewed-on: https://chromium-review.googlesource.com/1161710Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#580824}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I83202210a016a62b421c4cf0d864614d2b2e6e45 Reviewed-on: https://chromium-review.googlesource.com/1163297Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580823}
-
Adam Rice authored
Update WritableStream to standard version https://github.com/whatwg/streams/commit/51227372cc84846bdcf68312724c4cac6a4b9e58 Remove failing test expectations. Changes: The timing of access of strategy parameters has been changed to match the standard. This mostly only affects the tests that are looking for it. Algorithms are cleared out once they will no longer be called, enabling garbage collection. Bug: 866388 Change-Id: I948a858c101960bd19c826f9d8764575d5360c66 Reviewed-on: https://chromium-review.googlesource.com/1146622Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580822}
-
Oscar Johansson authored
When building using jumbo, files gets merged and constants with the same name may end up in the same namespace and conflict. This happens for: chrome/renderer/chrome_content_renderer_client.cc chrome/renderer/extensions/extension_hooks_delegate.cc chrome/renderer/extensions/tabs_hooks_delegate.cc This commit solves the issue by renaming the constants to something more file specific. Bug: 870617 Change-Id: I3ded3625b3851724362d496191c5bd25dda081f6 Reviewed-on: https://chromium-review.googlesource.com/1161803Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#580821}
-
Adam Rice authored
I removed these histograms in March 2017 in https://codereview.chromium.org/2764683002 but I forgot to mark them as obsolete in histograms.xml. Mark them as obsolete. BUG=700568 Change-Id: I76e83d25ea45488ae8631c6402171dda3e61f987 Reviewed-on: https://chromium-review.googlesource.com/1161719Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580820}
-
Marina Ciocea authored
This reverts commit eab3705f. Reason for revert: regression reported in https://crbug.com/870171 Original change's description: > Delay audio service launch on the browser startup. > > (see the bug) From the traces the service/process creation gets posted to the > IO thread during startup. > It may be delaying startup for some other services needed for the first paint, or it may be > just eating up CPU when the load is already quite high. We'll experiment with delaying > the service launch. > > Bug: 867461 > Change-Id: I048e33d049e665d8e9489046c5813918d8077524 > Reviewed-on: https://chromium-review.googlesource.com/1153248 > Commit-Queue: Olga Sharonova <olka@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579460} TBR=gab@chromium.org,olka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 867461 Change-Id: If0751dd76f8e880d0fc8454c6707778de5ce6685 Reviewed-on: https://chromium-review.googlesource.com/1162183Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580819}
-
Marc Treib authored
ProfileSyncService::Initialize used to early-out if DISABLE_REASON_PLATFORM_OVERRIDE or DISABLE_REASON_ENTERPRISE_POLICY were present. However: - In practice, platform_sync_allowed_provider_ isn't set at this point, so DISABLE_REASON_PLATFORM_OVERRIDE will never occur. Even if it did, calling StopImpl(KEEP_DATA) at this point (before |engine_| exists) does nothing. - Both disable reasons can disappear during Chrome's lifetime, in which case ProfileSyncService is left in a half-initialized state. In particular, it won't be listening for auth events. This CL removes handling for DISABLE_REASON_PLATFORM_OVERRIDE, and does not early-out anymore for DISABLE_REASON_ENTERPRISE_POLICY. Bug: 870683 Change-Id: I354629deaa42a782e10658190c84e967fee593a3 Reviewed-on: https://chromium-review.googlesource.com/1162236Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580818}
-
David Staessens authored
Currently the jpeg decoder always assumes the VAAPI will support decoding to the I420 format. As this might not be the case for all VAAPI implementations this change adds a method to the VAAPI wrapper to check whether a specific format is supported. Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8ad54a27b9e1d560f5590ae778e43f8d75bba8e9 Reviewed-on: https://chromium-review.googlesource.com/1102277 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#580817}
-
Kunihiko Sakamoto authored
Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen* as Failure on Android TBR=mcnee@chromium.org No-Try: true Bug: 871139 Change-Id: If29b18d3297e306364b87f0c2582bab476c35c68 Reviewed-on: https://chromium-review.googlesource.com/1163408Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580816}
-
Darren Shen authored
Currently, when we disable the keyboard, we directly reset the state back to UNKNOWN without logging or validation. This means that in the UMA metrics for state transitions, the transitions going into a state does not add up to the transitions going out of a state. This patch explicitly changes the state back to INITIAL when the keyboard is disabled. When the keyboard is about to be disabled, the only valid states are INITIAL, LOADING and HIDDEN. We don't change if the current state is INITIAL to avoid self-transitions. Bug: 775354 Change-Id: Idab146e017d179a9086808481f3ed65b6f0dfbcf Reviewed-on: https://chromium-review.googlesource.com/1163346Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#580815}
-
Kouhei Ueno authored
Bug: 868592 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5cff4653a62c357e8eb9d5a82a11b8018653b712 Reviewed-on: https://chromium-review.googlesource.com/1163235Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Hayato Ito authored
https://bugs.webkit.org/show_bug.cgi?id=82702 was already closed. We can remove this old FIXME. TBR=rakina Change-Id: Ib04660f4cb4be99c68a71d935de4d8bf429716ce Reviewed-on: https://chromium-review.googlesource.com/1163343Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580813}
-
Hayato Ito authored
Change-Id: Icd3665e37131c31c584a97355b3f74d76b0f34ff Reviewed-on: https://chromium-review.googlesource.com/1162084Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580812}
-
Chih-Yu Huang authored
When VDA enqueue flush input buffer to the Tegra driver before enqueuing any normal input buffer, Tegra driver will stuck. Now for the devices which do not support V4L2 decoder command, if we call Flush() before decoding any buffer, we skip sending an empty buffer to the driver and notify flush is done. BUG=chromium:845627 TEST=pass video_decode_accelerator_unittest on nyan-big and peach-pit Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I34a5ec76d95fac8f5bedd3ead08202b1a4e41dcd Reviewed-on: https://chromium-review.googlesource.com/1127559 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580811}
-
Hayato Ito authored
Change-Id: I8cfd1db4b3b48b69c478a0bc5a60402e035272eb Reviewed-on: https://chromium-review.googlesource.com/1162085Reviewed-by:
-
Ramin Halavati authored
Preferences related to Arc are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I45d5f5bb40841c386d39709d9da80ca431b2a2e1 Reviewed-on: https://chromium-review.googlesource.com/1158069Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580809}
-
Yuki Yamada authored
Removed V8WorkerOrWorkletEventListener::HandleEvent() in order to remove blink::V8WorkerOrWorkletEventListener. The difference between V8AbstractEventListener::HandleEvent() and V8WorkerOrWorkletEventListener::HandleEvent() was checking if script controller is available or not. This should be done in not only V8WorkerOrWorkletEventListener but also other event listeners, so this CL added this operation by checking ScriptState::ContextIsValid(). Bug: 869778 Change-Id: I3168f9990d2c6d076061b4d7d8f9ab85619f71d5 Reviewed-on: https://chromium-review.googlesource.com/1160069Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#580808}
-
Hayato Ito authored
These comments don't make sense at this point. No behavior change. Just removing comments. TBR=rakina Change-Id: I39b0097f45775551ef1614cd4b4efdfce9f41146 Reviewed-on: https://chromium-review.googlesource.com/1163341Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit 94558b66. Reason for revert: Findit thinks this made the following tests flaky: TabRestoreTest.RestoreWindowBounds (crbug.com/870945) BrowserNavigatorTest.Disposition_NewPopupFromAppPopup (crbug.com/871010) Original change's description: > [NTP] Adds an experiment for M69 NTP features. > > Only the first experiment entry gets covered by perf waterfall, so adding > this item ensures better test coverage. Also, the existing experiment, > NewTabPageAllBirthday_Enabled, could not be re-used since > go/revising-finch-configs recommends creating a new experiment when > changing size or behavior of existing groups. > > Bug: 831910 > Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 > Reviewed-on: https://chromium-review.googlesource.com/1160925 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580314} TBR=holte@chromium.org,ramyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831910,870945,871010 Change-Id: Ifb86fbc322d939eba40f84b1ee32a21d76361f86 Reviewed-on: https://chromium-review.googlesource.com/1163361Reviewed-by:
-
Takashi Toyoshima authored
Bug: none Change-Id: Ia12fd5e686b2642a37ac30a372d0a54394310e47 Reviewed-on: https://chromium-review.googlesource.com/1157962Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Dominic Farolino authored
There is no observable result of this change. Before this CL, ModuleScriptFetchRequest stored a blink::Referrer and a blink::ScriptFetchOptions. This effectively stored two blink::ReferrerPolicy members under ModuleScriptFetchRequest. We also generated ModuleScriptFetchRequest's Referrer in two different places in ModuleTreeLinker. Finally ModuleScriptFetchRequest's Referrer member was used in ModuleScriptLoader::FetchInternal to set ResourceRequest's referrer header. After this CL, we store only a referrer string in ModuleScriptFetchRequest, as the spec indicates, and do not generate a blink::Referrer in ModuleTreeLinker. Then in ModuleScriptLoader::FetchInternal, we generate and set ResourceRequest's final referrer. This also leaves a TODO, to stop storing ResourceRequest's referrer as a header value. R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org Bug: 863769 Change-Id: Id22467f5c93e59b33ca01571addeceb1a505a1af Reviewed-on: https://chromium-review.googlesource.com/1157237 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580804}
-
Yoichi Osato authored
Since "rendered position" is ambiguous, this patch renames it to simply the function name implemented in the file. Bug: 789870 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I98d310b092edc0983ec03012f32c81f60224d2e0 Reviewed-on: https://chromium-review.googlesource.com/1160070Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#580803}
-
Eric Willigers authored
Keywords for the following properties now serialize in lower case: - color-rendering - image-rendering - shape-rendering - text-rendering https://drafts.csswg.org/cssom/#serializing-css-values "To serialize a CSS component value depends on the component, as follows: keyword The keyword converted to ASCII lowercase." Firefox and Edge already serialize such properties in lower case. BUG=863741 Change-Id: Idca31224b0f0186d76ddca814ffb913d46c8a4f9 Reviewed-on: https://chromium-review.googlesource.com/1163047Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#580802}
-
Takashi Sakamoto authored
Bug: 810293 Change-Id: I0fdbb07ef9ebf78c964f9ffeb68dc21f9675bdb7 Reviewed-on: https://chromium-review.googlesource.com/1158112 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
-
Andrew Moylan authored
ML Service is being configured to launch automatically via D-Bus service activation (crrev.com/c/1163227 and crrev.com/c/1163228), instead of launching at boot time. Therefore, we won't need to WaitForServiceToBeAvailable any more. Tested by: Test build with CrOS CLs above & a modified Chrome that calls ML Service a few times. Bug: 863781 Change-Id: I508ee505705de14332b1cdf4e5b0b29c04937c7b Reviewed-on: https://chromium-review.googlesource.com/1163229Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580800}
-
Devlin Cronin authored
Extract C++ type generation from the json_schema_api gni template into a separate generate_types gni template. This has the advantage of cleaning up which arguments are necessary and used for the template, as well as being able to isolate the different generation steps (which may have different dependencies or dependents). As part of this, introduce separate "bulk" `api` targets in each of the API directories, which each dependent can depend on. This obviates the need to depend on e.g. `api` and `api_registration`. A follow up will break up the JSON string generation bundle and the extension function registration bundle. Bug: 864576 Change-Id: I50a1fbe059ec5b7d73c405b230a221c1c6ce3af1 Reviewed-on: https://chromium-review.googlesource.com/1150930 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580799}
-
Jia authored
We will need the same bucketization during inference. Hence move common code to the helper file to avoid code duplication and also to ensure consistency. Bug: 862461 Change-Id: I75e53c6a409ce7f61383637b783158abd7f59e32 Reviewed-on: https://chromium-review.googlesource.com/1154607 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580798}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If380e8785994c0c0108909f029ab0d048c38a941 Reviewed-on: https://chromium-review.googlesource.com/1163291 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I89ed1b22333f20f9d54100dbfb043dc0127f228f Reviewed-on: https://chromium-review.googlesource.com/1163303Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#580796}
-
Shu Chen authored
Bug: 733825 Change-Id: I4232ab3e2d55a03d1522971a544374a3aae2c7ed Reviewed-on: https://chromium-review.googlesource.com/1128780 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#580795}
-
Jakub Pawlowski authored
If libbase is compiled with -Wmissing-field-initializers this is causing warning to be generated. Change-Id: I446160d4c94bb59dd23f2f151004a8bfaeae832d Reviewed-on: https://chromium-review.googlesource.com/1161927Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580794}
-
Kunihiko Sakamoto authored
This reverts commit dc7c0730. Reason for revert: suspected of breakage in 'browser_tests' on Mac: crbug.com/871106 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761 Original change's description: > [Mac] Bring up the audio service sandbox. > > This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox > > Bug: 850878 > Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198 > Reviewed-on: https://chromium-review.googlesource.com/1152080 > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580672} TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850878,871106 Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89 Reviewed-on: https://chromium-review.googlesource.com/1163230Reviewed-by:
-
Alexey Baskakov authored
Erase web_app_extension_helpers.h in favor of web_app_helpers.h Rename legacy helpers. TBR=lazyboy@chromium.org Bug: 860581 Change-Id: I67799d5d8ef79ce55e3d8f8b5acb51c59afc662b Reviewed-on: https://chromium-review.googlesource.com/1161707 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#580792}
-
Kunihiko Sakamoto authored
Mark virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html as Failure on Linux Failing on Linux (dbg) too. TBR=hbos@chromium.org No-Try: true Bug: 832842 Change-Id: I6eaa6c2814046a5452ab0a2d63524b6650f6803b Reviewed-on: https://chromium-review.googlesource.com/1163236Reviewed-by:
-
Devlin Cronin authored
Event argument massagers are passed a function to dispatch the event. We need to ensure the arguments are returned to the caller, similar to how calling dispatch() on the event itself would be treated. This is necessary for the input IME custom bindings. Wire this up, and add a unit test for the same. Bug: 867310 Change-Id: I48841d60cb4940a15cd439ce6c4ea156eeeeaab6 Reviewed-on: https://chromium-review.googlesource.com/1150410 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580790}
-
Giovanni Ortuño Urquidi authored
Adds a function to start the installation of an app and implements it for PendingBookmarkAppManager. If there is an app being installed the installation is delayed until the current installation finishes. Bug: 864904 Change-Id: I2397b243dd8065eb67edd055536305e8da0201a1 Reviewed-on: https://chromium-review.googlesource.com/1157948 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Gabriel Charette authored
(and a few minor git-cl-formats-du-jour + spot fixes to make new presubmit checks happy) (and make thread_restrictions.h presubmits only warnings -- I've been realizing that making migration presubmits error is a bit too aggressive specifically because it hinders migrations like these and have been dialing them down, this one was left behind) This finalizes the structure for base/task as planned @ https://docs.google.com/document/d/1h-FlOeO-27g__JnuRvdJ8KG9G-bmG_zn6zuw7GerFkc/edit which makes even more sense in a world where post_task.h and task_traits.h may be used outside the TaskScheduler (ref. crbug.com/867421). There is a low-activity time this week in base/task_scheduler per OOOs so this is as good a time as ever to make this move (and it must happen before eseckler's work to use TaskTraits outside TaskScheduler). The move strategy outlined @ https://chromium-review.googlesource.com/c/chromium/src/+/1161179 makes this CL a simple file move from git's point of view without requiring all users of public headers to be updated in the same large CL Also removed a per-file *task_scheduler* rule from base/test/OWNERS as there are no such files anymore. Bug: 867421 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I48b219b9f781deab606e2c6349bc03a0c5b701d8 Reviewed-on: https://chromium-review.googlesource.com/1161088 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#580788}
-
- 05 Aug, 2018 2 commits
-
-
Christopher Cameron authored
This reverts https://crrev.com/580656 because it re-introduced driver crashes on macOS. This don't re-introduce the logging that had been added (yet) because this patch is to target merging for M69. TBR=kbr Bug: 863817 Change-Id: I5912f25416d11606fa335d3955a70478a5edf6fb Reviewed-on: https://chromium-review.googlesource.com/1163180Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580787}
-
Gabriel Charette authored
This is https://crrev.com/c/1161179 applied further up the tree while trying to land https://crrev.com/c/1161088 TBR=skyostil@chromium.org Bug: 867421 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I3d9830332e9c7331faa2576e92677274bfa06273 Reviewed-on: https://chromium-review.googlesource.com/1163285 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
