- 02 Aug, 2019 40 commits
-
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mmenke@chromium.org Change-Id: I2abffb81e28b6afcf29a9e0d96b1eff8163c130e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733494 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683639}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=carlosil@chromium.org Change-Id: I8a40cda13a2956cddde98da24717da74081f8457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733609 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#683638}
-
Brendan Hansknecht authored
Add navigationListVerticalScroll test. Rename navigationScrollsWhenClipped to navigationListHorizontalScroll. Add TODO to cleanup navigationListHorizontalScroll. Test: browser_tests --gtest_filter="FilesApp*navigationList*Scroll" Bug: 966807 Change-Id: Ia1a3eade2b9fbbe1341db2333ee4939dc13eb8a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726871 Commit-Queue: Brendan Hansknecht <bhansknecht@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#683637}
-
Mugdha Lakhani authored
We sometimes change the actual delay after which a periodicsync event is fired based on other registrations for the origin. Update what we show in Devtools so it corresponds to the actual delay_until set on the registration. Bug: 989524, 990207 Change-Id: Ie74b5cf1c4e48d58fb1b165aec54597cc018bc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733487Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#683636}
-
Matt Menke authored
Previously, http_server_properties_impl.h included on broken_alternative_services.h which included http_server_properties.h. Since HttpServerPropertiesImpl is the only implementation of HttpServerProperties, I want to merge the two files, but that would result in a circular dependency due to the aforementioned dependency. This CL moves the alternative services-related members of http_server_properties.h into alternative_services.h, which broken_alternatives_services.h now depends on. Bug: 984996 Change-Id: Ibb037219662ea0c3eab534c1bf9b7c0f3ef4c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724752 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683635}
-
Tim Volodine authored
Remove code that is not used anymore with the network service enabled. BUG=989104 Change-Id: If77bd19df957e6cb34f165cdafbe87a5e72c1fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731932Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#683634}
-
Sky Malice authored
virtual/blink-cors/http/tests/fetch/serviceworker/thorough/redirect-loop-base-https-other-https.html virtual/blink-cors/http/tests/fetch/serviceworker/thorough/access-control-base-https-other-https.html TBR: zmin@chromium.org Bug: 990175, 990176, 989863 Change-Id: I7a58b9d6efad18a0fc8c3fe66d1f5f39d341ad24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732155 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683633}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=donnd@chromium.org Change-Id: Iffa04b1db906d1a04a73529a01711aa782a11971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733597 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#683632}
-
Aya ElAttar authored
Upon entering the fullscreen/locked-fullscreen while the chromeVox panel is working, You can see an empty bar in the top of the screen. 1. The fullscreen rect y dimension starts after the height of the chromeVox panel, and as we don't want the chromeVox panel to be displayed, its height should be removed from the calculations. UPDATE: This issue got fixed by another colleague. So I added a unittest, and removed two workarounds were added to fix this issue in the locked-fullscreen mode. (one was to disable chromevox panel upon starting the lockedscreen mode, and the other was to hide the vox panel specifically for the locked fullscreen mode) When a window is set to fullscreen screen_util::GetFullscreenWindowBoundsInParent & AccessibilityPanelLayoutManager::UpdateWindowBounds() are called twice with this stacktraces order: [23272:23272:0723/164119.757770:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() #3 0x000009b93e62 ash::wm::DefaultState::UpdateBoundsFromState() #4 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #5 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #6 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #7 0x000008d085f6 aura::Window::AfterPropertyChange() #8 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #9 0x000008d0324c ui::PropertyHandler::SetProperty<>() #10 0x000009268956 views::Widget::SetFullscreen() #11 0x00000a088c28 BrowserView::ProcessFullscreen() #12 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #13 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #14 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #15 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #16 0x000009b93fc0 ash::wm::ToggleFullScreen() #17 0x000009b9177e ash::wm::WindowState::OnWMEvent() #18 0x000009a153ca ash::accelerators::ToggleFullscreen() #19 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #20 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #21 0x000009253988 ui::AcceleratorManager::Process() #22 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() .... #80 0x0000eae970a2 __libc_start_main [23272:23272:0723/164121.271202:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() #3 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() #4 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() #5 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #6 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #7 0x000009a93680 ash::ShelfLayoutManager::SetState() #8 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() #9 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() #10 0x000009b8f6e4 ash::wm::SetBoundsInScreen() #11 0x000009276346 views::NativeWidgetAura::SetBounds() #12 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() #13 0x000009269980 views::Widget::OnNativeWidgetMove() #14 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() #15 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() #16 0x000008d0978c aura::Window::OnLayerBoundsChanged() #17 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() #18 0x000008d0730c aura::Window::SetBoundsInternal() #19 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() #20 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() #21 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #22 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #23 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #24 0x000008d085f6 aura::Window::AfterPropertyChange() #25 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #26 0x000008d0324c ui::PropertyHandler::SetProperty<>() #27 0x000009268956 views::Widget::SetFullscreen() #28 0x00000a088c28 BrowserView::ProcessFullscreen() #29 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #30 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #31 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #32 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #33 0x000009b93fc0 ash::wm::ToggleFullScreen() #34 0x000009b9177e ash::wm::WindowState::OnWMEvent() #35 0x000009a153ca ash::accelerators::ToggleFullscreen() #36 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #37 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #38 0x000009253988 ui::AcceleratorManager::Process() #39 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #40 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() .... #97 0x0000eae970a2 __libc_start_main [23272:23272:0723/164123.029099:ERROR:screen_util.cc(47)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a8b57c ash::screen_util::GetFullscreenWindowBoundsInParent() #3 0x000009b93764 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() #4 0x000009b9367a ash::wm::DefaultState::HandleWorkspaceEvents() #5 0x000009b5ac5e ash::wm::BaseState::OnWMEvent() #6 0x000009b9177e ash::wm::WindowState::OnWMEvent() #7 0x000009b968e6 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() #8 0x000009b96af8 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() #9 0x0000099ebd12 display::DisplayManager::NotifyMetricsChanged() #10 0x0000099ebf5a display::DisplayManager::UpdateWorkAreaOfDisplay() #11 0x000009a33610 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #12 0x000009a94ec6 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #13 0x000009a93680 ash::ShelfLayoutManager::SetState() #14 0x000009a932be ash::ShelfLayoutManager::UpdateVisibilityState() #15 0x000009b96428 ash::WorkspaceLayoutManager::SetChildBounds() #16 0x000009b8f6e4 ash::wm::SetBoundsInScreen() #17 0x000009276346 views::NativeWidgetAura::SetBounds() #18 0x000009225b72 views::BubbleDialogDelegateView::SizeToContents() #19 0x000009269980 views::Widget::OnNativeWidgetMove() #20 0x000009276cd4 views::NativeWidgetAura::OnBoundsChanged() #21 0x00000a0b4332 BrowserFrameAsh::OnBoundsChanged() #22 0x000008d0978c aura::Window::OnLayerBoundsChanged() #23 0x000008d19a6e ui::Layer::SetBoundsFromAnimation() #24 0x000008d0730c aura::Window::SetBoundsInternal() #25 0x000009b929a6 ash::wm::WindowState::SetBoundsDirect() #26 0x000009b93f0e ash::wm::DefaultState::UpdateBoundsFromState() #27 0x000009b93da4 ash::wm::DefaultState::EnterToNextState() #28 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #29 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #30 0x000008d085f6 aura::Window::AfterPropertyChange() #31 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #32 0x000008d0324c ui::PropertyHandler::SetProperty<>() #33 0x000009268956 views::Widget::SetFullscreen() #34 0x00000a088c28 BrowserView::ProcessFullscreen() #35 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #36 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #37 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #38 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #39 0x000009b93fc0 ash::wm::ToggleFullScreen() #40 0x000009b9177e ash::wm::WindowState::OnWMEvent() #41 0x000009a153ca ash::accelerators::ToggleFullscreen() #42 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #43 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #44 0x000009253988 ui::AcceleratorManager::Process() #45 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #46 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() .... #103 0x0000eae970a2 __libc_start_main [23272:23272:0723/164124.932334:ERROR:accessibility_panel_layout_manager.cc(103)] ayaaa #0 0x0000081162bc base::debug::CollectStackTrace() #1 0x0000080a6c88 base::debug::StackTrace::StackTrace() #2 0x000009a190fa ash::AccessibilityPanelLayoutManager::UpdateWindowBounds() #3 0x000009ab0dea ash::Shell::NotifyFullscreenStateChanged() #4 0x000009b96a4c ash::WorkspaceLayoutManager::OnPostWindowStateTypeChange() #5 0x000009b92738 ash::wm::WindowState::NotifyPostStateTypeChange() #6 0x000009b93ddc ash::wm::DefaultState::EnterToNextState() #7 0x000009b93c2e ash::wm::DefaultState::HandleTransitionEvents() #8 0x000009b92e3e ash::wm::WindowState::OnWindowPropertyChanged() #9 0x000008d085f6 aura::Window::AfterPropertyChange() #10 0x0000082c62fc ui::PropertyHandler::SetPropertyInternal() #11 0x000008d0324c ui::PropertyHandler::SetProperty<>() #12 0x000009268956 views::Widget::SetFullscreen() #13 0x00000a088c28 BrowserView::ProcessFullscreen() #14 0x000009f48638 FullscreenController::EnterFullscreenModeInternal() #15 0x000009f47c98 FullscreenController::ToggleFullscreenModeInternal() #16 0x000009f47bba FullscreenController::ToggleBrowserFullscreenMode() #17 0x00000a0b45a8 (anonymous namespace)::BrowserWindowStateDelegate::ToggleFullscreen() #18 0x000009b93fc0 ash::wm::ToggleFullScreen() #19 0x000009b9177e ash::wm::WindowState::OnWMEvent() #20 0x000009a153ca ash::accelerators::ToggleFullscreen() #21 0x000009a13f72 ash::(anonymous namespace)::HandleToggleFullscreen() #22 0x000009a12332 ash::AcceleratorControllerImpl::AcceleratorPressed() #23 0x000009253988 ui::AcceleratorManager::Process() #24 0x000009ac225a ash::PreTargetAcceleratorHandler::ProcessAccelerator() #25 0x000009ab4ebe wm::AcceleratorFilter::OnKeyEvent() ... #82 0x0000eae970a2 __libc_start_main Bug: 945794,959786 Change-Id: If04f70f2c71563e9660c18ca942ef4b798ebcd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702312 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683631}
-
Matt Simmons authored
R=yusufo@chromium.org Change-Id: I2835007aa3449fcecd258a0ada14a00b5e1ec0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730503Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#683630}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/06eacf44d50f..01915c0dd073 git log 06eacf44d50f..01915c0dd073 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 bsalomon@google.com GrCaps::supportedWritePixelsColorType takes CT/format rather than config. 2019-08-02 michaelludwig@google.com Update skottie/sksg to use new filter factories 2019-08-02 michaelludwig@google.com Update docs and samplecode to use new image filter factories 2019-08-02 michaelludwig@google.com Update fuzzer to use new image filter factories 2019-08-02 bungeman@google.com Tweak css3 weight score, prevent ties. 2019-08-02 senorblanco@chromium.org First implementation of GrDawnProgramBuilder. Created with: gclient setdep -r src/third_party/skia@01915c0dd073 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I9973214a99d06d800f0130c681a1ea5c24f3dfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683629}
-
Lei Zhang authored
Convert all callers to work with the returned ScopedFD appropriately. Bug: 814832 Change-Id: Id8e87d70aba6374891652f4b61cb4864e0066dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728309Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#683628}
-
Matt Menke authored
With https://chromium-review.googlesource.com/c/chromium/src/+/1710779, a number of methods in HttpServerPropertiesImpl are only used by HttpServerPropertiesImpl itself when loading prefs and tests. This CL makes these methods private, with public ForTesting methods for tests to call them. It also renames them, making it clear that they're for dealing with loading data, and not general purpose setters. This CL also renames spdy_servers_map() and GetCanonicalSuffix, which are only used by tests, removes broken_alternative_service_list() and recently_broken_alternative_services(), which are not used, removes GetFlattenedSpdyServer(), which is not actually defined, and reorders methods defined in http_server_properties_impl.cc, which did not match the order of the header file. This is done in preparation to merge HttpServerPropertiesImpl with HttpServerProperties. Bug: 984996 Change-Id: I1122ea2d2576696877634d3a4e9485edfa72847f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724497 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Nicolò Mazzucato authored
Thanks to this CL the logs from chrome will be put inside a trace, so that they can later be shown in the perfetto UI. Bug: 983534 Change-Id: I66a3c2b54fd8bd2b5960bd042cb0e90ada6377f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698365 Commit-Queue: Nicolò Mazzucato <nicomazz@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#683626}
-
Vlad Tsyrklevich authored
The GWP-ASan unit tests need to use multi-process tests to tests crashing processes and modifying global state. On Android (before Q) running multi-process tests requires not running on the main thread, but whether tests do/don't run on the main thread is a global property of the entire unit test suite and setting the entirety of components_unittests to not run on the main thread causes a multitude of failures. Instead, create a gwp_asan_unittests test suite just for the GWP-ASan tests, run it everywhere components_unittests used to run, and set it to launch tests off of the main thread. Bug: 973167 Change-Id: I40aa9ca99ee32580a570ceda9b282eed05705eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730770 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#683625}
-
Benjamin Beaudry authored
Simple change that improves AXPosition::Initialize(0) performance. It's useless to call MaxTextOffset inside of AXPosition::Initialize when text_offset = 0, since MaxTextOffset will always be >= 0. We have seen hangs in AT's calling into UIA API's that end up creating many AXPosition's that start at 0 that this change mitigates. An A/B test shows us the improvement: before the change, get_DocumentRange would take 1,033 ms to execute and there would be 154 calls to MaxTextOffset. After the change, get_DocumentRange only takes 59 ms and MaxTextOffset is called 15 times. A/B test reproduction: on Windows, open an HTML file with a lot of text. In Inspect, select the root of the document and click Actions > Text Pattern Explorer. Execution should take around a minute to complete. Record the trace using WPR and analyze it in WPA. Bug: 928948 Change-Id: Ibbd5e929b9d7ba3a9d6342c7e7fd4550f945b16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729246 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#683624}
-
Matt Menke authored
The Manager manages writing data to/reading data from prefs, while the HttpServerPropertiesImpl manages the in-memory cache. Previously, the Manager wrapped the Impl, with both implementing the HttpServerProperties interface. This CL flips the relationship, with the Impl owning and calling into the Manager, which no longer implements the 33-member HttpServerProperties interface. Instead, it just exposes a method to write to prefs, and a callback it invokes once prefs are loaded. This simplifies things a fair bit, and should make future changes to this code a fair bit simpler. This CL leaves in a number of warts from the old implementation, in an attempt to be easier to review. TBR=rohitrao@chromium.org Bug: 984996 Change-Id: I282b3a1f2de87f189d7d59fc2bd913131f61c55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710779 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the names of the touch tracking recognizers delegates name. The gesture recognizer has two delegates: 1. The UIGestureRecognizerDelegate (self.delegate) 2. The CRWTouchTrackingDelegate (self.touchTrackingDelegate) Prior to this CL, 1. was called using self.delegate and 2. was called using _delegate. This was very confusing as the reader could expect _delegate to be the ivar associated with self.delegate, not with self.touchTrackingDelegate. This CL cleans this by changing _delegate into _touchTrackingDelegate. Bug: none Change-Id: I24331d455f8cea61c117ea698e06f26fbc13ca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732083 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#683622}
-
James Cook authored
UX wants "Add languages or reorder list". http://screen/Aup5LgOdpCe Bug: 982299 Change-Id: I16bc6b1770fd402253d75753be6838a6c1f4b94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731177Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#683621}
-
Robert Sesek authored
If the fuzzer creates a 0-sized null Channel::Message, accessing num_handles() goes through the message header, which won't exist. Switch to using the TakeHandles() vector instead. This is a somewhat artificial bug, but it is easy to fix. Bug: 978709 Change-Id: I7995fb9f809d0d623bece0ef238323a30ec90518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732009Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/017c9d8ea78b..825233007c7d git log 017c9d8ea78b..825233007c7d --date=short --no-merges --format='%ad %ae %s' 2019-08-02 lujc@google.com Vulkan: Recycle VkFence in checkCommandsCompleted Created with: gclient setdep -r src/third_party/angle@825233007c7d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I54ba5dcb92214c050ad3ff0b2cbdd1e1be2f6e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733451Reviewed-by:
-
Carlos Caballero authored
Remove dead code in preparation for a refactor that will get rid of MessageLoopForIO Bug: 891670 Change-Id: I03b063dd2bb29fd32f986caefbf614f00ada3c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733489Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#683618}
-
Thomas Tangl authored
User actions are tracked and recorded per profile. Bug: 965469 Change-Id: I41fc7f4df88b015a01f7ac6982a67da70eb08a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730059 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#683617}
-
Morten Stenshorne authored
Simplify the code that stitches fragments together in the legacy flow thread. This should be a good thing on its own, but the main motivation behind this is to get rid of finished break tokens (which this code relied on in obscure ways). Change-Id: I135f0c9089fcbb79ec31cc10d029b416c1433692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731947Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#683616}
-
Anatoliy Potapchuk authored
Bug: 981200 Change-Id: I910ba2d30e92c6a3605fb3bac98618d0491a5859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730903Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683615}
-
Piotr Pawliczek authored
Instances of BulkPrintersCalculator class dispensed by BulkPrintersCalculatorFactory cause random crashes in test environment. Sometimes, BulkPrintersCalculatorFactory is not cleared and it may hold pointers to BulkPrintersCalculator created in previous tests. These objects are used by two different modules (policies and printing) and there is no simple rule when they should be deleted, because in many tests different parts of the real chrome environment are available. I have decided to bind their lifetime to objects responsible for handling external policies. BUG=chromium:966561 TEST=on my workstation Change-Id: I894e67ab9c1fe61da2ab67832d6e6d65d157719e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722196 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683614}
-
Takuto Ikuta authored
The builder has 25 hour hourly resource usage in p99. http://shortn/_BO0EwXcF2a So I expect this won't add much burden to existing xenial pool. Current usage is in https://datastudio.google.com/s/uf5Kh6NZ8XA And we have 3250 xenial bots in MTV time now. Bug: 954450 Change-Id: I85123c1b4c2eeabbf257739535a41679e4adf540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732704 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#683613}
-
Takuto Ikuta authored
ToT builders use at most 43 hours hourly resource usage in recent 30 days https://screenshot.googleplex.com/wzLX3JisHDU (from http://shortn/_N0m7MLW0kg) ToTLinuxOfficial has only 3~4 hours hourly resource usage in internal pool. http://shortn/_EPucI9F8nx I think this fits to current buffer in Chrome pool that we have 3250 xenial bots in MTV time now. https://datastudio.google.com/s/uf5Kh6NZ8XA Bug: 954450 Change-Id: If9e68bfe201c21e473a17250d823d03a4ff7c851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732432 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 990341 Change-Id: I53dc8205fffa1f78ed54c2b1b52621fab6d0dfb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732106Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683611}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/33faa512..b43eb88b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59a378ad57ac28303c6b1efba074470145ecc411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732772Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683610}
-
Sergio Villar Senin authored
It's much better located in wtf/ and the WTF namespace than directly under platform/ under the blink namespace. In order to limit the amount of required changes it was decided to add a forward declaration to wtf/forward.h so that all the current usages of SharedBuffer do not have to explicitly use the WTF:: namespace. Bug: 919385 Change-Id: I26e029c9ba17e95a1921c12cd87d6433df26cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715373 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683609}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 69fc937e. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 6790530d "[WPT/common/security-features] Make subresourceContext unmodified" 219bce7d "Worker: Add upgrade-insecure-requests tests for top-level classic shared worker script loading" 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibc2c3905ccc1dd1e05f5aa80db7cf4a3cf9c8fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732173Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683608}
-
Robbie Gibson authored
Bug: 976665 Change-Id: Iaab827e250e73c7ea788442285ddfd5ad2050f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731903 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#683607}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/36fb019c0657..b9d6775dfb5f git log 36fb019c0657..b9d6775dfb5f --date=short --no-merges --format='%ad %ae %s' 2019-08-02 treehugger-gerrit@google.com Merge "Use using ::testing::* declarations in tracing_service_impl_unittest" Created with: gclient setdep -r src/third_party/perfetto@b9d6775dfb5f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I93418397b0846310bf93244b70ed0a325ad7c302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733450Reviewed-by:
-
Mugdha Lakhani authored
When initing the BackgroundSyncManager for the storage partition, we're not setting the origin of the registrations on the internal map. This causes problems down the line when checking for site engagement. Also add a unit test to verify we're getting the expected origin after restart. Bug: 990338 Change-Id: I2416fee5f9c4d3fa3302f20704d3ea4837f50fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731944 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
This change allows the assist app calling direct actions to provide a definition of the action they want to run to bypass the need to make RPCs to the server. This is just meant as a speedup and is not supposed to fully replace definitions on the server. For example, if RPCs are already made, the definition from the server is used instead of the local one. This is done by passing an opaque base64 encoded proto to list_assistant_actions. Bug: b/138278201 Change-Id: I9a7303357e8a44c517e77c9519d8c54d84ffe305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718948 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#683604}
-
Chris Sharp authored
This reverts commit 8f5f3e89. Reason for revert: Revert wasn't needed Original change's description: > Revert "Reland "Remove references to MessagePump::Type"" > > This reverts commit 1c1d61e5. > > Reason for revert: I suspect this is causing a compile failure on the Linux ChromiumOS Full Bot. > > Output: > FAILED: obj/chromeos/services/assistant/tests/service_unittest.o > /b/s/w/ir/cache/goma/client/gomacc ../../third_par... > ../../chromeos/services/assistant/service_unittest.cc:12:10: fatal error: 'ash/public/interfaces/constants.mojom-forward.h' file not found > #include "ash/public/interfaces/constants.mojom-forward.h" > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > Original change's description: > > Reland "Remove references to MessagePump::Type" > > > > This is a reland of bfca9d67 > > > > Was reverted because an optional trybot failed due to a missing include in an unrelated file. > > That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894 > > > > Original change's description: > > > Remove references to MessagePump::Type > > > > > > It is going away soon, replace with the real thing: MessagePumpType > > > > > > Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). > > > > > > This is a mechanical change that will be reviewed according to > > > https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes > > > > > > Bug: 891670 > > > TBR=gab@chromium.org > > > > > > Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 > > > Commit-Queue: Carlos Caballero <carlscab@google.com> > > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#682731} > > > > TBR=gab@chromium.org > > > > Bug: 891670 > > Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416 > > Commit-Queue: Carlos Caballero <carlscab@google.com> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683592} > > TBR=gab@chromium.org,carlscab@google.com > > Change-Id: Ie479741cf8092d9110a9ee6c5fa81e7e084c6788 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 891670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733432 > Reviewed-by: Chris Sharp <csharp@chromium.org> > Commit-Queue: Chris Sharp <csharp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683602} TBR=gab@chromium.org,csharp@chromium.org,carlscab@google.com Change-Id: Ieb323e7afaf248384c05b8cb0c13d6ec50856c75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733434Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683603}
-
Chris Sharp authored
This reverts commit 1c1d61e5. Reason for revert: I suspect this is causing a compile failure on the Linux ChromiumOS Full Bot. Output: FAILED: obj/chromeos/services/assistant/tests/service_unittest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_par... ../../chromeos/services/assistant/service_unittest.cc:12:10: fatal error: 'ash/public/interfaces/constants.mojom-forward.h' file not found #include "ash/public/interfaces/constants.mojom-forward.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > Reland "Remove references to MessagePump::Type" > > This is a reland of bfca9d67 > > Was reverted because an optional trybot failed due to a missing include in an unrelated file. > That was fixed in https://crrev.com/c/1729634 and https://crrev.com/c/1730894 > > Original change's description: > > Remove references to MessagePump::Type > > > > It is going away soon, replace with the real thing: MessagePumpType > > > > Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). > > > > This is a mechanical change that will be reviewed according to > > https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes > > > > Bug: 891670 > > TBR=gab@chromium.org > > > > Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 > > Commit-Queue: Carlos Caballero <carlscab@google.com> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#682731} > > TBR=gab@chromium.org > > Bug: 891670 > Change-Id: I7654fb4ff3a5e8c0505aafb33939d2035f28f88b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730416 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683592} TBR=gab@chromium.org,carlscab@google.com Change-Id: Ie479741cf8092d9110a9ee6c5fa81e7e084c6788 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733432Reviewed-by:
-
Egor Pasko authored
There are a couple of benefits for doing so: 1. to get informed in case there is data loss in unknown amounts 2. document the assumptions so that the pattern of reusing read(3) without handling EINTR does not get copied elsewhere Bug: 981536 Change-Id: I6ac638e3a9bd692b3b437fda4d77d7782a7c17be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729256 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
-
Chris Sharp authored
This reverts commit 8d648953. Reason for revert: Causing failures on WebKit Linux Leak Failure output: 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed: 06:31:06.621 2998 worker/6 leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) Original change's description: > Add web tests virtual suite for audio service - Take 2 > > Adds extra expectations with respect to reverted > https://chromium-review.googlesource.com/c/chromium/src/+/1715811 > > Bug: 976696 > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683565} TBR=guidou@chromium.org,armax@chromium.org Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508Reviewed-by:
-
