- 14 Aug, 2018 40 commits
-
-
David Black authored
Line length should not exceed 376dip and should have a line height of 24dip. See bug for spec/demo. Bug: b:112597108 Change-Id: Ic0b920d33bc0d571b98f7622a0e9d0fb965c74f1 Reviewed-on: https://chromium-review.googlesource.com/1175057Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#583080}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/db93180205a6..a2f48ac5546b git log db93180205a6..a2f48ac5546b --date=short --no-merges --format='%ad %ae %s' 2018-08-14 dgarrett@google.com chromeos_config: Disable chrome_binhost_only globally. Created with: gclient setdep -r src/third_party/chromite@a2f48ac5546b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1355c118e89be711526f97554a00095b413eb52b Reviewed-on: https://chromium-review.googlesource.com/1174798Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583079}
-
edchin authored
Previously we thought this was only flaky on devices. It is also flaky on simulator. TBR=justincohen, javierrobles Bug: 873633 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iddc823fc1034ba26db75da1b42a63a864e58878a Reviewed-on: https://chromium-review.googlesource.com/1175194Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583078}
-
Helen Li authored
This CL removes unused SqlitePersistentCookieStore::Close(). Bug: 801910 Change-Id: Ibba90aaeb5c07215de73e85f33bb5c4067cf9f42 Reviewed-on: https://chromium-review.googlesource.com/1174948Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583077}
-
Joel Hockey authored
Tbr: tbuckley@google.com Change-Id: Ia9079c26605d5cee901b46a13335985ca4ec9e49 Reviewed-on: https://chromium-review.googlesource.com/1174575 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#583076}
-
Xiyuan Xia authored
Move AppListView::ExcludeWindowFromEventHandling from browser process to app list code in ash process. Bug: 854787 Change-Id: I7509fdd8c5cc4ea0db211bdc4c7fe8715fb10660 Reviewed-on: https://chromium-review.googlesource.com/1170036 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583075}
-
Peter K. Lee authored
Firebase target depends on a Firebase resources target instead of a file path. Build configurations that want Firebase enabled should define a target to bundle GoogleService-Info.plist to application bundle. At the same time, unit test and Earl Grey test targets need Firebase SDK too. Bug: 848117 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I902437afc93dcef39ccdbc89287638ae9d761afe Reviewed-on: https://chromium-review.googlesource.com/1162713 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#583074}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ce57437..4f1630e3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I40321b5e2126f7f905e77c76998acc5246e51e59 Reviewed-on: https://chromium-review.googlesource.com/1175088Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583073}
-
Wenzhao Zang authored
Verified it works on a Paine. This is a regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/1138861 Bug: 873609 Change-Id: I929fb3be9f0f811d901811aebf34c8c52ea42bf2 Reviewed-on: https://chromium-review.googlesource.com/1175192Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583072}
-
Chris Mumford authored
This reverts commit 3dcaec6e. Reason for revert: Failing Linux MSan tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11191 DevTools listening on ws://127.0.0.1:34267/devtools/browser/a12caedc-549b-4d49-b9bb-a0519f91f318 ==14126==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x3c2bb23 in ExitFullscreenModeForTab ./../../content/browser/web_contents/web_contents_impl_browsertest.cc:1561:9 Original change's description: > Security drop fullscreen for any nested WebContents level. > > BUG=873080 > TEST=as in bug > > Change-Id: Icd75715ac42789c84870967b11c9917a972ae086 > Reviewed-on: https://chromium-review.googlesource.com/1173342 > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582970} TBR=avi@chromium.org,sdy@chromium.org Change-Id: I52a9b29f2d17ea6e7db0128815653de624fa5b13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873080 Reviewed-on: https://chromium-review.googlesource.com/1174640Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#583071}
-
Luke Halliwell authored
Now that we display a wider range of web content, some sites are serving desktop sites with images too large for our memory limits and so on. Longer-term, it may be possible to use this UA string for all products. Bug: internal b/112465626 Change-Id: I5c30b1966f75143eb5d99efabfb9093bf6159e90 Reviewed-on: https://chromium-review.googlesource.com/1175087Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#583070}
-
Nektarios Paisios authored
1. Employs a static local variable to store the single instance which is thread safe. Also prevents destruction which is not thread safe. 2. Took the opportunity to do some cleanup: Added "const" and "* const" to some places. Move the COMInitializer to the tools module because there should only be one instance per module and content_browsertests already had one instance. Used FAILED instead of !SUCCEEDED. R=sdi@chromium.org, mcasas@chromium.org, aleventhal@chromium.org Change-Id: Ie4ed3db74342e42c9325a647401b03a44aa0cba2 Reviewed-on: https://chromium-review.googlesource.com/1171562 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583069}
-
Christian Fremerey authored
Devices using certain legacy Empia chips appear to get listed and report valid formats in both DirectShow and MediaFoundation but only work in DirectShow when actually trying to open them. This CL adds a blacklisting mechanism that forces device models known to exhibit this issue to always get opened with DirectShow instead of MediaFoundation. Test: capture_unittests.exe --gtest_filter=VideoCaptureDeviceFactoryMFWinTest* Bug: 792640, 849636, 862395 Change-Id: Ia70d13a45eb49ed185f27630d0e544f3a484b6f2 Reviewed-on: https://chromium-review.googlesource.com/1174902Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583068}
-
Dale Curtis authored
Crash dumps are unclear and the issue seems resolved on Pixel hardware, but some earlier stack traces suggest we're getting a null TaskRunner when attempting to BindToCurrentLoop during CreateCodec(). As such move binding to a known good thread. This should be reverted if the issue is not fixed. If it is fixed there's additional work to be done to understand the consequences of CreateCodec() being called on an unexpected thread. BUG=873094 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2928d7866c1f40de63f526ee7393d2d8b90884f2 Reviewed-on: https://chromium-review.googlesource.com/1175092Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583067}
-
Dale Curtis authored
This caps these devices support for hardware decoding to 1080p. BUG=873996 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4b640cf8537a33518d06994d9aaeac772e428b8e Reviewed-on: https://chromium-review.googlesource.com/1175095 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#583066}
-
Tarun Bansal authored
Use network quality tracker instead of network quality estimator (NQE) to obtain network quality in data reduction proxy component. Network quality tracker can provide network service when network service is enabled as well as when network service is disabled. data_reduction_proxy_service.h receives network quality estimates on UI thread from network quality tracker. On receiving estimates, it posts them to d_r_p_io_data which lives on IO thread, and consumes the estimates. PS#2 is the original CL that got reverted. Bug: 819244 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id9f28abaea42a7eb55dd3647c88d13a427a4e5ae TBR: xunjieli@chromium.org, sky@chromium.org, ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1174698 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583065}
-
Scott Chen authored
Bug: 866941 Change-Id: I1c5a6a8117eb347dbe838ae1818e726ff1dafcb7 Reviewed-on: https://chromium-review.googlesource.com/1175062Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583064}
-
Chris Mumford authored
This reverts commit 562c52f7. Reason for revert: cc_unittests failing on Linux TSan: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/24797 [ RUN ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy [22487:22487:0814/143420.957209:26522082454:ERROR:pixel_comparator.cc(47)] Number of pixel with an error: 30000 [22487:22487:0814/143420.957442:26522082676:ERROR:pixel_comparator.cc(48)] Error Bounding Box : 0,0 200x200 [22487:22487:0814/143421.140401:26522265659:ERROR:pixel_test_utils.cc(79)] Pixels do not match! [22487:22487:0814/143421.140586:26522265816:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAACHUlEQVR4nO3VMRHAMBADwXf4ozUBh0DmWqfYRaDmRmvvOQN8em4PgD8TCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQFgz+9weAX/lQSAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAILygpAZjjfRdXgAAAABJRU5ErkJggg== [22487:22487:0814/143421.140737:26522266017:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAIAAAAiOjnJAAACNklEQVR4nO3dsQ0DMQwEQb3hWP3XqQrcgEMvnm/MVMBgwfSutc6CX3vdfQD/SVgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRF4n33Ad+ds+8+4TH2nriR62OREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGRuM7Eec6hq6EzzVyj9bFICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBIDF1Y5el8LBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBIfCVIMShDYZKEAAAAASUVORK5CYII= ../../cc/test/layer_tree_pixel_test.cc:129: Failure Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_) Actual: false Expected: true Stack trace: #0 0x000001ceb5ff (/b/s/w/ir/out/Release/cc_unittests+0x1ceb5fe) #1 0x0000017ae1e9 (/b/s/w/ir/out/Release/cc_unittests+0x17ae1e8) #2 0x0000017bda1f (/b/s/w/ir/out/Release/cc_unittests+0x17bda1e) #3 0x0000017bd178 (/b/s/w/ir/out/Release/cc_unittests+0x17bd177) #4 0x000001a362be (/b/s/w/ir/out/Release/cc_unittests+0x1a362bd) #5 0x000001a3b5ba (/b/s/w/ir/out/Release/cc_unittests+0x1a3b5b9) [ FAILED ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy (4296 ms) Original change's description: > Roll src/third_party/skia 32c7d4dfcdca..d19fed1e291d (2 commits) > > https://skia.googlesource.com/skia.git/+log/32c7d4dfcdca..d19fed1e291d > > > git log 32c7d4dfcdca..d19fed1e291d --date=short --no-merges --format='%ad %ae %s' > 2018-08-14 fmalita@chromium.org [skottie] Eliminate some temp SkString allocations > 2018-08-14 mtklein@google.com pass sprite opacity to color xform when blitting. > > > Created with: > gclient setdep -r src/third_party/skia@d19fed1e291d > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=kjlubick@chromium.org > > Change-Id: Ib608389718b76c94782e3415bcc82dc607902e82 > Reviewed-on: https://chromium-review.googlesource.com/1174793 > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#583019} TBR=kjlubick@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I0e6bc9c3c8c052a0ae17eb292cad8bb5e579faf2 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1174639Reviewed-by:
-
Kevin Schoedel authored
Final cleanup after https://crrev.com/581931 Bug: internal b/73383411 Test: manual Change-Id: I9407ebbaa7b189bf3b71aa1700451198ec5c5810 Reviewed-on: https://chromium-review.googlesource.com/1169586Reviewed-by:
-
Evan Stade authored
Port a couple related browser tests to ash unit tests. Change-Id: Id1fcf3b823b3f470dc93d651c681738053cc3383 Reviewed-on: https://chromium-review.googlesource.com/1173152Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#583061}
-
David Tseng authored
Bug: 874102 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I64ae721146a6ac631800bd0bbd1ca6cca9f522f8 Reviewed-on: https://chromium-review.googlesource.com/1172741 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583060}
-
Xiao Yang authored
Previously, "OK Google" Now, "Ok Google" This string is used in Chrome OS settings. Bug: b:112326023 Change-Id: Ic69713f93518241ade199034bce0a0c1063e89e1 Reviewed-on: https://chromium-review.googlesource.com/1171219Reviewed-by:
-
Xiao Yang authored
"Answering on another device": To display when disambiguating "Ok Google" and we lose devie selection to another surface. "What's on my screen": show on suggestion chip in Assistant UI to initiate a contextual search Bug: b:112464186 Change-Id: Ia61f12d3c39f5005486824ad7982736719dfd14b Reviewed-on: https://chromium-review.googlesource.com/1173263Reviewed-by:
-
Evan Stade authored
Bug: 854704 Change-Id: If3326d678e53b3ccff89bcd2ba98d02a0611b605 Reviewed-on: https://chromium-review.googlesource.com/1172739Reviewed-by:
-
Vlad Tsyrklevich authored
SafeStack [1] introduces a secondary thread stack called the unsafe stack that also needs to be scanned for object references. Introduce matching logic in oilpan to scan the unsafe stack for heap references. [1] https://clang.llvm.org/docs/SafeStack.html Bug: 864705 Change-Id: I376077bd985e2077aa3771101c1822e1570c7807 Reviewed-on: https://chromium-review.googlesource.com/1169772Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583056}
-
Stefan Zager authored
This patch adds a flag indicating whether an iframe element is occluded or has visual effects applied in the parent document; and adds the flag to the IPC message containing the iframe's intersection with the parent's viewport. BUG=869049 R=kenrb@chromium.org,chrishtr@chromium.org Change-Id: I0891a3e6740dbce39f0cf0120353feb8c9fca173 Reviewed-on: https://chromium-review.googlesource.com/1167960Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#583055}
-
Eric Roman authored
Bug: 851609 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2f261550d21f80e4b2143c0253a3867f11091885 Reviewed-on: https://chromium-review.googlesource.com/1175054 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583054}
-
Mike Dougherty authored
This fully enables support for context menu in iFrames. Bug: 873660, 873662 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3345f56f6812ef619c6ed5b7bcabd34e09de410f Reviewed-on: https://chromium-review.googlesource.com/1174052 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583053}
-
Wei-Yin Chen (陳威尹) authored
For those subfolders of //chrome/ without violations, add them to gn check targets. Otherwise, add number of errors in comments. Bug: 367595 Change-Id: I8a2dc703f9b415e47f6fa3c1910b6338dd02ae69 Reviewed-on: https://chromium-review.googlesource.com/1174095Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583052}
-
Martin Kreichgauer authored
Currently, the |FidoRequestHandlerBase::AddAuthenticator| method synchronously invokes the virtual |DispatchRequest| method, which subclasses implement to process the request and invoke the response handling callback. Most authenticators are instantiated by a |FidoDiscovery| which does some asynchronous discovery work and then calls |AddAuthenticator|. Platform authenticators, on the other hand, are instantiated by |MaybeAddPlatformAuthenticator|, which gets invoked synchronously with request handler instantiation. This makes it possible to have a synchronous code path from request handler instantation to response callback invocation (i.e. hairpinning). In those cases, |AuthenticatorImpl| is unable to handle the response (see e.g. https://cs.chromium.org/chromium/src/content/browser/webauth/authenticator_impl.cc?sq=package:chromium&dr&g=0&l=749). This change makes |DispatchRequest| invocation asynchronous, which eliminates any possibility of response callback hairpinning. Bug: 678128 Change-Id: I6bf273775885abac1fa38fe12c964e930407cc7e Reviewed-on: https://chromium-review.googlesource.com/1172917 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583051}
-
Fernando Serboncini authored
TBR=kbr@chromium.org Bug: 753483, 873914 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I958694f9db571b66c40baf144025d87acf824dc2 Reviewed-on: https://chromium-review.googlesource.com/1173169 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583050}
-
rbpotter authored
Specifically, adding new test suites webui_polymer2_browser_tests and webui_polymer2_interactive_ui_tests that run a given list of tests and explicitly excludes currently failing tests. This will allow gradually getting to a state where all tests are passing with the flag on. Bug: 862472 Change-Id: Ia19ae36a4b2b63499b970e14c742b7719e118f83 Reviewed-on: https://chromium-review.googlesource.com/1132320 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This was removed in r577553 but I unintentionally reintroduced it in r578809 (incorrect rebase). This regressed https://crbug.com/860801#c18 R=kylechar@chromium.org Bug: 860801 Change-Id: Ia42d24f915d271832b59c481ebe77ee1bc6fd11d Reviewed-on: https://chromium-review.googlesource.com/1175060Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#583048}
-
Lukasz Anforowicz authored
This is a reland of unmodified r582223, after separately taking care of https://crbug.com/873780 which caused the earlier revert. Original CL description follows below: After this CL site-per-process is the default in all layers on desktop platforms, except: - Layout Tests which still run with no isolation by default (see https://crbug.com/856734#c5 for the explanation why) - //content embedders that don't want to use site-per-process: //chromecast - //content embedders that don't yet support site-per-process, but will need to migrate eventually: //headless Also note that even after this CL: - //content on Android still defaults to no isolation. This is compatible with not_site_per_process_* test steps because such steps are not run on Android bots... - //chrome layer ChromeContentBrowserClient controls usage of site-per-process in the Chrome browser and continues to be controlled by a field trial (note that Android is not covered by the field trial or by testing/variations/fieldtrial_testing_config.json). Bug: 856734 Change-Id: I0cfd7e342c44a36d22a885b46892a9e4e3f2c758 Tbr: Stephen Lanham <slan@chromium.org> Tbr: Sami Kyöstilä <skyostil@chromium.org> Tbr: Bo <boliu@chromium.org> Tbr: Nico Weber <thakis@chromium.org> Tbr: Alex Moshchuk <alexmos@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1174855Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Sam McNally authored
The drive-internals page uses GCache/v1 as the root for the files displayed in the GCache Contents section of about:drive-internals. Use its parent instead so the GCache/v2 contents are also displayed. Bug: 829703 Change-Id: I7e47db743737a2331484e2b913600051470000b5 Reviewed-on: https://chromium-review.googlesource.com/1174135Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#583046}
-
Peter Boström authored
Moves any values that were still handled by ChromeLayoutProvider into HarmonyLayoutProvider and adds a bunch of CHECK(false) inside ChromeLayoutProvider to make sure that it's not called. The next step will merge all HarmonyLayoutProvider code back into ChromeLayoutProvider and remove the HarmonyLayoutProvider class completely (effectively making HarmonyLayoutProvider the new ChromeLayoutProvider). Moving code into HarmonyLayoutProvider as a first step is only done because it generates an easier diff for review (less code had to move from ChromeLayoutProvider than vice versa). Bug: chromium:867557 Change-Id: I477925c09e37b328103102e0d606a9d9db605eb5 Reviewed-on: https://chromium-review.googlesource.com/1171191Reviewed-by:
-
Kevin McNee authored
Bug: None Change-Id: Id76ae87bf92bf00c6f32e54afe963713b0e9f8c4 Reviewed-on: https://chromium-review.googlesource.com/1175064Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#583044}
-
Zhiqiang Zhang authored
This CL migrates the CastMessageHandler for CAF. There's not much code change between CastMessageHandler and CafMessageHandler. Bug: 711860 Change-Id: Id58454c51cd6ada50b507d750a979ffe4e248241 Reviewed-on: https://chromium-review.googlesource.com/1169920 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Zhiheng Vincent Li authored
isRemoteControlMode is obtained from (Cast)WebApplication when creating CastWebView and passed to cast_content_window_android.cc -> CastContentWindowAndroid.java to reach Java side. From cast to other Android app: add a param in intent to start CastWebContentsFragment in CastWebContentsComponent.java Bug: b/110761726 b/111887184 Test: cast_shell_junit_tests cast_shell_internal_junit_tests Change-Id: I08cf42a492647d4d7c7b0c6593c6eb8852ae7179 Reviewed-on: https://chromium-review.googlesource.com/1164631 Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583042}
-
Xiaoqian Dai authored
After drag starts, the window needs to be dragged vertically a small amount of distance to be considered as 'moved' and only after that, the drag indicators will show up and the window can be snapped. But after the window has been 'moved', it should stay moved even the window is dragged toward to the top of the screen. Bug: 873275 Change-Id: I4546a3a6839427c7232dcc5b6f234913b9dd516d Reviewed-on: https://chromium-review.googlesource.com/1173472 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
