- 07 Feb, 2018 40 commits
-
-
Yoshifumi Inoue authored
This patch introduces |FindNextWord{Backward,Forward}()| as replacement of |FindNextWordFromIndex()| to avoid |bool| parameter |forward| since all call sites pass constant value for improving code health. Change-Id: Ife6fe6bc355b17985d3c16c8f4fa4f5605cfb7c6 Reviewed-on: https://chromium-review.googlesource.com/900565Reviewed-by:Dominik Röttsches <drott@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534907}
-
Hwanseung Lee authored
1. replace "DOMString or CSSVariableReferenceValue" with CSSUnparsedSegment using typedf keyword. 2. using sequence<> keyword instead of "..." in constructor https://github.com/w3c/css-houdini-drafts/pull/619 Bug: 807525 Change-Id: I99c11c26dd2235e46e259e63991d0192a025bcb4 Reviewed-on: https://chromium-review.googlesource.com/904582Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#534906}
-
Nick Harper authored
This is a merge of internal change 184350463 Change-Id: Ifca239fb8f9941cb718baba9e01f3d22ba1c3918 Reviewed-on: https://chromium-review.googlesource.com/900486 Commit-Queue: Buck Krasic <ckrasic@chromium.org> Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#534905}
-
Dmitry Gozman authored
The token is naturally UnguessableToken, but is plumbed as String in multiple places for historical reasons. This patch makes it consistent with navigation token and the rest of the code. Also plumbed DevToolsWorkerToken to dedicated workers for the same purpose. We already plumbed it through a side channel, now it's a part of global scope. Bug: none Change-Id: I2b52f1945730950473aaed307baaf58b19c881a8 Reviewed-on: https://chromium-review.googlesource.com/905234Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534904}
-
Kent Tamura authored
- CreateCustomElement with three arguments calls CreateCustomElement with four arguments internally. - Code cosmetic change in CreateCustomElement with four arguments. This CL has no behavior changes. Bug: 806641 Change-Id: I7ae0fa4452b665533c8e250ae0ce2cbf74bc244c Reviewed-on: https://chromium-review.googlesource.com/905902Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#534903}
-
Fady Samuel authored
Queuing delay can cause BeginFrames to arrive late in SurfaceDependencyDeadline. Prior to this CL, SurfaceDependencyDeadline counted BeginFrames to determine whether a deadline was hit. The problem is each BeginFrame could be delayed and so 4+ BeginFrames could translate into hundreds of milliseconds even if the system is intended to run at 60fps (67ms for 4 BeginFrames). This CL converts SurfaceDependencyDeadline to measure wall time instead and uses BeginFrames as a signal to check how much time is left until the deadline. This CL mocks out base::TimeTicks::Now() through a base::TickClock object. This allows this code to be unit-testable. Bug: 808315, 672962 TBR: skyosil@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6f76d1f55ea9e7920d7872414618ec225c25d454 Reviewed-on: https://chromium-review.googlesource.com/902844 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#534902}
-
Hikaru Nishida authored
This patch removes a redundant class specifier |LayoutObject::| for |SetSelectionState()| call in |ResetOldSelectedLayoutObjects()| because it is non-virtual member function for improving code health. Change-Id: I684f6cc385adbfb172fb1020154e659a9f037977 Reviewed-on: https://chromium-review.googlesource.com/903024Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Add ios_web_view_inttests and ios_chrome_payments_egtests as dependencies of gn_all to ensure they are build when building "All" in Xcode hybrid project. Bug: none Change-Id: I972e095241d487561ce3d3afdcd4511284292b01 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/899246Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#534900}
-
https://webrtc.googlesource.com/src.git/+log/dffead8835d1..03e5ce84dedc $ git log dffead883..03e5ce84d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5018b3f1c2a4510865d5dde8c97f00de479c4a48 Reviewed-on: https://chromium-review.googlesource.com/905985 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534899}
-
Christopher Cameron authored
Add DumpWithoutCrashing whenever we fail IOSurfaceLookupFromMachPort. Remove the CHECKs, since this was frequent enough to affect stability. Change anonymous image creation to not use mach ports, but add an attempt to locally open via mach port for debugging purposes. For non-anonymous image creation, where the image will be passed via a mach port to the client process, attempt to open the mach port before passing to the client. If this open fails, then do not send the mach port to the client. This may determine if the problem is independent of the process attempting to open. Bug: IOSurfaceLookupFromMachPort Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8d201ca2d370efac58a9a690100fbf63f0bc6a27 Reviewed-on: https://chromium-review.googlesource.com/905239 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#534898}
-
Hikaru Nishida authored
This patch removes a redundant class specifier |LayoutObject::| for |SetSelectionState()| call in |LayoutSelection::Commit()| because it is non-virtual member function for improving code health. Change-Id: I0a6c6b4f32b8689b0c5bfd0bd6487aa55075f9db Reviewed-on: https://chromium-review.googlesource.com/902986Reviewed-by:
-
Joel Einbinder authored
This uses 'aria-alert' to read out SuggestBox items in StylesSidebar and Console, and FilteredListWidget items in the CommandMenu. Change-Id: I4126e2344ec585adb81f512156bc8506d0ebb70f Reviewed-on: https://chromium-review.googlesource.com/867238Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#534896}
-
https://skia.googlesource.com/skia.git/+log/5dd202dc9002..9ca602ae04a7 $ git log 5dd202dc9..9ca602ae0 --date=short --no-merges --format='%ad %ae %s' 2018-02-06 mtklein guard xml-using tests with SK_XML 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ fbb1c7921..57dd97aaa (1 commit) 2018-02-06 mtklein remove SkCanvas::kIsOpaque_SaveLayerFlag 2018-02-06 bryct Add link annotation support to SkSVGDevice. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I77e0913f1a56ed0dca83b04a7b91519040bcb62d Reviewed-on: https://chromium-review.googlesource.com/905812Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534895}
-
Karan Bhatia authored
activeTab also grants host permission to the main frame origin of tab on which activeTab access was granted. This access is bound to the tabID. For e.g., this would allow extensions with activeTab to monitor/block etc. network requests to that origin on that particular tab temporarily. This CL documents the same. BUG=805753 Change-Id: If839fde0ff1ea2494e1ea36a1df80bca5e9ec848 Reviewed-on: https://chromium-review.googlesource.com/905868Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534894}
-
Wez authored
https://chromium-review.googlesource.com/881501 introduced fixed file paths into some of these tests, causing them to randomly interfere with one another if they happened to end up being run in parallel. Bug: 809780 TBR: olka@chromium.org Change-Id: Idb2143f9c44ddab559b7402182e69d3b2e7220de Reviewed-on: https://chromium-review.googlesource.com/905991Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#534893}
-
Rachel Blum authored
BUG=796935 Change-Id: Ib1ca8a5af6e57b3f8173d64383b33b636eaa613b Reviewed-on: https://chromium-review.googlesource.com/905798Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Rachel Blum <groby@chromium.org> Cr-Commit-Position: refs/heads/master@{#534892}
-
Ian Vollick authored
This is a reland of 31c3e864. Original change's description: > [vr] Add not-web-exposed media feature for immersive mode. > > With this change, I've added a media feature that returns true when > in immersive mode (eg, in VR). I've added extra plumbing to ensure that > this new feature is not web exposed. > > More info on media features here: > https://www.w3.org/TR/css3-mediaqueries/#media1 > > The plumbing for this particular feature is very close to the plumbing > for -webkit-transform-3d. > > I've also changed the "page popups suppressed" setting (which was only > ever true in immersive mode) to be named immersive, accordingly. > However, the uses of the immersive mode setting for suppressing page > popups are meant to be temporary, so I've added comments referencing > the bug that explains the removals. > > Bug: 809021 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11 > Reviewed-on: https://chromium-review.googlesource.com/901484 > Reviewed-by: Rick Byers <rbyers@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534497} TBR=avi@chromium.org Bug: 809021 Change-Id: I23ec9a7506a5fa8904f716a3c43bb4ad5b5bbe2c Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/905782Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#534891}
-
Megumi Hattori authored
While the inline settings is appearing right after the settings button at the top of the notification is clicked, the notification is changing the color from white to light gray as a ripple circle like ink drop expands. At the same time, the actions row which has inline action buttons or an inline textfield is hidden. When the inline settings is closed, the animation is hidden, and the action rows appeares. Bug=796029 Change-Id: I0d9e1a98f6f83c120d18f274d8fa3910170489ef Reviewed-on: https://chromium-review.googlesource.com/903622Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#534890}
-
Alexey Kozyatinskiy authored
R=pfeldman@chromium.org Bug: none Change-Id: I62da55ee4203759b8c5bba2e375c196c5a1a4842 Reviewed-on: https://chromium-review.googlesource.com/905928Reviewed-by:
-
Alex Newcomer authored
Our logic assumed that an ET_GESTURE_END will always come after an ET_GESTURE_TAP_DOWN, this isn't true. When a Two-finger tap (ET_GESTURE_TWO_FINGER_TAP) occurs the event stream is ET_GESTURE_TAP_DOWN -> ET_GESTURE_TAP_CANCEL -> ET_GESTURE_TWO_FINGER_TAP with no ET_GESTURE_END. This CL fixes the issue by clearing the set state by ET_GESTURE_TAP_DOWN on ET_GESTURE_TAP_CANCEL. Bug: 809751 Change-Id: Iefeda869c70a75ba09a21fe4449b337a5cb7a826 Reviewed-on: https://chromium-review.googlesource.com/905864Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#534888}
-
Yuri Wiitala authored
Remove RenderWidgetHostView::CopyFromSurfaceToVideoFrame() and all FrameSubscriber interfaces. They served us well for the past 5 years, but it's time to retire them in favor of the new frame sink-based tab capture implementation. Almost all of this change is code deletion. Only minor, trivial clean-ups were performed in files touched. Bug: 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iec3b5754fccf800d6cbf70c15fcc0f6779da960f Reviewed-on: https://chromium-review.googlesource.com/896588 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#534887}
-
Katie D authored
Also turns of tts when chromevox is disabled. Bug: 809733 Change-Id: I9a9c6b6b2c314f29b3207f1ed38b0820d878c430 Reviewed-on: https://chromium-review.googlesource.com/905807Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#534886}
-
David Tseng authored
Problem Suppose a node a has an active descendant b. A page author might change |b| to aria-selected="true" immediately after setting |b| to be the active descendant. As a result, we have the events and actions: active descendant changed on |a| client gets event on |a| and emits output attribute changed on |b| client gets attribute changed on |b| but focus remains over |a| Solution Let the client know about changes in its related nodes. For example, changes to |b| would cause an event on |a|. Bug: 808061 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I58a3d99d3187db348320223f0bde588015ab6f55 Reviewed-on: https://chromium-review.googlesource.com/899862 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#534885}
-
Victor Costan authored
This is a reland of b05f99c3. Unlike the original, this CL does not enable SQLITE_OMIT_AUTOINIT, to avoid the crashes caused by the problem being addressed in https://crrev.com/c/894692 This CL shrinks the Linux binary by 26KB (139,005,496 to 138,979,176). Code savings aside, this makes sure we don't unintentionally start depending on these features. The following compile-time options are recommended in the SQLite documentation [1]: * SQLITE_LIKE_DOESNT_MATCH_BLOBS - The LIKE and GLOB operators don't work on BLOB columns. This access pattern would be a performance wrench, so it's nice to fail hard here. * SQLITE_OMIT_DEPRECATED - This removes support for deprecated SQLite APIs. Note that SQLite promises to maintain indefinite backwards compatbility for SQL queries (modulo features disabled via compile-time options), so this only applies to the SQLite API. We should never be using deprecated APIs. * SQLITE_OMIT_PROGRESS_CALLBACK - Remove sqlite3_progress_handler(). We don't use this feature, and the documentation says it comes with a small performance penalty. * SQLITE_OMIT_SHARED_CACHE - Using a shared cache sounds nice from a memory consumption standpoint, and we already do that for LevelDB. Unfortunately, Chromium's SQLite databases use a variety of page sizes, which makes cache sharing impossible. * SQLITE_USE_ALLOCA - Use alloca() instead of malloc() for allocating temporary spaces in functions. All of Chrome's platforms support this option, and it results in a slightly smaller binary and less heap churn. The following compile-time options disable features that happen not to be used. * SQLITE_OMIT_AUTORESET: We calls sqlite3_reset() correctly to reset prepared statements. * SQLITE_OMIT_GET_TABLE: We don't use sqlite3_{get,free}_table(). * SQLITE_OMIT_LOAD_EXTENSION: We don't use sqlite3_{enable_}load_extension(). Asides from the code savings, there's a tiny security benefit to knowing that extension loading code is definitely not reachable from WebSQL. * SQLITE_OMIT_TCL_VARIABLE: We don't use TCL variables. * SQLITE_OMIT_TRACE: We don't use sqlite3_{profile,trace}(). [1] https://www.sqlite.org/compile.html#recommended_compile_time_options Bug: 807093 Change-Id: Ic7510b32f96d5d3f98f8c5a9ba522478ad728ad0 Reviewed-on: https://chromium-review.googlesource.com/894708 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#534884}
-
Jun Choi authored
HID packet and message structure defined by the U2F spec is a strict subset of structure defined by the CTAP spec. Migrate all HID packet or HID message related code and tests to device/ctap. Bug: 807043 Change-Id: If4ff1fcbbd2a638ccf2c4eb6f5dc518f08054fe4 Reviewed-on: https://chromium-review.googlesource.com/892045 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#534883}
-
https://chromium.googlesource.com/catapult.git/+log/874bc7c4eabb..1d86294f159a $ git log 874bc7c4e..1d86294f1 --date=short --no-merges --format='%ad %ae %s' 2018-02-06 eakuefner [Telemetry] Preserve shared diagnostics added in JavaScript Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id25269d48c5d6c8afd2355e90dda9b5ed98dfbdf Reviewed-on: https://chromium-review.googlesource.com/905811 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534882}
-
Zhenyao Mo authored
BUG=744658 TEST=bots R=piman@chromium.org,boliu@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icb4f88dbbdca34541d3921b57574a9d843326254 Reviewed-on: https://chromium-review.googlesource.com/905791Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534881}
-
Matt Menke authored
HandleRequestCallbacks and MonitorRequestCallback are now explicitly RepeatingCallbacks instead of just base::Callbacks. Also update some consumers of those APIs in net/ to use BindRepeating, though there are still a great number outside of net/ that just use Bind. Bug: 714018 Change-Id: I473c7f3128b3398e97c2c587e5b70bf51cde83fa Reviewed-on: https://chromium-review.googlesource.com/900186Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534880}
-
Shenghua Zhang authored
In the case of migrating Chrome mac 10.9 bots to 10.13, make use of the trigger tool //testing/trigger_scripts/trigger_multiple_dimensions_unittest.py, to support buider chromium.mac bot 'Mac10.9 Tests' running tests on either 10.9 or 10.13 bots in a load-balancing way. This CL: 1) adds add_common_test_properties in generate_buildbot_json.py which adds the tigger script logic. 2) add 'alternate_swarming_dimensions' for 'Mac10.9 Tests' tester config in waterfalls.py 3) manually run generate_buildbot_json.py and generated the multiple swarming dimensions configs in chromium.mac.json Bug: 805475 Change-Id: I4aeb4b67d085c58e777c59e9685e39e3d5504598 Reviewed-on: https://chromium-review.googlesource.com/898534 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534879}
-
Andrey Kosyakov authored
This moves the instrumentation for Network.{requestWillBeSent,responseReceived,loadingFailed} to browser and prevents renderer from reporting these. The dataReceived and loadingFinished events are still reported from the renderer. TBR=alexclarke Bug: 791838 Change-Id: I6f7ce1f0c243342ad15cb1bd6290c0f68a0da647 Reviewed-on: https://chromium-review.googlesource.com/861952Reviewed-by:Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#534878}
-
François Degros authored
Used RepeatingCallback instead of deprecated Callback. Change-Id: I36a1079c5a5c2c0341d85e1e7230ac9055347349 Reviewed-on: https://chromium-review.googlesource.com/894962 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534877}
-
Ke He authored
Automated test missing was found when moving geolocation-config related codes. Add a service unittest against it. BUG=800633 Change-Id: I99332c942626f8acf2e8ced1387c259024c2a2c3 Reviewed-on: https://chromium-review.googlesource.com/885913Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#534876}
-
CJ DiMeglio authored
This CL allows video surfaces to utilize rotation information provided in the metadata. Providing this information is important because it ensures that videos are played in the correct orientation. In order to accomplish this, we wait to enable submission of frames until after metadata has loaded. This CL also gets rid of the use of the |submitter_| variable in VideoFrameCompositor, only using it for ownership purposes, simplifying the code. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I06eb182be69d326f97b9ae9613cd196db55621a8 Bug: 750313 Reviewed-on: https://chromium-review.googlesource.com/865462Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/bfeed4ddfcd6..57dd97aaaf09 $ git log bfeed4ddf..57dd97aaa --date=short --no-merges --format='%ad %ae %s' 2018-02-06 jmadill Vulkan: Add helper for allocating image memory. 2018-01-19 oetuaho Store symbol names as a ImmutableString 2017-12-22 talentediq Added Documentation for running dEQP tests 2018-02-06 jmadill Vulkan: Reorganize BUILD.gn files. 2018-02-05 lucferron Vulkan: Fix bug in reuse of vertex input bindings 2018-02-05 wez Replace a POSIX API call not supported by Fuchsia. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ibf92ddb541c01c2a5eb03ff9b38e1163cd7f0603 Reviewed-on: https://chromium-review.googlesource.com/905639 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534874}
-
Tetsui Ohkubo authored
MessagePopupCollection::GetBaseLine had an unused argument ToastContentsView* last_toast. It was just used as a boolean value. TEST=message_center_unittests BUG=none Change-Id: I044a057074fdcf2cd5227746e83c0f8ecfd01ee3 Reviewed-on: https://chromium-review.googlesource.com/895204Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#534873}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 808311 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ica27f0cdadfe3a8381eb2dd90bd1a781d5b04cd5 Reviewed-on: https://chromium-review.googlesource.com/905704Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#534872}
-
Matt Wolenetz authored
If a range B starts with the same timestamp as the end of the previous range A, these would normally merge due to being adjacent within the fudge room based on the end timestamp of range A (not the buffered end timestamp of A). This is sufficient for coalescing adjacent ranges in all cases except where fudge room has not been increased to account for an increased estimated buffer's duration. In complex overlap/abutting append scenarios, A and B previously would have remained outside of fudge room of each other and not have been coalesced, if A ended with an estimated duration buffer longer than the fudge room. This change patches CanAppendBuffersToEnd to recognize this specific scenario and allow A and B to coalesce. BUG=806181 TEST=CF case no longer repros locally, new SBSTest.MergeAllowedIfRangeEndTimeWithEstimatedDurationMatchesNextRangeStart Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic749c2e4e0bb6cc1b69983efd16ef6e346410c9e Reviewed-on: https://chromium-review.googlesource.com/898604 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#534871}
-
Kent Tamura authored
The second argument was a bool representing craete_by_parser. This CL changes it to CreateElementFlags, which contains the same flag. This is a preparation to support <script is=>. This CL has no behavior changes. Bug: 808311 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I065b23a4797ba26b050e2113a4df7daf1cc385d6 Reviewed-on: https://chromium-review.googlesource.com/904225Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a462f872..017935cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifc4c5a633e5a90428ec3294045f531fb88e42bb3 Reviewed-on: https://chromium-review.googlesource.com/905269Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534869}
-
Theresa authored
BUG= Change-Id: Ic2e4a9abe542e2ebce04ce89de7f3e77cb5eda13 Reviewed-on: https://chromium-review.googlesource.com/904950Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534868}
-
