- 05 Oct, 2018 40 commits
-
-
A Olsen authored
src/chrome/browser/chromeos/settings OWNERS should also own src/chromeos/settings, so now they do. Moved the OWNERS file to chromeos/settings, and c/b/chromeos/settings OWNERS inherits from there. Bug: 446937 Change-Id: I72202017fa2c0c6fd3f4a322b8ea38dfb3bc6c04 Reviewed-on: https://chromium-review.googlesource.com/c/1264584 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597262}
-
Jun Choi authored
Connected Bluetooth FidoAuthenticator can be in pairing mode when discovered by the browser, or device can change to pairing mode anytime during the lifetime of FidoDiscovery. As so add function to notify embedder when connected FidoAuthenticator changes its state to pairing mode. Bug: 877344 Change-Id: I3dc46e67064fdf7361b6cf2ef144d7daa907e92a Reviewed-on: https://chromium-review.googlesource.com/c/1246596 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#597261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8efa341839a6..78df3362ac21 git log 8efa341839a6..78df3362ac21 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 oetuaho@nvidia.com Fix clearing out-of-range default FB drawbuffer Created with: gclient setdep -r src/third_party/angle@78df3362ac21 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If6e4b8e98a5ff007e4f33f6c0f5ce582394fd6d7 Reviewed-on: https://chromium-review.googlesource.com/c/1265046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597260}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/96a0f6191781..ef8a3eb5221c git log 96a0f6191781..ef8a3eb5221c --date=short --no-merges --format='%ad %ae %s' 2018-10-05 niklas.enbom@webrtc.org Include NTP value in playout path. 2018-10-05 srte@webrtc.org Removes initial window field trial. 2018-10-05 phensman@webrtc.org Reland "Tidy up and increase exception handling in compare_videos" 2018-10-05 srte@webrtc.org Adds Clamping functions for DataRate. 2018-10-05 srte@webrtc.org Removes logging spam from congestion window. 2018-10-05 aleloi@webrtc.org Reland of 'Bug in histogram metric reporting.' 2018-10-05 brandtr@webrtc.org Remove old data files. 2018-10-05 stefan@webrtc.org Move FecController to RtpVideoSender. 2018-10-05 brandtr@webrtc.org Remove old video_bitrate_allocator.h 2018-10-05 phoglund@webrtc.org Use Chromium's code for locating the src dir. 2018-10-05 stefan@webrtc.org Add UMA metric and logging of frames dropped in the render queue. Created with: gclient setdep -r src/third_party/webrtc@ef8a3eb5221c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:b/80195113 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e8a33a6699e93da12bdc99774a3b662d0ef7d0b Reviewed-on: https://chromium-review.googlesource.com/c/1265355Reviewed-by:
-
bsheedy authored
Adds support for fake controller input when using OpenVR in the VR browser tests. This is done by adding several new functions and structs to the existing test hook and Mojo interface so that controller data set by a test is retrievable by the fake OpenVR implementation. Bug: 863487 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib9da6756df51093126d641e69fbf96ec05f2270b Reviewed-on: https://chromium-review.googlesource.com/c/1220806 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597258}
-
Sam Maier authored
This is to allow R8 to proguard and dex in one call, since it has some optimizations that only work when doing everything in one shot. Bug: 872904 Change-Id: Id2c75dac4d9feecae461a0b1e279056253f1b71b Reviewed-on: https://chromium-review.googlesource.com/c/1227142Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#597257}
-
Daniel Bratell authored
The DEPS system and gn will enforce some kind of dependency on //crypto if code needs to use crypto/wincrypt_shim.h. Now, that header file will not in itself indicate a dependency on actual code in //crypto so the dependency becomes a bit unexpected. By moving it to base/win, code can avoid depending on //crypto just to use that header file. This became an issue when //printing needed to use wincrypt_shim.h Change-Id: I68a3b8263da0d4307907a0b242444402675072a4 Reviewed-on: https://chromium-review.googlesource.com/c/1261024Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#597256}
-
Xi Han authored
This is a follow up CL for: https://crrev.com/c/1115783. In this CL, we use ScopedExecutionFence to prevents tasks running between the peorid from BrowserMainRunner is instantiated to BrowserMainLoop::CreateThreads() is called. Bug: 846846 Change-Id: I9dec8415e45f901c5883c196ab867c0ea4928594 Reviewed-on: https://chromium-review.googlesource.com/c/1174955 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#597255}
-
Steven Bennetts authored
Bug: 752315 Change-Id: Iaee8b7f66471482f08dc3c310523e6fb88bb7a50 Reviewed-on: https://chromium-review.googlesource.com/c/1260015Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597254}
-
Robert Ogden authored
Looks like I missed two things in implementation: * The preview security icon should be Modern Blue 600 * I switched the two colors, making Blue 300 primary instead of Blue 600 Bug: 871839 Change-Id: I3fe0ebaf0fb230a491bcae891ef3f29b4286c00b Reviewed-on: https://chromium-review.googlesource.com/c/1265021Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#597253}
-
Lambros Lambrou authored
In the per-frame statistics, instead of sending raw frame quantizer values from the VPX encoder (from 0-63), this sends a simple measure of frame quality, from 0-100, with 100 being a lossless frame. Bug: 888833 Change-Id: I9e869f2f302232d10311719a209c79e2492579b7 Reviewed-on: https://chromium-review.googlesource.com/c/1263560 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#597252}
-
Jun Choi authored
Expose BluetoothDevice::Pair() function to WebAuthN embedder layer via BleAdapterManager. Previously named BleAdapterPowerManager(which only handled notifying BluetoothAdapter power changes to the embedder) is now renamed to BleAdapterManager and it handles both a) Handling pairing events received from the UI layer. b) Handling events related to triggering/notifying BluetoothAdapter changes. Bug: 877344 TBR: ortuno@chromium.org Change-Id: I078f60cd4b0d491973276a3279503642c94d8d9d Reviewed-on: https://chromium-review.googlesource.com/c/1239621 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
-
Carlos IL authored
After crrev.com/c/1262637 interstiitals will link to a different support URL for Symantec errors, check against that one too in ConnectionHelpTabHelper. Change-Id: I1318534ad3db2235b1e8f5f383d7c69ad74db65c Reviewed-on: https://chromium-review.googlesource.com/c/1265081Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#597250}
-
danakj authored
When a renderer creates a new frame (via window.open()) it goes through a request to WebContentsImpl to ShowCreatedWindow(). This adds comments to that path, improves code style, changes variable names from "popup" to not confuse this path with popup widgets which are not frames/windows, and changes types to WebContentsImpl instead of WebContents to avoid some casting. Note that some of content does refer to frames/windows opened with window.open() as popups even though they are not popup widgets (ie WebPagePopup in the renderer). R=ajwong@chromium.org, avi@chromium.org Bug: 419087 Change-Id: I76e77a64669ad59577f9681d5bfff13b48830e52 Reviewed-on: https://chromium-review.googlesource.com/c/1262923 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#597249}
-
Tom Anderson authored
This is a followup to r596815 which added pipewire packages to sysroot-creator-sid.sh. That CL's author does not have write permission on the appropriate GCS bucket to upload the new sysroots, so this CL rolls the sysroots. R=thestig CC=tomas.popela@gmail.com Change-Id: Ia9af1c3c490bd0f60f4e0e0b4d32ad0cf09ace72 Reviewed-on: https://chromium-review.googlesource.com/c/1263579Reviewed-by:
-
Joanmarie Diggs authored
Child elements with role="presentation" and an explicit ARIA names (e.g. an aria-label value) were not participating in the name calculation due to the presentational role trumping the ARIA property value. The ARIA specification states that global ARIA properties trump the role. Fix this by having AXObject::DetermineAriaRoleAttribute() return kUnknown for presentational objects where AXObject::SupportsARIAAttributes() returns true. Change name of SupportsARIAAttributes() to HasGlobalARIAAttribute() as that is what the method appears to for. Also add missing global ARIA attribute to those being checked. In order to be more performant, iterate through all attributes and do a string match, removing sanity checks (e.g. on certain attribute values). This also makes the method more consistent with its new name, namely just checking the presence of a global ARIA attribute. Lastly, ensure that a space character gets inserted between inline block flow children when the text used for a child comes from a text alternative, such as an ARIA label, or a title or alt attribute. This insertion is specified in the Accessible Name and Description Computation specification and also consistent with what other user agents do. Bug: 891731 Change-Id: Ib906acc89ea6d0517288fe0d81e0b74f1abfa583 Reviewed-on: https://chromium-review.googlesource.com/c/1259124 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597247}
-
Jun Mukai authored
It's been flaky as far as I see in the FYI bot log. Bug: 892263 Test: none Change-Id: I5caf4329168d193d485bca908432f90c7b87ddd2 Reviewed-on: https://chromium-review.googlesource.com/c/1262415Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#597246}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Id19c417438950bb28415db1fb1e91abae23b9a8c Reviewed-on: https://chromium-review.googlesource.com/c/1265419Reviewed-by:
-
Tommy Steimel authored
This CL updates the volume slider length to be shorter in order to fix an issue where the slider is too long for the default audio controls length. Bug: 892048 Change-Id: I545fd2395ec277125f7c6edbfbdc56aa03b2580f Reviewed-on: https://chromium-review.googlesource.com/c/1265057Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597244}
-
Mounir Lamouri authored
Bug: 892483 Change-Id: Ia0a8347c1f31ba087759c2f53bea156f9d091d41 Reviewed-on: https://chromium-review.googlesource.com/c/1264818Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#597243}
-
Mounir Lamouri authored
This changes follow the spec with regards to pausing a video when it leaves a document: when a video leaves a document, the removal process should continue and, asynchronously, Blink checks that the video is still in an active document. It allows a video to move from one part of the document to another without pausing. Moving into a document or into two different outside of the document trees will also not pause. This is following the specification and Edge/Safari/Firefox implementations. Bug: 382879, 490511 Change-Id: I48abdaa5f81790e2cae7edc7b0bfb444f6ee7787 Reviewed-on: https://chromium-review.googlesource.com/c/1074808 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/64626344db73..942603d49e30 git log 64626344db73..942603d49e30 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ihf@chromium.org Add betty-arcnext to pre-cq. Created with: gclient setdep -r src/third_party/chromite@942603d49e30 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0660fda5253a32c71f5109b81b8413778e095779 Reviewed-on: https://chromium-review.googlesource.com/c/1265045Reviewed-by:
-
James Wallace-Lee authored
Pass mouse events to chromevox's mouse_handler.js, and fire hover events on mousemove. This allows mousemove events to cause spoken feedback using the same functions as touch exploration. Mouse events are only rewritten if the chromevox option speakTextUnderMouse is enabled. Note: chromevox only receives mousemove events when the mouse is down. Temporarily, this functionality is used by holding the mouse button down and moving the pointer around the page. Bug: 853581 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2feb14a1f5d765296fde9a923b862c99f45b41bb Reviewed-on: https://chromium-review.googlesource.com/c/1234260Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#597240}
-
Xi Han authored
In the new startup code, ServiceManagerContext (SMC) will be created before the BrowserMainRunner is created. In the constructor of SMC, the GetMediaTaskRunner() accesses the TaskRunner of a media thread created by CastBrowserMainParts which will be created after the BrowserMainRunner. So we make the CastContentBrowserClient own the media thread and create it upon request. Bug: 887638 Change-Id: I8986f5b00600760afc8bf00bac140f459c7145d1 Reviewed-on: https://chromium-review.googlesource.com/c/1258204 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597239}
-
Christopher Cameron authored
Track parent and children in BridgedNativeWidgetHostImpl. This tracking is already done in BridgedNativeWidgetImpl, which is not necessarily accessible in the browser process. Update the parent in NativeWidgetPrivate::ReparentNativeView, but only when the BridgedNativeWidgetImpl state would be updated by BridgedNativeWidgetImpl::ReparentNativeView. Remove BridgedNativeWidgetHostImpl from its parent in OnWindowWillClose. Move removal of children from being in BridgedNativeWidgetImpl's destructor to between calling OnWindowWillClose and OnWindowHasClosed, to ensure that all children have detached themselves before their parent is destroyed. Update some functions in NativeWidgetMac and NativeWidgetPrivate to use the state in BridgedNativeWidgetHostImpl, instead of using the state in BridgedNativeWidgetImpl. Bug: 859152 Change-Id: Id98b9239db88154d9304f84d369d40d47af61d0f Reviewed-on: https://chromium-review.googlesource.com/c/1262624 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#597238}
-
Kurt Horimoto authored
Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iadcd8c150ab8cf90821f0ea9bef7e71eccf706d6 Reviewed-on: https://chromium-review.googlesource.com/c/1262796 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597237}
-
Jonathan Metzman authored
Bug: 888006 Change-Id: I95b5936b1d9f2358a1b6dd75f7f3e3f1edcf2dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1260217 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#597236}
-
Anne Lim authored
Implemented a cache in form of a [key, StrikeData] map for set or retrieved values to avoid hitting the disk repeatedly for the same card. Bug: 884717 Change-Id: I5e8a5936a54f30a64a919a97314cd04d3874b2a2 Reviewed-on: https://chromium-review.googlesource.com/c/1249130 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#597235}
-
Drew Davenport authored
In UpdateControllerToWindowMapping, EnableController only needs to be called if the window is moving from one controller to another. Check if the window was not associated with a controller, and do not call EnableController in that case. BUG=888561 Change-Id: Ie077c13c804dbbce9315c75b6ad22a3ec4d6c8d8 Reviewed-on: https://chromium-review.googlesource.com/c/1263415Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#597234}
-
Marijn Kruisselbrink authored
This is a reland of 9594a943 Original change's description: > [FileSystem] Add support for selecting multiple files or directories. > > Bug: 878581 > Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c > Reviewed-on: https://chromium-review.googlesource.com/1227366 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594132} Tbr: dmurph@chromium.org, dcheng@chromium.org Bug: 878581 Change-Id: Ic145a6b48279f29368fbbc802751eb3d43b4ef4c Reviewed-on: https://chromium-review.googlesource.com/c/1265058Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597233}
-
Morten Stenshorne authored
Remove NG special code from LayoutText::DebugRect() and have it call FirstRunOrigin() instead of FirstRunX() and FirstRunY(). Remove those two methods. Also update WriteTextFragment(), so that the coordinates it outputs match those from DebugRect(). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I10947db5a031580095633eb690711720736c99d1 Reviewed-on: https://chromium-review.googlesource.com/c/1264639 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597232}
-
Jian Li authored
Also make EoS url fetcher support immediate or background fetch with different backoff policy. Bug: 867488 Change-Id: If41abed1f85781cf84b9038f600e0a94c6c1524c Reviewed-on: https://chromium-review.googlesource.com/c/1263053 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#597231}
-
Matt Menke authored
Since NetLog is moving to the network service, we will no longer need ChromeNetLog. This is a step towards removing the class, while maintaining all functionality. This is the only member of ChromeNetLog that was used on iOS, so this CL also updates iOS to use NetLog directly instead. Bug: 767450 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0ef4674b564f4575e256d40795bac051242ccf2a Reviewed-on: https://chromium-review.googlesource.com/c/1264915 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
-
Scott Violet authored
This argument ended up setting the field twist on PointerDetails. The TouchEvent constructor *also* takes a PointerDetails. So, having TouchEvent reset the twist was mildly confusing, especially when it has a default value. This patch removes the angle argument to PointerDetails. BUG=none TEST=covered by tests Change-Id: I5edf042df2e6e61c73a406bf2f15f45079991cb9 Reviewed-on: https://chromium-review.googlesource.com/c/1264975Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597229}
-
Lan Wei authored
In the test "hover-during-scroll.html", we tried to test that new hover effects should not be invoked during scroll if the mouse cursor is not visible, so we set |internals.setIsCursorVisible| to false. However, when we run the test, we set the mouse cursor visible to true when we run smoothScroll function, and a mouse move will also set the mouse cursor to be true. Therefore, we should remove the related code from this test. Bug: 877132 Change-Id: I860b778dacc62c20dbd541d607a2b4ee83bb84b1 Reviewed-on: https://chromium-review.googlesource.com/c/1250082Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#597228}
-
Steven Bennetts authored
This also includes some cleanup of default values, renames 'override' -> 'behavior', and documents the KeyboardOverscrollBehavior enum. Bug: 843332 Change-Id: I5149d41701ff44606f2ce4dec3f74d263ed411d2 Reviewed-on: https://chromium-review.googlesource.com/c/1262958Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#597227}
-
Donn Denman authored
Introduced recently in CL https://chromium-review.googlesource.com/c/chromium/src/+/1262090. BUG=892669 Change-Id: I9b69ba69c0a950c11de218a622bce041b4b6a98f Reviewed-on: https://chromium-review.googlesource.com/c/1265156Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#597226}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/497958d899c3..03cbf33a695e git log 497958d899c3..03cbf33a695e --date=short --no-merges --format='%ad %ae %s' 2018-10-05 jaebaek@google.com Validator: FPRoundingMode decoration (#1482) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@03cbf33a695e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I43af696c49d7bbcd206ec534629ad1568bbdbfb2 Reviewed-on: https://chromium-review.googlesource.com/c/1265067Reviewed-by:
-
danakj authored
Currently the URL is acquired through a few jumps between RenderWidget and RenderViewImpl. RenderFrameImpl asks RenderView for the URL, but it is actually asking the RenderWidget. RenderWidget goes to the owner delegate if present, so back to the RenderView, to get the main frame in order to get the URL. With pepper, the RenderWidgetFullscreenPepper overrides the RenderWidget method, so when it tries to get the URL it ends up going to the pepper object instead. This makes 2 different ways that the GetURLForGraphicsContext3D() method gets redirected. Then also the UpdateURLForCompositorUKM() finds the main frame and gets the URL itself, if the RenderWidget is attached to the main frame. Notably, popups do not provide a way to redirect GetURLForGraphicsContext3D(), so they do not get a URL at all for the gpu channel ever. Instead of these many methods, we add a GetURLForDebugTrace() method on WebWidget, that RenderWidget can query. When the RenderWidget is for a frame, the WebFrameWidget will acquire the URL. When the RenderWidget is for a popup, the WebPagePopupImpl will do likewise, from the frame tree that spawned the popup. And when the RenderWidget is for fullscreen pepper, the PepperWidget can know the URL and return it (in this case RenderFrameImpl continues to grab the URL and give it to the RenderWidgetFullscreenPepper in order for it to provide it. Then UKM can also use this method, and but just only use the URL if the RenderWidget is itself attached to the main frame, which can be queried without involving the RenderView. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: Iad18c5f7ea902eaa02f58645ede61a5b4609b561 Reviewed-on: https://chromium-review.googlesource.com/c/1237177 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597224}
-
rbpotter authored
Fixing and enabling: CrSettingsInternetDetailPageTest.InternetDetailPage CrSettingsInternetPageTest.InternetPage Bug: 875454 Change-Id: I2a1f31c623d67e178ab99d3558aa9e7e06a8c8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1262934Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597223}
-
