- 19 Sep, 2017 40 commits
-
-
Lucas Garron authored
This CL also adds unit tests for .foo preloading and updates two tests that were using http://foo as a test URL. There are still other places in the code that use http[s]://foo as a test domain. If this change causes issues for them down the line, they should be changed to use foo.test or another domain under a test TLD: https://tools.ietf.org/html/rfc2606#section-2 BUG=b/65158868 (Google-internal) Change-Id: I8005a3767677e819b8df898ccc073cf1db523d60 Reviewed-on: https://chromium-review.googlesource.com/669396Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#502948}
-
yucliu authored
In offline, MediaDrm provision will fail because browser can't send provision request. This will return a null MediaCrypto object to VDA. This patch: 1. Return empty String from Java, instead of null when calling getSecurityLevel. 2. Make OnMediaCryptoCB always return a valid std::unique_ptr<JavaRef> of MediaCrypto. Client is expected to check if JavaRef contains a null object instead of checking if std::unique_ptr contains a null JavaRef. 3. AVDA::SetOverlayInfo early returns if in ERROR state. BUG=762192 TEST=repro step in the bug Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie264e5a1d803fd4d2afbbdabcac7d1b600e26f85 Reviewed-on: https://chromium-review.googlesource.com/669776Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502947}
-
David Tseng authored
Bug: 763249 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ide7da288c77645cd16391a6de869f91c6f89cad3 Reviewed-on: https://chromium-review.googlesource.com/671497 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#502946}
-
Sandeep Vijayasekar authored
BUG=internal b/63104369 BUG=internal b/64753989 TEST=run cast_shell_junit_tests Change-Id: I3d6aea7e5434bdb206d2ba0ab47a1a84d118c218 Reviewed-on: https://chromium-review.googlesource.com/659177 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#502945}
-
yucliu authored
Avoid run video only test on audio only build. BUG=internal b/65382374 TEST=Build Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idcfa3fa2cc3d0e3e54a311274bcb05fda1507c58 Reviewed-on: https://chromium-review.googlesource.com/673128Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502944}
-
Scott Nichols authored
Bug: 611181 Change-Id: Ie1e5d658455ac553ece2417cd3b11e86fbbafe61 Reviewed-on: https://chromium-review.googlesource.com/630336 Commit-Queue: Scott Nichols <nicholss@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#502943}
-
Toni Barzic authored
Removes the following methods (that became unneeded since background state is not used anymore): * MoveToBackground - use CloseLockScreenNote instead * MoveToForeground - no-op unless in background state * RecordLockScreenAppUnlockAction - no-op unless in background state BUG=765039 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifea8f289b24f96c21dd0675f2fc4cfa0c9d0e49d Reviewed-on: https://chromium-review.googlesource.com/668236 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#502942}
-
Etienne Bergeron authored
This CL is lowering down the thresholds to trigger a detailed memory dump. Android is now using a different set of metrics. These metrics are based on recent memory usage for canary users. Bug: 753514 Change-Id: I3a56d150d29f027fcc954e4fa1228670a6db7b5e Reviewed-on: https://chromium-review.googlesource.com/671768Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502941}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/2d510f7dc4d6..c2db74bb65ab $ git log 2d510f7dc..c2db74bb6 --date=short --no-merges --format='%ad %ae %s' 2017-09-19 thestig Default to c++11 instead of c++14. 2017-09-19 dsinclair Setting focus on a widget may destroy the widget Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I57db7330aa7d221aa3a5e9e336d90fe76be8d8dd Reviewed-on: https://chromium-review.googlesource.com/673131 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502940}
-
Mikhail Atuchin authored
The CL fix UpdateClient::IsUpdating behavior for queued updates. Bug: Change-Id: Ic9af70338a702e8e4356f5fda55e5cd35e415105 Reviewed-on: https://chromium-review.googlesource.com/671348Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#502939}
-
Takumi Fujimoto authored
Bug: 766181 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I697b83366ab4f53c5414d713c521a91f569a69db Reviewed-on: https://chromium-review.googlesource.com/671478Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#502938}
-
danakj authored
These are part of the viz display service, not the cc layer compositor, so move them from cc/output to components/viz/service/display. NOTRY=true Bug: 722935 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I72f79828cf353e3d5edbec68b3436806456b05d3 Reviewed-on: https://chromium-review.googlesource.com/669007 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Xingyu Zhang <staraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502937}
-
Fady Samuel authored
Prior to this CL, there were two ways to specify transparent backgrounds: 1. LayerTreeHost::SetHasTransparentBackground(true) 2. LayerTreeHost::SetBackgroundColor(SK_ColorTRANSPARENT) The former avoided filling the background of the LayerTreeHost with SolidColorDrawQuads, while the latter would cause transparent gutter in DelegatedFrameHost, and fill the background with *transparent* SolidColorDrawQuads. This CL unifies this into 2. Setting SK_ColorTRANSPARENT as the background color will now avoid generating extra SolidColorDrawQuads. After this CL, guttering can be implemented in Viz based on the background color specified in CompositorFrameMetadata if that color is not Sk_ColorTRANSPARENT. If the color is transparent, like in top level windows in Mus+Ash, the embedder (Ash in this case) will perform the guttering (in order to avoid obscuring the window decorations). Bug: 766013 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaca9a230ba42cbd8cf70b8fb833af5e8b5e145ea Reviewed-on: https://chromium-review.googlesource.com/669646Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502936}
-
Lutz Justen authored
Separates translation of policy_templates.json using grit from writing the different output files like admx, doc and json. Moves template generation to components/policy since this is where it belongs and where its owners are. It's really not a translation task. Makes templates more maintainable by multiplexing per-language file paths instead of having them all spelled out. Scripts also multiples files and do (and can) not rely on grit anymore to generate output lists. Google.adm? files do not need special casing anymore. They are generated like other adm? files. BUG=chromium:165412 TEST=tools/grit/grit/test_suite_all.py components/policy/tools/template_writers/test_suite_all.py Verified folder diff of outputs from old code vs new code are the same. Change-Id: Iac7acbc855186abf6e45606fb304ddbe1e4d8447 Reviewed-on: https://chromium-review.googlesource.com/654870Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#502935}
-
Steven Bennetts authored
This is now part of the details dialog for the Cellular network. BUG=717063 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib221c819fe0f76220d7bbd88d30525df171581a7 Reviewed-on: https://chromium-review.googlesource.com/669952Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502934}
-
Nick Carter authored
In TableModelObserver, support a OnItemsMoved() operation which indicates that a number of rows have been reordered in the model. In a subsequent CL, the TaskManagerTableModel will emit these, with the goal being to keep a tab properly selected during cross-process navigation. In TableView and its unittest, handle the OnItemsMoved() operation, by updating the ListSelectionModel as appropriate. In ListSelectionModel, Add a |length| parameter to Move, and provide an efficient implementation of this. Implement IncrementFrom() and DecrementFrom() in terms of the Move() operation. Add unittests that exercise Move(). Bug: 527455 Change-Id: I448bc18b2a3efbe6b2acb78d73ee350212bbf485 Reviewed-on: https://chromium-review.googlesource.com/661757 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#502933}
-
Maxim Kolosovskiy authored
Bug: 753806 Change-Id: I9c735122920dbc20a543125d9fa3fd0dc076845a Reviewed-on: https://chromium-review.googlesource.com/672823Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#502932}
-
Rouslan Solomakhin authored
Bug: 765951 Change-Id: Ib445ab84cc3be7f8aa8be327497c8af73c204456 Reviewed-on: https://chromium-review.googlesource.com/673097Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502931}
-
Helen Li authored
TBR=rdsmith@chromium.org Bug: 762686 Change-Id: I644d345d283528b417a5a8398bf40530a8ace1f7 Reviewed-on: https://chromium-review.googlesource.com/673095Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502930}
-
Pavel Feldman authored
Bug: 765506 Change-Id: I16fbe56180f96eb1daf504510a6d07965e226622 TBR: (api is changing) Reviewed-on: https://chromium-review.googlesource.com/667804 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#502929}
-
Bettina Dea authored
Changes in this patch: -Created a IncognitoWindowTracker class, which contains methods to notify the IPH server when events happen and if the help UI should be triggered. -Created a IncognitoWindowTrackerFactory class and registered in the chrome browser main parts. -Added unit tests for IncognitoWindowTracker event logging and expected functionality. -Take out event_on_history_deleted as we don't actually need to record this. Bug: 734248 Change-Id: Ib25154c50f952b9349884eb48eb58ef1d757a9bb Reviewed-on: https://chromium-review.googlesource.com/666333 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502928}
-
Walter Korman authored
Simplifies code in parts of KeyframedAnimationCurve and TransformOperations. Following we broke out separately on the off chance that there are performance ramifications. https: //chromium-review.googlesource.com/c/chromium/src/+/673346 which Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9591f1dd17b2c2607200694e7169fa52106d5244 Reviewed-on: https://chromium-review.googlesource.com/673351Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#502927}
-
Ian Vollick authored
With this CL you can now iterate across elements both forward and backward (for rendering and hit testing, respectively). Bug: None Change-Id: Iadc1f43353ac5ed8cef550103bac223129802035 Reviewed-on: https://chromium-review.googlesource.com/672605 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#502926}
-
Bo Liu authored
From "Intel" to "Intel.*". Follow up to previous change that actually missed certain edge devices. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id3d815dcb7f415955f71c19e4d1c1546ab5f8221 Reviewed-on: https://chromium-review.googlesource.com/673373Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502925}
-
Robert Sesek authored
This is a reland of 7844944f Original change's description: > [Android] Allow __NR_process_vm_readv under Seccomp. > > Bug: 766245 > Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d > Reviewed-on: https://chromium-review.googlesource.com/671556 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502714} Bug: 766245, 766400 Change-Id: I369421422f8bced50a5577167b5ccb59f9901f3d Reviewed-on: https://chromium-review.googlesource.com/672643Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#502924}
-
Robert Hogan authored
Bug: 759195 Change-Id: I06e0d3e61badeab247e0fa9d6e3677113f7c461a Reviewed-on: https://chromium-review.googlesource.com/671366Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#502923}
-
Yuke Liao authored
This CL adds support to the code coverage tool to include files by build targets and also exclude files by paths or build targets. The motivation of this change is that some view controllers are not supposed to have unit tests, and instead, they should run agaist integration tests in terms of code coverage. Given that view controllers are often grouped together by build targets, so it is desirable to have a way to include or exclude the sources of a list of build targets in the code coverage report. Bug: 763959 Change-Id: I68079e0e6e5952883259b8806cb250166d0a50dc Reviewed-on: https://chromium-review.googlesource.com/669979 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#502922}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/371ed53..abd3135 BUG=,None,chromium:507755,697758,chromium:759402,chromium:765363 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id871246203c86489e25aac00149b1590cdb5f3e0 Reviewed-on: https://chromium-review.googlesource.com/673403Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#502921}
-
Morten Stenshorne authored
In particular, avoid <algorithm>. Specifying the default template parameters to Vector in Forward.h means that we can no longer specify them along with the template definition. Bug: 766315 Change-Id: I62eeaf5da82f59431d68011f904a1fcaf9f93f81 Reviewed-on: https://chromium-review.googlesource.com/668367 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#502920}
-
Maria Khomenko authored
BUG=766695 Change-Id: Id1ab14ac9bd32aec910b2de4dd5cf8119ecd8eb8 Reviewed-on: https://chromium-review.googlesource.com/673203Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#502919}
-
David Reveman authored
This adds a --pen-devices flag that works the same way as --touch-devices and makes it possible to simulate pen devices on Linux in addition to the current support for touch devices. Bug: Test: manual Change-Id: Icc103b029b91b1e9e5d12e89c594069da38577ed Reviewed-on: https://chromium-review.googlesource.com/667719 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#502918}
-
Rouslan Solomakhin authored
Bug: 765272 Change-Id: I6765342abbe88489690a6759d3f6dfadfa6b427b Reviewed-on: https://chromium-review.googlesource.com/673270Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502917}
-
Sergey Ulanov authored
Python doesn't work on Android, iOS and Fuchsia, so it doesn't make sense to compile PythonUtils there. Also disabled compilation of LocalTestServer and LocalSyncTestServer on Android because they are not used there. Bug: 731302 Change-Id: I35361cbd79f10bca5122b375a63ab1ac0e31d7bf Reviewed-on: https://chromium-review.googlesource.com/663100Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502916}
-
Peter Qiu authored
Bug: internal b/65850770 Test: cast video using Youtube app Change-Id: Ic2093170c2fc2ecace6e8580a3dacabd504ca75e Reviewed-on: https://chromium-review.googlesource.com/671133Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#502915}
-
Jeffrey Kardatzke authored
This adds support for sending a GPU Mojo interface to the OEMCrypto daemon so that it can communicate with the GPU to get access to secure buffers for storing decrypted content. The actual implementation of the Mojo interface will be done in another CL. BUG=b:62576736 TEST=E2E test w/ & w/out secure buffers work (used prototype for secure) Change-Id: Ifb4677e3349530efd5115c0a81249e71cbdb2e2b Reviewed-on: https://chromium-review.googlesource.com/671412Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#502914}
-
Walter Korman authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0bad150bb7a896042c37784c0f7a3870aa56e82b Reviewed-on: https://chromium-review.googlesource.com/673346 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502913}
-
Mark Pilgrim authored
Create net::OnceCompletionCallback and use it in AppCacheService::GetAllAppCacheInfo TBR=jam@chromium.org Bug: 714018 Change-Id: Ie134d99a7c54deb9ded852e3a817420f5ac59b93 Reviewed-on: https://chromium-review.googlesource.com/664844 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#502912}
-
Denis Kuznetsov authored
Reorder calls so that parent_webview_ is always defined in gaia.chromeOSLogin.backButton / gaia.chromeOSLogin.clearOldAttempts calls. Bug: Change-Id: I1c938b4ff522f7299f500e6de39248487bd857b2 Reviewed-on: https://chromium-review.googlesource.com/667179Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#502911}
-
Darin Fisher authored
This change introduces a new service (SharedWorkerFactory) exported from renderer processes to support the instantiation of shared worker instances. The SharedWorkerFactory is instantiated from within the SharedWorkerServiceImpl::TryReserve function, which runs on the UI thread. This way we defer connecting to that service until we want to create a shared worker. It also allows the unit tests to swap in a mock implementation of SharedWorkerFactory. In a future CL, it'll be possible to remove the SharedWorkerMessageFilter. Even though that class now no longer filters any Chrome IPC messages, its other functionality is still needed. Similarly, we still need to allocate a routing ID for the shared worker even though that is not needed by the shared worker infrastructure. Dev Tools uses the routing ID to help lookup the shared worker, so that'll need to change before we clean this up. Also, in a future CL, it'll be possible to move the shared worker service code to run entirely on the UI thread. This will allow a lot of code simplification as we'll no longer have to deal w/ the race conditions during process reservation. A bunch of complexity will disappear. To try to keep this CL manageable, I chose to postpone the threading changes to a follow-up CL. The lifetime of the SharedWorker instance in the renderer process is a bit squirrely thanks to how WebSharedWorker manages its lifetime. This CL does not attempt any changes there. Bug: 612308 Change-Id: Ifc355d42d0c869519acee853c953342a2bcf691a Reviewed-on: https://chromium-review.googlesource.com/659139Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda (slow) <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502910}
-
Tatiana Gornak authored
After the user clicks bin icon, display the toast that notifies about the deletion. BUG=764078 Change-Id: Ie50bea0d7d7a730e1522ca85bd7e136829e5e14a Reviewed-on: https://chromium-review.googlesource.com/670863Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#502909}
-