- 07 Jun, 2018 14 commits
-
-
Rintaro Kuroiwa authored
- Because PowerMonitor uses ObserverListThreadSafe, the observers are notified on the sequence from which they were registered. Change-Id: Iea01ec415fca7b9b327a9b1d92ed77008e0cd77c Reviewed-on: https://chromium-review.googlesource.com/1089584Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#565122}
-
Dongseong Hwang authored
WebRTC causes GPU hang on ChromeOS because of this bug. WebRTC can switch the resolution of video size depending on network condition. So the first size-changed frame can be inter frame. However, vp8 decoder assumes the first size-changed frame is always key frame, and passes wrong size value with the different sized encoded data and then libva causes GPU hang. Unfortunately, we don't know the first inter frame after rtc dropping frames has different size or not, because vp8 doesn't store the size in inter frame. So this CL makes vp8 decoder give up decoding all inter frames when rtc dropping frames. If vp8 decoder has to skip more than 75 frames (i.e. around 3 secs), it reports decode error to request new keyframe. In the same sense, vp9 decoder also doesn't report decode error until 75 frames skipped. Extract P frame from bear-320x240.webm to add an unittest by Sreerenj <sreerenj.balachandran@intel.com> gst-launch-1.0 -v filesrc location=bear-320x240.webm ! matroskademux ! multifilesink location=vp8-frame-320x240_%d TEST=run https://appr.tc/?vsc=vp8 on 2 IA chromebooks. e.g. KBL, APL, SKL add VP8DecoderTest in media_unittests BUG=831037, b/72676160 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2e116efcc28ebdbea9739c84b28ce3027eac836d Reviewed-on: https://chromium-review.googlesource.com/1009324 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#565121}
-
John Chen authored
Add a missing call to base class tearDown in ExistingUserDataDirTest, to fix breakage in waterfall. Bug: chromedriver:2446 Change-Id: Ibf0356c53edb92d729aa3d5b8de01a1471fc8bdf Reviewed-on: https://chromium-review.googlesource.com/1090040Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#565120}
-
James Cook authored
For out-of-process ash code in //chrome/browser can't call into ash. BrowserStatusMonitor was installing a global window activation observer on ash::Shell. However, it doesn't need to do that anymore. The code was written to change the brightness of the "running" dot we show under the shelf icon for a v1 (non-packaged) app. However, with the MD redesign of the shelf we always use the same dot so we don't need to track activation state any more. See removal of ash::STATUS_ACTIVE from enum ShelfItemStatus in https://chromium-review.googlesource.com/c/chromium/src/+/758800 Bug: 850184, 557406 Test: browser_tests --gtest_filter=*Launcher* Change-Id: I38ed5e563d8b52386c53fafd17174608cd4ef8d6 Reviewed-on: https://chromium-review.googlesource.com/1089914Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#565119}
-
Zhenyao Mo authored
Regardless of driver being older BUG=721121 TEST=manual on a AMD switchable win10 device with older driver R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25456570984ccbe2bcdf0d452acb71e37a8571ca Reviewed-on: https://chromium-review.googlesource.com/1089835Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#565118}
-
Joey Scarr authored
For the following string-valued define: defines = [ "CR_CLANG_REVISION=\"$clang_revision\"" ] this was outputting the following on Windows: -D"CR_CLANG_REVISION=\"332838-1\"" The Windows shell can't handle the extra quotes, and so the following macro was being written: #define "CR_CLANG_REVISION "332838-1"" This change moves the first quote to before the -D, allowing Windows to correctly handle the define parameter. R=brettw@chromium.org Bug: 396230 Change-Id: I4f6f70acf775577ff9b3077eba9ebf7f8d002da1 Reviewed-on: https://chromium-review.googlesource.com/1071274Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#565117}
-
Kevin Marshall authored
Defines the initial high-level structure for the "web" library, and as a starting point, defines enough functionality that it can be used in place of the existing WebView component in Fuchsia. Bug: 822474 Change-Id: I870b217b8b3fbd4581ca511403c7759491a8d35d Reviewed-on: https://chromium-review.googlesource.com/1083414 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565116}
-
Peter Boström authored
This provides circular inkdrops for favicon-only bookmarks for both Refresh and Touchable Refresh (the insets are different for the larger buttons). As this makes the ink-drop end cap start at the center of the favicon, this also looks significantly better for circular favicons. The change also fixes the way-too-small insets in Touchable Refresh (as they were overridden by Refresh in MaterialRefreshLayoutProvider). Bug: chromium:822072, chromium:834503 Change-Id: I12586a7588a0fb5163d25b43ebd327df65da6862 Reviewed-on: https://chromium-review.googlesource.com/1082477 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#565115}
-
Antoine Labour authored
This refactors MailboxToSurfaceBridge a bit based on existing callers. A follow-up change will merge GenMailboxCHROMIUM and ProduceTextureDirectCHROMIUM. DestroyMailboxTexture was dead code, so removed. We can resurrect in a later CL if needed. Bug: 847674 Change-Id: I8fa52a4b7288955d3571c41bdf7b23f0ca4290f0 Reviewed-on: https://chromium-review.googlesource.com/1083333Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565114}
-
edchin authored
Bug: 804589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib1ad651adb3d7c1025ab5e50375bc291cef52aed Reviewed-on: https://chromium-review.googlesource.com/1090004Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565113}
-
Marcin Wiacek authored
Change-Id: I4eea2645f0439d1cb6ccf53e0ac1ddd359e1b95b Reviewed-on: https://chromium-review.googlesource.com/1089340 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#565112}
-
Xiaocheng Hu authored
When calling PositionForPoint() on an inline element with continuation, we need to find the correct block flow to enter. Legacy has such handling, but NG currently doesn't. As NG currently doesn't build its own tree, which means continuation info is only available in legacy layout tree, this patch makes NG PositionForPoint() reuse the legacy handling code to find the correct block flow. Bug: 811502 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7155d09cc4f820580b2f72d316fabc345dd4d848 Reviewed-on: https://chromium-review.googlesource.com/1087826 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#565111}
-
Xing Liu authored
When user disabled the download location dialog, we need to show the duplicate infobar. Bug: 849876 Change-Id: I2efad87e670291dd453b12fa157ea10e7cb77011 Reviewed-on: https://chromium-review.googlesource.com/1088236Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#565110}
-
Robbie McElrath authored
Bug: 612330 Change-Id: I9f99f13f6450787fa8cee7e8dfb73edb10c961dd Reviewed-on: https://chromium-review.googlesource.com/1089632Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#565109}
-
- 06 Jun, 2018 26 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce4b14e..6ffd840 git log ce4b14e..6ffd840 --date=short --no-merges --format='%ad %ae %s' 2018-06-06 tsepez@chromium.org Remove still more v8::Context slot usage. 2018-06-06 rharrison@chromium.org Unsuppress dynamic_password_field_background_fill.pdf 2018-06-06 art-snake@yandex-team.ru Reland "Simplify CPDF_HintsTable." 2018-06-06 rharrison@chromium.org Add ability to log click events reaching PDFium 2018-06-06 hnakashima@chromium.org Embedder tests can write saved PDFs to a file for debugging. 2018-06-06 tsepez@chromium.org Get global consts without use of v8::Context slot 2018-06-06 tsepez@chromium.org Stop using some v8::Context slot to find runtime. 2018-06-06 dsinclair@chromium.org [fm2js] Fixup initialized variable conversion 2018-06-06 dsinclair@chromium.org [xfa] Make class error description better 2018-06-06 art-snake@yandex-team.ru Simplify check root availability. Created with: gclient setdep -r src/third_party/pdfium@6ffd840 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2a5c7744e80be5a86b557eaca8073b6b5ab70cd1 Reviewed-on: https://chromium-review.googlesource.com/1089970Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565108}
-
Antoine Labour authored
This avoids producing the same texture multiple times with the same mailbox, which is redundant. A follow-up change will merge GenMailboxCHROMIUM and ProduceTextureDirectCHROMIUM. Bug: 847674 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I20561edc0490a1f2e2ea86af9c778c48a14a57fe Reviewed-on: https://chromium-review.googlesource.com/1083142Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565107}
-
Bruce Dawson authored
This change updates the VS 2017 package to fix a bad version of dbghelp.dll in the Debuggers package, caused by a now-obsolete workaround in the packaging script, removed in crrev.com/c/1086990. The package still uses VS 2017 Update 7.1 and the 10.0.17134.12 SDK. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading VS 2017 Update 7.1, from https://www.visualstudio.com/vs/, and then passing these parameters to the installer: --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add the Debuggers package. Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.17134.0 The results were compared to make sure that there were no unintended changes. One quirk is that the new package is missing the arm/arm64 directories in Debuggers, which is correct, whereas the previous package was *not* missing them, for some reason. Other than that there are no unintended changes. Bug: 773476, 846313 Change-Id: I43db2ea95999fb7b2aeb02ba078e70298b62ffad Reviewed-on: https://chromium-review.googlesource.com/1086992Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#565106}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91b51619..29182915 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I881d0315dae905de95924c2b958bc9491e0f3fe1 Reviewed-on: https://chromium-review.googlesource.com/1089656Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#565105}
-
Frank Liberato authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I02d7fcb62abda9eab421aee71dd8229b5f21ba2c Reviewed-on: https://chromium-review.googlesource.com/1081232Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#565104}
-
Christian Biesinger authored
This should avoid some double-layouts, and as a side-effect (the original motivation) it also makes sure that we mark any descendants we find for UseOldOutOfFlowPositioning(), which fixes a number of DCHECK(!NeedsLayout) failures. That works through the result->OutOfFlowPositionedDescendants() loop in LayoutNGBlockFlow::UpdateOutOfFlowBlockLayout. Bug: 849839 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If885b16cedaa01b65f7fe2548e42a48c5d3a8a0d Reviewed-on: https://chromium-review.googlesource.com/1089652Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#565103}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f454bd3..e0aeedd git log f454bd3..e0aeedd --date=short --no-merges --format='%ad %ae %s' 2018-06-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0211346..2bd1fab (3 commits) 2018-06-06 herb@google.com Smarter use of glyph cache 2018-06-06 brianosman@google.com Fix matrix multiplication order 2018-06-06 kjlubick@google.com Add Dockerfile for building and running local Skia checkout with SwiftShader 2018-06-06 herb@google.com Reland "Have draw(Text|PosText|PosTextH) use a single entry on the device" 2018-06-06 brianosman@google.com Update MSVS toolchain for bots: Created with: gclient setdep -r src/third_party/skia@e0aeedd The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@chromium.org Change-Id: Iaef7ec046071d9677d0c9919d8e86e57b54cf663 Reviewed-on: https://chromium-review.googlesource.com/1089491Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565102}
-
Ryan Tseng authored
Bug: 790277, 790274, 790292, 790281 Change-Id: I719d67df74e137855ac3c4f5e8a6586aae07b661 Reviewed-on: https://chromium-review.googlesource.com/1090033Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#565101}
-
Scott Violet authored
Now that we reset the connection when nothing is focused we need to ack any pending events. BUG=681563 TEST=covered by test Change-Id: I1fc3219a04a49f911434ea8def7d9eca223c4ab6 Reviewed-on: https://chromium-review.googlesource.com/1089885Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#565100}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6563513..71e9aae Created with: gclient setdep -r src-internal@71e9aae The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:848052 TBR=mmoss@chromium.org Change-Id: Ie5924c890330352337a5fd2905c0679dbf62a145 Reviewed-on: https://chromium-review.googlesource.com/1089692Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565099}
-
Dominik Röttsches authored
Change-Id: I402ab2491cc71d76169c2336d0a514fba18375c4 Reviewed-on: https://chromium-review.googlesource.com/1089111Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#565098}
-
Xi Cheng authored
Change-Id: Ie3d2ebaf98ca26de363dd961f64d5461b909ec14 Reviewed-on: https://chromium-review.googlesource.com/1089803Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#565097}
-
Findit authored
This reverts commit 413675e9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 564933 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQxMzY3NWU5YjY2N2UwN2FlODRhMTE1MjY4YWJlZGZkYjc0MzA3NDAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7480 Sample Failed Step: browser_tests Original change's description: > Run PrioritizedTaskRunner tasks with the same priority in posting order > > What: > If two tasks have the same priority, they should run in posting order. > > A second thing this CL does is fix a race in the unittests. I meant to block > the task runner before queueing up requests but failed to. Fixed here. > > Why: > This can prevent hypothetical task starvation. It's also necessary for the > SimpleCachePrioritization control group to ensure that we maintain old > behavior. > > Bug: 850085 > Change-Id: I1f259296604bf04ea33ecbee9ad3180f064c4266 > Reviewed-on: https://chromium-review.googlesource.com/1088759 > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564933} Change-Id: Id4930090c0026aefa9d92bb8871e809a3fcfa124 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 850085 Reviewed-on: https://chromium-review.googlesource.com/1089892 Cr-Commit-Position: refs/heads/master@{#565096}
-
Nigel Tao authored
This brings the (still hand-written) externs/file_manager_private.js file closer to what tools/json_schema_compiler/compiler.py generates. Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3dfdddd9a6b9c0d67d143f89a5f9348eaecb4ae Reviewed-on: https://chromium-review.googlesource.com/1088345Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565095}
-
Charlie Ma authored
Bug: 845328 Change-Id: Ia55620022af7303904c3da0987f1514822d8c973 Reviewed-on: https://chromium-review.googlesource.com/1089865Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Charlie Ma <charliema@chromium.org> Cr-Commit-Position: refs/heads/master@{#565094}
-
Lei Zhang authored
Change-Id: Id296f888fc40eb2758c6fc9827024e2871082b37 Reviewed-on: https://chromium-review.googlesource.com/1087398Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#565093}
-
Erik Jensen authored
On Linux, the user-session binary, after forking the host deamon, keeps running in the foreground to relay log messages and return the ultimate success/failure of starting the host to the caller. However, if the host takes more than 120 seconds to signal it is online, the foreground process will time out and quit, leaving the background process running. With this commit, the foreground process will optimistically return success to the calling process in this case, rather than failure as it did previously. This allows the setup flow to be completed even when replication delays or other issues cause the host to take a long time to start, as an error return code during initial setup would cause the host to be automatically unregistered from the directory. Change-Id: Ie8d157cf2bc433a59857b65b495cc79aeea63ffc Reviewed-on: https://chromium-review.googlesource.com/1086386Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#565092}
-
Ryan Hansberry authored
SecureChannelClient's full implementation will follow in a subsequent CL; we are creating the interface and test fake now to unblock other engineers' work. Bug: 824568, 752273 Change-Id: Ic7bc054d6a59d1f1b65e7831c4be9c6f77045ad0 Reviewed-on: https://chromium-review.googlesource.com/1083948 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565091}
-
Aleks Totic authored
Bug: 467127 Change-Id: I4176cb0e4216ced9434c5c84832df6d6a5cd37d3 Reviewed-on: https://chromium-review.googlesource.com/1089205Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#565090}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b40071..93a962f git log 1b40071..93a962f --date=short --no-merges --format='%ad %ae %s' 2018-06-06 benjhayden@chromium.org Add logging to measure alerts query latency. Created with: gclient setdep -r src/third_party/catapult@93a962f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2c5ea98c547a15ad394c0a3fbeb3d28cc66210de Reviewed-on: https://chromium-review.googlesource.com/1089693Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565089}
-
Ken Rockot authored
There's no reason for Mojo to provide this API. Bug: 844763 Change-Id: I32e9e92f82e55564273961f3f59dd15677125e81 Reviewed-on: https://chromium-review.googlesource.com/1086035Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#565088}
-
Ethan Kuefner authored
Disabling a couple of stories due to bot health bugs. These are in benchmarks blink_perf.svg, and rendering.desktop/mobile. NOTRY=true TBR=nednguyen@google.com Bug: 850293, 850295 Change-Id: I9d201fd8997d94e53aa16f55c48ed136566b9570 Reviewed-on: https://chromium-review.googlesource.com/1090007 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#565087}
-
Xi Cheng authored
Change-Id: Ic5a1a6e51a2387e3215e2aac5192e318ab31c525 Reviewed-on: https://chromium-review.googlesource.com/1087789Reviewed-by:
-
edchin authored
This CL enables the badged reading list by default. Bug: 848358 Change-Id: I23e371c2de66f39c6e2b856c802451129911140f Reviewed-on: https://chromium-review.googlesource.com/1088191Reviewed-by:
-
David Grogan authored
Old code only supported auto and fixed flex bases. This makes 3 more tests pass. Also added a ton of comments. From spot checking, it seems many non-crash failures are due to not setting the flex container's height correctly, e.g. external/wpt/css/css-flexbox/align-content-001.htm css3/flexbox/relpos-with-percentage-top.html Bug: 845235 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I06a3d8f4b8923c8acb1d6fb07826da66d55826a5 Reviewed-on: https://chromium-review.googlesource.com/1088229 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#565084}
-
John Z Wu authored
will combine signin and sync for //ios/web_view. //ios/web_view only needs to signin because it needs to sync autofill data. As such, we will combine them to simplify the API. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ecefad6523ae0207ec5c33516fd90bc536633b1 Reviewed-on: https://chromium-review.googlesource.com/1089352Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565083}
-
