- 24 Sep, 2018 40 commits
-
-
Min Chen authored
changes in this cl, - Added overview exit type kWindowDragged for ending overview on window drag. - Set the dragged window as active window on window drag ended, this will make sure the dragged window will not lost its activation on overview ended. - Update the non-dragged windows' bounds at the end of animation. Since we want no animation if overview ends on window drag, including the update bounds animation. Set the animation type to ZERO for all the other windows except the dragged window. Then we can only see the update bounds animation of the dragged window. All the other windows' bounds will be updated at the end of the animation, which can not be seen by users. Bug: 883579 Change-Id: I6a523e6be7caf32757299462cdf6197574768be2 Reviewed-on: https://chromium-review.googlesource.com/1232957 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593715}
-
Robert Sesek authored
Bug: 887808 Change-Id: I6ed08f68c1c4b059c412b91c2a6f7952fd44aea4 Reviewed-on: https://chromium-review.googlesource.com/1241493Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593714}
-
rbpotter authored
Also fix a bug where enter still leads to print if one of the paper-buttons on the page is focused (should open dialog instead). Previously print preview did not have paper-buttons, so did not check this case. Bug: 887844, 888465 Change-Id: Ie041ace8ea0fd5d62096331efba727af55e935f5 Reviewed-on: https://chromium-review.googlesource.com/1239365 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#593713}
-
Xiaocheng Hu authored
The entire test suite should be parameterized for legacy and LayoutNG, but there are some leftover legacy-only tests due to search-and-replace errors. This patch parameterizes all such leftovers. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia3979861c4213142c4361d1d9d45250e5c9a1772 Reviewed-on: https://chromium-review.googlesource.com/1241153Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#593712}
-
Tom Anderson authored
This is a reland of d4d1506d Original change's description: > [X11] Don't clear WM state bits when a window is unmapped > > _NET_WM_STATE holds the window state which may be eg: maximized, fullscreen, > minimized, etc. In shutdown, Chrome queries this state so that it can restore > browser windows to the correct state on the next launch. The problem is that > Chrome queries this state (hundreds of times, in fact) after the window has > already gone away. The EWMH spec requires window managers to delete the > _NET_WM_STATE property when a window is unmapped [1], so the state that Chrome > was getting was invalid. > > This CL saves the state when a window becomes unmapped, and includes some small > cleanups. > > [1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336 > > BUG=882258 > R=sky > > Change-Id: Iacc43563cd54ade77ac83a580ed24434b6802c91 > Reviewed-on: https://chromium-review.googlesource.com/1226645 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592570} Bug: 882258 Change-Id: I0b68e0d386949f3fe458381a640af7358b7c2269 Reviewed-on: https://chromium-review.googlesource.com/1239252 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593711}
-
Scott Violet authored
Specifically, if in applying a property from a client another property changed, then client would not be notified. BUG=none TEST=covered by test Change-Id: Ie0f28eb07a7874a9acdcb4fd4f94b2eda03a040b Reviewed-on: https://chromium-review.googlesource.com/1240197Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593710}
-
Jialiu Lin authored
This CL is to fix the crash caused by invalid web_contents access in safe_browsing::SafeBrowsingUIManager::MaybeReportSafeBrowsingHit Bug: 888159 Change-Id: I6e7beaa5cd4d7c249d03465e3924635bead0d283 Reviewed-on: https://chromium-review.googlesource.com/1241314 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#593709}
-
Etienne Pierre-doray authored
Instead of ScopedBlockingCall or AssertBlockingAllowed(), AssertLongCPUWorkAllowed is used in FinalizeLauncherIconInBackground() and in CreateLauncherIconFromFaviconInBackground(). Original CL intention was: This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/android/webapps. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=dominickn@chromium.org Bug: 874080 Change-Id: I31ed4164dbd93d424b7a3a69f833519d13c6fbf1 Reviewed-on: https://chromium-review.googlesource.com/1191185Reviewed-by:Dominick Ng <dominickn@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593708}
-
Christian Biesinger authored
Implements this change: https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 external/wpt/css/css-flexbox/percentage-heights-003.html ostensibly tests this, but I don't think the test is correct (and we don't pass it) TESTED=css3/flexbox/definite-main-size.html Bug: 784059 Change-Id: I8ee0ee797b54a8166849ab6e9b9f019b9e43760b Reviewed-on: https://chromium-review.googlesource.com/1240871 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 267cb8af. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 593674 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI2N2NiOGFmMjA0YmVjMGM4YWIxNmI5NTZmZjNiZWZlYzI3OTBmY2EM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-jumbo-rel/7066 Sample Failed Step: compile Original change's description: > Remove SkColorSpaceXform usage from Canvas code > > This is the last CL to remove SkColorSpaceXform call sites from > third_party/blink. This change also does some refactoring in > ImageBitmap unit tests, etc. > > TBR=fserb@chromium.org > > Bug: 774520 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I8279f1687ef096ae9aa2179c74d5d6cf2364ce9b > Reviewed-on: https://chromium-review.googlesource.com/1237140 > Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> > Reviewed-by: Mike Klein <mtklein@chromium.org> > Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593674} Change-Id: I8fd0d3dcd6e2e5e4eb8251485ce07451bf8f11e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 774520 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1241762 Cr-Commit-Position: refs/heads/master@{#593706}
-
Aiden Benner authored
Change-Id: Ie9594e5ee6b01ff2f940119dcf77f0ba7503693b Reviewed-on: https://chromium-review.googlesource.com/1239420Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#593705}
-
Stephen Martinis authored
Bug: 880973 Change-Id: Ic92339a48740e4e18781d81861252c9fc6424d2a Reviewed-on: https://chromium-review.googlesource.com/1239629 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
The problem was that the old sign-in flow didn't work with networking service. This hasn't been converted to use DICE, which already works. There were two causes: -webRequest interception wasn't enabled for the few internal webui pages that are whitelisted for webRequest API -webRequest users don't see Set-Cookie headers for responses (since these were sent to the interceptor from the network process, and the IPC serialization removes Cookie headers) Bug: 887381 Change-Id: I4f0b598c1610cd3b11dcf01cdd4d43425f218a4f Reviewed-on: https://chromium-review.googlesource.com/1238720Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#593703}
-
Scott Violet authored
The current code is problematic because it's assuming Window::SetEmbedFrameSinkId() synchronously calls WindowPort::RegisterFrameSinkId(). That isn't necessarily the case as Window calls RegisterFrameSinkId() when parented to a valid root. The fix is to cache the FrameSinkId and compare against it. BUG=none TEST=none Change-Id: Ib49b044921868ccca8c5feaba1d8a8716939bd28 Reviewed-on: https://chromium-review.googlesource.com/1240745Reviewed-by:
-
Scott Chen authored
Bug: 874142 Change-Id: Ibe260cf8d4f2c8a52808a207e25eb067206dc3ff Reviewed-on: https://chromium-review.googlesource.com/1239167 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#593701}
-
Xiyuan Xia authored
sky's crrev.com/c/1233174 resolved the destruction threading issue. Bug: 874089, 884589 Change-Id: I35b2ffee918626b6d83e497ff0a0d3dae7f27024 Reviewed-on: https://chromium-review.googlesource.com/1241315Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593700}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96954b704ff5..fb85aabf9a15 Created with: gclient setdep -r src-internal@fb85aabf9a15 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id900c8d348faebb60de9fe93920c60fe6fc09a95 Reviewed-on: https://chromium-review.googlesource.com/1240837Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593699}
-
Tarun Bansal authored
Replace some of the if-conditionals that check finch params by DCHECKs since those experiments have finished. Also, clean up the tests. fieldtrial_testing_config.json has also been updated to only reflect the parameters that we should be experimenting with. Change-Id: I1c3c2669c38dc7229b9c64b930b3342fa7843ca4 Bug: 513681 Reviewed-on: https://chromium-review.googlesource.com/1239695Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593698}
-
bsheedy authored
Automates the manual test for <select> tags/dropdown lists on webpages while in the VR browser. Bug: 887513 Change-Id: I5419c6e94bc9d1cb149fb32aff9b7c5cee87732b Reviewed-on: https://chromium-review.googlesource.com/1241198Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593697}
-
Kyle Milka authored
Doodles only need a focus ring when tabbed to but not when clicked. Bug: 778247 Change-Id: Ida0556ae6f03f272d576d76d0842ae3ca42afa57 Reviewed-on: https://chromium-review.googlesource.com/1241313Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#593696}
-
Alexandr Ilin authored
SharedMemoryMapping::Unmap() call passes a mapping size to the munmap() or a similar system call on some platforms. The actual size of a mapping is stored in the SharedMemoryMapping::mapped_size_ but the SharedMemoryMapping::size_ which contains the logical size of the mapping has been mistakenly used instead. This bug is not severe though because the mapped_size_/size_ mismatch exists only on Windows and Windows system call for unmapping doesn't accept the size. Change-Id: Id25c3dce6f0e2ea78d885e76e936572d4e5d2d52 Reviewed-on: https://chromium-review.googlesource.com/1241054Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593695}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e06567b30fdd..64f2ed4bb2f1 git log e06567b30fdd..64f2ed4bb2f1 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 jbudorick@chromium.org Revert "Use vpython and remove vendored pymock." Created with: gclient setdep -r src/third_party/catapult@64f2ed4bb2f1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878777,chromium:777865 TBR=sullivan@chromium.org Change-Id: Ia7a75c175d7efa7f628faabf583f193998b4bb60 Reviewed-on: https://chromium-review.googlesource.com/1240835Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593694}
-
Zhenyao Mo authored
Most user reports are for driver version 8.970.100.9001. However, there is one report on AMD r7 M360 (0x6900) with driver 24.20.11016.4, which is from May 2018. Limit the scope of applying this workaround, so we can backport to Beta without changing code path for most users, although in theory we don't need direct composition on non Intel GPUs on Windows. BUG=800950 TEST=manual R=sunnyps@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib2e224c2c316cf84a96ca252a3a7aa9828979fd0 Reviewed-on: https://chromium-review.googlesource.com/1241273 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#593693}
-
Eugene But authored
Sessions restoration should not trigger web state observer callbacks. Also updated the tests to wait for web state observer callbacks from the last page load. Bug: 877671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0ae13d40e106dc7ad344518c31258db7ab110b0e Reviewed-on: https://chromium-review.googlesource.com/1238378Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593692}
-
Karan Bhatia authored
Currently the ExtensionAPITest.ActiveTab fails with the RuntimeHostPermissions feature since it assumes that the active tab access grant is revoked when the page is navigated. However, with the runtime host permissions feature enabled, the active tab grant is only revoked when the page navigates to a different origin. Fix the test and also test the behavior with RuntimeHostPermissions enabled. This is in preparation of enabling RuntimeHostPermissions for field trial testing. BUG=888158 Change-Id: I46c2c1f92d273eff80395642d0fe2733528cdf70 Reviewed-on: https://chromium-review.googlesource.com/1239210 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593691}
-
Dmitry Gozman authored
Currently, RenderFrameImpl returns kWebNavigationPolicyHandledByClientForInitialHistory policy, which instructs FrameLoader to just mark itself as loading. This patch makes it explicit from the client side. The end goal is to delegate all commit decisions to the client. Bug: 855189 Change-Id: Ided8227efe4f1e99335141f5710fc1d47072a903 Reviewed-on: https://chromium-review.googlesource.com/1235323 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Cathy Li authored
Bug: 867488 Change-Id: Ied05d87e4d1a104f4a6012d465fcf20fd85c3bcf Reviewed-on: https://chromium-review.googlesource.com/1225935 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593689}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/97f4483de007..fed6e124109f git log 97f4483de007..fed6e124109f --date=short --no-merges --format='%ad %ae %s' 2018-09-24 tsepez@chromium.org Give CFX_GraphStateData a work-over. Created with: gclient setdep -r src/third_party/pdfium@fed6e124109f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I94f02a794f82dc2b704250677e840fd58450830a Reviewed-on: https://chromium-review.googlesource.com/1240833Reviewed-by:
-
Pavel Yatsuk authored
+697,754 bytes normalized apk size +3 zip entries file count +53,964 bytes main lib size +442,364 bytes main dex size +259,086 bytes APK size +2,046,236.56 bytes Estimated installed size InstallBreakdown (+2,048,104.56 bytes): +3,696 bytes unwind_cfi (dev and canary only) size +1,458 bytes Non-compiled Android resources size +53,964 bytes Native code size +179 bytes Package metadata size +1,974,131.56 bytes Java code size +14,676 bytes Compiled Android resources size +2,186 entries fields +3,020 entries methods +728 entries types +1,507 entries strings Specifics: InstallSize: Dex: Change-Id: I50076aa2405ed276cfba7978aa1173a9f9036995 Reviewed-on: https://chromium-review.googlesource.com/1240744Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#593687}
-
Christian Biesinger authored
For the cases where we store that vector on the stack, we can easily give it an inline capacity and gain some performance. There is one function that can take either a stack-based or LayoutResult-based positioned floats vector; I made that a template so it can accept either one. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2afb67e03862f062864dd4d36c740b5c578041aa Reviewed-on: https://chromium-review.googlesource.com/1226159Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593686}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e22586a..1afc0dd4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib819bb6e35ae941add9acfd33751e7b6e41e4af4 Reviewed-on: https://chromium-review.googlesource.com/1240869Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593685}
-
manuk authored
Where appropriate, replaced `var`s with `let`s, `function`s with lambdas, closure function with braces, and construction functions with classes. Change-Id: I45dcf2e7aa840242cf2b25cd73cf8a81bfe5b3da Reviewed-on: https://chromium-review.googlesource.com/1239352 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Alex Newcomer authored
Just check before showing the tooltip. Bug: 857258 Change-Id: Ie9b6768d89ac65ff21bbf729c7fc84a467a98790 Reviewed-on: https://chromium-review.googlesource.com/1240209Reviewed-by:
-
Evan Stade authored
Bug: 888613 Change-Id: If7bb4952eb3a19d4d32afec18dc037e66d4c55b4 Reviewed-on: https://chromium-review.googlesource.com/1239363Reviewed-by:
-
James Cook authored
The text insertion caret in web contents can have a positive height but zero width. Ensure the a11y highlight is still visible in this case. This regressed in: https://chromium-review.googlesource.com/c/chromium/src/+/1152373 due to the change to AccessibilityHighlightController::IsCaretVisible. Bug: 882762 Test: added to ash_unittests Change-Id: I2743cb234b49eb5c0d71ba5bf1d25e3869c2492f Reviewed-on: https://chromium-review.googlesource.com/1241215Reviewed-by:
-
Alexandre Frechette authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1230694. Change-Id: I5043132eb238ce968d451df28f5939d0de9129e3 Reviewed-on: https://chromium-review.googlesource.com/1240974 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#593680}
-
Weilun Shi authored
NTP will not invert the color back to white when we set invert color scheme on system setting. This can not only make the default background color change according to the system setting but also avoid weird color on both themes and custom backgrounds. Notice that, only windows has the invert color setting. Screencast: https://screencast.googleplex.com/cast/NjI0ODU4OTI2NTIwNzI5NnxhYzdiNWI3YS04NQ Bug: 802186 Change-Id: Icd64f1350b8014d15107c565785b612ae9febe2e Reviewed-on: https://chromium-review.googlesource.com/1241156Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#593679}
-
Nico Weber authored
Bug: 832676 Change-Id: I4664d3052a0131ab591b166c1a725f042b55b6b0 Reviewed-on: https://chromium-review.googlesource.com/1240513 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593678}
-
Xiaohui Chen authored
Avoid the crash when handing stop interaction without an active assistant manager. The root cause of this issue is still unknown. Bug: 882952 Test: locally build and run Change-Id: Ic7b9fc0f013ba926917a2b266235e887c169418b Reviewed-on: https://chromium-review.googlesource.com/1240856Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#593677}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/background/background_mode_manager_mac.mm. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=avi@chromium.org Bug: 874080 Change-Id: Ic807c6eb4e22dc7ebdd34e2240e1fe6484e44174 Reviewed-on: https://chromium-review.googlesource.com/1191232Reviewed-by:Avi Drissman <avi@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593676}
-
