- 12 Nov, 2019 40 commits
-
-
Rachel Carpenter authored
This allows our client code (coming) to load in a sandboxed iframe. Bug: 1012578, b/144121590 Change-Id: I0e3a1442a9d2959652a36737b8b22abd4d633de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904552 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#714727}
-
Etienne Bergeron authored
This CL is removing the unused method: void Canvas::DrawFadedString(...); Change-Id: I77c279ab1de9cf587b840142563501cb870fff79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902477Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#714726}
-
W. James MacLean authored
TBR=pkotwicz@chromium.org Bug: 1023437 Change-Id: I79f0974609260af143d1956ab4ecc0ba437807c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913464Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714725}
-
Demetrios Papadopoulos authored
This is in preparation of migratincg WebUI pages that depend on it (History, Downloads, Settings) to Polymer3. Bug: 1022215 Change-Id: I536beb13fa639ad6ecf20d2b414c5bd23f5032f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912799Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714724}
-
Aga Wronska authored
This reverts commit 5e94ee4e. Reason for revert: ParentAccessServiceTest tests are failing on linux-chromeos-google-rel https://crbug.com/1023998 Original change's description: > Convert ParentAccessServiceTest to LoggedInUserMixin for child login > > Currently, ParentAccessServiceTest uses LoginPolicyTestBase to log in > as child user for tests. We should deprecate LoginPolicyTestBase in > favor of LoggedInUserMixin instead. This CL converts > ParentAccessServiceTest to replace LoginPolicyTestBase with > LoggedInUserMixin for logging in as child user for tests. > > Bug: 1014663 > Change-Id: I66f8c308e87efd49945ac322d969d162104ff130 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909273 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Toby Huang <tobyhuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714592} TBR=xiyuan@chromium.org,agawronska@chromium.org,tobyhuang@chromium.org Change-Id: I0bb109845474112a545431adb5f575f135e69dfd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014663, 1023998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913577Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#714723}
-
Toni Barzic authored
When starting animation to target drag state when sliding app window into home screen, if target home visibility is shown, HomeLauncherGestureHandler will hide and minimize the dragged window, which might cause focus to move to app list, and app list visibility to get updated before home gesture launcher animation is finished. If the app list visibility is changed at this point, the observers (notably shelf layout manager) will still think that the home state is changing, and will update its state accordingly. The state would not get updated when the animation finishes, given that another AppListVisibilityChanged notification would be skipped after the animation state is updated. To avoid this, delay the AppListVisibiltiyChanged notification until the home launcher finishes the transition. BUG=1021253 Change-Id: I65d06cb88fd7042ca8df0a1a84d24109ccaa0e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894750Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#714722}
-
Robert Sesek authored
Bug: 1021948 Change-Id: I74e0975de611056948613411217b6d6b75a0e6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912885Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#714721}
-
Victor Hsieh authored
The dep roll is currently blocked due to a recent change that adds a new value to the enum: error: enumeration value 'InputEvent_Type_DOUBLE_TAP' not handled in switch [-Werror,-Wswitch] This change unblocks the roll. https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1873850 https://chromium-review.googlesource.com/c/chromium/src/+/1907072 Test: Build Bug: None Change-Id: I00e27b31d35607d094dff60f196e9b7307e9e89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913019 Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#714720}
-
James Cook authored
As part of go/cros-sync and go/split-settings-sync we're creating a new OOBE sync consent dialog. The main new feature is that the user can turn OS sync off in the dialog and the OS sync system will never start. OS sync is tied to a user profile pref that is set only when the user closes the dialog. This version of the dialog has placeholder strings and layout. Strings won't be available until M81 and I suspect the layout might change. See bug for screenshot and link to mocks. Bug: 1023854 Test: added to browser_tests Change-Id: I3e86a827eae1d80b8784b89b433d9aebb92eb5d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912899Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714719}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e2f83aa33d88..59fa599a2a59 git log e2f83aa33d88..59fa599a2a59 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 tobine@google.com Vulkan:maxPerStageDescriptorStorageBuffers = 16 2019-11-12 nicolascapens@google.com Revert "Suppress 32-bit MSVC warning." Created with: gclient setdep -r src/third_party/swiftshader@59fa599a2a59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140575360 Change-Id: I1bca610b71693702359d01326e68da6508d56335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714718}
-
Eric Orth authored
Greatly simplifies the startup delay before allowing probes by moving all the delay logic outside the contexts. Now probes can be triggered without any worry of conflicts between the delay logic and context creation/removal. No hanging delay timers with references to contexts that may or may not be valid. Within HostResolver/DnsClient, probes are started when requested and cancelled when cancelled. Bug: 1013350 Change-Id: I9189f16e13f8f3fd4b51a081bef7676f7c3330a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902236 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714717}
-
Min Qin authored
BUG=695115 Change-Id: I58d7e2ddbc004be6fcf16ca2b203e0f85132645f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911223 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714716}
-
Haiyang Pan authored
Bug: 1001643 Change-Id: I2bf3e664a720055baa91bd062f170b70d77ee226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893407Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#714715}
-
Chris Blume authored
This reverts commit 2ef6fce8. Reason for revert: This CL broke GPU FYI Win x64 DX12 Vulkan Builder (dbg) https://ci.chromium.org/p/chromium/builders/ci/GPU%20FYI%20Win%20x64%20DX12%20Vulkan%20Builder%20%28dbg%29 lld-link: error: obj/gpu/vulkan/vulkan/vulkan_instance.obj: locally defined symbol imported: public: __cdecl gpu::VulkanInfo::VulkanInfo(void) (defined in obj/gpu/config/vulkan_info/vulkan_info.obj) [LNK4217] Original change's description: > Add vulkan information in about::gpu page > > This CL adds VulkanInfo in GPUInfo, and then send it to browser > process with GPUInfo. And it will be serialized to binary data and pass > to about:gpu page for displaying. > > This CL adds a vulkan_types.mojom generated from vulkan header file. > The structs in that files have many fields. It increases binary size. > The increasing is expected. > > Bug: 887018 > Change-Id: I2725326091ef47c3034939b3970d0e5bbaf6dc3f > Binary-Size: Size increase is unavoidable (see above) > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868832 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714424} TBR=penghuang@chromium.org,backer@chromium.org,zmo@chromium.org,kbr@chromium.org,tsepez@chromium.org,alexmos@chromium.org Change-Id: I3b0aff2cfcfa8b65df2ca9109325451567cf8039 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913565Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#714714}
-
Sergey Poromov authored
The experiment was tested on 50% of Canary, Dev and Beta, result was as expected. Adding to FTTC before moving to Stable. https://screenshot.googleplex.com/wuVmDDsVOXH.png Bug: 940648 Change-Id: If63dc8bd94703f9c59b236516d398369b4655aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912519 Auto-Submit: Sergey Poromov <poromov@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#714713}
-
Mustafa Emre Acer authored
This reverts commit 2308d074. Reason for revert: This broke `git cl upload` with string changes. Original change's description: > Support grdp files in translation screenshot presubmit > > Translation screenshots project requires Chrome devs to upload UI > screenshots along with string changes in .grd and .grdp files. These > are XML files containing all user visible strings in Chrome. > > Translation screenshots has a presubmit checks that extracts the > list of modified strings, looks for image files associated with these > strings and warns the developer to add them if they are missing. > > This presubmit parses .grds to extract the list of modified strings but > it skips <part> tags which are used to reference .grdp files. As a > result, the presubmit currently ignores string changes in .grdp files. > .grdp files contain the majority of UI strings in Chrome, so the lack of > presubmit checks for them results in low translation screenshot coverage. > > This CL changes how .grdp files are loaded in the presubmit: Previously, > they were written in a temporary directory alongside a fake .grd file > that referenced the loaded .grdp file. The code loaded the fake .grd file > which resulted in loading the strings in the actual .grdp file. However, > test mocks override all os.path methods which in turn breaks temporary > directory creation. As a result, it was not possible to properly test > the .grdp loading code, so we skipped <part> tags as a workaround. > > The new loading code writes a temporary copy of the .grdp file and wraps > its contents with proper tags so that it can be loaded as a .grd file > instead. This avoids the need to create a temporary directory and is > fully testable. > > The end result is that Translation Screenshots presubmit will now ask > Chrome devs to upload screenshots for changes in .grdp files. This should > significantly increase the coverage of strings with translation screenshots, > leading to better quality in string localizations. > > Bug: 924652 > Change-Id: Iae7933e8147cefdabc15ef21d2b6daa43d5002bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875554 > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714550} TBR=meacer@chromium.org,anthonyvd@chromium.org,jochen@chromium.org Change-Id: I1a6ee198b1dd76e84bcf962cd2396f4d00c5c126 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913564Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/119ab23ab620..cea09e02b1a6 Created with: gclient setdep -r src-internal@cea09e02b1a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2e8791ba18c9dddb264bfdd3179dbd0e4069769a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714711}
-
Ahmed Mehfooz authored
Bug: 1020530 Change-Id: I8fdbd312edb9e98ffa2f089b7d227c4065e416c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912901Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#714710}
-
Clark DuVall authored
This splits the webview and weblayer component strings into separate paks, so that weblayer can include english only translations of the necessary strings. Bug: 1021257 Change-Id: I636586b29cdf2564cd6e7bbd5c72feeb965ce3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912654 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/581108137b46..8c1e0effbbe1 git log 581108137b46..8c1e0effbbe1 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mtklein@google.com sketch out structure for ops with immediates 2019-11-12 mtklein@google.com implement assert_true on x86 2019-11-12 mtklein@google.com add Release SkVMBlitter bot 2019-11-12 robertphillips@google.com Remove final usage of GrProgramDesc's header Created with: gclient setdep -r src/third_party/skia@8c1e0effbbe1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I7aa576f2288c0967c7adca7f312e82a431f041fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912775Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714708}
-
Moe Ahmadi authored
Rather than supplying a callback when querying the Autocomplete system, this CL makes the NTP realbox updates its UI every time AutocompleteControllerDelegate's OnResultChanged() is called. This allows the UI to get updated with not just the first, but also the subsequent Autocomplete updates. Bug: 243926 Change-Id: I435d6985487995038f41e68616bc0147f9955d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875030 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714707}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0b67efd7e5ea32281d8dbaa3a40c1f1ff7152f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913161Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#714706}
-
Alex Moshchuk authored
The new name better reflects what this function actually does, which is check all frames in the WebContents and return true if any of them have *either* beforeunload *or* unload handlers. This is purely a rename with no behavior changes. Bug: 1015882 Change-Id: I07962047ccb2711eeb7fe3e2272fd1476011bc38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895886Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714705}
-
Liquan (Max) Gu authored
Since the EphemeralTabToolbar's layout has been reused by PaymentHandlerToolbar. The layout will be more readable if it uses a more general name. In this patch, we change the name in the following manners: * ephemeral_tab_toolbar --> sheet_tab_toolbar * preview_tab_toolbar_height --> sheet_tab_toolbar_height * ephemeral_tab_text --> upper_text * ephemeral_tab_caption --> lower_text Bug: 999196 Change-Id: Ia993c024f192980d071461f46b73a40106457d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911604 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714704}
-
Sergey Ulanov authored
Support global configuration options being read from /config/data. This allows some WebEngine properties to be tailored to suit the specific device and system configuration. Initially two options are provided, to control availability of protected memory for video playback. Bug: fuchsia:41143 Change-Id: I5222b956fcce33ae49d575cdd308388310fa80b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907474 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714703}
-
Akihiro Ota authored
This change: 1. Adds braces for all control structures according to the Google JavaScript style guidelines: http://go/js-style. 2. Access the phase member variable (this.phase_) when checking the current phase. The previous code was confusing because sometimes we would check the tree walker phase using the getter (this.phase) and other times we would directly check the member variable (this.phase_). Change-Id: Id2288716d7b1bb1a08fb8c06760a17a753be8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880178 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#714702}
-
Xiaoqian Dai authored
Bug: 997885 Change-Id: I93bda4028f5dc1b59d29b8f26aa30f050e6b3eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909284 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714701}
-
Changwan Ryu authored
Since interruption is raised and caught in a separate thread, it may take some time to get interrupted exception on the test thread. Also, we should not feed data since the task may be executed even before it gets interrupted. Test: I was able to reproduce this issue when I add some delay in the test thread, which proves my point. With the changed logic I could not reproduce the issue. Bug: 1022954 Change-Id: I48899279d5bc678a75f40b21b6adf3faf2efe2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906639 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#714700}
-
W. James MacLean authored
This CL re-implements the named test so that it is meaningful in the context of OOPIF-based PDFs. The test (i) verifies that the embedder loads correct boilerplate <embed> tag, and (ii) that the extension loads. Bug: 1019367 Change-Id: I79193923d2b0572bd49bf75cb462f2db8768a901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906181 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#714699}
-
Ahmed Fakhry authored
The test used to navigate to chrome://settings, which may take a long time causing the test to flake. The test's intent is to verify correct WebPrefs applied when switching to tablet mode for internal pages; doesn't have to be the settings page. Use chrome://version instead. BUG=1023903 TEST=Run test locally with no flakes Change-Id: I5bc62a1eb9d67e1d0ca62693110081d4fd512974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913020 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714698}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/729798cc3be6..21b5adc8409a $ git log 729798cc3..21b5adc84 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 jophba Fix chrome build, add unit testing in Chrome 2019-11-06 mfoltz [Open Screen] Consolidate BUILD.gn for cast/ 2019-11-05 mfoltz Roll buildtools/ cf454b247..140e4d7c4 (2 commits; 1 trivial rolls) 2019-11-05 mfoltz [Open Screen] Move mDNS code to discovery/mdns. 2019-11-05 btolsch Add virtual connections for cast socket 2019-11-05 rwkeane DNS-SD: Add new TxtRecord method 2019-11-05 rwkeane DNS-SD: More Conversions 2019-10-31 rwkeane DNS-SD: Conversions From mDNS 2019-10-30 rwkeane DnsSd: Querier Skeleton 2019-10-29 yakimakha MdnsService base interface 2019-10-25 miu Cast Streaming: Add RTP Payload Type hacks for AndroidTV. 2019-10-25 rwkeane DNS-SD: TxtRecord implementation 2019-10-25 rwkeane DnsSd: More Operators for Constants 2019-10-24 rwkeane DNS-SD: Instance Record Created with: roll-dep src/third_party/openscreen/src Change-Id: I64f4e8d5ac63657c1bac61d012321c80c5f90b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906125Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#714697}
-
Tim Song authored
The status area collapse/expand animation is currently unspec'd, so skip the animation for now. TEST=manually verified with --force-status-area-collapsible flag BUG=982511 Change-Id: Idaa95fd9a2393d668ad7d154663fc1e876c184d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903937Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714696}
-
Lambros Lambrou authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1903934 with missing deps added. This adds a PermissionWizard::Delegate implementation which runs the Me2Me or IT2Me binary with a command-line for checking permissions. This can be used to create a PermissionWizard which checks the permissions on either the ME2ME or IT2ME host. TBR=garykac@chromium.org Bug: 1015201 Change-Id: Ie704ff1a7c6c90c33b614f042a19c81e9ad6e2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912917Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714695}
-
Matt Menke authored
It already has two timeout mitigations - one on the size of output, one on the size of the input, but they're not enough. This CL replaces them with a single limit on the number of reads, which should hopefully mean we don't have to invest any more time dealing with silly timeouts. Bug: 1006309 Change-Id: I50c6c52b26c43826efd5071ce0b345cd9782ca84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912142Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714694}
-
Martin Kreichgauer authored
From the overview page of the fingerprint enrollment dialog for chrome://settings/securityKeys, drop the table's header and top-most separator line. Also align the page's subheader ("Fingerprints on this security key") with the dialog title ("Manage fingerprints"), and align the right-hand sides of the dialog body and button container (in order to align the secondary "Add" button, table and "Done" button visually). Also change the dialog title while enrolling a new fingerprint to "Add fingerprint". Demo: https://drive.google.com/open?id=1xmJj3XA9Vzz0Dx5G9a822HJdGDKC12WM Bug: 974046 Change-Id: I77aa2d45a3d3a98a1472cd1865d2ac8a8488db48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907548 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714693}
-
Mohamed Heikal authored
The android framework does not require an extension to parse image drawables correctly (only that they do not have the .xml extension). This cl removes all image extensions from the APK to reduce binary size. Bug: 1014555 Change-Id: I2100d8d008543a4cd36672d80a8a9a2ceaa98dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902231 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714692}
-
Fredrik Söderquist authored
Also use it SVGSMILElement::SvgAttributeChanged(...). Change-Id: Ic3352bf30eda7b86736858e7f68c50a6ce8a628c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912240 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714691}
-
Fredrik Söderquist authored
It is no longer used. Change-Id: Ie73e71cd135f4005b2d66c80fc4fa8d90c349243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912200 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714690}
-
Fredrik Söderquist authored
Also move it be protected access. Change-Id: I763a8112079ca3fb567b20a89c69bbfc0e420f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912299 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714689}
-
Maggie Cai authored
This CL removes the DECHECK_EQ for the unique_ptr because this is a C++20 feature. BUG=957519, 980914, 853604 Change-Id: I87c3213788ac4447aad2f3d46f8af2876ebf0053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910821Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714688}
-