- 24 Sep, 2018 40 commits
- 
- 
Zhenyao Mo authoredBUG=867155 TEST=manual R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idafc99cf9a486cc23751eff36084d63115b5d87f Reviewed-on: https://chromium-review.googlesource.com/1239733Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593618} 
- 
Nicolas Ouellet-Payeur authoredThe policies don't exist on ChromeOS, and the 'enterprise default' only applies to ChromeOS. This caused policies to get set, and appear in `about:policy`, even though they were not supported on that platform. Bug: 882533 Change-Id: Ibc17dc4254812fb39048d97ea4b6e45dae7f4380 Reviewed-on: https://chromium-review.googlesource.com/1240494Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#593617} 
- 
Ioana Pandele authoredIn order to disable the keyboard accessory within the contextual search panel,the ManualFillingMediator calls isSearchPanelOpened() on the ContextualSearchManager that it gets from the acivity. Since the contextual search manager can be null, a check is required prior to calling that method. Bug: 887833 Change-Id: I85203cbb233a2ae7eec8a008ebd63c40bbd1a170 Reviewed-on: https://chromium-review.googlesource.com/1238473Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#593616} 
- 
Kevin McNee authoredThe work done in crbug.com/833380 to address flakiness in SitePerProcessHitTestBrowserTests likely resolves the source of flakiness for this test. Bug: 833380 Change-Id: Idd54686f2ad3294ae9daca4faf43945dc428afb0 Reviewed-on: https://chromium-review.googlesource.com/1236835Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#593615} 
- 
Becca Hughes authoredAdds a WasActivatedOption to allow embedders to override the `was_activated` logic for browser initiated navigations. This is for when a user activation occurs on a surface outside of the page and we want this to be passed to a navigation as if this had occured on a previous page. BUG=884777 Change-Id: Ifc7ce9352c3736d9e5c5c7d6909b3c5b2ead0cd8 Reviewed-on: https://chromium-review.googlesource.com/1228502Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#593614} 
- 
Stephan Herhut authoredWith the new v8 interface for externalizing array buffer contents, we no longer need to store the kind or allocation_base/size on the blink side. Hence, this change removes those fields completely. Furthermore, gin now also uses the custom deleter based interface. Change-Id: Ifa1a1900e83e7f9fab859672edc8fe54ad7e647e Reviewed-on: https://chromium-review.googlesource.com/1235937Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593613} 
- 
Tatiana Buldina authoredBug: chromedriver:2016 Change-Id: I9a5d54fdec6b8750d9893382c927435ad1200ae6 Reviewed-on: https://chromium-review.googlesource.com/1240196Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#593612} 
- 
Balazs Engedy authoredBug: 887404 Change-Id: Ice13eb0166da5590170e7cc7d152d58ee64f0248 Reviewed-on: https://chromium-review.googlesource.com/1235938Reviewed-by: Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593611} 
- 
Samuel Huang authoredThis CL updates the milestone selection page. Details: * Add small drop-down to select between "compare" or "view" mode. "Compare" is the old behavior, and "view" shows only one select box. * Under view mode, clicking "Open report" will open report to view single milestone. * Opened report now appears on new tab. * For "compare" mode with incompatible changes (version 1 equal or newer than version 2): Old behavior of graying out options was non-robust. This is repalced with disabling "Open report" button and showing error message. * Extra change: generate_milestone_report.py: Correct gsutil.py rsync parameter. Bug: 880671 Change-Id: Ie3c1e23c2f78ea4818f86f71954cf3ece0bea513 Reviewed-on: https://chromium-review.googlesource.com/1240503 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593610} 
- 
James Zern authoredhttps://chromium.googlesource.com/webm/libvpx.git/+log/282087a14c84..3448987ab20a $ git log 282087a14..3448987ab --date=short --no-merges --format='%ad %ae %s' 2018-09-22 jzern Revert "Revert "Revert "Loopfilter MultiThread Optimization""" 2018-09-21 johannkoenig Revert "third_party/googletest: update to v1.8.1" 2018-09-20 theonetruecamper better-hw-compatibility: fix out of bounds access 2018-09-21 jianj vp8: exit with bad fragment size in decoder. 2018-09-21 jingning Rework is_compound_allowed logic at encoder 2018-09-21 theonetruecamper internal stats: fix mem leak and initialize memory 2018-09-21 theonetruecamper sanitizer: fix unaligned loads 2018-09-20 angiebird Use different corner detection score 2018-09-17 johann.koenig third_party/googletest: update to v1.8.1 2018-09-20 jingning Generalize encoder comp_var_ref setting 2018-09-18 jingning Skip checking compound modes with same sign bias for sub8x8 2018-09-18 jingning Update the comp_refs counts 2018-09-18 jingning Skip RD check for compound modes that have same sign bias 2018-09-18 jingning Sync ref frame writing with decoder 2018-09-18 jingning Add frame_start/end to gf_group Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@chromium.org, tomfinegan@chromium.org Bug: webm:1562 Change-Id: I3225512a15061b4f456b3a969a4a23a9cdf18b0d Reviewed-on: https://chromium-review.googlesource.com/1239993Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#593609} 
- 
Robert Sesek authoredBug: 832676 Change-Id: If732ef321da1a440003906763d5c8c64b3d4ba5f Reviewed-on: https://chromium-review.googlesource.com/1239637Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593608} 
- 
Sigurdur Asgeirsson authoredA subsequent CL will plumb this out to the chrome://discards page. Bug: 874968 Change-Id: I18496f73a4a76cfe05151b67fb7cce4d9e256064 Reviewed-on: https://chromium-review.googlesource.com/1239002 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#593607} 
- 
chromium-autoroll authoredhttps://pdfium.googlesource.com/pdfium.git/+log/e65756725f82..97f4483de007 git log e65756725f82..97f4483de007 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 hnakashima@chromium.org Revert "Make potentially dangerous Actions require a user click." 2018-09-22 thestig@chromium.org Remove useless charset data in CFGAS_FontMgr. 2018-09-22 thestig@chromium.org Roll build/ f53effa79..dfca77bb0 (53 commits) 2018-09-22 thestig@chromium.org Move some CFGAS_FontMgr methods into an anonymous namespace. 2018-09-22 thestig@chromium.org Change CBC_QRCoderMatrixUtil::BuildMatrix() to return a bool. 2018-09-22 thestig@chromium.org Encapsulate CBC_QRCoderMatrixUtil code. 2018-09-22 thestig@chromium.org Remove CBC_CommonByteArray and CBC_QRCoderBlockPair. 2018-09-21 npm@chromium.org Cleanup in CCodec_FaxModule 2018-09-21 tsepez@chromium.org Replace CPDF_Color::Copy() with honest-to-goodness operator=(). 2018-09-21 npm@chromium.org Make OutputIndex() a void method 2018-09-21 thestig@chromium.org Fix destruction order with CPDF_StreamAcc. 2018-09-21 thestig@chromium.org Remove unreachable code in CPDF_DIBBase. 2018-09-21 thestig@chromium.org Validate more image values in CPDF_DIBBase. 2018-09-20 hnakashima@chromium.org Make potentially dangerous Actions require a user click. Created with: gclient setdep -r src/third_party/pdfium@97f4483de007 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851821,chromium:887626,chromium:851821 TBR=dsinclair@chromium.org Change-Id: I1cfa2cae8e4f0aae0ca74f00ecfc7e8a8060efa9 Reviewed-on: https://chromium-review.googlesource.com/1240534Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593606} 
- 
Jeremy Roman authoredBug: 888634 Change-Id: I81df8a179f925e6dcb07bbdec118f407f3395567 No-Try: true Tbr: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1240520Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593605} 
- 
Dave Tapuska authoredUse wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I7c36518c6b88f5d8b8b3ea3f90551eed3177d85a Reviewed-on: https://chromium-review.googlesource.com/1240496Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#593604} 
- 
Sarah Hu authoredCurrently fingerprint attempts are not treated as user activities. So when the screen is off, user touch the sensor with an enrolled finger will silently unlock the screen, with the screen remains off. And after hitting a key, the screen turns on and already unlocked which makes user think the screen is never locked. This CL reports fingerprint attempts as user activity so when user touch the sensor, the screen will be turned on. Bug: b:115779078 Change-Id: I10acd8cc3eccb7d594465573fecf9f3099a65f8d Reviewed-on: https://chromium-review.googlesource.com/1236556 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593603} 
- 
Bailey Berro authored- Changes the option displayed in the files app "add new services menu" from"SMB Shares" to "SMB file share" Bug: chromium:887132 Change-Id: I066e36e1ec992dce40971eced993b9aea5a0b7c8 Reviewed-on: https://chromium-review.googlesource.com/1239213Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#593602} 
- 
Christopher Cameron authoredThe interface RenderWidgetHostNSViewLocalClient provides a set of helper functions that add functionality to a RenderWidgetHostNSViewClient. These functions may be implemented directly using that Client, or using a side-channel. The naming of this class is very confusing as we add the ability to have local (in-process) and remote (out-of-process) clients. To this end, rename this to a name that more closely mirrors the names in ui/views and doesn't these naming ambiguities. Move the ForwardingLocalClient from render_widget_host_view_cocoa.mm over to a new render_widget_host_ns_view_client_helper.mm. Change the instance which is created as a dummy pipe to always be identified as a dummy pipe. Bug: 821651 Change-Id: I1dd130ddbed46d4854a065fa3d629b7f9833824c Reviewed-on: https://chromium-review.googlesource.com/1239641Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#593601} 
- 
Ryan Meier authoredBug: 884062 Change-Id: I584dda328551a10db2100d493e802f42da83c1e5 Reviewed-on: https://chromium-review.googlesource.com/1237262 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#593600} 
- 
Ryan Meier authoredWhen CalculateKMeanColorOfBitmap was called with a desired (sample) height larger than the size of the raw image to sample, it would only initialize the buffer up to the number of pixels in the image (appropriately), but this would result in the buffer containing uninitialized memory at the end. Changed the function to clamp the input height to the height of the image. Also simplified the control button background sampling logic in BrowserThemePack to only crop the image when sampling (instead of trying to tile it). Bug: 883588 Change-Id: Ief3a27d63bac7e54757c3d3c4dad47d73aa980d9 Reviewed-on: https://chromium-review.googlesource.com/1228126 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#593599} 
- 
Saman Sami authoredAlso when a fallback exists but has a different FrameSinkId or embed token than the primary, don't use the fallback because the resulting range in the new view will not cover any surface with the FrameSinkId or embed token of the old view's primary. Bug: 857575,870456 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia4736f354160dfd510793bf35ae4292c276bf115 Reviewed-on: https://chromium-review.googlesource.com/1236456Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593598} 
- 
Sam Maier authoredBug: 825947 Change-Id: Id03b7c06a7173afb7b15e64eb91974735a979c0d Reviewed-on: https://chromium-review.googlesource.com/1240514Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#593597} 
- 
erikchen authoredColorSyncDeviceCopyDeviceInfo sometimes returns nil. The GPU test framework should gracefully handle this failure. Bug: 888035 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6374f2ef01e6272a7220a030e1e0ff5ecdaa80b9 Reviewed-on: https://chromium-review.googlesource.com/1238780Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593596} 
- 
Patrick Noland authoredIn the associated bug, we decline to restore the anchor after the initial restoration, which causes us to fall back to using the saved scroll offset. This clears the anchor, causing the anchor to get re-restored on subsequent layouts. This feedback loop causes flickering. To avoid this, we early return true from RestoreScrollAnchor when there's an existing anchor. This prevents us from falling back to using the saved pixel offset. Bug:884139 Change-Id: I22f17e1f73a7604eb7b99df9291f2f37b2ea9229 Reviewed-on: https://chromium-review.googlesource.com/1231831Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#593595} 
- 
Sandeep Vijayasekar authoredBug: b/112748586 Test: none Change-Id: If42ab10a110e563c88cd24551a76d7806d5603c1 Reviewed-on: https://chromium-review.googlesource.com/1232956Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Sergey Volk <servolk@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Cr-Commit-Position: refs/heads/master@{#593594} 
- 
Xi Cheng authoredUSER_BLOCKING is too high for this task as it doesn't affect UI. This CL lowers the task priority to BEST_EFFORT. Bug: 888276 Change-Id: I5d2a45915dfb82206e2880e58d1c4ec593ef09ca Reviewed-on: https://chromium-review.googlesource.com/1239162 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593593} 
- 
Jeremy Roman authoredThis reverts commit f7623733. Reason for revert: causes DCHECK failures in external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled.html Original change's description: > Workaround for nested remove for datalists. > > Nested removes confuses the style traversal roots. Make this a general > workaround for UA shadow removals. > > Bug: 888236, 888448 > Change-Id: Ia0165e7478c96282900a8191eeac18ae34586a2c > Reviewed-on: https://chromium-review.googlesource.com/1238728 > Reviewed-by: Anders Ruud <andruud@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593510} TBR=futhark@chromium.org,andruud@chromium.org Change-Id: I843b4cc5d9be74fea13ff43305b0093fd64dcae3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 888236, 888448, 888618 Reviewed-on: https://chromium-review.googlesource.com/1240505Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593592} 
- 
Yi Su authoredFlag for the new feature that allows user to add custom search engines in settings. Bug: 433824 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If3b91e276b752b546013644119a5560f0a486314 Reviewed-on: https://chromium-review.googlesource.com/1236314 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#593591} 
- 
Sammie Quon authoredThe minimized windows are now stacked underneath non-minimized windows. Minimized windows now animate back when uncessfully swipe to close. Test: manual Bug: 886392, 886390 Change-Id: I520a9cfc642e5f417af6755b783b831098430ce8 Reviewed-on: https://chromium-review.googlesource.com/1238782 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#593590} 
- 
Parastoo Geranmayeh authoredThere are some cases that though the validity map on the server side has not changed, we need to update the validity states of the profiles. This is when the profiles are updated. Thus, we need to turn on the flag for profile_validities_need_update in case they have changed. Change-Id: I87f7d6f6df914b98ffb9ef744ff055c0b4c92f3c Reviewed-on: https://chromium-review.googlesource.com/1239436Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593589} 
- 
Xiaohan Wang authoredCurrently this is only allowed for renderer and gpu process. This CL also allows it for utility process. Also pass logging switches to the UtilityProcessHost. These switches are already passed in ServiceUtilityProcessHost. Both are using kUtilityProcess process type. Bug: 888088 Change-Id: Ic26b9c9e6ce0c9024fb3ca4c8d352c5a283bef81 Reviewed-on: https://chromium-review.googlesource.com/1239172Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593588} 
- 
chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/a9adb6f03525..4fb073ac7328 git log a9adb6f03525..4fb073ac7328 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 mtklein@google.com use __builtin_debugtrap() in sk_abort_no_print() where possible 2018-09-24 mtklein@google.com make only valid SkRRects in FuzzPath 2018-09-24 kjlubick@google.com Remove coverage bots 2018-09-24 mtklein@google.com Reland "focus exported color apis" Created with: gclient setdep -r src/third_party/skia@4fb073ac7328 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:888381 TBR=bsalomon@chromium.org Change-Id: I9f3de224dfaf69b7693e936acd43d9f192a44ff3 Reviewed-on: https://chromium-review.googlesource.com/1240476Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593587} 
- 
Robert Sesek authoredBug: 832676 Change-Id: I25fa2e314592f392a716bcb3b5dd3836bfb878cc Reviewed-on: https://chromium-review.googlesource.com/1239636 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593586} 
- 
Thomas Tangl authoredWhen the user disables the unified consent toggle in settings, a metric is recorded. This metric is added to UnifiedConsent.RevokeReason. Bug: 868892 Change-Id: Iff196b3428b130ea4b3d71a50c2b861f5da48966 Reviewed-on: https://chromium-review.googlesource.com/1240278Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#593585} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2c8e12da..d786acd3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If21a1481d1c94548968e357b1c8294f5acc96212 Reviewed-on: https://chromium-review.googlesource.com/1240493Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593584} 
- 
Pete Williamson authoredChange-Id: I69b90b0ff716c3b506f699fcec6fed9ab32f351c Reviewed-on: https://chromium-review.googlesource.com/1239994Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#593583} 
- 
Wei Li authoredThese two tests were disabled due to assertion failures on Cocoa call stack. By porting fullscreen code to Views, we no longer call into such functions. With some minor improvement -- adding initial preference setup, the tests should pass. BUG=823490 Change-Id: I9b3c7838d1502c52a2da8cbc4a954ae9f8e71da7 Reviewed-on: https://chromium-review.googlesource.com/1239356Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#593582} 
- 
Dominic Battre authoredThis CL changes the default parameters for password generation so that we don't need a configuration on the server unless anything changes. It also removes the PasswordGenerationRequirements feature which was only implemented as an early kill switch in case of crashes and is not necessary anymore. PasswordGenerationRequirementsDomainOverrides remains as a feature that is enabled by default in case some distribution wants to disable this feature that talks to Google. Bug: 846694 Change-Id: I32bd06ef908f16c189cd0fa2a376d490c6fe20d0 Reviewed-on: https://chromium-review.googlesource.com/1233740Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#593581} 
- 
Xianda Sun authoredBefore launching V2 viz hit testing, we need to verify the correctness. This patch forces V2 to do slow path async hit testing and compare the results. If there is no reported mismatched results, it will be safe to launch V2 viz hit testing. Bug: 823888 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I060b9626e6e59cc12ae2b476425cef715475e40d Reviewed-on: https://chromium-review.googlesource.com/1157227 Commit-Queue: Xianda Sun <sunxd@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593580} 
- 
Luigi Semenzato authoredImplementation CL: https://chromium-review.googlesource.com/c/aosp/platform/system/connectivity/shill/+/1220430 BUG=chromium:729335 TEST=none Change-Id: I00fe89328d9ec0f910b354733fb1914838c5d75c Reviewed-on: https://chromium-review.googlesource.com/1234696 Commit-Queue: Luigi Semenzato <semenzato@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#593579} 
 
-