GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/76033be..1e0bf7e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1005183004

Cr-Commit-Position: refs/heads/master@{#320669}

We are investigating the cost of ExtensionService::Init(), and want to see the effect of this static initialization, specifically in the browser process which affects startup.

BUG=454789

Review URL: https://codereview.chromium.org/996013004

Cr-Commit-Position: refs/heads/master@{#320668}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f3aeb9f..fd8f503

TBR=

Review URL: https://codereview.chromium.org/1001203003

Cr-Commit-Position: refs/heads/master@{#320667}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/de7665a..76033be

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1009083002

Cr-Commit-Position: refs/heads/master@{#320666}

This change includes the following changes:
e079768  [MIPS] Fix syscall clone implementation
da4a489  MIPS: tweak register constraint to build under clang
db1e07d  ARM64: fix build due to incomplete ppoll decl

Note: MIPS related changes are required for Chromium
to be compiled for mips32 using Clang.

BUG=

Review URL: https://codereview.chromium.org/997303004

Cr-Commit-Position: refs/heads/master@{#320665}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3a444f91..daf4e50f

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1008013004

Cr-Commit-Position: refs/heads/master@{#320664}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/59ae94e..f3aeb9f

TBR=

Review URL: https://codereview.chromium.org/1013433002

Cr-Commit-Position: refs/heads/master@{#320663}

* Uses guid instead of service path in the Internet Settings UI
* Uses chrome://settings/internet?guid= instead of ?servicePath=
* Uses chrome.networkingPrivate.getManagedProperties and setProperties directly in Internet Settings
* Makes callback parameter optional in networkingPrivate for setters
* Removes the difficult to maintain (and only partially implemented) Error translation from internet setigns, adding a general TODO for translating ONC properties in the UI.
* Replaces ShowNetworkSettings with ShowNetworkSettingsForGuid in NetworkConnect::Delegate and ash::SystemTrayDelegate
* Uses guid instead of service path in UIProxyConfigService

BUG=467275
For chrome/browser/ui/ash:
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/983823002

Cr-Commit-Position: refs/heads/master@{#320662}

BUG=chromedriver:1058

Review URL: https://codereview.chromium.org/1004333002

Cr-Commit-Position: refs/heads/master@{#320661}

We (srawlins@ and I) suspected that testEmulateNetworkConditionsSpeed would be flaky, but we wanted to try it on the buildbots first. Turns out we were right, and it is very flaky. It almost always fails on Android, and fails often on desktop too. So I'm deleting this test.

BUG=

Review URL: https://codereview.chromium.org/1002343003

Cr-Commit-Position: refs/heads/master@{#320660}

Now with "override" to merge with skia's new virtual

Intended to allow this to land in skia
https://codereview.chromium.org/1005183003

This reverts commit 3d4669df.

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1009053002

Cr-Commit-Position: refs/heads/master@{#320659}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/57a48a7..de7665a

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1009733002

Cr-Commit-Position: refs/heads/master@{#320658}

Depends on https://codereview.chromium.org/996813002/

BUG=464328

Review URL: https://codereview.chromium.org/990283002

Cr-Commit-Position: refs/heads/master@{#320657}

BUG=434007,426020

Review URL: https://codereview.chromium.org/1006043002

Cr-Commit-Position: refs/heads/master@{#320656}

Reenable "ready" in push messaging browsertest after it was fixed by
https://codereview.chromium.org/912443002.

BUG=466694

Review URL: https://codereview.chromium.org/1001153003

Cr-Commit-Position: refs/heads/master@{#320655}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ee9e9fb..59ae94e

TBR=

Review URL: https://codereview.chromium.org/1009713002

Cr-Commit-Position: refs/heads/master@{#320654}

Cr-Commit-Position: refs/heads/master@{#320653}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/173e5fe..57a48a7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1003413002

Cr-Commit-Position: refs/heads/master@{#320652}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f8181c2..ee9e9fb

TBR=gavinp@chromium.org,mkwst@chromium.org

Review URL: https://codereview.chromium.org/1005283002

Cr-Commit-Position: refs/heads/master@{#320651}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9b5bedf2..3a444f91

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1003403002

Cr-Commit-Position: refs/heads/master@{#320650}

Cr-Commit-Position: refs/heads/master@{#320649}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8e14d66..173e5fe

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1006133002

Cr-Commit-Position: refs/heads/master@{#320648}

TBR=pdr
NOTRY=true
BUG=467281

Review URL: https://codereview.chromium.org/1007803005

Cr-Commit-Position: refs/heads/master@{#320647}

BUG=466907

Review URL: https://codereview.chromium.org/1001283002

Cr-Commit-Position: refs/heads/master@{#320646}

BUG=464843,464120

Review URL: https://codereview.chromium.org/1002323002

Cr-Commit-Position: refs/heads/master@{#320645}

TBR=mikhal1@chromium.org
BUG=410451

Review URL: https://codereview.chromium.org/1003333002

Cr-Commit-Position: refs/heads/master@{#320644}

Need to starge a pre-cl in skia first (and then add override to chrome's classes)

This reverts commit 6e54eb96.

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1005213004

Cr-Commit-Position: refs/heads/master@{#320643}

Revert of Increase YUV video clamping (patchset #4 id:60001 of https://codereview.chromium.org/1008493002/)

Reason for revert:
I think this patch caused blink layouttest failures (e.g., media/video-colorspace-yuv420.html). See http://crbug.com/467283

Original issue's description:
> Increase YUV video clamping
>
> The current clamping is not enough to avoid bleeding issues. This is
> exposed when changing the background color in CreateEdgeBleedPass from
> black to gray. The reason it works now is because interpolating U/V
> textures from black (YUV = 0, 0, 0) to green (YUV = 149, 43, 21) will
> still result in saturated green pixels (RGB = 0, 255, 0). All YUV values
> in the range (149, 0-43, 0-21) will end up as RGB = (0, 255, 0).
>
> The current clamping is not enough, because the calculation
> '0.5f / quad->tex_size.width()' is using the Y texture size, the highest
> resolution plane, but the U/V texture size is only half of that. This CL
> changes tex_size to represent the lowest resolution texture instead.
>
> BUG=429640
>
> Committed: https://crrev.com/4be817dd606efdba1614d32608ddd6e16bfa687d
> Cr-Commit-Position: refs/heads/master@{#320567}

TBR=enne@chromium.org,danakj@chromium.org,wfh@chromium.org,magjed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=429640,467283

Review URL: https://codereview.chromium.org/1007953003

Cr-Commit-Position: refs/heads/master@{#320642}

This fixes the computation of screen-space and target-space transforms
when flattening is involved.

Property trees currently compute the transform from a source node
to a target by combining the source node's to_screen transform and
the target's from_screen transform. This is correct in the absence
of flattening, but not with flattening, since the source node's
to_screen transform might include a flat version of the target
node's local transform, while the target node's from_screen transform
includes the inverse of the unflattened version of this transform.
This CL changes this computation to no longer use inverses.

Property trees currently distinguish between flattening inherited by
a node (applying to the combined transform inherited by the node) and
flattening initiated by a node. Flattening initiated by a node only
applies to descendants, never to the node itself. However, this
flattening does need be applied by layers that have this node as a
transform parent, excluding the layer corresponding to the node
itself. Since nodes aren't created just for flattening, descendant
layers may need to flatten even when their transform parent node's
local flattening bool is false. This CL removes the local flattening
bool from each node, and instead adds a flattening bool to each layer.

BUG=386810

Review URL: https://codereview.chromium.org/1009573002

Cr-Commit-Position: refs/heads/master@{#320641}

Some more cleanup. In this CL:

- VideoCapturerDelegate::OnStateUpdateOnRenderThread
 does not need OnRenderThread suffix since it lives on
 Render Thread exclusively. Removed the suffix.

- cosmetic changes (removed unnecessary {}, updated comments).

- media_stream_video_source.cc struct SourceVideoResolution
 does not need to be named, defined anonymously together
 with the array it's used for, |kVideoResolutions|.

- Some for loops are substituted with range-based versions.

- Some member vars are made const.

- Some methods are reordered to follow class declarations.

- MediaStreamVideoTrack::thread_checker_ is unnecessary and
 |main_render_thread_checker_| from parent class can be used
 instead. Similar story for WebRtcLocalAudioTrack.

- MediaStreamVideoTrack::FrameDeliverer uses void* to identify
 a MediaStreamSink, changed to typedef MediaStreamSink* VideoSinkId
and used in this class (IMHO this is more readable).

All these happened to be noticeable as I was re-reading
the code, some kind of state-of-the-pipeline review :)

[1] https://code.google.com/p/chromium/codesearch#chromium/src/remoting/host/audio_pump.cc&l=135

BUG=441836

TBR=avi@chromium.org
(Avi, I'm TBRing you since it's just removing an
unused 2-class forward declaration @
content/public/renderer/media_stream_video_sink.h)

Review URL: https://codereview.chromium.org/976233002

Cr-Commit-Position: refs/heads/master@{#320640}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c0a00a28..9b5bedf2

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1005273002

Cr-Commit-Position: refs/heads/master@{#320639}

As the comment in web_data_service_backend.h by caitkp@,
rename WebDataServiceBackend to WebDatabaseBackend and related class.
Rename the files also.

BUG=
R=caitkp@chromium.org

Review URL: https://codereview.chromium.org/962903003

Cr-Commit-Position: refs/heads/master@{#320638}

Instead of just taking the text of the previous row, try to look for a
cell in the previous row that matches the position of the current cell.

Review URL: https://codereview.chromium.org/1006743002

Cr-Commit-Position: refs/heads/master@{#320637}

This solution allows empty blobs (and files) to be created.
Most tests for this change are Blink layout tests, so will land
in a separate CL.

BUG=399323

Review URL: https://codereview.chromium.org/942633004

Cr-Commit-Position: refs/heads/master@{#320636}

Accessing the Location->Birth std::map takes up about 0.5% of the CPU cycles, according to recent data from ChromeOS-wide profiling. That is a LOT for Chrome, which contains a ton of stuff.

Replacing it with a hash map cuts that down by 1/3 to 1/2. See the bug for more details.

BUG=chromium:463700
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/957573002

Cr-Commit-Position: refs/heads/master@{#320635}

A recent change (https://codereview.chromium.org/973753002/) removed the
width/height properties from the IDL, but the Google Cast Extension needs
them to be present until a patch rolls out to all Chrome Canary/Dev/Beta
users.

BUG=466357
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/1009643002

Cr-Commit-Position: refs/heads/master@{#320634}

If Frecon is in the middle of an animation and GPU process is starting,
the GPU process won't be able to take DRM master. So we want to
synchronize with Frecon such that the GPU process waits for Frecon to
finish.

BUG=463665

Review URL: https://codereview.chromium.org/1007443005

Cr-Commit-Position: refs/heads/master@{#320633}

Previous CL disabled wrong one...

BUG=467072
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/996013006

Cr-Commit-Position: refs/heads/master@{#320632}

BUG=467249

Review URL: https://codereview.chromium.org/1001883005

Cr-Commit-Position: refs/heads/master@{#320631}

Previously this class would only possibly set the error message on
certain conditions (the confirm passphrase field had focus or text),
but would then incorrectly use the existence of that error as the
validation for the text.

Now those things are correctly decoupled. Additionally, the Ok button
will now pop up an error instead of closing the dialog if pressed when
the passphrases are invalid.

BUG=461071,466095

Review URL: https://codereview.chromium.org/996073002

Cr-Commit-Position: refs/heads/master@{#320630}