GitLab

The crashes under --mash are due to heap corruption from code trying
to disable multi-user switching animations. That code does not seem
necessary any more. Per crrev.com/223823004 when it was added this
test was reliably failing. The multi-user switch animations have
been recently refactored and a shelf animation removed. The test
now passes even without the animation disabling code.

I cannot reproduce failures or crashes without --mash. I've done
ASAN runs as well. I suspect the non-mash problem in the bug is
unrelated to this test and may have been fixed separately.

Bug: 787050
Test: browser_tests --gtest_filter=PreferencesTest.* --gtest_repeat=100
Change-Id: I08dc3897361440fdbd49df1a11429e06fb9bac51
Reviewed-on: https://chromium-review.googlesource.com/804401Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521134}

This CL removes some unused code in RulesetMatcher.

BUG=None

Change-Id: I233c3b59e982df380ef8345a3328765445a0b97c
Reviewed-on: https://chromium-review.googlesource.com/803750Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521133}

If a resource is marked to request a promotion hint, but it isn't
used by any quad, then it might not be synced by GLRenderer before
promotion hints are sent.  In that case, locking the resource for
read will DCHECK.

This CL adds a check for unsynchronized resources, and skips sending
hints for those that aren't synced.

Bug: 788359
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I54a2d4ced392a313a56f48a1b066ca3f2f62d152
Reviewed-on: https://chromium-review.googlesource.com/794598
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521132}

commit 296c7dc4ac54becebec0b8f32b072becf0b94c33
Author: James Zern <jzern@google.com>
Date:   Wed Nov 29 16:54:23 2017 -0800

    fix lossless decoding w/WEBP_REDUCE_SIZE

    alpha processing is still required when requesting premultiplied output

    since:
    1b27bf8b WEBP_REDUCE_SIZE: disable all rescaler code

Bug: 789665
Change-Id: I4920127e71519a1534ae84ea04b92a8e2ac271d3
Reviewed-on: https://chromium-review.googlesource.com/802399Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#521131}

- introduce MessageCenterScrollView and use for
MessageCenterView::scroller_. We need this because the |scroller_| is
the one that gets focused when a user invokes Alt+Shift+N.

- remove accessibility bits from MessageCenterView including accessible
data and focusability.

Test: with ChromeVox, press Alt+Shift+N and tab around. Verify that the
scroller gets focused and outputs correctly when first entering message
center and that tabbing never reaches the MessageCenterView, but only
reaches the scroller_. Previously, both were tab stops.

Bug: 
Change-Id: I1c8b06f157bbb4749f61cdd6a4f80c5693d76f48
Reviewed-on: https://chromium-review.googlesource.com/801344
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521130}

This CL also changes the mojoPrivate API to be simply an async wrapper around
require().

Bug: 699569, 718047
Change-Id: I271887d1cc1eb49fd2faefff47467c47be23a3be
Reviewed-on: https://chromium-review.googlesource.com/783645Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521129}

The new ones don't pull in a dependency on the giant OID table. This
should be the last link in all of Chromium aside from WebRTC. (Also
that random build tool in //net, but that's not shipped.)

Bug: 706445
Change-Id: I06d0c953b829a592afeeb8399e788e8ea8e53af6
Reviewed-on: https://chromium-review.googlesource.com/804119
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521128}

When tests were run locally on buildbot builders, we'd set
CHROME_HEADLESS to tell tests that they weren't being run
interactively (so we wouldn't do things like show modal dialogs
that might be flaky or problematic).

Apparently we never thought to propagate this over to swarming :(.

This change sets the env var in test_env.py, which should take
effect for all desktop gtest-based tests. It's unclear if the
env var also is needed for iOS and Android, and whether we'll
need to set this elsewhere as well, but this should solve at
least some problems for now.

R=jbudorick@chromium.org, maruel@chromium.org
BUG=790985

Change-Id: I3914568c2a9e56ae5f6e450708491fecf6f57f48
Reviewed-on: https://chromium-review.googlesource.com/804398Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521127}

Fix typo in //media/test/README: s/@/2/. No new code.

TBR=kcwu@chromium.org

Change-Id: Iee9e1d086498d1fce340576f0d32db42920ac103
Reviewed-on: https://chromium-review.googlesource.com/804055Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521126}

Converted accessibility module as an example.

Bug: none
Change-Id: Ib7f475c9a20a58839aa580508c130ea88027170e
Reviewed-on: https://chromium-review.googlesource.com/804418Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521125}

Manual removals for the HSTS preload list.

TBR=palmer@chromium.org

Change-Id: Ia222959e2307e8f61a13438b1ae824579ef103ac
Reviewed-on: https://chromium-review.googlesource.com/801896
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521124}

This is a logic bug introduced in crrev.com/c/789791. If
SetWebUsageEnabled(true) is called twice consecutively, the session at
the time of the first call will incorrectly be restored during the
second call. The navigation history between the two calls will be lost.

This was exposed in TabUsageRecorderTestCase/testColdLaunchReloadCount
egtest.

Bug: 781916
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6f7226fb42ba7d647b9229514a574afc57703ae3
Reviewed-on: https://chromium-review.googlesource.com/803740Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521123}

NPAPI plugin support has been removed from chrome and the "plugins" extension
manifest key is effectively deprecated. This CL deprecates the plugins
requirement. Extensions which specify the plugins requirements will now get an
install warning. Extensions explicitly requesting the npapi requirement (by
setting requirements.plugins.npapi to true) in their manifest will get a load
error.

BUG=732590

Change-Id: I874ca17b5143516f1746fff90197243eb6ac2999
Reviewed-on: https://chromium-review.googlesource.com/795361Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521122}

Currently, if ARC++ is uninstalled while an Android VPN is running,
shill will not receive a disconnection event and this will break
networking on Chrome OS.  Fix this by forcing ARC VPN to disconnect
whenever ArcNetHostImpl shuts down.

BUG=768053
TEST=uninstall ARC++ through Settings with a VPN connected

Change-Id: Iccbdc20bb26bce154f8041a517b1220519a2b738
Reviewed-on: https://chromium-review.googlesource.com/778340
Commit-Queue: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521121}

https://chromium.googlesource.com/angle/angle.git/+log/361df070323f..76746f9bc29d

$ git log 361df0703..76746f9bc --date=short --no-merges --format='%ad %ae %s'
2017-11-22 brandon1.jones Optimize Fragment Shader Type Match Validation

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: I64278a9b3a17edb0810849f5d5e7d0c40a77aa0e
Reviewed-on: https://chromium-review.googlesource.com/804412Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521120}

BUG=none
TEST=none

Change-Id: I3cee01abf6159f9e632c4929538c13554e4c2dfb
Reviewed-on: https://chromium-review.googlesource.com/804147Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521119}

https://pdfium.googlesource.com/pdfium.git/+log/1f0d1fda6db8..752e9bf892ab

$ git log 1f0d1fda6..752e9bf89 --date=short --no-merges --format='%ad %ae %s'
2017-12-01 thestig Add CFX_FloatRect::ToRoundedFxRect().
2017-12-01 thestig Add CFX_FloatRect::Scale().
2017-12-01 thestig Rename CFX_FloatRect::Scale() to ScaleFromCenterPoint().
2017-12-01 thestig Remove unused CFX_FloatRect::Substract4().
2017-12-01 thestig Add some CFX_FloatRect unit tests.
2017-12-01 npm Remove unneded structs from CFX_CTTGSUBTable part 2

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I17774bd6b170e086953b375ea5601f38689dd71a
Reviewed-on: https://chromium-review.googlesource.com/804409
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521118}

Creates a ToolbarCommands protocol so the ToolbarVC can cancel the omnibox edit.

Bug: 791092
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5e283cfd1144b41c6f207103de153f0c6a4d7128
Reviewed-on: https://chromium-review.googlesource.com/804140
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521117}

The primary objective of this CL is to ease SPv175+ implementation by making sure
there's a 1:1 mapping from meta display items to property tree nodes.

1. A bunch of meta display items have been converted to embedded drawing commands
in ClipPathClipper. For each layout object that has a clip-path, at most 2 effect
nodes (for isolation and mask) and 1 clip node (for raster-based clip, if applicable)
will be created. All meta display items that apply to individual clip-path in a
nested clip-path chain are flattened into drawing commands. e.g. local transforms,
and save layer that intersects nested masks.

2. Switched around the mask painting order. Before this CL it was
result = mask <SrcIn> content
After this CL it becomes
result = content <DstIn> mask
The result should be equivalent, this change is to unify with other similar usage,
thus sharing code in the compositor logic.

3. Reduce the number of save layer with nested clip-path. Previously each clip-path
in a chain will use 2 layers for isolation and mask application, but in fact the
isolation can be shared. For example it was:
result = (((mask_3 <SrcIn>(mask_2)) <SrcIn>(mask_1)) <SrcIn>(content))
using 6 save layers for a nested clip-path of 3, with this CL it becomes:
result = (content <DstIn>(mask_1 <DstIn>(mask_2) <DstIn>(mask_3)))
using only 4 save layers.

4. Caching logic in LayoutSVGResourceClipper has been improved. Previously if a SVG
clip-path can't use raster-based clip, subsequent calls to AsPath() will attempt
to compute a path again. Now it should remember it has failed from last time.

5. Previously added helper functions LayoutObject::LocalReferenceBoxForClipPath()
and LayoutObject::LocalClipPathBoundingBox() has been moved to ClipPathClipper.

6. Miscellaneous coding style improvement. Prefer NRVO over output argument.

BUG=769942

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9a8602bb7a8bcaf990cfa14dca77012d27c1c46c
Reviewed-on: https://chromium-review.googlesource.com/770096Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521116}

Several services require "app" capability from all other services
(wildcard), which is in itself probably a Bad Thing; but it's
especially bad now because the catalog service exposes module
directory access through its app capability.

This changes the catalog manifest to move the capability to a
different more specific capability, and updates two of its
consumers.

May break other random mash/mushrome (i.e. non-production) services
depend on the blanket directory access behavior since aura mus
client library code depends on it in some environments.

Bug: 791003
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I81d81af8385fb1e013445a6b8c175ebf96388077
Reviewed-on: https://chromium-review.googlesource.com/804397
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521115}

Fix a bug where snapped windows in splitview while still in overview
do not have their headers painted. Make CustomFrameViewAshBase look for
splitview state changes, and repaint the header if the state is snap
left or snap right.

Test: ash_unittests CustomFrameViewAshTest.HeaderVisibility*
Bug: 789378
Change-Id: I7ff65181134205544af2a717a3ee3e3797aa2ad2
Reviewed-on: https://chromium-review.googlesource.com/797681
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521114}

BUG=790776

Change-Id: I445eb3ef0dc957342ef2afc62fed3c51b06f893a
Reviewed-on: https://chromium-review.googlesource.com/804059Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521113}

Bug: 788148
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I82a5d1ca789d62effc897ccccd981dc12c93610b
Reviewed-on: https://chromium-review.googlesource.com/804236Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521112}

If there are concurrent attempts (ie, spamming spacebar and enter) lock
would get into a bad state. Prevent concurrent attempts.

Bug: 719015
Change-Id: I4e40368fc8daa1d6ba3c47d4d181a0331b29d2a2
Reviewed-on: https://chromium-review.googlesource.com/688734
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521111}

NGOffsetMapping::GetFor() used to return the wrong mapping for positions before
or after an inline block. Example:

<div><span style='display: inline-block'>foo</span></div>

When taking SPAN@BeforeAnchor, GetFor() returns the offset mapping of the SPAN,
but the correct result should be that of the DIV since the position is outside
of the SPAN. The root cause is that EnclosingNGBlockFlow() on SPAN returns the
layout object of SPAN itself, since it is a LayoutNGBlockFlow by itself.

This patch fixes the issue by returning EnclosingNGBlockFlow() of its parent
instead when the given position is before/after an atomic inline.

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Idf2cdda0fd9c5ed533e5d516fe459374e0383b29
Reviewed-on: https://chromium-review.googlesource.com/802628Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521110}

Each AXPlatformNodeWin, including the accessibility system caret, is assigned a unique ID on construction. Mistakenly, I was assigning a new ID instead of using the existing one when constructing the AXSystemCaretWin object which meant that all events were sent having the wrong object ID.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 789176
Change-Id: I15681365ad0e461cf29789df9a4f69301e3e6104
Reviewed-on: https://chromium-review.googlesource.com/803858Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521109}

Ensure that we call DispatcherDelegate::InitializeBindingsSystem for
the bindings system created for worker-thread bindings in order to
allow adding custom bindings.

Bug: 653596
Change-Id: I4e5a71d13d27738098daf281ff49400f533b716d
Reviewed-on: https://chromium-review.googlesource.com/759720
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521108}

This makes the paint record dumped in the verbose GraphicsLayer tree
reflect the actual painted result and consistent with the cc display
item list.

Bug: 771643
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ida7342b5d729b4b6f3ed2f8820242671ed1a2a3a
Reviewed-on: https://chromium-review.googlesource.com/798219Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521107}

There's no break opportunity before the first block child, only between
siblings.

Bug: 788337
Change-Id: I185e9d5a8318d2964c9db3c3a80733ed2617eb24
Reviewed-on: https://chromium-review.googlesource.com/803441Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521106}

This CL moves most of the logic for monitoring audibility of audio
output streams from AudioStreamMonitor to AudioOutputDelegateImpl.
This is in anticipation to moving the audio stack to an utility
process.
AudioStreamMonitor is tightly coupled with WebContentsImpl and will
remain on the browser process.

The approach this CL takes is to move actual monitoring to
AudioOutputDelegateImpl and use a Mojo object to pass notifications
to AudioStreamMonitor. The Mojo object (AudioOutputStreamObserver) will
live on the browser process and a reference to it will be passed to
AudioOutputDelegateImpl so that it can forward updates.

The only significant behavior change is that the indicator will be on
for some amount of time after the tab becomes inaudible. Previously,
the indicator was on for some amount of time after the last time the
tab was polled to be audible. In both cases, frequent changes in
audibility do not affect the indicator on the tab UI, but the new
scheme might keep the indicator on slightly longer due to the
notification latency.


Bug: 784812
Change-Id: I38912122e8bca8a0c508957271fd762f27ecda2a
Reviewed-on: https://chromium-review.googlesource.com/738198
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521105}

Using wpt-import in Chromium e59817eb.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6556

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts

TBR=qyearsley

No-Export: true
Change-Id: I8dccb65f75d393473fe8d67b3802e4725c0a0d0b
Reviewed-on: https://chromium-review.googlesource.com/804356
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521104}

Bug: 790964
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6f8a4eb0cddd8bd695723645fbab551f3935fbd5
Reviewed-on: https://chromium-review.googlesource.com/803899
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521103}

Bug: 781189
Change-Id: I1472076e579a94fe14c0ee1aa6d52d1d7cf0931f
Reviewed-on: https://chromium-review.googlesource.com/801541Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521102}

Now that lighthouse has succeeded our legacy audits panel, it's time to
remove audits, the extension audits API, extension audits-related
docs, and relevant tests.

Bug: 790541
Change-Id: Ie2cf3fb439dab768a8511b151d81d6066b41a3a9
Reviewed-on: https://chromium-review.googlesource.com/798633Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521101}

For taking the VP9 HDR metadata from the video container and passes it to MediaCodec
Reference for packing HDR metadata in MediaFormat:
https://github.com/google/ExoPlayer/pull/2729/commits/e93ce41a285fe6b0493faa91523b010469591be7

Bug: internal b/68950223
Test: none
Change-Id: Id2b83c98a0844832f3bdfae7e3bd1dfa9c3728dc
Reviewed-on: https://chromium-review.googlesource.com/755952Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521100}

PopulateNetworkSessionParams was incorrectly missing some members
(specifically, missing NetLog caused this bug).  The existing builder
method is designed to populate all members correctly.

Bug: internal b/68856390
Test: cast on steak
Change-Id: Ief423d5658a31ccd2eb35b6fd29b6721cc7c7910
Reviewed-on: https://chromium-review.googlesource.com/777786Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521099}

The TabIcon will schedule its own painting when its state changes.

This call was left from a previous iteration where it did not do so.

Bug: 778461
Change-Id: I351f2c2e6e11c9ab942c98ccb3e002fd8cbfb67f
Reviewed-on: https://chromium-review.googlesource.com/804239Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521098}

Bug: chromium:775329
Change-Id: Ie4e9ec4b7e2e17a2081336fb7a525b37de5e1c75
Reviewed-on: https://chromium-review.googlesource.com/793171Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521097}

Bug: 780994
Change-Id: I549f606839d8fd36facd6a729fd1be27be9a3a09
Reviewed-on: https://chromium-review.googlesource.com/803628Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521096}

This change sees single-line text rendering properly update the vertical
dimension of the underlying texture.

In addition, the recently-added text unittest is reworked to allow more
thorough and easy testing, by separating text layout from rendering and
canvas, and also exposing the internal text layout to tests.

BUG=
R=bshe

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib0ec5b678adf2727d58543e281685ce49ae691af
Reviewed-on: https://chromium-review.googlesource.com/801955Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521095}