GitLab

Review URL: https://codereview.chromium.org/637223006

Cr-Commit-Position: refs/heads/master@{#301137}

Create a single implementation of MotionEvent's |Clone()| and
|Cancel()| methods using MotionEventGeneric. Expand
MotionEventGeneric to support historical events, also removing
CompoundMotionEvent from the MotionEventBuffer implementation.

By avoiding JNI and garbage creation, this reduces the cost of both
methods by ~10x on Android, from ~25us call to ~2us.

BUG=501503003

Review URL: https://codereview.chromium.org/502993004

Cr-Commit-Position: refs/heads/master@{#301136}

  * To load the apps you can specify a comma-separated list in the command-line.
    For example: 'app_shell --app-shell-app-path=path/to/app1/,path/to/app2'

  * For now there's no API to control the focus of the apps, so the only way
    to switch apps is to either close the app_window (which will switch focus to
    the next app in the hierarchy) or using the aura::Window API directly and
    calling Focus() on the windows.

BUG=422618

Review URL: https://codereview.chromium.org/642383003

Cr-Commit-Position: refs/heads/master@{#301135}

Huge solid layers can cause a lot of memory to be allocated because
append quads function would use the content_bounds, not the
visible_content_rect.

PLI now uses visible rect, but SCLI is still using the content
bounds, this should probably be addressed in a follow up, but I'm
not too worried about this since it always worked this way and
this is mostly used by unit tests.  We can't simply pass the
visible rect because none of the unit tests set the visible rect,
and the visible rect is not passed from SCL to SCLI for tests that
don't directly interact with the SCLI.

BUG=423950

Review URL: https://codereview.chromium.org/675903002

Cr-Commit-Position: refs/heads/master@{#301134}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b3eb687..c6f3e2c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/674193002

Cr-Commit-Position: refs/heads/master@{#301133}

BUG=230018
TEST=unit_tests:OwnerSettingsServiceChromeOSTest.*

Review URL: https://codereview.chromium.org/654263003

Cr-Commit-Position: refs/heads/master@{#301132}

BUG=405876
TEST=existing unit_tests and browser_tests

Review URL: https://codereview.chromium.org/672203003

Cr-Commit-Position: refs/heads/master@{#301131}

This CL implements the Chrome signin on desktop using webview. Since the webview approach is
significantly different than the current iframe one, thus I created a fork of some files
instead of adding more logic to the existing over-complicated code. The feature is enabled
under a flag --enable-webview-based-signin. Once the feature is fully launched on both dekstop
and ChromeOS, the old files should be deleted.

There are a few known issues.

1. Gaia needs to update their script to post credentials directly to chrome://chrome-signin
instead of the gaia auth extension. Before the gaia code is updated, webview signin cannot scrape
password and the checkbox value for choosing what to sync.

2. Webview currently only loads in a full tab, need to investigate why it doesn't work when
embedded in the avatar menu.

3. Some webview apis are broken in an extension-less webui context.
https://codereview.chromium.org/670173002/ fixes a few that are required for a minimum desktop
signin flow. One important missing piece is the extension messaging api, and as a result Gnubby
does not work with a webview, tracked in crbug/426016.

4. Some standard WebUI features are missing, such as zoom, find, print preview, need to
decide whether it is worth to support them.

5. Webview is not fully accessibility proof. According to webview team, most accessibility bugs
have been fixed by the accessibility team (crbug/330307, crbug/368298), need to confirm.

6. This CL only implements the desktop signin flow. The ChromeOS signin flow is a superset
of the desktop one, and ChromeOS team needs to add extra logic to complete it for ChromeOS.

BUG=364432

Review URL: https://codereview.chromium.org/646983008

Cr-Commit-Position: refs/heads/master@{#301130}

BUG=426498

Review URL: https://codereview.chromium.org/672303003

Cr-Commit-Position: refs/heads/master@{#301129}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bcef85c..28d0729

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/675983003

Cr-Commit-Position: refs/heads/master@{#301128}

Revert of Close the select box when the parent RWHVA loses focus (patchset #2 id:170001 of https://codereview.chromium.org/652793003/)

Reason for revert:
Broke Linux ChromiumOS Tests (dbg)(1):
RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus (run #1):
[ RUN      ] RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus
Xlib:  extension "RANDR" missing on display ":9".
../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:875: Failure
Value of: observer.destroyed()
  Actual: false
Expected: true
[  FAILED  ] RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus (10 ms)

Original issue's description:
> Close the select box when the parent RWHVA loses focus
>
> BUG=422264,414550
> TEST=RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus
>
> Committed: https://crrev.com/1f909ee8c8ae5cbc92416482374d2228f087684c
> Cr-Commit-Position: refs/heads/master@{#301108}

TBR=tkent@chromium.org,ben@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422264,414550

Review URL: https://codereview.chromium.org/663483005

Cr-Commit-Position: refs/heads/master@{#301127}

See https://codereview.chromium.org/679553002/

BUG=
R=jamesr@chromium.org,navabi@chromium.org

Review URL: https://codereview.chromium.org/675203002

Cr-Commit-Position: refs/heads/master@{#301126}

BUG=268157

Review URL: https://codereview.chromium.org/657983003

Cr-Commit-Position: refs/heads/master@{#301125}

BUG=

Review URL: https://codereview.chromium.org/675183002

Cr-Commit-Position: refs/heads/master@{#301124}

The tvcm HTML files were shuffled around in the trace-viewer repo and moved
back up to a higher directory. The tvcm prefix was renamed to tv to show they
are no longer in tvcm itself. This CL updates the telemetry files to match
the new trace-viewer structure.

This includes the DEPs roll in order to get the new structure from
trace-viewer.

Review URL: https://codereview.chromium.org/669153009

Cr-Commit-Position: refs/heads/master@{#301123}

This will land shortly before 650403004 gets landed.

BUG=410400
TEST=-

Review URL: https://codereview.chromium.org/652293005

Cr-Commit-Position: refs/heads/master@{#301122}

BUG=405876
TEST=existing unit_tests and browser_tests

Review URL: https://codereview.chromium.org/672233002

Cr-Commit-Position: refs/heads/master@{#301121}

This was accidentally enabled in crrev.com/680463002.

BUG=chromedriver:913
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/678703002

Cr-Commit-Position: refs/heads/master@{#301120}

This doesn't do anything yet, mostly adds supporting infrastructure.

R=lliabraa@chromium.org, mark@chromium.org, sdefresne@chromium.org, lliabraa, mark, sdefresne
TBR=darin

BUG=426870

Review URL: https://codereview.chromium.org/669673004

Cr-Commit-Position: refs/heads/master@{#301119}

Cleans up various unnecessary namespace declarations and also fixes
some lint errors. Code is reformatted using git cl format.

BUG=374763

Review URL: https://codereview.chromium.org/636363004

Cr-Commit-Position: refs/heads/master@{#301118}

The change https://codereview.chromium.org/653423004 introduced a warning. The Simple Chrome workflow treats all ChromeOS warnings as errors (https://sites.google.com/a/chromium.org/dev/chromium-os/how-tos-and-troubleshooting/building-chromium-browser?pli=1)

This change initializes the variable to a default unknown value.

BUG=424596
TEST=Compiled with Simple Chrome workflow. Ran existing EventRewriterTest

Review URL: https://codereview.chromium.org/677093002

Cr-Commit-Position: refs/heads/master@{#301117}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cee4ddf..b3eb687

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/677083003

Cr-Commit-Position: refs/heads/master@{#301116}

HTML Tags: head, input type tel, noscript
ARIA Role: listbox, separator
ARIA state/property: aria-required(true/false)

Following HTML tags are undergoing/done in some other CL:
HTML Tag - input type num, pre, header, blockquote.

HTML ruby tag is not exposed correctly. Will submit it with the fix in new CL.

BUG=170577

Review URL: https://codereview.chromium.org/680483002

Cr-Commit-Position: refs/heads/master@{#301115}

Instead of GetCommandLineString, uses
GetCommandLineStringWithPlaceholders, which is specially designed to
quote placeholder arguments like "%1". This is necessary when writing a
command line to the Windows registry, because otherwise Windows may put
a filename with a space in it, and recognise it as two separate
arguments.

BUG=130455

Review URL: https://codereview.chromium.org/669943003

Cr-Commit-Position: refs/heads/master@{#301114}

This CL refactors the current class hierarchy, currently looking sth like:

VideoCapture (abstract)
    ^    ^--- VideoCaptureAndroid
    +-------- VideoCaptureTango

into:

VideoCapture (abstract)
    ^    ^---VideoCaptureCamera (abstract)
    |           ^    ^--- VideoCaptureAndroid
    |           +-------- VideoCaptureTango
    |
    +--------VideoCaptureCamera2  (To be introduced in parallel CLs(*))

(*) Note that http://crrev.com/611283002 only introduces static
methods, so this "plugging" into this new hierarchy can be done
afterwards.

Some operators are also moved from end of line to beginning of the next
one following presubmit warnings.

Also some accessing qualifiers are revisited, and some static methods
consolidated at the top of the class declaration, where they seem to belong.

BUG=418052

Review URL: https://codereview.chromium.org/656323004

Cr-Commit-Position: refs/heads/master@{#301113}

BUG=None
R=msw@chromium.org

Review URL: https://codereview.chromium.org/673013002

Cr-Commit-Position: refs/heads/master@{#301112}

viewer hierarchy aware.

BUG=425017

Review URL: https://codereview.chromium.org/654203006

Cr-Commit-Position: refs/heads/master@{#301111}

It's only used by Loader code.

BUG=426442

Review URL: https://codereview.chromium.org/669073003

Cr-Commit-Position: refs/heads/master@{#301110}

This is the concrete implementation of the web::NavigationItem interface.

BUG=422033
TEST=None

Review URL: https://codereview.chromium.org/678483003

Cr-Commit-Position: refs/heads/master@{#301109}

BUG=422264,414550
TEST=RenderWidgetHostViewAuraTest.PopupClosesWhenParentLosesFocus

Review URL: https://codereview.chromium.org/652793003

Cr-Commit-Position: refs/heads/master@{#301108}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/672293008

Cr-Commit-Position: refs/heads/master@{#301107}

Previously if the browser got an accessibility IPC it was unable to
interpret, it killed the renderer. This change makes it reset the
accessibility state instead so we're tolerant of corner cases that
are very difficult to completely eliminate in practice.

The accessibility reset is designed to be safe, it throws away all
accessibility state on the browser side and waits for an IPC from
the renderer acknowledging the renderer reset as well.

BUG=372478

Committed: https://crrev.com/0c5e8d16661df7e08c708997f24c0a3070e58080
Cr-Commit-Position: refs/heads/master@{#298297}

Review URL: https://codereview.chromium.org/625443002

Cr-Commit-Position: refs/heads/master@{#301106}

The file blink_skia_config.gyp is changing to a gypi.
This allows easier sharing between the gyp and gn build systems.

Review URL: https://codereview.chromium.org/677513003

Cr-Commit-Position: refs/heads/master@{#301105}

This CL adds a list of active field groups to NetLog dump. The string
representation is human readable, in the form of trial_name:group_name.

BUG=426474

Review URL: https://codereview.chromium.org/671253002

Cr-Commit-Position: refs/heads/master@{#301104}

This makes it clear that this target depends on //content and lays the
groundwork for a future sessions_ios target.

The files in components/sessions/core/ are moved to a variable so that
they can be shared across targets.

TBR=finnur@chromium.org
TBR=sky@chromium.org
BUG=371476
TEST=None

Review URL: https://codereview.chromium.org/673843002

Cr-Commit-Position: refs/heads/master@{#301103}

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/645223008

Cr-Commit-Position: refs/heads/master@{#301102}

gfx::Font already contains a FontRenderParams struct. Make
RenderTextHarfBuzz use it when possible instead of always
querying for a new struct.

BUG=none

Review URL: https://codereview.chromium.org/674683003

Cr-Commit-Position: refs/heads/master@{#301101}

This extracts the common SystemWebview gyp params to a shared .gypi file.

BUG=None
TEST=compiles

Review URL: https://codereview.chromium.org/677033002

Cr-Commit-Position: refs/heads/master@{#301100}

Revert of Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #1 id:1 of https://codereview.chromium.org/671183002/)

Reason for revert:
White success page and no way to proceed only reproduces for use_athena=1 builds.

This CL fixes that: https://codereview.chromium.org/642693003/

Re-landing.

Original issue's description:
> Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #46 id:1740001 of https://codereview.chromium.org/473153002/)
>
> Reason for revert:
> This breaks Chrome OS GAIA login.
>
> After successful GAIA authentication uses sees blank white page and nothing happens.
>
> Please build chromeos=1 build and check that sign in as new user works fine before relanding this CL. Unfortunately autotests rely on fake gaia server and doesn't check this end-to-end sign in flow.
>
> Original issue's description:
> > Inline login handler extracts gaia id from HTTP header and seeds account tracker
> > service during sign in.
> >
> > BUG=341408
> >
> > Committed: https://crrev.com/a8e7c94b1b79a0948d05a1fcfff53391d22ce37a
> > Cr-Commit-Position: refs/heads/master@{#300750}
>
> TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=341408
>
> Committed: https://crrev.com/bbaf207927765f4b7c7cae2a4af8db6c4c4a67ce
> Cr-Commit-Position: refs/heads/master@{#300873}

TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341408

Review URL: https://codereview.chromium.org/677703002

Cr-Commit-Position: refs/heads/master@{#301099}

The version was so old that recording some modern web pages failed.

BUG=425548

Review URL: https://codereview.chromium.org/669413002

Cr-Commit-Position: refs/heads/master@{#301098}