- 26 Nov, 2018 40 commits
-
-
Dan Elphick authored
Fixes uses of Object::Set, Get, ToObject and GetPropertyNames in content/renderer/pepper/ppb_var_deprecated_impl.cc. Bug: v8:7283, v8:7286, v8:7279, v8:8238 Change-Id: I54b420f7173b23d241508ad697c0410c8ae45da6 Reviewed-on: https://chromium-review.googlesource.com/c/1349332Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610921}
-
Akihiro Ota authored
Build on PosInSet and SetSize functions in ax_node.cc to handle invalid or erroneous assignment. SetSize should not allow decreasing assignments, while PosInSet should not allow decreasing nor duplicate assignments among nodes in the same container. Change-Id: I07b0e9c493439aca9ef50ecfe3c3f5bbf7a7ce7a Reviewed-on: https://chromium-review.googlesource.com/c/1343374 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#610920}
-
David Jacobo authored
TextClassifier provides methods for text classification via the ARC container, one of these methods is classifyText(), this method expects (among other params) a text to classify which needs to be non-empty. This CL ensures that the provided text string is not empty before passing it to the container, we already had a check in place but is likely that converting the string could have messed with it. Bug: b/119794258 Test: Build. Change-Id: I155295c283e1f774f152483c8f5f009ded70baa3 Reviewed-on: https://chromium-review.googlesource.com/c/1344196 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#610919}
-
Min Chen authored
Bug: 907660 Change-Id: Ic0b3916328d92a4989be0a9e3b2553986ab4f830 Reviewed-on: https://chromium-review.googlesource.com/c/1347618Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#610918}
-
Sammie Quon authored
This CL fixes: Consolidates TestShellObserver in window selector controller unittest and TestOverviewObserver in window_selector_unittest. Removed two overlapping tests. Remove a TODO about bouncing a window, since a toast shows anyways. Remove a enum for the header layout which is not needed anymore because the header always fades in at the final location now. Previously there was this enum to differentiate when the header animated with the window, or when there was color on header which had to be slided in. Test: none Bug: none Change-Id: I7578b2809fda56b8f783875eef12f12ae6e57dd1 Reviewed-on: https://chromium-review.googlesource.com/c/1345536Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#610917}
-
Etienne Bergeron authored
see: https://cs.chromium.org/chromium/src/base/metrics/user_metrics.cc?l=33 TRACE_EVENT_INSTANT1("ui", "UserEvent", TRACE_EVENT_SCOPE_GLOBAL, "action", action); R=oysteine@chromium.org Bug: 867931 Change-Id: I27b80317c4fccc1bb27958a5c3d0439fd6d760c6 Reviewed-on: https://chromium-review.googlesource.com/c/1350193Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610916}
-
Tarun Bansal authored
Simplify the browser tests by not checking for when the experiment is disabled. Also, add DCHECKs to the cc file to ensure that the navigation predictor mojo binding object is created only if the field trial is enabled. Change-Id: I24189c75994e73a1f30d1a7aecc6d7bdaf4e8857 Bug: 903945 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349873Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610915}
-
Ken Buchanan authored
This CL changes browser process asynchronous hit testing so that if the InputTargetClient returns a FrameSinkId for a RenderWidgetHostView that has no children, it stops doing any further asynchronous queries and accepts that as the current target. It does not take into account whether the point being hit test is over any of the descendant views, should any exist. Test: SitePerProcessHitTestBrowserTest.* Bug: 847604 Change-Id: Ic70a26c19a7e06cef86d2b5b0b91227589e14755 Reviewed-on: https://chromium-review.googlesource.com/c/1342771Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610914}
-
Micah Morton authored
This change causes the cros-disks mount operation to be called with the 'nosymfollow' mount option if the FsNosymfollow Chrome flag is enabled. R=stevenjb@chromium.org Bug: 867807 Change-Id: I394a8c536b77146a0f2fe15c5fafda985f9a44a4 Reviewed-on: https://chromium-review.googlesource.com/c/1344933Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Micah Morton <mortonm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610913}
-
Antonio Gomes authored
BUG=907517 Change-Id: I0d0d73d43ad7af5e2b3cf2091bc45fe782334347 Reviewed-on: https://chromium-review.googlesource.com/c/1349591Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610912}
-
Anastasia Helfinstein authored
Bug: 907179 Change-Id: I1f66d659690027191a5c2d0d21f09abb2f2d82d0 Reviewed-on: https://chromium-review.googlesource.com/c/1347575Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Weidong Guo authored
Bug: 907196 Change-Id: I760dc43fc5fd31aec1addc020190a568596b3109 Reviewed-on: https://chromium-review.googlesource.com/c/1344649Reviewed-by:
-
danakj authored
When a RenderWidget is frozen, its compositor is stopped. However when the main frame is being navigated, we want to start requesting mojo pipes for the gpu and display compositor immediately so that it can happen in parallel with the navigation loading. Previously, we just always did this when creating a RenderWidget, and left them active when freezing the RenderWidget. After 678f025f however, we don't, and this causes time-to-first-pixels regressions on navigation. So we add a WarmupCompositor() method to RenderWidget, and call this from RenderFrameImpl::CreateFrame() when it makes the provisional frame, and the WebFrameWidget, since we expect to make use of the main frame RenderWidget shortly. Then, if RenderFrameImpl::FrameDetached() occurs, due to the navigation failing, we will AbortWarmupCompositor() to drop the mojo pipes instead of holding onto them indefinitely. This recovers the loading regressions introduced, while also not allocating mojo channels for frozen RenderWidgets indefinitely. In order to do this reasonably, we drop the "callback" from the request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that it always returns something immediately. This way RenderWidget does not need to worry about having a task run to collect the new frame sink, and ordering with tasks from the compositor to collect it. R=piman@chromium.org Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0 Bug: 905191 Reviewed-on: https://chromium-review.googlesource.com/c/1341073 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610909}
-
Toni Barzic authored
The CL changes how SystemNotificationHelper initializes notification display service for (transient) system notification. Previously, the notification display service was created as a profile keyed service for the sign-in or system profile. On Chrome OS, we are trying to reduce usage of sign-in profile beyond sign-in screen (ideally, the profile would be shutdown once a user session starts). Having system notifications attached to the sign-in profile prevents this. Good news is that the profile in NotificationDisplayService is used mainly to map notifications to users/profiles. In this CL, NotificationDisplayService is updated to be able to work with null profile (at least for transient notifications), and uses null profile NotificationDisplayService to handle system notifications. The system notification display service ownership is moved to SystemNotificationHelper (it's created lazily, and shut down during browser process shutdown). In addition, this changes how NotificationPlatformBridgeChromeOs detects profile shutdown - instead of explicitly observing profile desctruction, the bridge is notified of NotificationDisplayService shutdown (which occurs during profile destruction) by a NotificationDisplayService instance. This way the platform bridge can clean up system notifications on null-profile, system notification display service shutdown. BUG=901768 Change-Id: I63969f58683a38a009fd0253418c522d58b68512 Reviewed-on: https://chromium-review.googlesource.com/c/1338759Reviewed-by:
-
Peter Kasting authored
There's no real reason not to run this test on iOS/Android, as they define an AcceleratedWidget type and the test works correctly when they're serialized appropriately. The correct struct traits are obvious, so I don't see any benefit to not defining them. Bug: none Change-Id: I58db88a774abb441bb3af8e7f458040214c5fd93 Reviewed-on: https://chromium-review.googlesource.com/c/1343562Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610907}
-
Nico Weber authored
Unused after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1347346 Also remove code that's been unused since that change related to .isolated files from compare_build_artifacts.py Bug: 899438,876915 Change-Id: Ie572c2a27924b72a2ffb86165afca37fcbd667d6 Reviewed-on: https://chromium-review.googlesource.com/c/1351378Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610906}
-
Morten Stenshorne authored
If someone has bothered to set a containing block size override, that should be chosen in favor of special-code for orthogonal writing modes, that reads out data from some ancestor layout object. LayoutNG sets an override when entering legacy layout roots, since we shouldn't be allowed to read out data from ancestor objects during layout when using LayoutNG. We also need to take care when the child establishes an orthogonal writing mode, in order to pick the correct dimension. Bug: 869882 Change-Id: I63997ebc10b77fba37527ed7a01ae406854d8f96 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1348055Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610905}
-
jdoerrie authored
This change adds UTM parameters for navigations to the Google Password Manager. The UTM campaign parameter depends on the dialog from where the navigation originated. Bug: 904821 Change-Id: I0f2e55f83b3ba81a49c960583996aa2fe5bd392f Reviewed-on: https://chromium-review.googlesource.com/c/1350973Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#610904}
-
Benjamin Shaya authored
Bug: 112417422 Test: cast_audio_backend_unittests Change-Id: Iaf52c3ca4c09ab8290e1ddb165ead94d7fb59f63 Reviewed-on: https://chromium-review.googlesource.com/c/1347690Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#610903}
-
Vlad Tsyrklevich authored
Refactor a trivially copyable (e.g. plain old data) object out of the current GuardedPageAllocator. This 'base state' object encapsulates just the information required by the crash handler. Because its construction/destruction is trivial, a base state object can be overwritten with out-of-process memory and destructed without concerns about undefined behavior or destructing complex objects with pointers from another process. The GuardedPageAllocator encapsulates all of the remaining data and allocation logic that does not to be reached by the crash handler. As such, it's been refactored into client/. Bug: 896019 Change-Id: I418411b914a61c592f8b585d55058aa5a705acfb Reviewed-on: https://chromium-review.googlesource.com/c/1339246 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610902}
-
Hiroshige Hayashizaki authored
The long virtual test name caused crbug.com/906964 due to path length limit exceeded. Bug: 880027, 906964 Change-Id: I63cf49387adecf2f9e729ee10b26ffd86971cf8d Reviewed-on: https://chromium-review.googlesource.com/c/1344579 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610901}
-
Ian Kilpatrick authored
This removes another 2xLayoutUnits on the NGConstraintSpace. This should have no behaviour change. Bug: 635619 Change-Id: I765139563ffc9b167fefffe16ed3674c1db5dbf9 Reviewed-on: https://chromium-review.googlesource.com/c/1340585 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610900}
-
Anastasia Helfinstein authored
With this change, Dictation stops listening when a new tab is opened, as well as in most cases where focus changes between two text fields on a page. I will follow up on why it does not stop when using my minimal example of two <input type='text'> tags (and nothing else). Bug: 866489 Change-Id: Ib0a60dcb3b5871173bceeab9675491c81e72414d Reviewed-on: https://chromium-review.googlesource.com/c/1347002Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#610899}
-
Lan Wei authored
Since we have implemented test_driver Actions API, we will replace chrome.gpuBenchmarking.pointerActionSequence with this Actions API in all the tests. This CL will just replace the web platform tests with mouse inputs. Bug: 893480 Change-Id: Ie4eb7f4b8aaf23b2664182c5b8e814c7113dcf9a Reviewed-on: https://chromium-review.googlesource.com/c/1296823 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610898}
-
Brian Salomon authored
This version of the API takes an alpha per quad rather than one alpha for the set. This will allow the image sets to span multiple shared_quad_states (this is future work). Bug: skia:8563 Change-Id: Idc2c46da9e6274414bfc510408c14c79aa5c37a2 Reviewed-on: https://chromium-review.googlesource.com/c/1345091Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#610897}
-
Paul Jensen authored
Building maven modules is no longer done in Chromium so this code is dead. Change-Id: I7828ce3ce1ed42ebd9c923c428385c97661c6621 Reviewed-on: https://chromium-review.googlesource.com/c/1351369Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610896}
-
Anastasia Helfinstein authored
NOTRY=true Bug: None Change-Id: Ie43aeaedeb728f9c1a191ed988922cedcc2cc238 Reviewed-on: https://chromium-review.googlesource.com/c/1347611Reviewed-by:
-
Jérôme Lebel authored
Unified consent bump is not relevant anymore. Removing UI, images, and strings. The Chrome flags will be removed by tangltom, when all the UI from other platform will be removed. Bug: 907786 Change-Id: I6cbc5b9ffcee3f10cbb1613c8578e6f4fc7c3e93 Reviewed-on: https://chromium-review.googlesource.com/c/1343100 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610894}
-
Chrome Cunningham authored
This reverts commit 79faeacd. Reason for revert: broke linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9171 Original change's description: > Add TestKeyboardControllerObserver for ash keyboard unit tests > > This also includes some cleanup of the BUILD.gn files. > > Currently TestKeyboardControllerObserver is only needed by > AshKeyboardControllerUnitTests, but will be required by any tests > affecting the keyboard with SingleProcessMash once enabled. > > Bug: 843332 > Change-Id: I3c321cfaefe55bb61bb11f2232f524714f6453f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1343524 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610881} TBR=stevenjb@chromium.org,sky@chromium.org Change-Id: Ib7827c5a036c84e4486cb4ce8c32fd94a9c8f14a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/c/1351453Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#610893}
-
Peng Huang authored
SkASSERT() will print message with fatal = false, we assign INFO level for it, so message will not reach the conosle. Fix the issue by increase the level to ERROR. Bug: None Change-Id: I7bc8608b7130c3936152583bea9b030b75350026 Reviewed-on: https://chromium-review.googlesource.com/c/1348630Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610892}
-
Dave Tapuska authored
Cursor advance IDL didn't match the C++ code for types. Make them match. BUG=879657 Change-Id: I5248e1e40aa35ef471e62d818eafe9c335d82b3f Reviewed-on: https://chromium-review.googlesource.com/c/1348866Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#610891}
-
Rohit Rao authored
This will allow the resources to be reused on iOS. BUG=903381 Change-Id: I3f026a8c38da99eab403eb54ab57ad9503f9ddd5 Reviewed-on: https://chromium-review.googlesource.com/c/1332409 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#610890}
-
Andrew Grieve authored
No need to zip up the generated source just to unzip it again :P Bug: 908479 Change-Id: Iac6982eb4b436a7e33c53b79f239fe2954fa4f11 Reviewed-on: https://chromium-review.googlesource.com/c/1349871 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610889}
-
sangwoo.ko authored
RenderWidgetHostVisibilityTracker should outlive OnTabStripModelChanged(). Bug: 907237 Change-Id: I784140523076ba2472a04b98b0840f0bd75ba50d Reviewed-on: https://chromium-review.googlesource.com/c/1345750Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Ehsan Karamad authored
This CL makes the following changes to the feature policy parsing code: 1- ParsedFeaturePolicyDeclaration holds a sorted vector of unique |origins|. 2- AllowList uses std::set instead of std::vector. 3- When parsing for list of origins, in case of matching all origins (*), the current set of origins is cleared. 4- When comparing ParsedFeaturePolicyDeclaration, if both declarations include '*' then the set of origins are not compared. The noticeable outcome of the CL is that parsed policy will ignore repeated origins and will be sorted. This would make the feature lookup algorithm more efficient. Bug: 710324 Change-Id: I5c67ee2d6cff891304781bea0998e07739006a2e Reviewed-on: https://chromium-review.googlesource.com/c/1161753Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#610887}
-
Mike Reed authored
follow-on to CL 1343038 Bug: skia:2664 Change-Id: I5ae5640b6c8b025ba531bec633b71484cf4249d1 Reviewed-on: https://chromium-review.googlesource.com/c/1351371 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#610886}
-
Henrik Grunell authored
Bug: 830624, 826664 Change-Id: I28610bc94481ae2c3d843cbba1f2b61c9397cac5 Reviewed-on: https://chromium-review.googlesource.com/c/1350911Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610885}
-
Sam Maier authored
Testing done using is_java_debug=false, on patchset #6: - Ran Monochrome.apks with just the base module, went to a few webpages - Ran ChromeModernPublic.apks with base module only, few webpages - Ran Monochrome.apks with base and ar modules, opened AR and it worked - Ran ChromeModernPublic.apks with base and ar modules, ran VR fine - Unzipped the .aab files, compared the dex files to current master: * base/classes.dex files were byte-for-byte identical for both Monochrome and ChromeModernPublic * ar/classes.dex file in Monochrome was a bit smaller. In total, we went from 170->119 methods, 88->70 types, 27->21 fields, 260->213 strings * vr/classes.dex file in ChromeModernPublic was a bit smaller. We went from 1088->1030 methods, 330->316 types, 277->270 fields, 987->951 strings Since the base/classes.dex files were identical, and the vr and ar modules worked, I have good confidence that this is functional. Bug: 883162 Change-Id: Id1100193a0787c38680a63fe3b5f85a1c10ef926 Reviewed-on: https://chromium-review.googlesource.com/c/1327571 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610884}
-
Sky Malice authored
Bug: 901414 Change-Id: I7e20f3ed819d61e207d4072486bfbd0022a50b7a Reviewed-on: https://chromium-review.googlesource.com/c/1345422Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#610883}
-
Jeremy Roman authored
Inferring from the V8 context is very non-local and can easily break if this doesn't occur within an inbound V8 call. Explicitly plumbing the correct frame is preferred. Bug: 832862 Change-Id: Ie3ab0602ca1cb75201c9663b13adfd6a3152a901 Reviewed-on: https://chromium-review.googlesource.com/c/1347435Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610882}
-
