- 08 Nov, 2018 40 commits
-
-
Sahel Sharify authored
This cl resolves the regression that is caused by the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1313270 The previous cl calls UnregisterFlingSchedulerObserver() twice when a fling gets cancelled: once from gesture_event_queue while handling the generated GSE and once from FlingScheduler::DidStopFlingingOnBrowser. When there is only one active fling and the fling is not interrupted by another scroll/fling this works fine since the second Unregister call does nothing. However sometimes when a new fling replaces an active fling (e.g. starting a fling in the opposite direction of the currently active fling) the second Unregister call unregisters the observer that is added for the new fling. Since the observer is unregistered for the new fling no ProgressFling will get called till the user does a third fling. on the first ProgressFling call for the third fling, the controller tries to cancel the second fling and calls unregister which unregisters the observer for the third fling and the same thing happens for the rest of the flings from now on. This cl fixes the issue by not calling UnregisterFlingSchedulerObserver() in FlingScheduler::DidStopFlingingOnBrowser since it will get called once the generated GSE of the fling cancel is processed. Bug: 901831 Change-Id: I4d52f512ea38764fc64c580f6cac5ed4a32c1bee Reviewed-on: https://chromium-review.googlesource.com/c/1327145Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606606}
-
Thoren Paulson authored
The Android implementation of the CMA backend depends on APIs added in Android N. This change uses the default Android AudioManager on earlier versions. Bug: internal b/117838318 Test: audio with GPMusic and Spotify, video with Hulu & GPMovies. Change-Id: Ic59c37e103e098638c861efd8b350c29c028e64d Reviewed-on: https://chromium-review.googlesource.com/c/1327226Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#606605}
-
Pedro Amaral authored
This is the bottom toolbar refactor to allow for 5 buttons in browsing mode and moving the tab switcher toolbar to the bottom. This CL breaks the old bottom toolbar MVC component into 2 components: BrowsingModeBottomToolbar and TabSwitcherBottomToolbar. Those components have a common root coordinator called BottomToolbarCoordinator. I've also added two new providers. The first is the TabCountProvider. It notifies its listeners when the tab count changes. This is useful for the tab switcher button and the HTS tab layout icon. The other provider is the IncognitoStateProvider. It notifies its listeners when incognito mode is entered or exited. It also provides the tint and color for that state. Bug: 900759 Change-Id: Idced9f29ff4e5f3b0c6516b761416f32af78efe3 Binary-Size: Overhead from MVC Change-Id: Idced9f29ff4e5f3b0c6516b761416f32af78efe3 Reviewed-on: https://chromium-review.googlesource.com/c/1292405 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#606604}
-
David Jean authored
Bug: 845472 Change-Id: Id8d909eb12468774b52b74e0684b6ab1e72ad1f2 Reviewed-on: https://chromium-review.googlesource.com/c/1318975 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606603}
-
Juan Antonio Navarro Pérez authored
This reverts commit b1c0b554. Reason for revert: Stories show work now after fix of underlying issue. Original change's description: > [tools/perf] Disable browse:chrome:* stories > > These stories ara failing with an unhandleable error, preventing the > rest of the benchmark to run. > > Disable these as a short term quick fix. > > NOTRY=true > TBR=nednguyen@google.com > > Bug: 900909 > Change-Id: I8e51ced1644853469ff8310de03cb232abba9253 > Reviewed-on: https://chromium-review.googlesource.com/c/1311924 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604564} TBR=perezju@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 900909 Change-Id: Ia698d28b432cc0606e0bb157124c2dd39ca3eff0 Reviewed-on: https://chromium-review.googlesource.com/c/1327561Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#606602}
-
Siddhartha authored
Change-Id: I354d0cb1ba08877e3ec921faa8439f8219eec8c2 Reviewed-on: https://chromium-review.googlesource.com/c/1325530 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#606601}
-
Andrew Luo authored
Bug: 896857 Change-Id: Icfaf7503e60c476e434504971f832a65a3956235 Reviewed-on: https://chromium-review.googlesource.com/c/1321957 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606600}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7808cc796ef1..c66fe1a8930c $ git log 7808cc796..c66fe1a89 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 jianj Add operator<< to hadamard test. 2018-11-07 yaowu Simplify rdmult computation 2018-11-07 marpan vp9-screen-content: Adjust condition for large search area 2018-11-07 jingning Cosmetic clean up in find_arf_order 2018-11-06 jingning Unify GOP structure layout setup 2018-08-28 jianj vp9: postencode drop frame for screen content in CBR. 2018-11-05 marpan vp9 screen-content: Adjustments for screen content. 2018-11-01 sdeng Refactor Hadamard tests and add highbd tests 2018-10-26 paulwilkins Modified key frame detection. 2018-11-05 jianj vp8 dec: only compute ref frame buffer pointer for non intra 2018-11-05 jingning Track maximum layer depth in a GOP 2018-11-05 jingning Fix gf_group->frame_end assignment 2018-11-05 jingning Refactor define_gf_group_structure() 2018-11-05 jingning Remove redundant assignments in define_gf_group_structure() 2018-11-05 jingning Refactor find_arf_order() 2018-11-05 marpan vp8: Increase rate correction threshold for drop-overshoot 2018-10-31 johann.koenig vp8: remove VP8_ENTROPY_STATS code Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com BUG=b/118866248,b/112990050 Change-Id: I06b1b60c39fbdd0f2ed16713dae91a02969e918c Reviewed-on: https://chromium-review.googlesource.com/c/1327405Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#606599}
-
Tatiana Buldina authored
related CL: https://chromium-review.googlesource.com/c/chromium/deps/webdriver/+/1287025 Change-Id: I7e18664b01de7ed627eecec4f7cedac0eeb39079 Reviewed-on: https://chromium-review.googlesource.com/c/1287186Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#606598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/148454cafef1..ca7f9d6defef Created with: gclient setdep -r src-internal@ca7f9d6defef The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I412f20bbf85a9cecba73ad668b7b15b367c4934e Reviewed-on: https://chromium-review.googlesource.com/c/1327344Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606597}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/85be49ec0bc2..2d061b16ea6c git log 85be49ec0bc2..2d061b16ea6c --date=short --no-merges --format='%ad %ae %s' 2018-11-08 hjd@google.com Merge "perfetto_cmd: Fix log when streaming to file" Created with: gclient setdep -r src/third_party/perfetto@2d061b16ea6c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib77e252f062808ba36f3741f41bbb626e67af4a3 Reviewed-on: https://chromium-review.googlesource.com/c/1327341Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606596}
-
Mohamed Amir Yosef authored
Bug: 902349 Change-Id: I565b746737cc1567cf75abf4924c77eb648c3b46 Reviewed-on: https://chromium-review.googlesource.com/c/1322869Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606595}
-
Shawn Gallea authored
Remove pointer.h include and replace with wm_helper.h include. pointer.h is not needed, but wm_helper is needed as it was transitively included through pointer.h. Bug: 896710 Test: Built on ChromeOS Change-Id: Ic3dea290b4662cc5d868e7568c4909257dd55122 Reviewed-on: https://chromium-review.googlesource.com/c/1324749Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#606594}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e5e0aea5a404..625c7d270c1b git log e5e0aea5a404..625c7d270c1b --date=short --no-merges --format='%ad %ae %s' 2018-11-08 thestig@chromium.org Clean up CPDF_TransferFunc. Created with: gclient setdep -r src/third_party/pdfium@625c7d270c1b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7de81829e0e267160d20bde30c0f665100bd11a3 Reviewed-on: https://chromium-review.googlesource.com/c/1327342Reviewed-by:
-
Dmitry Gozman authored
Bug: 775132 Change-Id: I7f7f58f56e437895afd91002e2316c4ef40c92ce Reviewed-on: https://chromium-review.googlesource.com/c/1324455 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606592}
-
Mitsuru Oshima authored
Because the mask layer may be used by a detached layer, and re-using before the detached layer is deleted can lead to a crash. Bug: b/118822974 Test: manual. See bug for repro step. Change-Id: I82379d6f10f7b00fba8b581e667198f28f82f645 Reviewed-on: https://chromium-review.googlesource.com/c/1325565 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606591}
-
Fady Samuel authored
viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an allocation time for that viz::LocalSurfaceId. The purpose of this allocation time is to determine how long it takes for a surface to get embedded once an ID has been allocated for it. There was some concern raised about drift between LocalSurfaceIds and allocation times and so a previous CL bundled the two together in a class. This CL plumbs LocalSurfaceIdAllocation to more places to ensure the two quantities remain in sync with one another. This CL plumbs LocalSurfaceIdAllocation through FrameVisualProperties which ensures we plumb valid timestamps from a parent renderer to the browser and ultimately to child renderers. Bug: 655231 Change-Id: I1cb7e3e3acacc4fc5398d65f6f62892a2127346d Reviewed-on: https://chromium-review.googlesource.com/c/1324097Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606590}
-
sczs authored
Before this CL Infobar.cc was informing InfobarContainer of an InfobarView resize. Also, the InfobarView was being set by Infobar.cc it now sets its own height. This CL: - Adds functionality so InfobarContainer resizing is driven by UiKit. - Deletes InfobarViewSizing and InfobarViewSizingDelegate. - Removes the plumbing from InfobarView that informs Infobar.cc of a resize. - Removes InfobarIOS and InfobarController methods that were used to resize the InfobarView. Bug: 892376 Change-Id: Iaae3c0ec36ce226fc89fb405cb3d9c40376d3a79 Reviewed-on: https://chromium-review.googlesource.com/c/1321849 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#606589}
-
Tomas Popela authored
Previously we were using va_list for variadic arguments. The downside for this was that only the first value from the variadic argument was passed to the original function. To make it work properly we have to use the __VA_ARGS__ variadic macro that was introduces in C99 and is available in all major C/C++ compilers. Change-Id: I50652f7348a16214811aaab8af116d78cdb70444 Reviewed-on: https://chromium-review.googlesource.com/c/1323089Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#606588}
-
Ivan Šandrk authored
This was a mistake on my part when writing the original file, and it was just too bothering to see the wrong year on the file and get confused by it, so I had to update it :-) Change-Id: Ia59fd264f11bda490448a386528b9b2fc0606473 Reviewed-on: https://chromium-review.googlesource.com/c/1326641Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606587}
-
Dirk Pranke authored
The //chrome:chrome group was missing a data_deps declaration on //chrome:reorder_imports, which meant that chrome would build fine but if you ran `mb zip //out/Release //chrome` you'd only get the copy in //out/Release/initialexe/chrome.exe and not the final version in //out/Release. Bug: 902010 Change-Id: I0f3b662ced4c34eef974e8bede01fb9c89410dc1 Reviewed-on: https://chromium-review.googlesource.com/c/1325554Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606586}
-
Weidong Guo authored
Changes: Update the selected page to be the target page of dragged item at the end of dragging. Bug: 893832 Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df Reviewed-on: https://chromium-review.googlesource.com/c/1324851 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Add testing for the ratio metrics and fix bugs that were detected. Rename the ratio metrics to be specific to MainFrame to prepare for future ratios. R=pdr@chromium.org BUG=892861 Change-Id: I01ad5d059d423366e118335ff9288e7eb2cdb339 Reviewed-on: https://chromium-review.googlesource.com/c/1320692Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#606584}
-
Eric Roman authored
Instead use operator== and operator=. Change-Id: Ia2f694e75f3a5f22338d97ec7c4ce61e1a500996 Reviewed-on: https://chromium-review.googlesource.com/c/1324133 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606583}
-
Mike Frysinger authored
The usage docs were in the wrong docstring. Bug: 747171 Change-Id: Ia08331f8c41f86ce41c795ff1494e258c0d33bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1323807Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#606582}
-
Stephen Chenney authored
In preparation for a series of patches that change the arguments to UpdateAllLifecyclePhases, create a local helper in tests that do not derive from PageTest so that only one call site needs to be changed. There is no change in functionality at all. Tests writers no need to be less concerned about the arguments to lifecycle updates. R=pdr@chromium.org Bug: 902436 Change-Id: Icee20e327aa5d88ecdc38852d41d1b9bda4e2454 Reviewed-on: https://chromium-review.googlesource.com/c/1324230 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#606581}
-
Ehsan Chiniforooshan authored
Bug: 903204 Change-Id: I7d2cbff9184eb9f0fa93bfe14708ca719f145e7a Reviewed-on: https://chromium-review.googlesource.com/c/1327150Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606580}
-
Dale Curtis authored
BUG=webrtc:9530 TEST=cq R=sergeyu Change-Id: I7c007d4dfd12aa86a56fccaef176d614531533c2 Reviewed-on: https://chromium-review.googlesource.com/c/1327151Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606579}
-
Donn Denman authored
Fixes a bug in the existing Ranker code: the native logger cannot log 64-bit values, so we rename some misleading methods. Also fix some references to @Nullable. BUG=872902 Change-Id: I496c8140293200d7f8041fba1a5ede8fac26646a Reviewed-on: https://chromium-review.googlesource.com/c/1321670Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606578}
-
James Cook authored
Ash will end up maximizing the windows when they are added to the lock screen container. Creating the widget maximized avoids some back-and-forth with the window manager under mash. It also simplifies testing. Bug: 899055 Test: browser_tests Change-Id: I168ba67c1cc7c680cd0c9a4b4a1b22c3c40bd500 Reviewed-on: https://chromium-review.googlesource.com/c/1316438 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#606577}
-
Camillo Bruni authored
Bug: 878390 Change-Id: Ib536680adcbba24e86452ae16502c133eef01ddc Reviewed-on: https://chromium-review.googlesource.com/c/1256776Reviewed-by:
-
Stephen Chenney authored
WebFrameWidgetImpl was missing a call to record metrics, resulting in OOPIF not recording main frame metrics for their update. And the SingleThreadProxy was not recording metrics at all, which causes crashes with an upcoming patch. R=pdr@chromium.org BUG=902434 Change-Id: I96e4666d098ef22c2b5aec74851470319dd133f5 Reviewed-on: https://chromium-review.googlesource.com/c/1320691Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#606575}
-
Yiming Zhou authored
There are 15 different test scenario for password manager on each site. We therefore need to have subdirectories for different scenarios. This change adds support for 1 level of subdirectories in the password manager captured sites tests. Bug: 847905 Change-Id: If3b52088bf857f8fcb0b42a5abcbf33ba9382055 Reviewed-on: https://chromium-review.googlesource.com/c/1325309 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
-
Ella Ge authored
In crrev.com/588115 introduced capture mouse events to widget during text selection; and a later change crrev.com/599408 make subframe widgets capture mouse events on MouseDown, which follows the behavior without OOPIF. Since we are captureing mouse events on MouseDown and release the capture on MouseUp, we don't need to treat the text selection case special. Bug: 647378 Change-Id: I207777d16e11e069fb1ab60579d45324cb5b06c4 Reviewed-on: https://chromium-review.googlesource.com/c/1308606Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#606573}
-
Gordana Cmiljanovic authored
BUG= Change-Id: I621c411f767d2f1442bc45db78f3562101700c27 Reviewed-on: https://chromium-review.googlesource.com/c/1322870Reviewed-by:
-
Michael Ludwig authored
Bug: 903289 Change-Id: Ibc84f1083d0cb121435418fcda226b16917d1b87 Reviewed-on: https://chromium-review.googlesource.com/c/1327223 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#606571}
-
Eric Seckler authored
This is a reland of 2fc9f6f2 The crashes in flakiness were due to calling destroy() on the wrong thread, which has been addressed in the new patch set. Original change's description: > tracing: Address TracingControllerAndroid test failures. > > Fixes the flakiness of buffer usage / known categories tests by > resolving an accidental race condition. Also restricts disabling > the other two tests to <= kitkat devices since those seem to be > the only ones that show (inexplicable) flakiness. > > TBR=yfriedman@chromium.org > > Bug: 899894 > Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1307433 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604209} Bug: 899894 Change-Id: I3cb002950f32bc6b6b4d25892adc3073c2fdb967 Reviewed-on: https://chromium-review.googlesource.com/c/1327407Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#606570}
-
Scott Graham authored
Bug: 883496 Change-Id: Ib611c2d195b401475bb343099c8b12a644e942a7 Reviewed-on: https://chromium-review.googlesource.com/c/1324095 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606569}
-
Nick Harper authored
Bug: 875053 Change-Id: I3d798801537d6ede56d2f7acd8c26982e7291313 Reviewed-on: https://chromium-review.googlesource.com/c/1325568 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#606568}
-
Scott Violet authored
This test enables tablet mode, but it enables tablet mode in such a way that MultiUserWindowManager doesn't see (and process) the change. When the test is updated to correctly notify MultiUserWindowManager the test then fails. I think this may indicate a regression from recent changes and needs to be investigated. I came across this while doing some refactoring to MultiUserWindowManager. I've updated the test to ensure MultiUserWindowManager is called correctly and disabled it. BUG=756085,903427 TEST=none Change-Id: I7b6ead448ba8d942516e42d9ef5ee745a547cc2c Reviewed-on: https://chromium-review.googlesource.com/c/1327159Reviewed-by:
-
