- 11 Jul, 2019 40 commits
-
-
Mike Frysinger authored
Migrate all print statements to functions, and have all modules import the print_function future even if they aren't using print directly. This will help keep bad print statements from slipping back in. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I818d2b69c1280ad0f0f7ef02acea8a68444920d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698162 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676480}
-
Yao Xiao authored
Tested by expanding the existing service_worker_network_isolation_key_browsertest.cc and rename it to worker_network_isolation_key_browsertest.cc. Bug: 955476 Change-Id: I8d9dcca983049a870d33175550fbef958ef4054e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692968 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676479}
-
Mohammad Refaat authored
Extend them till 2020-07-01 Bug: 975840, 975669, 975532, 975084 Change-Id: Id3172dec81c0f5d47c8f31ffe118f51148b1e3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695999Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#676478}
-
Jun Cai authored
Per comment at: https://chromium-review.googlesource.com/c/chromium/src/+/1682870 This CL creates a subdirectory device_dialog under: //chrome/android/java/src/org/chromium/chrome/browser/ //chrome/android/javatests/src/org/chromium/chrome/browser/ //chrome/browser/ui/android/ and moves device api related files into this subdirectory. This CL also adds OWNERS files for these subdirectory. Bug: None Change-Id: Id109e016b35876511ae2f211993b463a19ce8138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696454Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#676477}
-
Daniel Rubery authored
For PhishGuard pings, we care about the originator of the currently visible content, not the URL of a pending navigation. Change-Id: I850782f31c0f5a604aeabc19cf21f26fd53bb98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696386Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#676476}
-
Friedrich Horschig authored
For now, we always want to fill the entire name into a name field. This CL therefore replaces uses of the three separated name fields with the FULL_NAME field for addresses. Small fixes: * The empty state tests don't need to wait for suggestions. * The margin of fields should be at the end so they remain left-aligned. Bug: 962548, 965494 Change-Id: I09016638b31c3d8443dcc8d6c4adc4a170e9a80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697190Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Doug Arnett authored
This will allow Dev and Canary channel users the ability to try out the new intervention. Bug: 965277 Change-Id: I7c9db7f469f0d82881118777a2f57c2d9e825ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696351 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676474}
-
Kevin Bailey authored
Enabled by flipping feature, so we can disable it. Also tweaked a test which relied on old behavior. Bug: 118094 Change-Id: I680fb072d5c6a16a006a0e9144a6b7db6035c267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695888 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676473}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ca160215c9d1..741b96b175cb git log ca160215c9d1..741b96b175cb --date=short --no-merges --format='%ad %ae %s' 2019-07-11 sprang@webrtc.org Pass RtpRtcp::Configuration to RtcpReceiver ctor and initialize ssrcs 2019-07-11 sprang@webrtc.org Optimize PacketRouter/RTPSender interactions. 2019-07-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fff68b41..8bdf10df (675999:676126) 2019-07-10 sukhanov@webrtc.org Move datagram_dtls_adaptor from p2p/base/ to pc/ 2019-07-10 mbonadei@webrtc.org Add wrapper to normalize flags. 2019-07-10 titovartem@google.com Use 16000Hz audio in PC test when specified 2019-07-10 sukhanov@webrtc.org Implements method on RtpPacket to extract extension. 2019-07-10 kuddai@google.com Make force_fieldtrials persistent string during entire program live. 2019-07-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 34d38f69..fff68b41 (675873:675999) 2019-07-10 titovartem@google.com Reland "Fix collection of audio metrics from PC test framework for audio test" Created with: gclient setdep -r src/third_party/webrtc@741b96b175cb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0fd8848395c08edef6240a384b20b9ed79fad54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697237Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676472}
-
Brandon Wylie authored
This change displays the google g in the omnibox (unfocused + focused). There is some tint jank when transitioning from the search loupe which will be fixed by a follow-up CL. Bug: 973153 Change-Id: I53940ee67bac3065b18505822a784e22bbb900be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653842 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
Drag interface has changed. Fixing compile error. BUG=None TEST=Compiled cast_shell Change-Id: I52f96f8f355a7cb80deb73ea8145111948c47144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697308Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#676470}
-
Edvard Thörnros authored
The monolithic SMILTimeContainer->UpdateAnimations() method has been split into two methods, one for calculating the values and one for calculating the progress of the animation. This will later lead to more refactoring and is the first step. Bug: 641437 Change-Id: I93bb6f9cb514f899537e8aca4c8574839e48be7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697191 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#676469}
-
Tatiana Buldina authored
These commands are not standard, and were never fully implemented in Chrome. Change-Id: I018d1ecf292ffb16f360c0ba7636e16a7425c913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695622Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#676468}
-
Daniele Castagna authored
viz::BufferQueue currently implements partial swap reading back from the previously swapped buffer contents that are outside the current swapbuffer damage. This introduces a dependency on a GPU API, that we want to get rid of (crbug.com/958670). This technique also assumes it is safe to read back from a buffer that is used from another driver (crbug.com/457511). This CL removes the readback and solves the same problem exposing a rectangle that the compositor needs to redraw to make sure contents damaged during all the swapbuffers before the current one are recomposited. Bug: 958670, 457511 Test: BufferQueueTest.PartialSwapCurrentBufferDamage Change-Id: I2d4a70b0122f665b68e25e043d57de6044092fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685909Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#676467}
-
Robert Liao authored
BUG=979530 Change-Id: I7d1a987b5d9f15bf285f730ec0269c3765f227bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696188Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676466}
-
Martin Robinson authored
When we get a reference to an AtkObject child, we need to unref it. Bug: 961029 Change-Id: I6fbd4b81daf2af048ca2a0443955a5af2a77745d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697645Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#676465}
-
Lei Zhang authored
Forward declare some classes and move bits not needed into the header into shadow.cc. Change-Id: I1b54966a2e1619be64951a58e6ac6ca0a8b705ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696387 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#676464}
-
Tomasz Wiszkowski authored
While this is currently unused, it will be bound in one of the upcoming changes The key makes sense to be used in RTL layouts where refine icon is located on the left hand side of the suggestion list, but users currently press right arrow key to select it. Change-Id: I0f47961a72b1e20691faaaa4c4959d5ad93ced73 Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8#heading=h.6a92f2gfl9le Bug: 982818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695992 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
Dave Tapuska authored
C++17 produces a build error if noexcept doesn't appear on the impl but on the declaration. BUG=752720 Change-Id: I8d11d08a847d2f680b2b52c66717b2e4cb5e16dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692866Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676462}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/28ae0a4b2810..f3dce1123b38 git log 28ae0a4b2810..f3dce1123b38 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 sugoi@google.com Fix for rendering being too dark Created with: gclient setdep -r src/third_party/swiftshader@f3dce1123b38 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I50ca9a41af5ebab2a5686bf768b9532e60ae281f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697234Reviewed-by:
-
Natalie Chouinard authored
Migrate the Contextual Search / "Tap to Search" Settings page from the deprecated Framework preferences to the preferences Support Library. Bug: 968592 Change-Id: I15e82216be6aef3c716b91477606c7782ec494ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695967Reviewed-by:
-
Sylvain Defresne authored
As suggested in https://crrev.com/c/1690965, rename methods from the OAuth2TokenServiceDelegate to reflect the name of the public API that is exposed through DevieAccountsSynchronizer. As suggested in https://crrev.com/c/1667346, remove the account_id parameter from OAuth2TokenServiceDelegate::ReloadAccountsFromSystem by declaring different methods on iOS and Android. Bug: none Change-Id: Ibf8c9bce07a61504fbaf00d9268f60f1a1d52e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697648 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#676459}
-
Tomasz Wiszkowski authored
This change resolves a NPE happening during deferred startup on slower devices. It looks like these devices do not have AutocompleteCoordinator ready in time to invoke the call to prefetch ZPS suggestions. The downside of this change is that in these cases prefetch would not happen, but there is a possibility we do not need to trigger it either; the prefetch is executed currently whenever user accesses a new tab page, too. Bug: 982343 Change-Id: Ida84fedcb8f0f057c95979d8571cb9033f2884c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693337 Commit-Queue: Ender <ender@google.com> Reviewed-by:
-
Xianzhu Wang authored
Bug: 981647 Change-Id: If34b775d7bd4b4ea261c9771a537d866d671ac41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693397Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676457}
-
Michael Ludwig authored
Bug: 981879, 982289 Change-Id: Ib2424bb8c149721f3380f9ff71dbcf078d0dace3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689335 Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#676456}
-
Wenjie Shi authored
Windows.Devices.Sensors WinRT API in Chromium As the first step for implementing usage of the Windows.Devices.Sensors WinRT API in Chromium, this CL: - Introduces a feature flag (disabled by default) to switch between the already existing ISensor API and the new Windows.Devices.Sensors API implementation. - Adds a skeleton PlatformSensorProviderWinrt. Verified by: 1. Built Chromium and installed the private build. 2. Verified ambient light sensor could be instantiated when the flag was in default state. 3. Verified ambient light sensor could not be instantiated when flag was set to Enabled. The new unit test was run as well. Bug: 958266 Change-Id: I3be7fa46c7d00d87d40fc0ea9074c88a42122512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685853 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by: -
Lei Zhang authored
Currently, pdf/draw_utils.* only contains code to draw shadows. Move this code into pdf/draw_utils/, so there is a directory for more drawing utility code in upcoming CLs. Change-Id: I869835ee82fca67622623b92c26e6af23b234741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696441Reviewed-by:
-
Xiaocheng Hu authored
According to spec (*), we shouldn't perform range checking for math function at parse time. This patch stops such checking on SVG lengths. This also eliminates an improper call of CSSMathFunctionValue::DoubleValue(), so that we can put runtime unit type checking in there. (*) https://drafts.csswg.org/css-values-4/#calc-range Bug: 979895, 982425 Change-Id: Id7abfcda611c23216127818e7e2473b065116fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693132 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#676453}
-
Xiaocheng Hu authored
When a calc() length is passed to media queries, the current code assumes that there's always a DoubleValue(), and the unit type matches TypeWithCalcResolved(), which is incorrect. This patch partially fixes the issue when the calc expression can be resolved without type conversion. Handling type conversion is more complicated and hence left broken by this patch (as it's already broken). Bug: 982542 Change-Id: I258b3d1aeec69fb65fbadd86981e97974239289b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696191Reviewed-by:
-
chrome://webapksckitagawa authored
Add support for a manual WebAPK update flow. This is a *dev* feature intended to help test changes to WebAPKs/manifests without waiting for a long time period. The buttons set a flag that schedules an update when next launching the WebAPK. Once scheduled, the update will occur sometime after the WebAPK is closed. This avoids the need for refactoring or modifying the update path and instead just requires plumbing a status message to the UI. Bug: 918898 Change-Id: I7eb3203f30de95f4918ae64489be9c72e24ce8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674164 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676451}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/620b7e9b012f..455c41a014c7 git log 620b7e9b012f..455c41a014c7 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 halcanary@google.com Sample/Camera: make it work without /skimages 2019-07-11 mtklein@google.com rename to bt709_luminance_or_luma_to_alpha 2019-07-11 jlavrova@google.com Fix for Windows specific compiler issues (constexpr). 2019-07-11 halcanary@google.com experimental/tools: set-change-id-hook 2019-07-11 robertphillips@google.com Alter approximate scratch texture binning after 1024 2019-07-11 scroggo@google.com Revert "Update Wuffs version" Created with: gclient setdep -r src/third_party/skia@455c41a014c7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@google.com Change-Id: I41c72abeb4098d6a560c1b7f738e03ef996529bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696993Reviewed-by:
-
Stephen Nusko authored
When we are tracing on android P and above we should be able to connect to the system tracing service and participate in the trace. Bug: 964324 Change-Id: I6fa212e0b01fcc11476598540704d050f33cd31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687266 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676449}
-
Tommy Steimel authored
This CL adds logic to disconnect TextTrackContainer's ResizeObserver when the container is removed from the document. This fixes an issue where video elements were leaked since the ResizeObserver was a root within the object graph. TESTED=Patched into M76 and it fixed the leak for StratosMedia Bug: 971193 Change-Id: Ie4c72ed34009a804d8f5d433c730ef146a9e42a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693027Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676448}
-
Marijn Kruisselbrink authored
Add a NativeFileSystemPermissionRequestManager class similar to the existing PermissionRequestManager class that queues and and combines multiple requests for the same permissions. Bug: 878585 Change-Id: Ice4f2c6f12a258b2f8210de2ee617487076175a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687563 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Tom McKee authored
We ran the SkipPassthroughTouchEventQueueFilter Finch experiment and pushed it out to 1% of the stable population across mobile and desktop. We've reviewed the data, paying particularly close attention to the Android results and are confident that we can adopt the 'skip filtering all events' behaviour by default. This will allow us to simplify (remove) the touch event filtering code from passthrough_touch_event_queue.cc as well as align our FID measurements to be closer to the user experience when there are no javascript touch event handlers on a page. This CL changes the corresponding base::Feature (SkipTouchEventFilter) to be enabled by default, effectively enabling the experiment for all users. This CL is planned to land in conjunction with a server-side config that will configure older clients to adopt behaviour similar to this new status-quo. That way, FID measurements will be more comparable across these versions, even for users who don't upgrade to new major versions. Bug: 914500 Change-Id: I8b5c1b20f02ecdcf8c1c76341c3adad86e5aa768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688353Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#676446}
-
Nektarios Paisios authored
Before every call to an accessibility API on the renderer, we were not checking if the layout tree is clean, but only if the LayoutView of the document object had a clean layout which is not the same thing. Change-Id: If8852842aaf4da06bbb8e65ba495b18c46f82b6a Bug: 133517108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601618Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#676445}
-
jonross authored
Some of the tests suites have had consistent flakes. Where at least one test fails, then passes. However the tests failing is not consistent. The errors also do not appear to be directly related to SkiaRenderer but are likely caused by timing changes. This adds a filter in order to not run those tests. TEST=skia_renderer_browser_tests Bug: 982933 Change-Id: I638b7a19bcf2b8b4369e100dec5131383fd0add9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696542Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#676444}
-
Fernando Serboncini authored
- this adds a new beforePrinting state to Document::Printing - if we are in beforePrinting, keep the Canvas recording and use it for printing - We only do this if rendering-mode is not pixelated Bug: 959357 Change-Id: If29b90b344b5af42cc3cbbed2f867d82841f2def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637656 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#676443}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6261553002bc8ec81226c8d2c1568d77d80b26b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696990Reviewed-by:
-
Ben Pastene authored
Looks pretty stable on the fyi bot: https://luci-milo.appspot.com/p/chromium/builders/ci/chromeos-kevin-rel-hw-tests And decreases shard count from 6 to 2 since the shards are pretty quick. Also remove the retry-limit args from telemetry_unittests. Not sure it's needed anymore. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel Bug: 938502 Change-Id: Ice81330589683772671f3133a4a607af8ff2bf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695760Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#676441}
-
