- 01 Sep, 2020 40 commits
-
-
Arnaud Mandy authored
Switch to loading *.mojom.js from /gen/ instead of resources/chromium in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Remove unused .mojom.js files from WPT. Bug: 1119858 Change-Id: I8c7226f4eca9f35ac88b3d02540aed31cf413ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385298 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#803394}
-
Minoru Chikamune authored
This reverts commit c7a29595. Reason for revert: We have finished to use this setting. Now the default mode of HeapMojoUseContextObserver is base::FEATURE_ENABLED_BY_DEFAULT. Original change's description: > Enable the HeapMojoUseContextObserver feature for waterfall testing > > To deprecate kWithoutContextObserver mode, we are going to enable > HeapMojoUseContextObserver feature for waterfall testing. By doing > this, we can detect crashes during the waterfall testing. > > Bug: 1049056 > Change-Id: I96e0be25ad6e6cc9eeac2fad600f1dadec02ecd6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Minoru Chikamune <chikamune@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784344} Bug: 1102041, 1049056 Change-Id: I23ec7ab38bc5bc7caaf965891e1b170e84770cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386857Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#803393}
-
James Vecore authored
Adds stub pages for high visibility and confirm to the receive dialog. Future CLs will flesh these out and wire up a mojo to communicate with the share service. Screenshots: http://screen/6QvnCB5NppKzGpC.png http://screen/32LmeXBLxmDvayD.png Bug: b:163148440, b:163147818 Change-Id: I68e248d54000ddd580ae8dc6a9ddc076b1ceddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384790 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803392}
-
Toby Huang authored
This CL adds an observer to FamilyUserMetricsService, which is intended to be the interface for all future Family User Metrics classes. Common functionality can be refactored into this interface. For example, many metrics require daily reporting, so this interface initially contains a virtual function that's called when a new day is detected. FamilyUserMetricsService will own all the metrics objects, and can manipulate them in a uniform way through the interface. This CL also adds logic to FamilyUserMetricsService for detecting date changes using a repeating timer. Bug: 1103081,1110557,1114849 Change-Id: I77c30e3e8bccb5f55b37a4b57db167daa2819160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359028 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803391}
-
Arnaud Mandy authored
switch to loading *.mojom.js from /gen/ instead ofresources/chromium in preparation for launching official MojoJS support in WPT. This would not change the test results on Chromium waterfall (everything should continue to pass) or upstream WPT (tests currently fail because MojoJS isn't enabled). Remove unused .mojom.js files from WPT. Bug: 1119858 Change-Id: Ifa1e07e47950b69c060880120f20bddb7556b90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385297 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
-
James Vecore authored
Adds a shared component to be used for all pages hosted in the receive dialog. This template just provides a common title, subTitle and utility/cancel/action buttons. The buttons fire events for the container element to receive. Final styling, a11y support will come in a follow up CL. Bug: b:163148440, b:163147818 Change-Id: Id52fd0eae2faa9e77e118acde3aace36f90c994e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384652 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1eb42f5ea752..d6c9e7955534 2020-09-01 jleconte@google.com Revert "Fix Bug ID layout on group report page." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: sadrul@google.com Change-Id: I452696de61f6b3e238c7b8086068173d1e1787b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803388}
-
Morten Stenshorne authored
We have code that compensates for the scroll offset on screen when printing, but this didn't work correctly in vertical writing modes. When printing, we set a rectangle for each page in logical coordinates, and then transpose it to physical coordinates if writing mode is vertical. The scroll offset, however, is already in physical coordinates, so we have to apply this after transposing. Pagination in vertical writing modes is very broken (crbug.com/881727), but before we can even get to that problem, we need to make sure that scrolling doesn't cause problems. Bug: 1123706, 881727 Change-Id: Ie0370bcd5c0856afe2e1ca8f85ecaa1ce752f92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386735Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803387}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/676387126d72..2d325ca00b9a 2020-09-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4592f136624649e8962de6f6548689342bb988ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387305Reviewed-by:
-
Alice Boxhall authored
This is a reland of b89144a4 AX-Relnotes: n/a Original change's description: > Add pixel test for AccessibilityFocusHighlight based on FocusRingBrowserTest > > AX-Relnotes: n/a > > Bug: 1114959 > Change-Id: Ib6d9f51a04fa8059dc6bd6192d182b8e0244367d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352451 > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803007} TBR=ellyjones@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Bug: 1114959 Change-Id: I747aee7e8c533c564ec279b05e5511f25c38f603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386935Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#803385}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I764284990aef6c674f22e4805eb0cbc88e860ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382754Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803384}
-
Yue Zhang authored
This reverts commit bfd26dd3. Reason for revert: Disable the failing test on x86 bot to land the actual logic first. Original change's description: > Revert "Don't show default undo bar for closure in TabGridDialog" > > This reverts commit e5b906d1. > > Reason for revert: > https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1134 > > Original change's description: > > Don't show default undo bar for closure in TabGridDialog > > > > This CL prevents default undo closure snack bar from showing when a > > closure happens within TabGridDialog. We use the visibility of > > TabGridDialog as a proxy to decide whether a closure happens in dialog. > > This is the step2 in https://docs.google.com/document/d/1OOlOVYtcFXE--8TMdcFAqAMqcsRyEsvJr0vzsNCR_F4/edit?usp=sharing. > > > > Bug: 1119899 > > Change-Id: Ibdfe53847af25921f32436d80a5868b97340a524 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369469 > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803203} > > TBR=yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > Change-Id: Ie98c1246828bc48c3569184c2565338d54f67629 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1119899 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386374 > Reviewed-by: Gang Wu <gangwu@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803348} TBR=yusufo@chromium.org,mdjones@chromium.org,gangwu@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1119899 Change-Id: Id7ceb4c63e7f044df10341cbc53b45192773dfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387302 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803383}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6522350f5c2..1a42d4b38183 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I7cb07a2842d285b058aa71e4bc7dab3c1157ae27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387301Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803382}
-
Kent Tamura authored
crrev.com/802523 seems to introduce a null pointer dereference in the function. According to the 5th |if|, |scrollable_area| can be nullptr. This CL has no tests. We don't know how to reproduce the crash. Bug: 1123327 Change-Id: Iec8a746f549d60890f3f050b72e4791ce7efe828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383595 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803381}
-
Wei Lee authored
This CL: 1. Add LaunchSystemWebApp() in autotest private API 2. Don't install platform app version of CCA if SWA version is used Bug: 980846 Test: Tested with related Tast CL and run "$tast run [DUT] camera.CCAUI*_swa" Change-Id: Ie66cc91bf5bfe574543f43f50b5a22dbb533bda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257086 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#803380}
-
rbpotter authored
Preprocess all shared JS module resources into: <root_gen_dir>/ui/webui/resources/webui_preprocessed and read all these resources from this directory when bundling with rollup. Bug: 1071641 Change-Id: Iaa88babb7aaa6f7235d2f23b24046c79798fad39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370090 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#803379}
-
Nektarios Paisios authored
Fixes Len and TextOffsetInContainer methods in AbstractInlineTextBox, and adds TextOffsetInFormattingContext in AXNodeObject In Legacy Layout we were not always computing the length of an abstract inline text box correctly. Sometimes, when there are two inline text boxes without a separating white space character in between them, we should artifitially add a space character to separate them. This also affected character bounds calculation. Similarly, our logic for returning an offset in collapsed text given a text offset in our static text parent, would sometimes return the wrong result. The wrong offset mapping was being retrieved when there were multiple overlapping offset ranges, such as: <div>an <span>example</span>.</div> Taking the inline text box inside the span and asking for the equivalent text offset in the span's static text node would return an offset in the div's node instead. A helper method, TextOffsetInFormattingContext, was added to aid with text offset calculations in the entire Blink code base. A formatting context is a Layout NG concept and it refers to the corresponding text offset starting from a node's deepest layout block flow ancestor, such as a span's enclosing paragraph. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ib82a0f4fd521cd3cde04cca8c1c1c26bb9a293a6 Bug: 1008031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289852Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#803378}
-
Darren Shen authored
This reverts commit f51b93d7. Reason for revert: Suspecting as cause of crbug.com/1123786. Original change's description: > [Cast MRP] Stop mirroring immediately when a the tab is closed. > > Bug: 1095764, b/159154368 > Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: John Williams <jrw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803343} TBR=miu@chromium.org,dominickn@chromium.org,jrw@chromium.org Change-Id: I3c8e562ee39e8cbf7ef5a5bb0312c9d51da7acc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095764 Bug: b/159154368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386439Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803377}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bba395ff. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I33160e412b63acb8f9a48772b7ef17a2dd552444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386759Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803376}
-
James Vecore authored
Adds an empty receive dialog stub that will host high visibility, confirmation and on-boarding pages within os-settings. The dialog does not set a title, sub-title or have buttons because a shared page component will handle these so they are consistent. This also allows page in and out animations to include the titles and buttons which would not be possible if the title and buttons were re-used between pages. Trigger Url: chrome://os-settings/multidevice/nearbyshare?receive Screenshot: http://screen/3jNcwoQgcQNtq4D.png See follow-up CLs for usage. Bug: b:163148440, b:163147818 Change-Id: I81fa2550ee7bd84cef851a31cc1a1b3fdc0affd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384542Reviewed-by:
-
Kuo-Hsin Yang authored
This is required to move the experiment to beta. BUG=b:151690175 TEST=presubmit passed Change-Id: I3e066526bc391d18f63632b888ff08a87659dab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383407Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803374}
-
Melissa Zhang authored
This CL adds metrics for the sharesheet. We record when a user makes an action and how many apps are showing in the sharesheet with each invocation. Bug: 1097623 Change-Id: I089524187db80aa31bff3ff2c11ac366da073f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379394 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#803373}
-
Andrew Grieve authored
And have upload_html_viewer.py check that caspian files exist Bug: None Change-Id: I9775e5c983cbb8d4a4aa4b74037eee88dffcee99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387400 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803372}
-
Gyuyoung Kim authored
As the first step to convert FrameHostMsg_SynchronizeVisualProperties to Mojo, this CL moves content::FrameVisualProperties to //third_party/blink/public/common. TBR=dtapuska@chromium.org Bug: 1093956 Change-Id: Ic2b337dd0e40bebf12c3b650fab56d3203445135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383594 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#803371}
-
Yuta Hijikata authored
This patch flips the default log format of chrome for chrome os to syslog format. For more detail go/cros-syslog-format-log-chrome. BUG: 1093033 TEST: base_unittests Change-Id: Ic5f40d1769439960c1d49799c1f201ce69110f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377669 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803370}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I42c87d7ed13b1a9a3ec11ae5bca50c8b0c0cc381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387344Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803369}
-
Kyle Horimoto authored
Fixed: 1123073 Change-Id: Ie822a54e391c87f622b8d92e55dfeb224046cf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386580 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803368}
-
David Black authored
Previously the `HoldingSpaceKeyedService` was constructed with a `BrowserContext` and internally converted to `Profile` as needed. Now, we'll take a `Profile` at construction time and avoid any downstream conversions. This CL also addresses a race condition that could occur when partitioning `HoldingSpaceItems` by existence. Previously, input order was not guaranteed to match output order. Now they will which should stabilize browsertests. Bug: 1119496 Change-Id: I8e213eeed8f4b4169bc033130fcdebf473c1fd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386383 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803367}
-
Kyle Horimoto authored
This code used oppressive language which needed to be removed, but it wasn't actually being used anyway, so I removed it. Bug: 1123072 Change-Id: I7034dfde159d317699988d4eeae417debb7c1fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387124 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Daniel Classon authored
Adds deep links to the Privacy Page. Splits the Privacy Page tests into AllBuilds and PrivacyPageTest_OfficialBuild in order to test deep linking to the collect crash reports setting. Bug: 1084154 Change-Id: I88cc0444260d951efd2972c5c8e825ef18c4b760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386424 Commit-Queue: Daniel Classon <dclasson@google.com> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: Ie6287c10e3a2e4ce2dc46f6a3d7d84b4df35f847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383591 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
-
Chris Blume authored
On Android, color gamut changes dynamically with the content being displayed. This is currently under a Finch flag at 50% canary/dev/beta and 1% stable. When not enabled, wide color content is not displayed in wide color. The Finch experiment has been successful. This CL enables the feature by default. R:khushalsagar@chromium.org Bug: 735658 Change-Id: I9eda388690e3d2fa37d597925c32e38afd7ffe11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370803Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#803363}
-
Daniel Classon authored
Adds deep links to the Date Time page and Time Zone subpage. Also adds a focus method to settings-radio-group to help with deep linking. Bug: 1084154 Change-Id: I53cfc17e386ce6799dff95a5d7afccfe7a847f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382960 Commit-Queue: Daniel Classon <dclasson@google.com> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Minggang Wang authored
Currently, the worker thread calls the Terminate() of the child threads during executing PrepareForShutdownOnWorkerThread(). This patch removes the explicit calling, because the nested workers are observers of the terminating worker's worker global scope, the child threads will get terminated when notified with ContextDestroyed(). Change-Id: I7b9fd424c5b954b31ff83b1027608e5e24c04bbd Bug: 1104847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377580Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#803361}
-
Xinghui Lu authored
This is a follow up CL for https://crrev.com/c/2359749. It is for pure refactoring. The plan for this two-sided patch is: 1) Add the new class under feedback/ and AppHooks method upstream with no reference. 2) Extend the new class downstream and add the new AppHooks method. 3) Update upstream references to point to the new AppHooks method. 4) Cleanup. This CL is for step 1). Step 2) will be done in https://crrev.com/i/3227761 once this CL is landed. Bug: 1117343 Change-Id: I312f3459360fa5e1b78f6e301b052a36bed2e9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364581Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803360}
-
Yulun Wu authored
This CL adds light mode for login shelf buttons, text, icons, and wallpaper. Bug: 1110757 Change-Id: I1057aa89bf777f3f35564d7876256f9381059e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363799Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803359}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7b69a44c8b1c..9e02f4716a1e 2020-08-31 deadbeef@webrtc.org Fix destruction order of PortAllocator and PacketSocketFactory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaff60306d3724cb402b96af01e9960a73d88d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386848Reviewed-by:
-
Gang Wu authored
This reverts commit 78a7ace4. Reason for revert: This CL make PhotoPickerDialogTest flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.components.browser_ui.photo_picker.PhotoPickerDialogTest%23* Original change's description: > Remove ApplicationStatus usage from PhotoPicker. > > ApplicationStatus only works in //chrome. See crbug.com/470582 > > Bug: 1110930 > Change-Id: I71a6a5701aa40434588830cfcc6dee8ff6f5143a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378633 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803247} TBR=finnur@chromium.org,dtrainor@chromium.org,estade@chromium.org Change-Id: I78eaf08ba277d516584ae75d38ce64909ba36bff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387196Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803357}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1e6f2940c25..59d28532a179 2020-08-31 jdarpinian@chromium.org Fix GL_EXT_texture_compression_s3tc_srgb on macOS 2020-08-31 m.maiya@samsung.com Vulkan: Optimize atomic counter buffer offset calculations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I48f674818122da58bb223f71a26ec51697c4ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386666Reviewed-by:
-
Devlin Cronin authored
InfoBarDelegate::infobar_ was uninitialized during construction - which is bad for delegates that try to access InfoBarDelegate::infobar(). Properly initialize it to nullptr. Bug: None Change-Id: I8f52e02fbca1486f7c60c8f2791cd7e8c464d5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387118 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803355}
-
