GitLab

The current behavior makes TransferEventsTo() before the window
move starts, but don't care at its end. This causes errors like
crbug.com/900363. But we can't simply transfer back to the original
window unconditionally since someone (like TabDragController) may
also want to continue dragging on a window other than the original
source window.

This CL introduces a new scoped class to control this; it makes
TransferEventsTo first, and then invokes TransferEventsTo back
again at the end, but it skips invoking the second transfer if
someone else also transfers the touch events on the same window.

BUG=900363
TEST=the new test case

Change-Id: I81792872a13f0e4bb2c88b526c92cf689d656b71
Reviewed-on: https://chromium-review.googlesource.com/c/1310501
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604473}

128 bits gone

Bug: 835484
Change-Id: I50045dc72b3037edca348c94eecf2d00acf037d6
Reviewed-on: https://chromium-review.googlesource.com/c/1311805Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604472}

The suggestion view no longer has direct references to any
of the backend suggestion data.

BUG=898522

Change-Id: Iacb03cff130d659c845e134f593f87b8416c16ae
Reviewed-on: https://chromium-review.googlesource.com/c/1306350Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604471}

https://pdfium.googlesource.com/pdfium.git/+log/22a617f93038..9d88af8f4ebe


git log 22a617f93038..9d88af8f4ebe --date=short --no-merges --format='%ad %ae %s'
2018-10-31 thestig@chromium.org Roll third_party/skia/ 7258e97e8..c994a93b3 (302 commits; 17 trivial rolls)


Created with:
  gclient setdep -r src/third_party/pdfium@9d88af8f4ebe

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If66f68f380076047cdf00c2fd4b224e1b1ce4e27
Reviewed-on: https://chromium-review.googlesource.com/c/1311674Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604470}

This is a pure refactoring change to make the code cleaner. There is no intended effects change.

Bug: 893618
Change-Id: I68d59e804c637da07cefac7fcdcdef3c70626227
Reviewed-on: https://chromium-review.googlesource.com/c/1311801Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#604469}

The official builds apparently doesn't print the error message from
CHECK failure, so delete the death test regexes. While we're at it,
switch from the ifdef to EXPECT_DEATH_IF_SUPPORTED.

TBR=dcheng@chromium.org

Bug: 900764
Change-Id: I61448b5fcb903b35a4cc01e0eb599ba35be1d402
Reviewed-on: https://chromium-review.googlesource.com/c/1311838Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Josh Gao <jmgao@google.com>
Cr-Commit-Position: refs/heads/master@{#604468}

Move:
  build/scripts/{ => core/css}/make_css_primitive_value_unit_trie.py
  build/scripts/{ => core/css}/templates/css_primitive_value_unit_trie.cc.tmpl

This CL has no behavior changes.

Bug: 732657
Change-Id: Iffd9b98f0eede7fc7349c89d26eb885de9953600
Reviewed-on: https://chromium-review.googlesource.com/c/1309377Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#604467}

Bug: 866926
Change-Id: I4811f8cafd4febc39955ea4c076b83fb7c0035a9
Reviewed-on: https://chromium-review.googlesource.com/c/1309094
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604466}

If 2 child dirs such as /a/a, and /a/b, are shared, then parent
/a is shared, we no longer register both children as being shared
and we only show the parent in settings page as being shared.
If the parent is subsequently unshared, then children will also be
unshared.

Bug: 878324
Change-Id: I1c85d75ad934d48cd353299943f7de893ca62017
Reviewed-on: https://chromium-review.googlesource.com/c/1306945Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604465}

Removes Widget::SetFocusTraversableParent* calls since we don't want
focus to escape bubble dialogs once they get here. There are several
bubbles that close once focus escapes.

We still set kAnchoredDialogKey of the anchor view to make sure that
focus can move into attached dialogs (this makes them keyboard
accessible).

Bug: chromium:899601, chromium:899996
Change-Id: Idc5d60c2f41ae20a343324ae75b0fd304f273c94
Reviewed-on: https://chromium-review.googlesource.com/c/1311090Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604464}

When active IME is changed in Android side, the event is sent to
OnActiveImeChanged().
ArcInputMethodManagerService should switch an active IME in Chrome OS
side according to the event.

Bug: 900756
Test: Ran on DUT.
Change-Id: Ia8002ec678775f6349020b90766423987a4f714b
Reviewed-on: https://chromium-review.googlesource.com/c/1311853
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604463}

BUG=900182
R=thakis
TBR=dschuff

Change-Id: I73402d71c1deb98564ec19d07d0e19e340bb6473
Reviewed-on: https://chromium-review.googlesource.com/c/1308097Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604462}

This reverts commit b93f1513.

Reason for revert: The outage is over, returning the bot to CQ.

Original change's description:
> [cq] EMERGENCY remove win10_chromium_x64_rel_ng from CQ
> 
> The builder is experiencing a massive failure due to a swarming error.
> Making it non-blocking for CQ while the fix is being worked on.
> 
> TBR=tandrii@chromium.org
> 
> Bug: 900742
> Change-Id: Ie6f95ec39062107b77fca6942992dbcb35557ec7
> Reviewed-on: https://chromium-review.googlesource.com/c/1311128
> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604384}

TBR=sergeyberezin@chromium.org,tandrii@chromium.org,bpastene@chromium.org

Change-Id: I56714ba00d32fbcc9c8d06d5d2dcf04b169b619f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900742
Reviewed-on: https://chromium-review.googlesource.com/c/1311811Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604461}

GPU raster caused slight differences around antialiased div edges.

TBR=kbr@chromium.org

Bug: 900599
Change-Id: I2531fb642c50df820c5f4947d8670818217141c9
Reviewed-on: https://chromium-review.googlesource.com/c/1311835
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604460}

Before this CL, it was difficult to handle IDLDictionaries with WTF containers
and to support partial dictionary[1].
And to support such use cases, we have non standard hacks for them.
e.g. HeapVector<IDLDictionary>

This CL makes IDLDictionaryBase inherited from GarbageCollected<>,
and hence we can remove strange restrictions and hacks, and it will be
easy to support partial dictionaries.

[1] https://heycam.github.io/webidl/#dfn-partial-dictionary


TBR=peter, mkwst

Bug: 714575, 579896
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia999589e5329cdf863d54ccb1bcea385f607fb62
Reviewed-on: https://chromium-review.googlesource.com/c/1226613
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604459}

https://google.github.io/styleguide/cppguide.html#Namespace_Names
> Namespace names are all lower-case.

This CL has no behavior changes.

Bug: 889726
Change-Id: I77ac4cf7c882d3d55e7f4f3e1c6a445c49bc108f
Reviewed-on: https://chromium-review.googlesource.com/c/1309895Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604458}

Includes moving the stretched size computation from legacy to FlexItem
so that NG can use it.

A big hack is that stretched items don't use the height of their parent
lines, they use the whole container height because we haven't
implemented line size calculation yet. This works for the majority of
cases.

About 6 tests newly fail. Some multi-line flex containers now fail
because of the above hack. But some tests with images that are flex
items fail because NG doesn't copy their data to legacy because there
are unplaced floats internal to the image (something related to alt
text). I haven't looked into why this used to work but fails now.

This patch nets roughly 110 layout test lines removed.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I0083e80797c1f01c8cc4c63ac696d68063f67ff2
Bug: 845235
Reviewed-on: https://chromium-review.googlesource.com/c/1285851Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604457}

Newly-added SharedMulticastAddress fails on Fuchsia, and the existing
JoinMulticastGroup test now fails due to a change in the parameters
passed to Listen() for non-Windows.

Bug: 900709
Change-Id: Ia98ec45897f88696e7eb872938822040ab5940c6
Reviewed-on: https://chromium-review.googlesource.com/c/1311662Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604456}

Bug: 886546
Change-Id: Ice466abf61544783407bac9601b23a01982c4055
Reviewed-on: https://chromium-review.googlesource.com/c/1309378Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604455}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/454cfea9e32c..28fd7569985c


Created with:
  gclient setdep -r src-internal@28fd7569985c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:891313,chromium:891734
TBR=mmoss@chromium.org

Change-Id: Ib6d640a1b75fbde186a44f606949125575bec101
Reviewed-on: https://chromium-review.googlesource.com/c/1311677Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604454}

Bug: None
Change-Id: Id54affe66c2ae4d31152461d32b2f97f39964579
Reviewed-on: https://chromium-review.googlesource.com/c/1310753Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604453}

This CL updates a DCHECK to allow for the BrowserNonClientFrameView
getting recreated when the browser window frame is updated via
NonClientView::UpdateFrame().

This also fixes a UI bug where we don't initialise the content setting
icons properly for PWA windows resulting in uninitialised state after
toggling GTK themes.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=365396&signed_aid=Z-gwLwzrT9I5krg3sUoY7Q==&inline=1
After (ignore Linux screen glitching): https://bugs.chromium.org/p/chromium/issues/attachment?aid=365397&signed_aid=e_kvzb_AGaLLi5zzKY_o7w==&inline=1


Bug: 878639
Change-Id: I57bd1a6f7f94687a0f95557914f34eda737129ee
Reviewed-on: https://chromium-review.googlesource.com/c/1308960Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604452}

Bug: None
Change-Id: I2918bedb89b3f8682d7fa5d5fdfabab06f6d56bb
Reviewed-on: https://chromium-review.googlesource.com/c/1311873
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604451}

Previously, each the following was treated the same:
  Content-Length: 7
  Content-Length: ,7
  Content-Length: 7,
  Content-Length: , ,7, ,

And all condensed into a single header with a value of 7. There's
nothing in any spec that instructs us to do this. Moreover, the spec
explicitly states that the two lines:

  Content-Length: 7
  Content-Length:

Can be safely merged into:

  Content-Length: 7,

Without changing meaning, but in the former case, Chrome treats two
headers lines as if they were separate header lines, while in the
latter, as mentioned, it ignores the existence of the comma. Also,
the original header line could never be retrieved in this case,
since the extra information was just silently purged.

This CL treats both responses as having two separate Content-Length
headers (And this applies to all other non-coalescing headers as
well).  This behavior seems to match that of all other browsers, so
breakages should be minimal.

Bug: 896233
Change-Id: I1acb26a3face0eef8d47c1dbe727aab5ec7dd7bd
Reviewed-on: https://chromium-review.googlesource.com/c/1297251
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604450}

This changes SyntheticGestureTargetAura to have an aura::EventInjector
rather than constantly creating one. In mash, EventInjector sends
events to the window service for dispatch. EventInjector establishes the
connection as necessary, but as SyntheticGestureTargetAura continually
recreates EventInjector the connection must be brough up (and destroyed) for
each event. This is non-trivially and adds unnecessary latency to perf
tests.

BUG=none
TEST=none

Change-Id: I22cc6ffe37808586ccd8904b75637e14f2532aea
Reviewed-on: https://chromium-review.googlesource.com/c/1311536Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604449}

Breaks out the use of GetColorWithMinimumContrast for bookmarks-bar
items to a separate function and makes sure all callers use that
instead of directly fetching COLOR_BOOKMARK_TEXT.

In practice this fixes the two items themes that don't specify good
contrasting colors for COLOR_BOOKMARK_TEXT. This also probably makes
the folder icon prettier on Mac in the same case as it uses a more
contrasting white.

Bug: None
Change-Id: Ief016b9bbd45991b2a357055c112704fc7f60097
Reviewed-on: https://chromium-review.googlesource.com/c/1311660Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604448}

This reverts commit 477fd905.

Reason for revert: I had already reverted that CLs that had caused flakiness to MSAN, it just takes a while for MSAN to pickup changes. It eventually picked up in this run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9366

Bug: 899664

Original change's description:
> Disable a few more FilesAppBrowserTest on MSan
> 
> Disable
>   CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads_GuestMode
>   KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode
>   KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteFolderDownloads_GuestMode
> due to flakiness under MSan.
> 
> TBR=lucmult@chromium.org
> 
> Bug: 899664
> Change-Id: Ic39f71f6b07999ca39a6d58f6674d32ab002739c
> Reviewed-on: https://chromium-review.googlesource.com/c/1310502
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604332}

TBR=xiyuan@chromium.org,lucmult@chromium.org

Change-Id: I1bb7400826d3143641d97d8eaaf44b69ccd4e6b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899664
Reviewed-on: https://chromium-review.googlesource.com/c/1312013Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604447}

We failed to abstract away the types with capabilities, so
I am bringing the type back in preparation of removing
service/shadow workers shadow page target.

Bug: 882467
Change-Id: I480bb18b1cfa9cf79e83435d735d102711991562
Reviewed-on: https://chromium-review.googlesource.com/c/1310759Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604446}

TBR=sky@chromium.org
BUG=895574

Change-Id: I78f2afbc465d27d26f9c9f27cfdac597b43dd944
Reviewed-on: https://chromium-review.googlesource.com/c/1311693Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604445}

Bug: 900413
Change-Id: I58da79246fb029656af59877b43b9743e893d3d0
Reviewed-on: https://chromium-review.googlesource.com/c/1311654Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604444}

Change-Id: Ia8c8f5bda50d31f70101e4247dcb606b28da7676
Reviewed-on: https://chromium-review.googlesource.com/c/1310568Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604443}

gn gen on Windows requires double quotes around the arguments. This
fixes the instructions so that they can be successfully copied and
pasted on Windows.

Change-Id: Id9c06cf19cea32a53a8dc4fd567d4243847afd38
Reviewed-on: https://chromium-review.googlesource.com/c/1311933Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604442}

As there are going to be multiple home screen tiles for media and remote control app.
We need to pass the session ID to android side so it could be used to retrieve target
device of a remote control app from remote control manager.

Bug: b/118458714

Test: cast_shell_junit_tests

Change-Id: I4f5372db96946c91cec3302d50fd837d26c91949
Reviewed-on: https://chromium-review.googlesource.com/c/1303236
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604441}

Allow for an AppShimHost to be created before the corresponding
AppShimHostBootstrap. Update OnAppLaunchComplete to save the launch
result and send it only once an AppShimHostBootstrap is attached.

Change ExtensionAppShimHandler profile paths to use the full path
(as is reported by the Profile object, as opposed to the shim's
message).

Change the method GetHostForBrowser to instead be
GetViewsBridgeFactoryHostForBrowser, because the ViewsBridgeFactory is
what all callers are after. Make this call trigger creation of an
AppShimHost if needed to provide a ViewsBridgeFactory. Keep this
guarded behind a flag for now.

Add tests for this functionality. In the tests, further decouple
the AppShimHostBootstrap from its AppShimHost.

Bug: 896917
Change-Id: Ib9e4ad6535ca87cd0e01303fbfc772b8892aec12
Reviewed-on: https://chromium-review.googlesource.com/c/1309307Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604440}

This reverts commit fea62cfd.

Reason for revert: Turns out this optimization was important for all the float tests.

Original change's description:
> [LayoutNG] Remove optimization that practically does nothing.
> 
> This was an over-otimization, which realistically probably never gets
> hit.
> 
> Bug: 635619
> Change-Id: Icac53b8605e56242b8455228d0767b2dafb66b5d
> Reviewed-on: https://chromium-review.googlesource.com/c/1305133
> Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604211}

TBR=ikilpatrick@chromium.org,mstensho@chromium.org

Change-Id: Id842627640dec23519c0b3de88b07958667e54ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/c/1311794Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604439}

This is more complex than you might expect because NGLogicalSize and
NGPhysicalSize depend on each other, so I can't inline the Convert
functions in both headers. Instead, I made NGLogicalSize::ConvertToPhysical
a global function and renamed it ToNGPhysicalSize.

Change-Id: I8d781fa73d262f75cd8196509a58f67a6fb5ec54
Reviewed-on: https://chromium-review.googlesource.com/c/1311083
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604438}

Change-Id: I152eb8755d68470f176a5715bd2d3da4cfdcee70
Reviewed-on: https://chromium-review.googlesource.com/c/1309175Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604437}

Test: local compile and manually test.
Change-Id: Ic1d6d6a7dc81a35f493d0c086bb5577b6a833116
Reviewed-on: https://chromium-review.googlesource.com/c/1306735
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604436}

Bug: 894328
Change-Id: Ia12904740ef4f57643233d26710c704908cca1c8
Reviewed-on: https://chromium-review.googlesource.com/c/1309420Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#604435}

Change-Id: I55ce7bb115c6b1202f503f9c7ddeff3fb348c381
Reviewed-on: https://chromium-review.googlesource.com/c/1300676
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604434}