- 27 Mar, 2018 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I9cfea5cfc14131a6f2b6a2aa853c5fd3252d7781 Reviewed-on: https://chromium-review.googlesource.com/981793Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#545937}
-
Shimi Zhang authored
We passed the wrong context for Chrome to start activity, so Android complains about that. Bug: 808510 Change-Id: I982f1d21cef0feeb3aaf0955fbe5ec6f755dcce9 Reviewed-on: https://chromium-review.googlesource.com/981439Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#545936}
-
Kenichi Ishibashi authored
This CL adds some tests for PerformanceNavigationTiming which are involved with service worker. - SW intercepts a navigation - SW falls back to network - Redirect and SW intercepts a navigation These tests check `workerStart <= fetchStart` because starting a worker should happen before fetching a resource when service worker is involved. Bug: 782958 Change-Id: Idd3fa8f76a328e77ee531b81bd91ee3db223f12c Reviewed-on: https://chromium-review.googlesource.com/979873 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545935}
-
Avi Drissman authored
Replace NOTIFICATION_BROWSER_WINDOW_READY with NOTIFICATION_BROWSER_OPENED. While there was a difference between them at one time, there is no longer any difference, so simplify. BUG=268984 Change-Id: I49ee92023508b5e8471f43ae62d40883786894e3 Reviewed-on: https://chromium-review.googlesource.com/979140 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545934}
-
Bret Sepulveda authored
This patch changes the window title color when the titlebar is painted. This ensures that the proper contrasting color is picked for both active and inactive states. The color is also made partially transparent when the window is inactive. The end result is that the window title should always be the same color as the window caption button symbols (unless a theme uses a button background with the opposite luma of the titlebar). Bug: 821980 Change-Id: Ib84edf0b9d2bb9415cd293d3683915b9d64b40be Reviewed-on: https://chromium-review.googlesource.com/979035 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#545933}
-
Scott Violet authored
This updates ios. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7a59eb0e91b3813855e79352a6146f4d1410c85a Reviewed-on: https://chromium-review.googlesource.com/981322Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545932}
-
Yuichiro Hanada authored
and use it everywhere to express keysets. This CL aims to reduce the risk to pass unexpected values to InputMethodManager::OverrideKeyboardUrlRef. - Rename OverrideKeyboardUrlRef to OverrideKeyboardKeyset This CL addresses the comment in crrev.com/c/950523. Bug: 819018 Test: No behavior change. Unit tests still pass. Change-Id: I96139abaa867c91de039113bc9006b72f210be26 Reviewed-on: https://chromium-review.googlesource.com/974668Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#545931}
-
Ryan Hamilton authored
Change-Id: I053cec0b52defc0ff4a6ceeb3f4f7c5efb5fd31d Reviewed-on: https://chromium-review.googlesource.com/979338 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545930}
-
erikchen authored
The flag is deprecated and replaced by --memlog and co. See https://chromium.googlesource.com/chromium/src/+/lkcr/docs/memory/debugging_memory_issues.md#taking-a-heap-dump for more details. Bug: 758739 Change-Id: I8f7ac614298334a90103cd5b4c9667468d662845 Reviewed-on: https://chromium-review.googlesource.com/970852Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545929}
-
Abhishek Arya authored
R=rsesek@chromium.org TBR=dcheng@chromium.org Change-Id: Ib1499f0f5a48a87558ede6aa255be8eb8def7009 Reviewed-on: https://chromium-review.googlesource.com/978371 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#545928}
-
Xiaocheng Hu authored
Since Position::Before/AfterNode(text_node) are valid DOM positions, offset mapping should accept such positions. This patch ensures it, and also fixes test cases incidentally passing such positions to offset mapping. This patch is also preparation for crrev.com/c/974909 Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I34aa4f9701d0476c93cbe5155e1b6758ebe8c7db Reviewed-on: https://chromium-review.googlesource.com/974903Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545927}
-
Sasha Morrissey authored
Fixed small TODO by tomasz@ to reverse order of entries and parentEntry in zipSelection() method. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8308cc85c4133e47036abeb02aab2df9002ecb58 Reviewed-on: https://chromium-review.googlesource.com/927901Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#545926}
-
Kevin Marshall authored
The current implementation was masking error return values, making all test and executable runs return 0. This lead to waterfall errors being shown as green/passing. Bug: 825714 Change-Id: I977faf461fceb5b5cd2d3e8e22d0c0135c77ce71 Reviewed-on: https://chromium-review.googlesource.com/981438Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545925}
-
Xiaoqian Dai authored
When user locks/unlocks screen using the on-screen keyboard, it will trigger the display metrics change. But at this moment, the snapped windows become inactivatable which will end the split view mode. We should not end split view mode in this case. Bug: 824833 Change-Id: I347caf0624c0683c48bbe44762e7449b8623939a Reviewed-on: https://chromium-review.googlesource.com/978608Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#545924}
-
Yuri Wiitala authored
The crash was being caused by having the NSView pointer passed back-and- forth between threads. In the meantime, the NSView had become invalid. This change ensures that the NSView pointer is always being used in the same call stack, where we know it must be valid. Bug: 818679 Change-Id: I5c9e0f9ac9b643785a99defd2041c78d90865208 Reviewed-on: https://chromium-review.googlesource.com/981309Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#545923}
-
Fredrik Hubinette authored
BUG=794736 Change-Id: Ie60cd3d4892dc0e641b8e59dee0294fee20fd8ec Reviewed-on: https://chromium-review.googlesource.com/981242Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#545922}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d39e8a4..6e9cb694 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7ef43031f28e31d3a9ee6e870eda6a94c5c54de3 Reviewed-on: https://chromium-review.googlesource.com/980606Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545921}
-
Saman Sami authored
Even with min size change period of zero black borders are still possible, so make sure we clip the video frame by content rect before presenting it to the user. This CL also fixes an issue in PaintCanvasVideoRenderer where we didn't handle visible rect properly. Bug: 813929 Change-Id: I59db4caaa2e8751e65801ed5d0b230ddece8d03b Reviewed-on: https://chromium-review.googlesource.com/974650Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545920}
-
Christopher Cameron authored
Add a cached variable for RWHVMac's display::Display. * Initialize it with the the current key window's display, and pass that to BrowserCompositorMac's constructor (and remove the equivalent initialization from BrowserCompositorMac). * Update ui::DisplayLinkMac to use the id from the cached display::Display, and move its update code into UpdateNSViewAndDisplayProperties (this will usually just be a std::map lookup). Move the display::DisplayObserver implementation from RWHVMac (in the browser process) to RHWVNSViewBridgeLocal (in the AppShim process). Change -[RWHVCocoa updateScreenProperties] to only push a new display::Display to the RWHVMac when the RWHVCocoa is attached to a window. Bug: 821651 Change-Id: Ifeddf82ca9858e7e9185b068094af45425790ad0 Reviewed-on: https://chromium-review.googlesource.com/979119 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#545919}
-
Ahmed Fakhry authored
This reverts commit 6dbf08b3. Reason for revert: Compile failure on linux-chromeos-dbg https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/4899 BUG=826101 Original change's description: > Adds AshAssistantController. > > Bug: b:76028606 > Change-Id: Iafdafed688333035f67067b3f60c9b35c99a8276 > Reviewed-on: https://chromium-review.googlesource.com/973551 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Muyuan Li <muyuanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545908} TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,muyuanli@chromium.org Change-Id: Ic33bb5e3efcec6547469999fd42e662529275942 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:76028606 Reviewed-on: https://chromium-review.googlesource.com/981464Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#545918}
-
Joel Einbinder authored
This adds the -theme-with-dark-background class to the html element instead of the body. Change-Id: I05fbc726a371de32447934825706d22c97a9edb5 Reviewed-on: https://chromium-review.googlesource.com/981460Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545917}
-
Bill Budge authored
- Block NaCl plugins from using DEV APIs. No NaCl plugins should depend on DEV APIs outside of development scenarios, and since NaCl is being deprecated, there is little point allowing them in development scenarios now. - Eliminate support for the DEV permission for NaCl in the renderer. Bug: chromium:823171 Change-Id: Id39814cfbf11682f9867c96ecfddb24c1c184fd1 Reviewed-on: https://chromium-review.googlesource.com/974655Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545916}
-
Christopher Cameron authored
RenderWidgetHostViewMac calls into the -[NSView bounds] and -[NSWindow frame] and -[NSScreen frame] methods for various reasons. This no longer going to be allowed when the NSView, NSWindow, and NSScreen are living in another process. Add client method OnNSViewBoundsInWindowChanged to inform the RWHVMac when the NSView's bounds in the window change, along with whether or not the NSView is currently attached to a window. Add a client method OnNSViewWindowFrameInScreenChanged to inform the RWHVMac of the window's motion in the screen. Store the resulting gfx::Rects in RHWVMac, and update the GetViewBounds and GetBoundsInRootWindow methods to use that data. Push this data to BrowserCompositorMac (so that that class no longer queries the NSView for the data directly). Change several locations in RHWVMac that were rolling their own version of mac/coordinate_conversions functions. Add caching to the coordiante conversion functions (somewhat awkwardly, and add a TODO about it). Bug: 821651 Change-Id: I498324f8965bd76031028adfa4f740a5653319f7 Reviewed-on: https://chromium-review.googlesource.com/977229 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Peter Boström authored
Bug: None Change-Id: Ieac0809e2253b8676bf374e255468443699bcab0 Reviewed-on: https://chromium-review.googlesource.com/981177Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545914}
-
Alexander Alekseev authored
This Cl prevents UpdateUserType call for users that has not changed their account type. Bug: 811541 Change-Id: Ic569025f47625478832ba32ccb3ed010ff6d98fe Reviewed-on: https://chromium-review.googlesource.com/981326Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#545913}
-
Robert Ogden authored
This makes it possible to specify alternate backends during testing and skip the tests that would then fail because of it. Bug: 825938 Change-Id: Ib8b1ada6b232da0ad60d035554f9e9ca429d6d85 Reviewed-on: https://chromium-review.googlesource.com/980750 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#545912}
-
gogerald authored
Bug: 825270 Change-Id: I978f26cbfbefa48c0c4b1dffe64d49d750749db6 Reviewed-on: https://chromium-review.googlesource.com/977950Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#545911}
-
Yuwei Huang authored
Currently we need to pass a raw pointer of PerfTracker to ClientTelemetryLogger because its rate accessors are not const, that's because RateCounter::Rate() evicts obsolete data points. Given that evicting obsolete data points doesn't quite change the stats result, we can simply const_cast the eviction logic. This CL also changes the VLOG level of the perf stats to 0 to allow them to be printed to the console. Bug: 825313 Change-Id: Idf8a9c5dd5190566b75a4b60720cd605be774329 Reviewed-on: https://chromium-review.googlesource.com/978662 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#545910}
-
Chris Harrelson authored
Previously, there was an assumption that the transform ancestor of the compositing container matched that of the squashed layer. This is wrong in the situation that the compositing container has a transform. Previously there was a check in the squashing code to skip some offsets if the compositing container has a transform. This code was brittle, and started failing once code was changed to omit composited scrolling offset from the compositing container. Bug: 824811,646437 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia11af0d954065b31d38d61f8d4561ee3edd57e41 Reviewed-on: https://chromium-review.googlesource.com/979169Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545909}
-
David Black authored
Bug: b:76028606 Change-Id: Iafdafed688333035f67067b3f60c9b35c99a8276 Reviewed-on: https://chromium-review.googlesource.com/973551 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545908}
-
Dave Schuyler authored
This Cl displays AiS (Answers in Suggest) differently iff OmniboxRichEntitySuggestions is enabled. This is a step toward presenting rich entity suggestions. Bug: 798631 Change-Id: I0ef87d9bdffdb392f32662a4f13a3721e2826d47 Reviewed-on: https://chromium-review.googlesource.com/981459Reviewed-by:
-
Greg Thompson authored
Observers of the UpgradeDetector are now given notice when the TimeDelta for the "high" annoyance threshold changes (i.e., the UpgradeNotificationPeriod policy setting is changed). This is accomplished via: - UpgradeDetector::GetCustomNotificationPeriod is introduced so that subclasses can easily get the policy setting. - UpgradeDetector::OnNotificationPeriodChange is introduced and is implemented by subclasses (for desktop Chrome and Chrome OS) to handle changes of the UpgradeNotificationPeriod. - UpgradeObserver::OnUpgradeRecommended is now also invoked when the thresholds change. - As a consequence of the above, a "runtime.onBrowserUpdateAvailable" event is broadcast to all extension event listeners and UpdateAvailable() message is invoked on service processes. As a result: - The relaunch recommended bubble is reshown upon a change to the UpgradeNotificationPeriod setting if the UpgradeNotification is set to show it and the new period puts the browser past the last time that it should have been shown. - If the relaunch required dialog is visible upon a change, its title is updated appropriately. - The relaunch required dialog is shown upon a change to the UpgradeNotificationPeriod setting if the new period puts the browser past the time that it should been relaunched. - The browser is relaunched at the proper time in the above case. Unrelated changes included here are: - UpgradeDetector and its subclasses now take and use a TickClock. - UpgradeDetectorChromeos and UpgradeDetectorImpl now use base::NoDestructor rather than base::Singleton or other techniques. - UpgradeDetectorChromeos no longer holds a ChannelsRequester instance after it is no longer needed. - UpgradeDetectorChromeos::Shutdown now does a more thorough shutdown that includes stopping its timer and calling off a call to the ChannelsRequester. - More use of base::TimeDelta for compile-time constants throughout. - Some documentation comments in RelaunchNotificationController have been updated. Bug: 511300 Change-Id: Id868072f494e8c6b2e01e36e4a234ae006e6cc97 Reviewed-on: https://chromium-review.googlesource.com/964324Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
Since r393078, WebMClusterParser no longer inspects payload to determine "keyframiness" of the blockgroup, this change removes the special case ChunkDemuxerTest code which fed a valid VP8 keyframe or nonkeyframe payload into generated BlockGroups for the parser. This simplifies an upcoming change that allows testing around 0-byte payloads (related to crbug 823375). BUG=823375 TEST=media_unittests passes Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I05b70f4dc22b9f75b7761188ecee9bd4f7909ac8 Reviewed-on: https://chromium-review.googlesource.com/981458Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545905}
-
Aaron Leventhal authored
Use ChromeViewsDelegate/WidgetObserver combination to ensure that all widgets are tested for accessibility as they become hidden or visible in a browsertest. The test goes through the View entire subtree and ensure any focusable View has an accessible name. Bug: 819350 Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0 Reviewed-on: https://chromium-review.googlesource.com/951933Reviewed-by:
-
sangwoo.ko authored
We manually calculated bounds for tabs duing mouse-based tab closure in order to persist tabs' bounds. But as |available_width_for_tabs_| is shrunk, we can simplify this using GenerateIdealBounds(). TBR=pkasting@chromium.org Bug: None Change-Id: Ice3f965b1224c2952ec0523591d9d3106ff0c5c7 Reviewed-on: https://chromium-review.googlesource.com/979372 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Bence Béky authored
This reverts commit 1a47d5d6. Reason for revert: https://crbug.com/825804 Original change's description: > Add WebSocket-related CHECKs to HttpStreamFactoryImpl::Job. > > The primary reason for these CHECKs is to better document expectations > in code. Also, they are CHECKs instead of DCHECKs to help track down > crashes in case these expectations do not hold. > > Bug: 819101 > Change-Id: Ia309bbff2f4e048926930cd9a15fbc107994895d > Reviewed-on: https://chromium-review.googlesource.com/975621 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Bence Béky <bnc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545196} TBR=pauljensen@chromium.org,bnc@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Skipping CQ (even though original CL landed more than 24 hours ago) because this is the top crasher in the browser process on Mac, so this should go in before next Canary cut, and definitely before next Dev cut, but ios-simulator bot fails with exception on multiple tries (and also with other CLs). Bug: 819101 Change-Id: Ib998f6b92dd70df943cfb25b1418e1070cb839aa Reviewed-on: https://chromium-review.googlesource.com/980632 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545902}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7ab45c02..5d39e8a4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2791959767664d44fbfcc9bcebc2e2b6f9806d4f Reviewed-on: https://chromium-review.googlesource.com/980776Reviewed-by:
-
Patti authored
Optimize the LocationBarView and friends for touch by making it taller and enlarging its decorations. This patch will make the circular inkdrops flush with the edges of the Omnibox as well. Icons are also enlarged. Screenshots - https://drive.google.com/open?id=1nzMYsrofnubyZFWT7GQb9KCyV30Wz13p Bug: 801583 Change-Id: Ifa5ae0e86842970add17b1b23a4f708c7a81a1d7 Reviewed-on: https://chromium-review.googlesource.com/915483Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
Similar to the IPC command buffer proxy unit tests. R=piman BUG=824510 Change-Id: I14ecfc448e12d4f143b645cc9290c476fdbf5d0d Reviewed-on: https://chromium-review.googlesource.com/978959 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545899}
-
Devlin Cronin authored
In manifest version 1, all extension resources were considered accessible by the web (i.e., could be embedded within or requested by a web page). In manifest v2, only resources explicitly specified in the web_accessible_resources key are accessible. Remove support for manifest v1, and always check the web accessible resources. Update unit tests to migrate relevant tests and remove tests for manifest v1-specific behavior. Bug: 816677, 816679 Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 Reviewed-on: https://chromium-review.googlesource.com/953177 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545898}
-
