- 08 Feb, 2019 40 commits
-
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: Id94947775c92bace04b850a23ed830ff44bb1042 Reviewed-on: https://chromium-review.googlesource.com/c/1461383 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#630526}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I082ece3478bba13b8868c97da2d7825c21d9e925 Reviewed-on: https://chromium-review.googlesource.com/c/1461132 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#630525}
-
Jimmy Gong authored
- Adds TickClock as a member object of SmbService. - TickClock will be used for its time stamping functionality to time-throttle the calls to host discovery from UpdateSharePath. Bug: 922273 Test: compiles Change-Id: I6c9de6cda079f94234a9acae28df8da44505507d Reviewed-on: https://chromium-review.googlesource.com/c/1444597 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#630524}
-
Kim Paulhamus authored
BLE on Linux is not officially supported by Chrome, and behavior can vary greatly depending on the BlueZ version or BLE dongle/adapter used, so we are considering this an experimental/poweruser feature. Bug: 924006 Change-Id: I7a58479048ab275019cc7bb2bc0f00b60222c2d0 Reviewed-on: https://chromium-review.googlesource.com/c/1457716Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#630523}
-
Chris Blume authored
There is a typo in a string literal which is used for logging in an error condition. This CL fixes that typo. BUG:930294 Change-Id: I5a4556da474e8225202ec1a7e9022ca2ae1ba99d Reviewed-on: https://chromium-review.googlesource.com/c/1461302Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#630522}
-
Ken Buchanan authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1437721 which was reverted due to a startup regression on Windows. The only change in this CL is to disable it on Windows, pending resolution of https://crbug.com/929375, and also downgrade the priority of sending metrics to make it a post startup task. TBR=isherman@chromium.org,rsesek@chromium.org Bug: 907279 Change-Id: I3c3182901b2f8a753646405699697661c3a12c3b Reviewed-on: https://chromium-review.googlesource.com/c/1460871Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630521}
-
Xiaocheng Hu authored
This patch adds test cases that record the current Blink's behavior when moving caret around an empty (but with non-zero size) inline block. From code review comments in crrev.com/c/1460476 Bug: 894651 Change-Id: Ibdc512ae02ce2d6e0deca5a8687e4895da38f368 Reviewed-on: https://chromium-review.googlesource.com/c/1460434 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#630520}
-
Yusuf Ozuysal authored
- Splits the TabGrid component into two for better sharing of responsibility. GridTabSwitcher is responsible for ContainerView related events like showing and hiding and also manages the tabModel that is being shown. Resets the TabGridCoordinator when hidden so that the Views can be torn down on the RecyclerView. Takes over lifecycle for TabGrid component. - GridTabSwitcherMediator, other than setting visibility on the ContainerView, implements OverviewModeBehavior and fully resets the toolbar components to listen to its events for switching between TabSwitcher modes. - Not in yet: Showing incognito doesn't work yet. (There is a toggle that does nothing). Change-Id: I325aecd8f52247c8e70e1be0f9b3ba45d7798d9c Reviewed-on: https://chromium-review.googlesource.com/c/1460408Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630519}
-
Danan S authored
This enum is used when launching apps from the Shelf instead of the currently used ash::ShelfLaunchSource::LAUNCH_FROM_UNKNOWN. This not only makes the source of the app launch more clear, but it helps make the behavior of code that examines the app launch source clearer. Bug: 900261 Change-Id: I8e7d8bdf5122621bf177cb1acb429445ed97a9c7 Reviewed-on: https://chromium-review.googlesource.com/c/1460106 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#630518}
-
Francois Doray authored
AdjustMaxTasks() must be scheduled there are pending MAY_BLOCK ScopedBlockingCalls *and* the current concurrency limits are not enough to accommodate all pending tasks. Entering a WILL_BLOCK ScopedBlockingCall cannot make this condition become true. Therefore, MustScheduleAdjustMaxTasksLockRequired() should always return false in WillBlockEntered(). This CL adds a DCHECK to enforce this. Bug: 813857 Change-Id: I2397ab30bd5800e972ee7fba994b31e4357f2202 Reviewed-on: https://chromium-review.googlesource.com/c/1456679 Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#630517}
-
Alexander Timin authored
The term "background" is confusing as it refers to a thread with a specific priority. Use worker_pool instead to refer to non-main-thread scheduler. R=haraken@chromium.org,gab@chromium.org Change-Id: Ia72090e39a3354cd14c539e64475cf661db15cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1282396 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#630516}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/43ecc6793a5c..6b5dce060865 git log 43ecc6793a5c..6b5dce060865 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 linben@google.com Move kevin-arcnext P Android PFQ to kevin Created with: gclient setdep -r src/third_party/chromite@6b5dce060865 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I11e7262d469f664d6cc8cfc4027c1c9df98a4e5f Reviewed-on: https://chromium-review.googlesource.com/c/1461154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630515}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb29edd5. With Chromium commits locally applied on WPT: c64e59c2 "Deflake RTCPeerConnection-track-stats.https.html." 14c11107 "Implement `Sec-CH-Lang`" c49d046d "Initial support for WorkletAnimation.playbackRate" 70938d55 "Fix remaining preload tests flaking on wpt.fyi" af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I576ff901701a4767a8dc4b25c5e0f9ab17c485b1 Reviewed-on: https://chromium-review.googlesource.com/c/1461259Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630514}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. Removed casts where they are now unnecessary. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I43577068160b171779166b1795b22dd69137b4a6 Reviewed-on: https://chromium-review.googlesource.com/c/1461376 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#630513}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I23306df06e8c761d22616ca3f9a341ca79f8c19d Reviewed-on: https://chromium-review.googlesource.com/c/1461035 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#630512}
-
Tomasz Wiszkowski authored
TextAppearanceSpans report font size in pixels, giving an odd effect of inflated answer on high density screens. Bug: 920396 Change-Id: Ice9810f5157f3276042462ca0ff379444c6afea6 Reviewed-on: https://chromium-review.googlesource.com/c/1457471 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Auto-Submit: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#630511}
-
Kevin McNee authored
Several web_tests define the value of the gesture source being used. A common definition is available in resources/gesture-util.js, so we use that. Bug: None Change-Id: Iea4767be229572d6e3555cc45d5f9caa00e5e7d4 Reviewed-on: https://chromium-review.googlesource.com/c/1457465 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630510}
-
Kristi Park authored
sendThemeInfoToEditCustomLinkIframe should only postMessage for Google NTPs, otherwise the edit custom link iframe will not be present. Change-Id: I7119ab9061130a1245b23d8fa0f384cbf94de438 Reviewed-on: https://chromium-review.googlesource.com/c/1460297 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630509}
-
Mihai Sardarescu authored
Consent for Google service is no longer unified. This CL is removing the AllGoogleServices of the UnifiedConsentService as it is now obsolete. Bug: 929372 Change-Id: I3762d27078b4d04280869c3226a087da53145c76 Reviewed-on: https://chromium-review.googlesource.com/c/1461020 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#630508}
-
Xiaocheng Hu authored
During caret navigation, certain contents should be ignored: - Anything that's not text, control or atomic inline - Generated contents - ZWS and <wbr> This patch does so and adds relevant tests. A new layout test that runs both in legacy and bidi caret affinity is added to ensure that this is not a new behavior. Bug: 894651 Change-Id: Idcc6a662afd05a440b67b09d1189b2fec23eadca Reviewed-on: https://chromium-review.googlesource.com/c/1460183 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#630507}
-
Justin Donnelly authored
Also, refactor the logic to combine how we handle allowed_to_be_default_match and how we handle entity suggestions. The former was added in https://crrev.com/c/1174860. Then I added similar entity suggestion handling but in a totally different way in https://crrev.com/c/1376322. When looking to update this logic to fix the issue in bug 922662, I realized that these were doing very similar things despite going about them in different ways. So this CL combines all the logic in the method that chooses between two candidate matches. Bug: 922662 Change-Id: I290573e4669360904bf049d252e4a4175ea6c499 Reviewed-on: https://chromium-review.googlesource.com/c/1403062 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630506}
-
Javier Ernesto Flores Robles authored
Enables manual fallback in incognito by getting the original browser state. Fixes the double input view by resetting the reference to the view when the keyboard hides on iPad. Reverts: https://chromium.googlesource.com/chromium/src.git/+/15f7cf85bc1fb76e51e58cea68e6fc183aa5fbde Bug: 923857, 923857, 905720 Change-Id: I253c4b25650cf6be184c59caa7285dc1ecdc8900 Reviewed-on: https://chromium-review.googlesource.com/c/1461080 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630505}
-
Yuwei Huang authored
This is a reland of c0cf050d Original change's description: > Add remoting FTL API key > > Add API key for remoting to use during the signaling process. Note that > this key is only used by Chrome Remote Desktop and will not be used in > the Chrome browser. > > Internal CL: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/831973 > > Bug: 927962 > Change-Id: Iecfa48aebe1078a4a0c747f42711000d9155fc3f > Reviewed-on: https://chromium-review.googlesource.com/c/1450409 > Reviewed-by: Joe Downing <joedow@chromium.org> > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Auto-Submit: Yuwei Huang <yuweih@chromium.org> > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630352} TBR=rogerta@chromium.org Bug: 927962 Change-Id: I63c2e7e16621a01827609fab0c8969fd85b2399c Reviewed-on: https://chromium-review.googlesource.com/c/1461306 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#630504}
-
wutao authored
This patch removes the chrome flag enable-settings-shortcut-search, but keeps the feature app_list_features::kEnableSettingsShortcutSearch for future development. Bug: none Test: manual Change-Id: I2d2c4310f9750d334dc0fa84cb3207e04a8d560a Reviewed-on: https://chromium-review.googlesource.com/c/1460425Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#630503}
-
Raul Tambre authored
//chrome/third_party/mozilla_security_manager: Convert base::(U)Int(64)ToString(16) to NumberToString(16) The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I67125c3d5067dc1b64aa89e2625de24fd5ca5d9c Reviewed-on: https://chromium-review.googlesource.com/c/1461131 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Matt Mueller <mattm@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#630502}
-
Wez authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. We also need to refer to the global persisted storage area via a different path when calling SCP to the path we use from within the applications we run on the device. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Bug: 930182 Change-Id: Ie927ac82959345f2605fcbf604c90409b4853f88 Reviewed-on: https://chromium-review.googlesource.com/c/1461307 Commit-Queue: James Robinson <jamesr@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#630501}
-
Yi Gu authored
AnimationWorkletGlobalScopeTest::SelectGlobalScope tests the behavior of AnimationWorkletProxyClient::SelectGlobalScope but it uses a mock client. Move this test to AnimationWorkletProxyClientTest to use a complete proxy client. Since we have used CreateAnimationAndPaintWorkletThread in three tests with duplicating most of the implementation, this patch also creates a helper file to handle this problem. Change-Id: Id86bd3c2cb796565a84fc8c30d14f46a3958ff17 Reviewed-on: https://chromium-review.googlesource.com/c/1459924Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#630500}
-
Sean Topping authored
This change introduces two SetContext() methods for CastContentWindow; SetActivityContext() is used to supply common data for all activities, while SetHostContext() provides data about the code that is hosting the activity instance. Merge-With: eureka-internal/239993 Bug: internal b/123538348 Test: CQ Change-Id: I7cb4a313de78b0d511f4423dd5af4595a2866a7e Reviewed-on: https://chromium-review.googlesource.com/c/1457722Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#630499}
-
Wenzhao Zang authored
The Autotest component extension is used to launch Android apps. It should be whitelisted in Demo Mode (which is implemented as public sessions). Bug: 870049 Change-Id: I31628dc5c659818990c1d280d6744112867db34a Reviewed-on: https://chromium-review.googlesource.com/c/1441795Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630498}
-
Karan Bhatia authored
These started failing on Linux bots after a WPT auto import. BUG=930297 TBR=jsbell@chromium.org No-Try: true NOTRY=true Change-Id: I8c9546510fe603db6dd9a4566dbbc90d6412eaa0 Reviewed-on: https://chromium-review.googlesource.com/c/1461348Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#630497}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I4ee6af43ac4b62ac09892774faba366f4f78e271 Reviewed-on: https://chromium-review.googlesource.com/c/1461380 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#630496}
-
Kevin McNee authored
Some of the GestureSourceType enum values are defined on chrome.gpuBenchmarking. We define the rest of them and then use them to define GestureSourceType values for web_tests. Bug: None Change-Id: I4e9eb85850fbfdda490b84ac665b7ae397e68a50 Reviewed-on: https://chromium-review.googlesource.com/c/1460121Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#630495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de578cdd6b58..295aca65583b Created with: gclient setdep -r src-internal@295aca65583b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4ef1452efd1e2891508a781faf945dd5065553ac Reviewed-on: https://chromium-review.googlesource.com/c/1461151Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630494}
-
Hector Carmona authored
Navigator.language can return either a language only ('en') or a full locale ('en-US'). If a locale is not found ('ru-RU'), then fall back to using only the language ('ru'). Bug: 922088 Change-Id: I215071e55a9a01a97348491603a4bdabe739ff87 Reviewed-on: https://chromium-review.googlesource.com/c/1460479Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#630493}
-
Mounir Lamouri authored
There is a regular bug being filed by ClusterFuzz about a CHECK when converting an infinity value to base::Value. I fixed a regular issue for duration. Folding the different events into the same entry guarantees that we don't repeat this work. Bug: 927634 Change-Id: I4d8833e8430d42036e6501db65cf4b5349772b07 Reviewed-on: https://chromium-review.googlesource.com/c/1461305 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630492}
-
Lukasz Anforowicz authored
Drag-and-drop into a web page is obviously handled by the web page. If the drag-and-drop started from outside the web page and contains a URL, then it needs to trigger a top-level navigations to that URL. Examples of such navigation-triggering drags are: dragging a Chrome bookmark into a web page; dragging a file from an platform-specific file viewer (e.g. Windows Explorer) into a web page. The navigation above needs to use a unique origin as the initiator of the navigation: 1. This matches other navigations initiated outside of a web page (e.g. omnibox navigations). Here also we have a navigation initiated by a user, to a destination chosen by a user (not by the webpage handling the navigation). One could argue that drag-and-drop started from another web page (say foo.com) should use the origin of that web page as an initiator. Unfortunately, drag-and-drop data doesn't have this information - it only has the destination URL (which can be a different site - say bar.com). I think treating this situation consistently with drags started from outside the browser is fine (at least for now). At the very least, using a unique origin is safer than using the destination origin (which might not always match the origin of the source of the drag). 2. The renderer process handling the drag-and-drop might be locked to a specific site or origin (and therefore not able to use arbitrary origin as the initiator). This has led to renderer kills in https://crbug.com/930049. A regression test will be authored and landed separately - please see https://crrev.com/c/1461339. Bug: 930049 Change-Id: I9c16ea30086d78dc010c8479ea528b0cb3181158 Reviewed-on: https://chromium-review.googlesource.com/c/1460424 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#630491}
-
Sylvain Defresne authored
The override of RegisterListPref taking a std::unique_ptr<base::Value> is never used, so remove it. Bug: 646113 Change-Id: I0267d0ac034f3d8c59c40f20b6e77b534e960184 Reviewed-on: https://chromium-review.googlesource.com/c/1460932 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#630490}
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is never used, so remove it. Bug: 646113 Change-Id: I72b981b2bd9f92394be65eddde1ad3d269552552 Reviewed-on: https://chromium-review.googlesource.com/c/1459538 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#630489}
-
Samuel Huang authored
Details: * Add 2 classes and 1 helper function to rel32_utils.h. * Rel32ReaderArm: ReferenceReader for ARM. * Rel32WriterArm: ReferenceWriter for ARM. * ArmCopyDisp(): Copies displacement data from one ARM instruction to another (of the same type) to make them more similar. This will be used for ReferenceBytesMixer. * These funtions take ADDR_TRAITS template argument, which matches ArmAddrTraits in arm_utils.h. * Add extensive tests. Bug: 918867 Change-Id: I7e7f8bee8cb2a8b49f7fd0e7115b39c49f576398 Reviewed-on: https://chromium-review.googlesource.com/c/1452780 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#630488}
-
Sreerenj Balachandran authored
Add the Hardware Accelerated VA-API based VP9 Encoder support in chromium. The vp9 specific webrtc metadata to make the encoding work with appr.tc is added by Erik Språng<sprang@webrtc.org>. BUG=811912 TEST=run the video_encode_accelerator_unittest on supported devices(eg: soraka) VEA: ./video_encode_accelerator_unittest --gtest_filter=SimpleEncode/VideoEncodeAcceleratorTest.TestSimpleEncode/0 --test_stream_data=bear_320x192_40frames.yuv:320:192:12:bear.ivf:100000:30 -v=0 --disable_flush --single-process-tests --ozone-platform=gbm TEST=appr.tc/?debug=loopback&vsc=VP9&vrc=VP9 Change-Id: I50b77d642684a03f7ecc35befd5442d35b41e3ae Reviewed-on: https://chromium-review.googlesource.com/c/1383540Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Cr-Commit-Position: refs/heads/master@{#630487}
-