GitLab

This reverts commit 9e4a1523.

Reason for revert:

fast/dom/MutationObserver/weak-callback-gc-crash-case2.html fairly consistently fails on Win7 Tests (dbg)(1) . See https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64920 as an example.

Original change's description:
> MutationObserver: Do nothing when its execution context is no longer available.
> 
> MutationObserver::DeliverMutations is a static function and
> registered to the microtask queue.  It maintains active
> observers and also makes active observers alive, but nothing
> else (the underlying callback function nor execution context).
> 
> So, when DeliverMutations invokes each active observer,
> DeliverMutations must make sure that each active observer's
> execution context is still available.
> 
> This patch adds the check of the execution context.
> 
> Bug: 788495, 789862
> Change-Id: Ic350603cc8a7b13275adf042e731fdd9605373aa
> Reviewed-on: https://chromium-review.googlesource.com/799653
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520509}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org

Change-Id: I00ea0349a3f441f6d2fb356d179b5e301c253df3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788495, 789862
Reviewed-on: https://chromium-review.googlesource.com/801222Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520680}

The setting does not seem to be documented, but was easily found by
tracking property changes to a device and playing around in settings.

This implementation keeps a suppression count and re-enables ambient
noise reduction, if it was initially enabled, once all streams
requesting this behavior have stopped.

Bug: chromium:789152
Change-Id: I1672a44bf185beedef2caaff8f66f5c50a9aad95
Reviewed-on: https://chromium-review.googlesource.com/737873
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520679}

Log whether the bookmark entry is a user bookmark or a partner bookmark
when it is opened.

Bug: 787132
Change-Id: Ia42d88125e60ba0fb1710ea9b3eef6c7d63a0b5d
Reviewed-on: https://chromium-review.googlesource.com/799030Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520678}

https://pdfium.googlesource.com/pdfium.git/+log/646257d65c65..fee910e6f81f

$ git log 646257d65..fee910e6f --date=short --no-merges --format='%ad %ae %s'
2017-11-30 npm Prevent integer overflow in CJBig2_HuffmanTable::ParseFromCodedBuffer

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I55e3ea4fbc1ff2a6f36d7f624a99e80da558b5ff
Reviewed-on: https://chromium-review.googlesource.com/801255
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520677}

Bug: 789653
Change-Id: I5ea9761a687b4c9a64437df032af27d1a96080fb
Reviewed-on: https://chromium-review.googlesource.com/797454
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520676}

This changes is for files in the path //t_p/WebKit/Source/platform/wtf/.

Added the include for base/macros.h where needed and moved the macro to the
end of the class as per the code guidelines enforced by lint.

This CL introduces no logic changes.

Bug: 565932
Change-Id: I55718a92a5e919e16aaac01fc33446e5ea169354
Reviewed-on: https://chromium-review.googlesource.com/791411
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520675}

This adds counters for key, mouse, and touch events to
TabActivityWatcher::WebContentsData. When a tab is logged, these
counters are reported in the UKM. The counters are reset on each
navigation.

These counters are passed to TabSnapshotLogger in a new hierarchical
structure, which will be built upon to add browser-, tab- and page-
specific metrics. Separating these event counts into a separate struct
makes it easier to reset them when a navigation occurs.

This CL counts the absolute number of events -- as an improvement, we
would prefer to count user actions rather than, say, the exact
number of mouse-move events fired.

A unit test simulates mouse activity, but key and touch are harder to
pipe in from a unit test.

Bug: 784639
Change-Id: I693c34f0845c3fdeca6c1fb172e7347f9c2a504f
Reviewed-on: https://chromium-review.googlesource.com/794592
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520674}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/9b6a22544458..7092a3102eae

$ git log 9b6a22544..7092a3102 --date=short --no-merges --format='%ad %ae %s'
2017-11-29 xiaochu Add constant to imageloader dbus API
2017-11-29 derat system_api: Document potential races in suspend readiness.
2017-11-27 allenvic smbprovider: Add ReadDirectoryOptions and GetMetadataEntryOptions

Created with:
  roll-dep src/third_party/cros_system_api

Bug=chromium:780575
TEST=None

Change-Id: I0f633691030275ebf8d3e398efc9b9a568a69db9
Reviewed-on: https://chromium-review.googlesource.com/801211Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520673}

Bug: 700624, 727514
Change-Id: I54f08aa19e76f505303b9314fa56d7deb3fcb348
Reviewed-on: https://chromium-review.googlesource.com/794490Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520672}

Includes from the X11 system libraries declare macros with common
names such as None, True, False, Status and those complicate
the life for other code. To avoid that complication we have
moved the common symbol names to the namespace x11 and changed
so that you include "ui/gfx/x/x11.h" instead.

Bug: 782184
Change-Id: I3d2893425bb79cb29d6c5a602512a0e8d3cc30cd
Reviewed-on: https://chromium-review.googlesource.com/800550Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#520671}

This CL adds two files to //media/test/data, namely:
- test-25fps.vp9_2: VP9 Profile 2 file in an IVF container
- test-25fps.vp9_2.md5: md5 version of its thumbnails.
to be used with video_decode_accelerator_unittests.

This CL also updates Vp9ParserTest to use the new file instead
of media/test/data/crowd-vp9.2.ivf, which is removed (the
new file is smaller).

It also updates media/test/data/README.md with details on how
the new files were generated.

TEST=compile and run on a soraka:
video_decode_accelerator_unittest --test_video_data=test-25fps.vp9_2:320:240:250:250:35:150:14
(Note the last number is a 14 == VideoCodecProfile for VP9.2)

Bug: 778093
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I53e1a1802cb4c8b634e5f979d7afba143b259b68
Reviewed-on: https://chromium-review.googlesource.com/797853Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520670}

https://chromium.googlesource.com/catapult.git/+log/9968f9b780e9..0ee7aab89cf2

$ git log 9968f9b78..0ee7aab89 --date=short --no-merges --format='%ad %ae %s'
2017-11-30 eakuefner [Dashboard] Remove spurious conditional

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I17e5ab01f8bd08cf0b6aa7bcbc2c457701726912
Reviewed-on: https://chromium-review.googlesource.com/801332
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520669}

Add the following system properties to the feedback collection
mechanism:
- CPU Architecture
- GPU Vendor
- GPU Model
- Total MB memory
- Available MB memory
- Total MB storage (of data directory)
- Available MB storage (of data directory)

BUG=773397,773399,773400,773402

Change-Id: I49fdc3955bf71577d77dfac18029e5b4d7895ae0
Reviewed-on: https://chromium-review.googlesource.com/794852
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520668}

If a trackpad pinch ends at scale level 105% or lower, snap to 100% with
a scale animation.

BUG=769934

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6d7e185951900f11afadf80c7eeea16f8a4156b6
Reviewed-on: https://chromium-review.googlesource.com/691202
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520667}

The lack of conversion was causing an offset error because some of the
numbers being used were in the character list index space and some of
them were in the text buffer index space. This CL combined with
https://pdfium-review.googlesource.com/c/pdfium/+/20014 in PDFium
resolves outstanding issues with Find highlights in PDFs with control
characters in the text body.

BUG=chromium:654578

Change-Id: I5f600a59926f137ed0a0901711a3ff57d3e42e34
Reviewed-on: https://chromium-review.googlesource.com/801310Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520666}

It currently uses URLRequestMockHTTPJob::GetMockUrl(), which is not compatible with network service.

BUG=776589

Change-Id: Ie6c46e1376c735b9885ce7d267001fbe2c3e6a09
Reviewed-on: https://chromium-review.googlesource.com/762184
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520665}

Change-Id: I39b36b6c1ae97c457c760bf1eff0398d43f07c2d
Reviewed-on: https://chromium-review.googlesource.com/799951Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520664}

This commit refactors the relationship among AppListModelBuilder,
AppListSyncableService, and AppListModel:

- removing the kEnableSyncAppList/kDisableSyncAppList switch;
- stressing the fact that AppListModel and AppListModelBuilders
  are owned by AppListSyncableService independently;
- creating AppListModelUpdater as an interface to access the model;
- accessing the model from AppListModelBuilder and its derived
  classes with AppListModelUpdater instead of a real model;
- creating a FakeAppListModelUpdater for affected tests;

This commit is part of the app list migration.

Bug: 733662
Change-Id: I421b1a96694fc6a7ad58d380c1644d16264d354e
Reviewed-on: https://chromium-review.googlesource.com/792511Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#520663}

This CL adds a class wrapping a provider which is responsible for
creating instances of file systems and returning capabilities. This
is a necessary change to support native file systems in the future.
Service will now lookup the Provider via provider_id to call
GetCapabilities() & CreateFileSystem().

Bug: 778791
Test: All unit tests pass.
Change-Id: Ic0d8c9cf12d3386755cb147cec0fbd1e277fce5b
Reviewed-on: https://chromium-review.googlesource.com/794754
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520662}

This reverts commit f3535b85.

Reason for revert: AccessibilityFullscreenBrowserTest.IgnoreElementsOutsideFullscreenElement is flaky on linux-chromeos-rel

Original change's description:
> Make elements outside of the fullscreen element inert
> 
> There is no spec for this, but an old open spec issue:
> https://github.com/whatwg/fullscreen/issues/15
> 
> Bug: 787867
> Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a
> Reviewed-on: https://chromium-review.googlesource.com/788052
> Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520620}

TBR=dmazzoni@chromium.org,mlamouri@chromium.org,foolip@chromium.org

Change-Id: I5e042244565404b7735f4e5fecc4d1194ed2a402
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787867
Reviewed-on: https://chromium-review.googlesource.com/801517Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520661}

ChromeOS user type is set based on decoded is_child_account information derived
from the ID token, and this type is also used to trigger website supervision on
the browser.

This is part of the migration from the deprecated GetUserInfo call that was used
to detect a child account.

DD: https://docs.google.com/document/d/13VBL5yBr6cXHX70bs7L1jIH68GXZp67f7cBqICcCESk/edit

Bug: 716063
Change-Id: I47177aa8e7a87c4b57ffe1599f8029bc684d7e55
Reviewed-on: https://chromium-review.googlesource.com/792285
Commit-Queue: Luciana Maroun <maroun@google.com>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520660}

If a file is changed on the filesystem and is ignored in devtools it
will now properly not be created in workspaces.

R=lushnikov
BUG=754371

Change-Id: Ic0bc61ede57fb1aa17f1483f614bcca414fe14b6
Reviewed-on: https://chromium-review.googlesource.com/798735
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520659}

The test should pass now after https://chromium-review.googlesource.com/c/chromium/src/+/773483

BUG=715630

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I1850aaf490b1920e9e2bc9766a6e291d0ba50b0f
Reviewed-on: https://chromium-review.googlesource.com/795037Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520658}

Control Flow Integrity [1] indirect call (cfi-icall) checking can not
verify that dynamically resolved function pointers call their intended
function. Instead we place the pointer for gdk_set_allowed_backends in
ProtectedMemory, a wrapper for keeping variables in read-only memory
except for when they are initialized.  After setting the pointer in
protected memory we can use the UnsanitizedCfiCall wrapper to disable
cfi-icall checking when calling it since we know it can not be tampered
with.

[1] https://www.chromium.org/developers/testing/control-flow-integrity

Bug: 771365
Change-Id: I5c359697c466921084aea17cda655231fdc33a92
Reviewed-on: https://chromium-review.googlesource.com/775617Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520657}

Jumbo is a unity build system for Chromium, aimed at reducing
compilation times by merging cc files into larger
translation units.

This is 0.1% of the total build time so not very much but also
the final remaining part of blink/platform. And all the CPU
minutes add up.

Bug: 761475
Change-Id: Id0643d869960a660a91a4f3a9a23b4585f9e0073
Reviewed-on: https://chromium-review.googlesource.com/785678Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#520656}

TBR: rbyers, foolip
Bug: 789707
Change-Id: I9ceb10e4ce74680a1d7d422a2d9391fd8b2a25c7
Reviewed-on: https://chromium-review.googlesource.com/801456Reviewed-by: Alex Vallee <avallee@chromium.org>
Commit-Queue: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520655}

Also add an images section.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I46fbc471c8ec047890e3866e522fecd53e9815c9
Reviewed-on: https://chromium-review.googlesource.com/798890
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520654}

The Blink Rename has made most uses of this-> unnecessary. The
relevant variable names no longer clash with the getters.

Bug: 789653
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5386997583eee778e5afc2b9718f62f3e814b5d4
Reviewed-on: https://chromium-review.googlesource.com/798031Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/heads/master@{#520653}

This closes the loop for tab focus change inside overlay in case it is
currently showm.

Bug: 788127
Test: Manually
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0dc45f0702e0608961718c8fafbd013227de3ee8
Reviewed-on: https://chromium-review.googlesource.com/797670
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520652}

This CL fixes the DOMTimer.cpp changes made in:
https://chromium-review.googlesource.com/737435

Bug: 772432
Change-Id: I1e990d1ac595c99249996372fcdd93530eb43f41
Reviewed-on: https://chromium-review.googlesource.com/800730
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520651}

removes colorspaces unused in chrome.
only supported ones are: RGBA/BGRA/rgbA/bgrA (decoder)
as well as: WebPPictureImportRGB/RGBX/RGBA (encoder).

Bug: 789665
Change-Id: I27fdfc197f806413526242d9b029c506e1a71c3f
Reviewed-on: https://chromium-review.googlesource.com/798472Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#520650}

Bug: 789242
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6c379b49dc444a786a5afa597c306d69f5a43841
Reviewed-on: https://chromium-review.googlesource.com/798799
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520649}

This reverts commit df64b29e.

Reason for revert: Caused http://crbug.com/790557 .

Original change's description:
> Add WebRTC logging to Windows audio input implementation.
> 
> Log failures in Open() and Start().
> 
> Bug: 757737
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Idaad68af9aabc753cb4fca17b2dfff3cdf69d83b
> Reviewed-on: https://chromium-review.googlesource.com/795727
> Commit-Queue: Henrik Grunell <grunell@chromium.org>
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520562}

TBR=grunell@chromium.org,maxmorin@chromium.org,marinaciocea@chromium.org

Change-Id: I54d97e5063d5a63325977ce19753d1e5439dd396
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757737, 790557
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/801263Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520648}

BUG=790549,788390
TBR=beccahughes
NOTRY=true

Change-Id: I4046eb8ca85c48ba0ec851a14700ace62deca5c0
Reviewed-on: https://chromium-review.googlesource.com/801656
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520647}

A header forward declared a WebUIMessageHandler in the global
namespace which seriously confused jumbo builds since the
actual WebUIMessageHandler is in the content namespace.

Change-Id: I623b2f729d03dbea199c27f62790f8119d0e3926
Reviewed-on: https://chromium-review.googlesource.com/800933
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520646}

Bug: 686281
Change-Id: I2909d2f199deec969948177770a6947ca86ddee8
Reviewed-on: https://chromium-review.googlesource.com/721843
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520645}

Makes the post-test WebappRegistry clearing occur on the UI thread.
This fixes the ConcurrentModificationException that was occasionally
being thrown due to the WebappRegistry's mStorages hash map being
simultaneously iterated over and modified on separate threads.

Bug: 
Change-Id: I38331b90d2c84cca59b4012ab4b407c191ad606f
Reviewed-on: https://chromium-review.googlesource.com/798111Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520644}

If the new virtual baseline is the same as the fallback, don't create
new baseline file. This is just the same logic as --reset-results for
normal tests and flag-specific results. Change the condition to remove
the old baseline before creating the new baseline to ensure the logic
for virtual tests.

(An example of the case:
Before rebaseline:
  base test: some/test.html
  generic baseline: some/test-expected.txt containing "BASE"
  virtual test: virtual/spv175/some/test.html
  virtual baseline: virtual/spv175/some/test-expected.txt containing "DIFF"

Suppose a code change causes the test produces the same result for the
base test and the virtual test. Previously we would reset the virtual
baseline leaving it along with the generic baseline file even if they
were the same. Now we will delete the virtual baseline.)

Remove extra spv175 baselines.

Change-Id: I3b586d7d0225b1ffd8b7da14f81914d9dacfbf03
Reviewed-on: https://chromium-review.googlesource.com/801210Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520643}

Drag up the closing launcher on the shelf area and end with FLING_START event
with velocity_y that exceeds |kAppListDragVelocityThreshold| will end with
setting the launcher state to FULLSCREEN_ALL_APPS. But the state was already
set to CLOSED after close animation is started and hence setting state to
FULLSCREEN_ALL_APPS does not have effect. Should dismiss the launcher instead
of setting its state in this case.
Related cl: https://chromium-review.googlesource.com/c/chromium/src/+/667949

Bug: 766324
Change-Id: Ibac26da14cd18c99046b801c96c974484f5d30c6
Reviewed-on: https://chromium-review.googlesource.com/798321
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520642}

Events that would trigger logging TabMetrics are ignored if we already
logged TabMetrics for the same UKM source (navigation) in the past 10
seconds. This is intended to prevent possible flooding of UKMs.

This CL parameterizes that timeout as a fieldtrial param so we
can tweak it as necessary while keeping a safe default.

Bug: 789678
Change-Id: Icd441e78cbef0a57d4b2ee2570bc09e1b1e565ef
Reviewed-on: https://chromium-review.googlesource.com/797772
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520641}