- 02 Aug, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a9c4581..e41c89b3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33021dad9a07ab61cffbcee9f8826db2be5c79ea Reviewed-on: https://chromium-review.googlesource.com/1159322Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580040}
-
Johannes Henkel authored
This consolidates the fields a bit; enabled_, suspend_, and show_size_on_resize are now used directly. Change-Id: I900203ee912946945e5242c667bd3ed8976c61a3 Reviewed-on: https://chromium-review.googlesource.com/1159472Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580039}
-
Esmael El-Moslimany authored
Bug: 860069 Change-Id: Ifa72a55db0f15050bb115a6f50c319124ec367ed Reviewed-on: https://chromium-review.googlesource.com/1155929 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580038}
-
mrefaat authored
Created CRWWebStatePolicyDecider delegate. Created WebStatePolicyDeciderBridge. Created CRWTestWebStatePolicyDecider (fake test class). Added unit tests for the newely created delegate/bridge. This will be required by PreloadController as it's an objective-c class and i'm going to make it a WebStatePolicyDecider (as part of effort to move any logic related to app launching out of the CRWWebController. Bug: 674991, 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8e17d4d23fc4960609a19708148baa73381983c8 Reviewed-on: https://chromium-review.googlesource.com/1157135Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#580037}
-
Shu Chen authored
Bug: 867084 Change-Id: I1a667b8c54d8f111dbe00a2b398fb99f1527aa0b Reviewed-on: https://chromium-review.googlesource.com/1157741Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580036}
-
Yutaka Hirano authored
With out-of-blink CORS, CORS errors for XHR are displayed in ResourceLoader, which brings flakiness to open-in-body-* tests, because Resource and ResourceLoader continue working a while after ThreadableLoader::Cancel is called, because of the async cancellation mechanism in ResourceLoader. These tests make ill cross-origin requests, and then abort them (by calling open() of the same XMLHttpRequest object) after that. When a response arrives befor the cancellation is performed but after async cancellation is started, then we see a console log of a CORS error for an aborted XHR. Let's have such tests use testharness.js instead of js-test.js so that such console errors don't affect the test results. Bug: 736308 Change-Id: I680ce2997a6c10e06368db8a89d789534c47097d Reviewed-on: https://chromium-review.googlesource.com/1156329 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580035}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d3b7ec2e911a..f5cf02ac2c4a git log d3b7ec2e911a..f5cf02ac2c4a --date=short --no-merges --format='%ad %ae %s' 2018-08-01 qingsi@google.com Use randomly generated IDs for candidate pairs in ICE event logs. Created with: gclient setdep -r src/third_party/webrtc@f5cf02ac2c4a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6104e504fe4e42b17832e6611f8fa676e02e6a24 Reviewed-on: https://chromium-review.googlesource.com/1159243Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580034}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 920c0ed0. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22248 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox jsbell@chromium.org: external/wpt/resources TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I6433e90e488c393e62a31da83513b0a5080bcd9e Reviewed-on: https://chromium-review.googlesource.com/1159331 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580033}
-
Avi Drissman authored
NSPopUpButtonCell in Mojave calls through the parent view at all times, even during destruction. Work around this by properly scoping the lifetime of the NSPopUpButtonCell in MenuButton, which is something we weren't able to do in 10.5 but that was fixed in 10.6 but that we never got around to updating. BUG=869844 Change-Id: Iaecd978bc410810f02276f21ba13dd20ca73b195 Reviewed-on: https://chromium-review.googlesource.com/1159191 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580032}
-
Findit authored
This reverts commit 5df2779d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 580012 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVkZjI3NzlkZTY0ODIxZmYwZDc2NGEwNGRmMmJmMzhhNDZlN2MzNGIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7101 Sample Failed Step: compile Original change's description: > cros: Add warning dialog in public account view > > Bug: 864549 > Change-Id: If79c0100067c62a9fedb3119f43813a87d5bd6c6 > Reviewed-on: https://chromium-review.googlesource.com/1145864 > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580012} Change-Id: Ib78a72feb7bc149a17fdef9865aa4fdffa669d2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864549 Reviewed-on: https://chromium-review.googlesource.com/1159802 Cr-Commit-Position: refs/heads/master@{#580031}
-
Tom Anderson authored
This CL introduces 2 changes to the behavior of pkg_config when use_sysroot=false: 1. The path is not made relative to the build directory. This fixes the case where your src directory may be mounted at different locations. 2. -I is used instead of -isystem. When -isystem is used, dep files do not reference the system header files. This is OK when using the sysroot because the CR_SYSROOT_HASH macro contains the sysroot revision so any source files will be rebuilt when the sysroot updates. R=dpranke Change-Id: Ia3d7df51880205fee888923283b76078ccb3112f Reviewed-on: https://chromium-review.googlesource.com/1159689Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#580030}
-
Alan Cutter authored
This CL adds a null check to RenderViewContextMenu::AppendLinkItems() ensuring we have an associated Browser before attempting to use it. Bug: 869280 Change-Id: Ib1ffecd9dfbe27fb4fc6f6c77762c6337c36d4d4 Reviewed-on: https://chromium-review.googlesource.com/1158110Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580029}
-
Jun Choi authored
Use Chromium pref as a persistant key-value storage to save previously used transport type. This will enable us to skip "Welcome" dialog if we know that the user has already used certain transport type before. Bug: 868212 Change-Id: Iff732f2d990291cfe1465107fc01d08b3cf3e019 Reviewed-on: https://chromium-review.googlesource.com/1152559 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#580028}
-
dpapad authored
Test: - Build chrome once, with optimize_webui=true - rm out/<out_folder>/gen/chrome/browser/resources/settings/vulcanized.p2.html. - Build chrome again. There should be no errors. Before this CL an error is thrown, because the file is not re-generated and GRIT fails to find it. After this CL, the file is correctly re-generated. Bug: 862472 Change-Id: Idd3896a74b8791558719052f145bb3a500005daf Reviewed-on: https://chromium-review.googlesource.com/1159276Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580027}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/134364159fa8..2acd8e0354e2 git log 134364159fa8..2acd8e0354e2 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 oysteine@chromium.org Removed an old restriction on timestamp ordering of trace events Created with: gclient setdep -r src/third_party/catapult@2acd8e0354e2 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5830d896d7a62027b4b30950becf5f87b745d865 Reviewed-on: https://chromium-review.googlesource.com/1159701Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580026}
-
Findit authored
This reverts commit b8dd9864. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 579953 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I4ZGQ5ODY0MjE3M2YyNmUyMDMzOGU5ZGE5ZWI3NGQzMTEyNjE5OGMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/9356 Sample Failed Step: not_site_per_process_unit_tests Original change's description: > Apply Google-related request modifications for networking service path. > > This adds support for: > 1) Safe Search > 2) YouTube restricted mode > 3) restricting consumer accounts > through Group Policy. > > The other supporting change is to make ThrottlingURLLoader handle a throttle changing the URL in WillStartRequest. > > Bug: 841313 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ic98e14dd5fa7b5b00d4befd3314aca7a67e6ba5a > Reviewed-on: https://chromium-review.googlesource.com/1152507 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579953} Change-Id: Ic1b90a4148f1d5ebb4442ce34fa5421d879ef32f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841313 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1159801 Cr-Commit-Position: refs/heads/master@{#580025}
-
Lindsay Pasricha authored
Bug: 847948 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1aa8d2b06ccbe326beb9e7832cee69d60882b25c Reviewed-on: https://chromium-review.googlesource.com/1159193 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change ports UserInfoFetcher from net::URLFetcher to SimpleURLLoader. This was the last user of the net::URLRequestContextGetter provided by policy::CloudPolicyClient and so this has been removed. Bug: 844951 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I752a16fbfcaa92419c79693d2379b918e04b7b9a Reviewed-on: https://chromium-review.googlesource.com/1156049 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#580023}
-
Nasko Oskov authored
The WebNavigationApiTest.UserAction loads a page with has a subframe in a different site than the main frame. Since the main page is an extension URL, those will get isolated in separate processes. The test checks that a context menu in the subframe, which opens a link in a new tab results in the correct event for the webNavigation API. However, since it doesn't wait for the subframe navigation to complete, the context menu creation can incorrectly capture the parent process id instead of the subframe process id. This is timing dependent, which leads to flakiness in the test. This CL adds an explicit observer for the subframe navigation and updates the test expectation to reflect the fact that the subframe is in a separate process than the parent. Bug: 662160 Change-Id: I40efc406818f572243720d8feaff2dd597262a5d Reviewed-on: https://chromium-review.googlesource.com/1155255 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580022}
-
Evan Stade authored
Tested via --ash-debug-shortcuts and Ctrl+Alt+Shift+T Bug: 854704,760811 Change-Id: Ia3aadae89fcd50d95a84fdf7d275e97bc2e9e2e9 Reviewed-on: https://chromium-review.googlesource.com/1152230 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580021}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2d1d2dbd58a..cc73f241145d git log a2d1d2dbd58a..cc73f241145d --date=short --no-merges --format='%ad %ae %s' 2018-08-01 jmadill@chromium.org Micro-optimize some validation checks. 2018-08-01 jmadill@chromium.org Final cleanup to ValidateDrawAttribs. Created with: gclient setdep -r src/third_party/angle@cc73f241145d The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I64516ed6f57faa643ef9e6b6a96cbb7d9e16f6bf Reviewed-on: https://chromium-review.googlesource.com/1159441Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580020}
-
Carlos Knippschild authored
With Offline Page being fully deployed there is no need anymore for the UI-exclusive flag that was introduced in its very beginnings, as a means to have its pipeline tested without any visual clues of its existence. This change removes that flag that and consolidates all UI related checks on the main feature flag that still remains in place. Bug: 850588 Change-Id: If30bbf36b8361a5af69bf59a748600d5fd1e71ea Reviewed-on: https://chromium-review.googlesource.com/1157526Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#580019}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifc1cef2d5690079e95fb7fda9c6ae5e81fbd7b57 Reviewed-on: https://chromium-review.googlesource.com/1159581 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580018}
-
Mohammad Refaat authored
Tests are failing because clipping is disabled for iOS 12 by this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1158566 Bug: 860790 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icffec0a18d6775c24195093f900d00343ac22b6a Reviewed-on: https://chromium-review.googlesource.com/1159696 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
-
Johannes Henkel authored
Change-Id: I7fc667a8bfd72c8896848a9443f8ff6abc2cdf38 Reviewed-on: https://chromium-review.googlesource.com/1159240 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Eric Karl authored
Currently VizProcessContextProvider assumes no alpha. Android needs alpha in cases where it is rendering on top of a video overlay. Plumb the alpha request through via RendererSettings. Bug: 869131 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c51a07b141e61d95b2e25183156ebf15daeca38 Reviewed-on: https://chromium-review.googlesource.com/1155715Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#580015}
-
Martin Kreichgauer authored
In 9aa7c545 AuthenticatorImpl::IsUserVerifyingPlatformAuthenticatorAvailable was changed to make Touch ID unavailable in Incognito and if the embedder does not provide a configuration for the Touch ID authenticator. The latter check dereferenced a nullptr in AuthenticatorImpl's request_delegate_. request_delegate_ only gets initialized for the duration of a MakeCredential or GetAssertion request. It is uninitialized during IsUVPAA. This works around the issue by adding a IsWebAuthenticationTouchIdAuthenticatorSupported instance method to ContentBrowserClient, so that the feature support can be checked without requiring a request delegate instance. Bug: 869651 Change-Id: Ib64a2278d63047d68876e224d44a9aab96f9cfea Reviewed-on: https://chromium-review.googlesource.com/1157605Reviewed-by:
-
Kyle Horimoto authored
This CL passes a MultiDeviceSetupClient to MultideviceHandler and utilizes it to pass data about the current multi-device host to the settings page. Additionally, this CL adds functionality to the TestWebUI class which allows it to store and respond to registered callbacks in WebUI. A follow-up CL will add functionality which provides the status of the various multi-device features (e.g. Instant Tethering) to the settings page as well. Bug: 824568 Change-Id: I5665e225122e7a2875150f61cef77aaf770298d9 Reviewed-on: https://chromium-review.googlesource.com/1157268Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#580013}
-
Sarah Hu authored
Bug: 864549 Change-Id: If79c0100067c62a9fedb3119f43813a87d5bd6c6 Reviewed-on: https://chromium-review.googlesource.com/1145864 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580012}
-
Joel Einbinder authored
This patch calls preventDefault on all events that we forward from extension panels into devtools. This would cancel too many events, so a list of devtools global keyboard shortcuts are passed into the extension. Bug: 682068 Change-Id: Ide557dafed759e20dfc6698d8cdc33f932acbe83 Reviewed-on: https://chromium-review.googlesource.com/1159467Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#580011}
-
Sergey Ulanov authored
Now a process that creates a WebContext must pass a service_directory handle. That directory is mounted as /svc in the context process. Also renamed dataDirectory->data_directory, which is a proper struct member name according to the FIDL style guide. Bug: 869216 Change-Id: I63af58a472edf0d45b79b0108082fffcac6eaa72 Reviewed-on: https://chromium-review.googlesource.com/1157196Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580010}
-
Xiaoqian Dai authored
If a window has transient children, the transform that's applied during dragging should be adjusted for the transient children. See before https://drive.google.com/open?id=1BK_AlNAFGJR9eDZdgvf5MY_rsWaB0YXe and after https://drive.google.com/open?id=12Mg8VHaEhpTEC40VLHImZC9NroWMayDA Bug: 823769 Change-Id: Ic04739d8327b5febffcc9ff4430ce1db52ba3194 Reviewed-on: https://chromium-review.googlesource.com/1152505 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#580009}
-
Adrienne Walker authored
Before this patch, there's no way to use --profiling-at-start or --profiling-flush to generate a profile of the gpu process, because these flags weren't being forwarded there. Change-Id: Idca9fd8daa9d67e91bb7270d6225b9255434e014 Reviewed-on: https://chromium-review.googlesource.com/1159393Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#580008}
-
Mitsuru Oshima authored
Bug: 869429 Test: covered by unittest Change-Id: I192d74e0dd467238af2bf0db7e7e37b5df69ed81 Reviewed-on: https://chromium-review.googlesource.com/1156881Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#580007}
-
Muyuan Li authored
Bug: b/77916222 Change-Id: Ic2efb6e21d243bf5c19554dbdd35773ef082e12b Reviewed-on: https://chromium-review.googlesource.com/1132624 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580006}
-
Anand K. Mistry authored
BUG=862892 Change-Id: Ib36cf0f8fdaadae0b9170ec3823d31e0fd398187 Reviewed-on: https://chromium-review.googlesource.com/1152638 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
The dragging behavior is the same with dragging an app window from the top of the screen. As it shares some same logic with dragging an app window, these logic are extracted to TabletModeWindowDragDelegate. See recorded video: https://drive.google.com/open?id=1d6t7K-ZuxgpT57b-Mx5gMJ49IjMHX-9X Bug: 823769 Test: SplitViewTabDraggingTest.OnlyAllowDraggingOnCaptionArea Change-Id: I09d852ef9eefd1059f2be85fee52e1714b1968fd Reviewed-on: https://chromium-review.googlesource.com/1150860 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Lu Chen authored
Add recording of AnchorElementMetrics.*.HrefEngagementScoreExternal. Bug: 850624 Change-Id: I049b5847beb76a80a7c30077373f50079cee061c Reviewed-on: https://chromium-review.googlesource.com/1157551 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#580003}
-
Renee Wright authored
Bug: 869734 Change-Id: Ie863c125d49c351b79f5b072bc20535a75dd8d6a Reviewed-on: https://chromium-review.googlesource.com/1157963Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/68b5e7dbc095..134364159fa8 git log 68b5e7dbc095..134364159fa8 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 jessehall@google.com [mali importer] Add Exynos Mali job event parser Created with: gclient setdep -r src/third_party/catapult@134364159fa8 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2dfb839946b066aa315b73b91f3be6d662200327 Reviewed-on: https://chromium-review.googlesource.com/1159421Reviewed-by:
-
