- 14 Jan, 2021 40 commits
-
-
Adam Langley authored
This change adds support for version two QR codes, with “low” error correction. This configuration matches how other platforms generate eSIM QR codes. Additionally, since version two QR codes are smaller, their blocks can be displayed with more pixels each, so a lower level of error correction is reasonable. Change-Id: I7f42239835f3d5c6c981b9c73680247858cc0f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623842 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#843693}
-
Ana Salazar authored
For tote, users should be able to clear the selection by clicking or tapping on the bubble background. Bug: 1146145 Change-Id: Ibaabe09ae6f6b5dfb73581e1169d0a2d46651ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628075 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843692}
-
Nina Satragno authored
Chrome should not attempt to write a large blob that exceeds the maxSerializedLargeBlobArray reported by the authenticator. Fixed: 1143767 Change-Id: I2cc4f553c131655e75d7cd5380092d1747e09708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626412 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Philipp Hancke authored
BUG=None Change-Id: I6941d9b5ecf5715297fe794717d6a649521e4b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627402Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#843690}
-
Daniel Rubery authored
This CL adds two new base::Features, SafeBrowsingEnterpriseCsd and SafeBrowsingDisableConsumerCsdForEnterprise to control whether using the Enterprise CSD server is enabled. It also makes two behavior changes depending on these flags. When enabled: - The consumer download ping is skipped - The |csd| field in the upload request is populated with the download metadata. Bug: 1165815 Change-Id: I00e3cc17ed56eff93803ab50232bb00497667afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626031 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843689}
-
Josh Nohle authored
Bug: 1157278, 1164572 Change-Id: I463c7c6fd65690f26004331a3475700ee0677351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629869 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843688}
-
David Black authored
Though the entire downloads section header is focusable and behaves as a single button, the focus ring is drawn as a circle around just the chevron. Screenshot: http://shortn/_yNqR9nC2Pk Bug: 1160011 Change-Id: Ie58083966e5bf1d01b09472cc7271b978741b91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628747 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Lachlan Ford authored
definition. https://github.com/immersive-web/webxr-input-profiles/blob/master/packages/registry/profiles/generic/generic-hand-select-grasp.json The grasp type exposes it as the correct button and does not trigger the squeeze events. Change-Id: I5041633e39f7f6b9bbc86bd379be64eeadc1055c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628888Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843686}
-
Sinan Sahin authored
This CL delegates the Animator#start calls in MessageBannerMediator to WindowAndroid#startAnimationOverContent. Bug: 1159429 Change-Id: I865e62718efa46eae8e1bf733271854475edaa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628497 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#843685}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/72c58a865b57..d392af02b749 2021-01-14 natsu@google.com Update roll AOSP scripts to reflect vulkan-deps subdirectory 2021-01-14 timvp@google.com Fix call to getImageFormatFeatureBits() in SurfaceVk.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: scripts/roll_aosp.sh && m ANGLE Change-Id: I96aa44f7caf98b92a2309a82c98ed50e60891ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843684}
-
Francois Doray authored
This is a cleanup prior to fixing crbug.com/1164477. It improves readability by removing code that handles situations that never occur. Bug: 1164477 Change-Id: Ia9356857eb82e75d8d3527e278036c12dfdc636d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618183 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843683}
-
Anders Hartvoll Ruud authored
This CL adds the StyleRecalcContext param to StyleForLayoutObject, OriginalStyleForLayoutObject, and all the CustomStyleForLayoutObject overrides. Bug: 1145970 Change-Id: Ib2453eb8920e2d478d8f1436c1b37f7e5ba55b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627388 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843682}
-
danakj authored
Step 5 for bug 1125106. This is a rework from part of the mega-patch in https://chromium-review.googlesource.com/c/chromium/src/+/2462248. Navigating on an error page should always be done as cross-document in order to attempt to reload the page. We should make this decision in the browser process directly instead of round-tripping through the renderer. This builds on the work of rakina@ in https://crrev.com/c/2581659 that did the same for history navigations. We use the same is_error_page() bool and also prevent same-document navigations from being attempted in non-history cases. The switch from same-document to cross-document is moved to a location that is shared between both code paths. A NOTREACHED() is added to the blink code that shows our navigation tests that navigate on an empty 404 page do not round-trip through the renderer anymore. This will become a CHECK() in the future as the RestartAsCrossDocument paths are removed. R=nasko@chromium.org, dcheng@chromium.org Bug: 1125106, 1147759 Change-Id: I2afaccf3de7764699aa6bb04c530d09f66f292b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626783 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843681}
-
Daniel Murphy authored
If the user starts chrome by launching the WebApp that is being migrated from, then Chrome crashed due to shutting down while the browser object is still being used by the migration code. This patch ensures that the browser doesn't exit during migration, and only keeps the browser alive during the migration itself. Note: This WebAppMover is not a permanent class, and will be removed after the Chat app is successfully migrated. Design Doc (Googlers only): https://docs.google.com/document/d/1GOek_Q4O_jTewHHx0MLnbYXvlTdEKT-KmkPZ5R0VJ3c/edit?resourcekey=0-K35fuzesohP36-qKSGbp0g Bug: 1165603 Change-Id: I3a38402513e3dacdd05b5d516b01f371043d5206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622584 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#843680}
-
Xianzhu Wang authored
This reverts commit 91c206e0. Reason for revert: The original CL accidentally removed some RuntimeEnabledFeatures::CompositeAfterPaintEnabled() guard. Fixed in this reland. Original change's description: > Revert "Add CullRect::ApplyPaintProperties()" > > This reverts commit 6f895b07. > > Reason for revert: The reverted CL is supposed not to affect > production, but it seems to cause crbug.com/1166540. > > Original change's description: > > Add CullRect::ApplyPaintProperties() > > > > It will be called to map a cull rect from parent space to local space > > in cull rect update during PrePaint. The purpose is to mark PaintLayers > > needing repaint on cull rect changes before paint, instead of checking > > interest rect / cull rect changes during paint, to avoid setting > > PaintLayer needing repaint unnecessarily, especially for CAP during > > composited scrolling. > > > > Besides the original features of CullRect::ApplyTransforms() which is > > used in cull rect mapping for CompositeAfterPaint, it also implements > > the following features to be on par with CompositedLayerMapping:: > > ReComputeInterestRect(): > > > > - Considering clips in additional to scroll clips, > > - Clipping expanded cull rect by scrolling contents rect for composited > > scroll translations, > > - Clamping extreme geometry values, > > - Adaptive expansion distance for composited transforms. > > > > The next steps are: > > 1. Add CullRectUpdater which updates cull rects during PrePaint when > > runtime feature CullRectUpdate is enabled. > > 2. Use the updated cull rect to replace interest rect in pre-CAP and > > cull rect in CAP and pre-CAP, still behind the runtime feature. > > 3. Enable CullRectUpdate for CAP > > 4. Enable CullRectUpdate for pre-CAP. > > 5. Remove old interest rect / cull rect code. > > > > Bug: 1046544 > > Change-Id: I6e7e9f85bc0b4640e67de1732744e647b6f7e230 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620090 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#843304} > > TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Idc3374d3d426b9f571e417b1acbbc18227fdf274 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1046544, 1166540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628021 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843592} TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1046544 Bug: 1166540 Change-Id: Idb93eed1ab34750cfd1c0903551ba8fd66102354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628383Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843679}
-
Daniel Hosseinian authored
Bug: 93619 Change-Id: I6c63eb0381d2a005e224d83b3075fcae9fab9ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629671 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843678}
-
Francois Doray authored
This is a cleanup prior to fixing crbug.com/1164477. It improves readability by removing code that handles situations that never occur. Bug: 1164477 Change-Id: I3251051a3f66283853bf551c29284595621bd759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616354 Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9513255f7c36..2a1c2dea7350 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1159788 Tbr: davidvc@google.com,adithyas@google.com Change-Id: Ia3a93a12e1a74a7e49e7f5cf018975840e5a0ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629787Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843676}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I484e3e5519b7a483cdb2a3ae553529534d1265ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626006 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843675}
-
Anthony Cui authored
On desktop, if the page has already been translated then the manual translate option in the context menu is disabled. Instead, keep the option enabled, and when selected re-surface the translate bubble UI without triggering a new translation. On Android, the menu option is enabled but does not perform any function. Instead, follow the same strategy and re-surface the UI without a new translation. Bug: 1024514 Change-Id: Ide42c3deead6ca5839ff03daff1c790084759a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622383Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#843674}
-
Ben Mason authored
R=benmason@chromium.org Change-Id: I6aa479830127ebba47dd306244a3889fa74de5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629570 Auto-Submit: Ben Mason <benmason@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#843673}
-
Robert Ogden authored
tbansal is histograms review for this project. Change-Id: I8de8ee4cc1ca106492c169156a03cb2f8daf01a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622428Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#843672}
-
Claude van der Merwe authored
Bug: 1106937 Change-Id: Ie4f3bf85e2dbddd232d4746e730a1e942f2587c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626604Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#843671}
-
Claude van der Merwe authored
Bug: 1117619 Change-Id: I1ce7cbfdd8da85fff0a584bd2f8254075ea305f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628209Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
-
Rakib M. Hasan authored
mb_config.pyl This Cl allows people to set the webview package name to com.android.webview when compiling skew tests. This package name is necessary on Android M and 10 x86 emulator builders. Test: Compiled binaries locally using mb_config.pyl Bug: 1163652 Change-Id: I968ab22359283caa9a5855f4b073df6ab5147b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628651Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#843669}
-
Gavin Williams authored
Create a new Scanning specific metrics handler to allow recording metrics directly from the UI layer. When scan job submitted, record the source type, file type, color mode, page size, and resolution settings. Bug: 1059779 Change-Id: Id3d46a617aa798ddc468aa9085c0f48854c2b737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601156 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#843668}
-
cfredric authored
FirstPartySets. Change-Id: Ic63b56cc0e6c425b950975a65ece8e1085a8447e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627094 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843667}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/247f511f198f..d2fb128052ae 2021-01-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from a7b52e33d5e8 to 0f4638b9e499 (2 revisions) 2021-01-14 dsinclair@chromium.org Update texture storage syntax. 2021-01-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 904c5b9621da to a7b52e33d5e8 (3 revisions) Also rolling transitive DEPS: https://dawn.googlesource.com/tint from 904c5b9621da to 0f4638b9e499 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I5695a7afa936b6ceeddd30cd5b4dd4353ba2ff2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627171Reviewed-by:
-
Richard Chui authored
The feedback button on the capture bar was only intended for use during the M88 dogfood, so this CL removes it for M89. Test: manual, removed test Change-Id: I2afe96e3f7860fa502cdbc5f62fc733b3ab43848 Fixed: 1144254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628744Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#843665}
-
Lijin Shen authored
When clank is switched from phone layout to tablet layout, the image will be set as the background of toolbar until the compositor is ready to clear the background. The existence of the bg image yields an unexpected height measure of the toolbar, which moves the toolbar upwards. Bug: 1157859 Change-Id: I27566156e8015abbb09bd0ae3a03ac1a1b2ee527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623124Reviewed-by:
-
Ross McIlroy authored
BUG=v8:9684 Change-Id: I91f0abfec542b81daaf113e8e7982d661ef7fdd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629514 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#843663}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: If47f8b9812eb28cc5f8c3c1ca4deb9978f3ea494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628929Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843662}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610614773-04b9d3e4229c2110629eb37dfecb509103b5731f.profdata to chrome-win32-master-1610625483-d2f1e02797211441cbc7cf411236f83624a240c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6dd9cc81f24e65dd786e614c5ae9d4d36ec65bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629669 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Eric Willigers authored
This reverts https://chromium-review.googlesource.com/c/chromium/src/+/2626687 as Impression::impression_data is initialized due to https://chromium-review.googlesource.com/c/chromium/src/+/2625293 Bug: 1165985 Change-Id: I6dbcb17c9f1f31487e2f1ba3b2da6febd906a8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627190 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843660}
-
Muhammad Hasan Khan authored
BUG=1165220 TEST=none Change-Id: I1aa6eed9ffa83df65019ec23b2763ba427d4e3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622004Reviewed-by:
-
Jarryd authored
* Add three new testing journeys to the test cases input file. * Implement |assert_app_in_list_not_windowed| testing action. Bug: 1156693 Change-Id: Icd01b43ff2bfaec12a136e232d46376707c5d168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625527 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#843658}
-
Yuta Hijikata authored
This change is a mechanical change replacing is_chromeos with is_chromeos_ash. This is in preparation to switching lacros from target_os="linux" to target_os="chromeos". More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I714585aea9ccd0973551c89fc535331b39ce713d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628710 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
minch authored
Bug: 1158583 Change-Id: I9c444c57c86d368477827f48f75cf9fd3197d117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623714 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch changes list markers to use custom counter style to generate counter text and calculate marker margin. The major complications are: - Predefined symbol marker styles ('disc', 'circle', etc.) require special handling, especially for margin calculation and painting - Legacy ListMarkerPainter paints marker text and prefix/suffix as separate text runs instead of a whole string Test failures are due to predefined counter styles not implemented as @counter-style yet, or not implemented exactly the same as the existing (non-custom) behavior. This will be fixed by follow up patches. Bug: 687225 Change-Id: Icf5468c6f12358aed291dbf60d75cc79ac7fdc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596826Reviewed-by: -
Yao Xiao authored
Incognito doesn't save history at all, so avoid calling HistoryService::SetFlocAllowed in incognito. Also don't set it when the history service is null. This aligns with the pattern elsewhere (e.g. calling hs->UpdateWithPageEndTime inside HistoryTabHelper::WebContentsDestroyed). Besides, this is a speculative fix for the crash crbug.com/1166194, as dereferencing a null history_service can trigger undefined behavior. Bug: 1162874, 1166194 Change-Id: Icb3adbd4ce311d4153bfd2b08b2bd43c4b4aa726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628927 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#843654}
-
