GitLab

our Coverity overlord.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/149155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Coverity should stop complaining about this leak.

Review URL: http://codereview.chromium.org/149153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19886 0039d316-1c4b-4281-b951-d872f2087c98

Hide menus when the window is blurred or the user presses Alt or Meta.

Only show tootlip for the title of the thumbnail.

Allow mouse over on the window menu.

Made the windows opaque but with a hsla background color to make it more readable.

Quote all background image URLs so that we can display icons for URLs with spaces in them.

Call preventDefault when using the keyboard to navigate the options menu so that the page does not scroll.

BUG=15268, 15503, 15715, 15769, 15411, 15458

TEST=See bug descriptions

Review URL: http://codereview.chromium.org/149163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19884 0039d316-1c4b-4281-b951-d872f2087c98

Update layout test expectations so that LayoutTests/plugins/netscape-plugin-map-data-to-src.html is grouped with the rest of all the failing plugin tests on mac.
Review URL: http://codereview.chromium.org/155034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19883 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19882 0039d316-1c4b-4281-b951-d872f2087c98

The layout test LayoutTests/fast/js/navigator-mimeTypes-length.html asserts
that the number of mimetypes handled by plugins should be greater than the
number of plugins.  This isn't true if the layout test plugin is the only
plugin and it only handles one mimetype, so we make it handle an additional
fake mimetype.

Review URL: http://codereview.chromium.org/149146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=13907,15664
TEST=media layout tests should no longer unexpecedtly pass

Review URL: http://codereview.chromium.org/149133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19880 0039d316-1c4b-4281-b951-d872f2087c98

Modify ThumbnailStore to make one call to the HistoryBackend using QueryTopURLsAndRedirects instead of a seperate call for each URL.  Also clean up some of the code and fix bug 14644.

BUG=14644
TEST=none

Review URL: http://codereview.chromium.org/149126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19879 0039d316-1c4b-4281-b951-d872f2087c98

Hard code the DOM and the layout for the default case so that we do not
need to do any js layout at startup.

Be more careful when calling layout. I added a dirty bit so that we
don't layout too often.

CSS cleanup/optimization to make selectors faster.

TEST=Run the perf test

BUG=13362

Review URL: http://codereview.chromium.org/149127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19877 0039d316-1c4b-4281-b951-d872f2087c98

We had some undefined symbols in webkit_glue.

Review URL: http://codereview.chromium.org/149162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=n/a

Review URL: http://codereview.chromium.org/150211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/15500
TEST=select an image in a file chooser

Review URL: http://codereview.chromium.org/151100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19874 0039d316-1c4b-4281-b951-d872f2087c98

TEST=along with <http://codereview.chromium.org/151100>, it's possible to preview jpeg images
BUG=none

Review URL: http://codereview.chromium.org/151163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=4202
TEST=added regression test.
Review URL: http://codereview.chromium.org/149143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19872 0039d316-1c4b-4281-b951-d872f2087c98

height = 29 matches windows constant
padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows.

BUG=http://crbug.com/15882
TEST=look at bookmark bar

Review URL: http://codereview.chromium.org/155019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19871 0039d316-1c4b-4281-b951-d872f2087c98

TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug
BUG=http://crbug.com/15844

Review URL: http://codereview.chromium.org/149151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19870 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/15859
TEST=see bug

Review URL: http://codereview.chromium.org/155008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19869 0039d316-1c4b-4281-b951-d872f2087c98

A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.

A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.

TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images.
http://crbug.com/13967

Review URL: http://codereview.chromium.org/150176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19867 0039d316-1c4b-4281-b951-d872f2087c98

The current implementation only allows getting file size
if the child process has been granted permission to upload file.
May need to update the policy checking code if getFileSize
is needed in other cases.

Here is the webkit implementation to support this:
https://bugs.webkit.org/show_bug.cgi?id=26521

TEST=none
BUG=9102

Review URL: http://codereview.chromium.org/131082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19865 0039d316-1c4b-4281-b951-d872f2087c98

Turning async loading off to get the beachdemo to work again in IE.  This is logged as issue #82.  Once it's fixed, we should turn async loading back on.
Review URL: http://codereview.chromium.org/155028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19864 0039d316-1c4b-4281-b951-d872f2087c98

Fixing the check for offscreen. If the variable doesn't exist, then the function will return 0 and off_screen should be false.

Review URL: http://codereview.chromium.org/149157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15784


Review URL: http://codereview.chromium.org/155001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19862 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/1455

Review URL: http://codereview.chromium.org/149156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/74002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19860 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/147237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19859 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
BUG=15892
TEST=none
Review URL: http://codereview.chromium.org/149158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19857 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19854 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19851 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19850 0039d316-1c4b-4281-b951-d872f2087c98

TEST=these
BUG=15873


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19849 0039d316-1c4b-4281-b951-d872f2087c98

TEST=disabled a couple
BUG=15873

Review URL: http://codereview.chromium.org/155013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19848 0039d316-1c4b-4281-b951-d872f2087c98

Times out too often under Valgrind on Mac
Tracking bug: crbug.com/15817

Review URL: http://codereview.chromium.org/150218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15854
TEST=none

Review URL: http://codereview.chromium.org/149141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19845 0039d316-1c4b-4281-b951-d872f2087c98

- Disconnect ports properly (javascript mistake).
- Use the right port ID when dispatching the disconnect event.
- Fix a bug with 2 extensions loaded in the same process.

BUG=12686
BUG=15798
TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting.

Review URL: http://codereview.chromium.org/152003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98

I removed the extra argument from WidgetGTK::Init but didn't update these sites.

Review URL: http://codereview.chromium.org/155006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19843 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19842 0039d316-1c4b-4281-b951-d872f2087c98

actions. One for the helper function that parses
a page action from the manifest and another that
tests the page action api.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/151181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19840 0039d316-1c4b-4281-b951-d872f2087c98

GTK: when doing a drag from a web page, pass a recent mouse down to gtk_drag_begin() so it has a better idea what time to pass to gdk_grab_pointer().

I believe the following was happening:
- render view gets mouse down, forwards to webkit
- render view gets motion, forwards to webkit
- user releases mouse button, that event is added to the queue
- browser gets message from webkit that a drag has begun, calls gtk_drag_begin() with no event
- gtk_drag_begin initiates a cursor grab, but it only applies to events that have not yet been added to the queue
- mouse release comes up in queue; passed to render view rather than the drag widget

TEST=You can't get stuck in really short render view drags. Whereas it was really easy to repro before (especially in Xephyr), I can repro no longer.
BUG=http://crbug.com/15768

Review URL: http://codereview.chromium.org/150204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19839 0039d316-1c4b-4281-b951-d872f2087c98