- 29 Jul, 2020 40 commits
-
-
Mei Liang authored
Getting the value of a null IntPropertyKey from a PropertyModel returns 0. This behavior causes the StaticLayout not setting the tab correctly when the tab id is 0, which leads to the blank page issue. This CL fixes this issue by initializing the TAB_ID IntPropertyKey to Tab.INVALID_TAB_ID. Bug: 1108693 Change-Id: I929b16327c2b7f57e7acd698ed235eadfdc0bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327187Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792864}
-
Stepan Khapugin authored
Adds a new helper, IsMultipleScenesSupported(), for runtime checks when multiple scenes can actually be entered. Replace some usage of IsMultiwindowSupported() with IsMultipleScenesSupported(). Bug: 1108774 Change-Id: Ia35253d73e53e1cabddad1c3452675f2832e55eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323336 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792863}
-
Matt Menke authored
This is no longer in use. Previously, it was used by the data reduction proxy. This was also the only code path that could race proxied and direct connections, so removing it lets us slim down tests a bit. Bug: 1109329 Change-Id: I463f55e02d67eeaa894375659dfb515df5b6ba84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324174Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792862}
-
Dylan Cutler authored
We can reuse this function to convert WTF::String to an IdentifiableToken instead of casting it to a sequence of bytes. Bug: 973801 Change-Id: I5dacf615f06ca777eaae7dbd5884dfa21a4a867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323311Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#792861}
-
Leonard Grey authored
This is the core of the Commander. It: - Receives input from the UI and responds with view models - Handles coordinating multiple sources of commands - Sorts and filters results - Serves as an intermediary between the view and a secondary backend if a composite command is being entered Bug: 1014639 Change-Id: Ife8022e5e5471cbe6dc794823f7acf1de7023d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304970Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#792860}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1596023419-4b4a08e94302fde0805a3dccb841fbad1e992234.profdata to chrome-mac-master-1596045560-aec562928bab06d0692bf930829a43aa15a04f06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I566696066f0836c98ffff1db5f50514ed48c54fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792859}
-
Xiyuan Xia authored
Add AutotestPrivateAPI to start/stop ui::ThroughputTracker data collection. Tast uses the API to collect data to calculate frame rate related sub score. Bug: 1098555 Change-Id: I4a135ef1bf7f96ceb77d0165e7db4a68bb792b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305109 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#792858}
-
David Tseng authored
This change: - adds the ability to swap between Autoclick and Magnifier in the same accessibility_common extension - fixes the accessibility_common_manifest_guest.json path; accessibility_common was actually not being loaded when using guest manifests (e.g. login screen) - adds starter class for magnifier R=katie@chromium.org AX-Relnotes: n/a Test: toggle all states of autoclick and magnifier: 0, 0; 0, 1; 1,0; 1,1. Verify the correct accessibilityCommon.autoclick_ and accessibilityCommon.magnifier_ objects get nullified/set and that the extension gets unloaded with 0,0. Automated tests tbd. Change-Id: I5bf2c25dd1a65403c07c5941c48129cd8ad86a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325131 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792857}
-
John Delaney authored
Adds Blink Usecounters for impression registration, conversion registration, and a composite usecounter for both of those events. These are necessary to measure the percentage of page loads using the API, for running an origin trial. A new test harness is added in the chrome/ layer to verify that metrics are recorded as expected. Bug: 1109079 Change-Id: I2f70bb3a2eac60ff45a5654169b4db959fd1d3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314843 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#792856}
-
Stephen Roe authored
Bug: 1067356 Change-Id: I8c22d44b774ece4135980d47df12bab4c9152dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317860 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#792855}
-
Rouslan Solomakhin authored
Before this patch, there was no way to display the secure payment confirmation UI for demo and development. This patch adds a chrome://flags/#force-secure-payment-confirmation-dialog flag that makes all PaymentRequest.show() call into the secure payment confirmation dialog UI instead of the regular browser payment sheet. After this patch, enabling the chrome://flags/#force-secure-payment-confirmation-dialog flag allows demo and development of the secure payment confirmation dialog UI on such demo pages as https://rsolomakhin.github.io/pr/cc/, for example. Bug: 1110322 Change-Id: I598e2bf2b2bdddc2bb6505939cc6c595fb2cd781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325031Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792854}
-
Yuly Novikov authored
Timing out due to https://chromium-review.googlesource.com/c/angle/angle/+/2280401 Ignore-CQ-Freeze: improves bot stability Bug: 1110445 Change-Id: I72af8f6627e5d654774207b345e4176cf020367e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327570 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#792853}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ab07b2bef2ac..d019af80a3a9 2020-07-29 jmadill@chromium.org Capture/Replay: Fix missing header. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I279d78755ebb1d0e139462fc01661466c8839ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327031Reviewed-by:
-
Thomas Lukaszewicz authored
Include mixinBehaviors from polymer/lib/legacy/class.js to allow reuse of Polymer behaviors with the non-legacy class based Polymer3 syntax. Increase in the minified bundle by 125 bytes. Bug: 1099917 Change-Id: Ia9c51e5a5672926d922fd0f66fb26d9fbcb760f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324810 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792851}
-
Scott Little authored
This CL cleans up unnecessary copies of std::strings and other objects in components/translate/core/browser/translate_prefs.cc, as well as some miscellaneous cleanup in this file. This CL does not change any functionality, and is only clean up. Bug: 1109032 Change-Id: I930d64accbf14e0b4163728a8ce23c1028e3f531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321768 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#792850}
-
Yue Li authored
No longer need to hide voice match settings option. No longer need to show opt-in flow instead of voice training flow. Update browser tests. browser_tests Bug: b/132107317 Test: run OSSettingsGoogleAssistantPageTest.AllJsTests in Change-Id: I518603672ef06f7b849532adf23581abfaeb56b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322066Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#792849}
-
Jan Wilken Dörrie authored
Following making invoke() constexpr this change also adds constexpr support to ranges::for_each. This is done by no longer dispatching to the std:: implementation, but rather implementing the loop ourselves. This change furthermore reduces the delta to C++20 by using the right return type for ranges::for_each, as well as adding an implementation of range::for_each_n. Bug: 1071094 Change-Id: Ic619f0c9926ef9c3e9fda4a67ab5e02bb5262402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325920Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#792848}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/53be1753dea9..3273521f4089 $ git log 53be1753d..3273521f4 --date=short --no-merges --format='%ad %ae %s' 2020-07-28 anujv Fix static compilation with Visual C. 2020-07-28 wl Formatting, improving comments. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I769d982f8905adcbc18561810474204f02e8a572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327131Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792847}
-
Steven Bennetts authored
Forgot to remove the 'hr' class when moving the toggle to Advanced in the previous CL. Bug: 971704 Change-Id: I4167393fc2883dd54b86cc7f61b15973ff31d6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327271Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792846}
-
Brandon Wylie authored
Bug: 1110939 Change-Id: I036b69711124ea89b4d2c008e31997000abb475d TBR=mahmoudi@chromium.org Change-Id: I036b69711124ea89b4d2c008e31997000abb475d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326770Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792845}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I1af1d0a3e595d1bc1dc6ab380743834a71b03777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324214 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792844}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Iced94df0bfda68ba8f04792a88dd136395621ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324900Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792843}
-
Avi Drissman authored
Because content is not used by iOS, this migrates defined(OS_MACOSX) -> defined(OS_MAC) Bug: 1105907 Change-Id: Ibf85273fea9c5566594ca00f2589b890515be6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321210 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792842}
-
Avi Drissman authored
Because /chrome is not used by iOS, this migrates defined(OS_MACOSX) -> defined(OS_MAC) Bug: 1105907 Change-Id: Ia85816af50aced9b21492bb5b6b2ceb7c5364692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321509Reviewed-by:
-
Sven Zheng authored
CI/CQ bot are being added and there are name conflicts. So we need to rename the fyi bot first. Bug: 1104291 Change-Id: Id36bf46a0b184e33f459195183d6f3809ff3d441 Ignore-CQ-Freeze: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321336 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792840}
-
Peter Marshall authored
Change-Id: I25ce97dfbab621bacc5818cb4b04c1778f39513f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323290 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792839}
-
Scott Little authored
This cleanup CL changes no functionality, it just cleans up some functions in components/language/core/common/locale_util.cc to use base::StringPiece instead of std::string where needed, as well as updating the callers of these methods accordingly. This CL also moves language::ContainsSameBaseLanguage into an anonymous namespace in the single file that it's called from. Change-Id: Ia2f8be1361b976e96aba95d78c59b88697343729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316811 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
-
Adrienne Walker authored
When transactions are aborted, any get all operations should still send an error with a valid receiver. This avoids a dcheck (and probable crash later) from mojo due to passing a null receiver. Bug: 1110781 Change-Id: If142072cae93f29dc3d4c1ac388bc27a3f3939f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324525 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792837}
-
Wei Li authored
Make MenuItemView's delegate an optional argument in its constructor so it can be default constructed. Its delegate can always be set thru the existing set_delegate() function. Also need to add a few more checks for the return delegate pointer. Bug: 1108460 Change-Id: Ie90709271c971cadccf3e13166df0c240d73dfca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321526Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#792836}
-
Michael Crouse authored
This is a reland of f672068e The tests timeout with closing the tab right after the navigation, so wait to close the tab until after the histograms are recorded. Original change's description: > [LiteVideo] Rework UKM to record on DidFinish and WCO destruction. > > This change resolves the UKM recording and ties it just to the > mainframe decision and result. It also flushes when the web contents > observer destructs. A future change will update the event on > rebuffers and consider more events for subframes. > > Bug: 1109068 > Change-Id: Iacd04920811d96c4eedd3290309a8bad93777b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321520 > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792513} TBR=tbansal@chromium.org Bug: 1109068 Change-Id: I99b458c593ea1b430fe5f35cbd8af4554942a3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325247 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#792835}
-
Brandon Wylie authored
Bug: 1110965 Change-Id: Ieb3ef6f6d76e8dc9ce1d5a0e50e029e3378bf641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327310Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792834}
-
David Grogan authored
When a flex item is a relayout root, it gets neither the flexed nor stretched dimensions from the parent flexbox. Though this problem seems to manifest only when the flex item is a legacy layout node. This change causes a 5% regression in the change-text-css-contain perf test, even though it doesn't use flex, probably just because we test for flex-item before deciding that a node with `contain: layout size` can be a layout root. Bug: 1108675 Change-Id: Iec0d35557ebfbf3136bd66fe986ba2456e0d92ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322074Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792833}
-
Avi Drissman authored
Because /chrome is not used by iOS, this migrates defined(OS_MACOSX) -> defined(OS_MAC) Bug: 1105907 Change-Id: I96d640781fb66f8ff16129736de112025a9508ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321407 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8c02e882a3f2..4a89ed360b5f 2020-07-29 janscheffler@chromium.org [TypeScript] Migrate `front_end/source_frame` to `devtools_entrypoint` 2020-07-29 jacktfranklin@chromium.org Copy sourcemaps into resources/inspector in is_debug mode. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2fd74219fe792fd7184ded977a84af41964d156e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327390Reviewed-by:
-
Nate Fischer authored
This adds setSafeBrowsingAllowlist (behind the DEV_SUFFIX) and deprecates the setSafeBrowsingWhitelist boundary interface. These are functionally similar, although setSafeBrowsingAllowlist accepts a Set<String> since this is a more appropriate data type. This adds an UMA counter for the new API and adds missing enum labels for other APIs. This CL also renames a couple references to the old API to be SET_SAFE_BROWSING_ALLOWLIST_DEPRECATED_NAME instead, to minimize non-inclusive terminology. Fixed: 1108667 Test: N/A Change-Id: I49ef11e4346e631e14b822943abb6482837d60a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321523 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792830}
-
Boris Sazonov authored
Removes ChromeSigninController assert from PassphraseActivityTest. This assert was verifying that addAndSignInTestAccount succeeded, which is already ensured in SigninTestUtil.signIn. Bug: 1046412 Change-Id: Ib54efe5bbe3eb7434cdea161514d48f97387562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316083Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792829}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5f80a2e..cdda9dfe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4820379ed64d35ffe0e1189984ef2763f0bf462e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325781Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792828}
-
Hesen Zhang authored
This reverts commit dd04950b. Reason for revert: Need to hide the query tiles internals WebUI in Incognito mode. Alternative CL: https://chromium-review.googlesource.com/c/chromium/src/+/2327374 Original change's description: > Fix crash of query tiles internals in incognito mode. > > - TileService not support incognito profile. > > Bug: 1110285 > Change-Id: Ief1c8025b74ec5df94c5e811d213a6679fd6069c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324938 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792500} TBR=dtrainor@chromium.org,qinmin@chromium.org,hesen@chromium.org Change-Id: I7126c77cc412de10f9a6af2495d408dd7153fc1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327313 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792827}
-
Ken Rockot authored
This is a reland of 596311e0 Original change's description: > [WebLayer] Use NetErrorAutoReloader > > Navigations which fail with network errors may attempt to > auto-reload in some cases, in order to more seamlessly recover > from transient failures. > > This behavior was previously implemented renderer-side and copied > verbatim from Chrome. The Chrome implementation has been moved > browser-side (see bug for why) and also made into a reusable > component. > > This changes WebLayer to use the same component implementation > and deletes all the corresponding renderer logic. > > Fixed: 1098578 > Change-Id: I10c337abcae36f64be47f31b89e36c7393989077 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311371 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792028} Tbr: mmenke@chromium.org Change-Id: I4dd0aaef47650d14c52b6b2ddcf35cee27d2ef35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324934 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#792826}
-
Sophie Chang authored
Bug: 1108610 Change-Id: I427b51c39b8b62a33ad262d8b8e21b864709bff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324995 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792825}
-
