- 26 May, 2020 40 commits
-
-
Rachel Wong authored
We are planning to refactor PrivacyInfoView so that it can be used by both the Assistant and Suggested Content notices. This CL moves privacy_info_view first in order to make the main refactor CL (https://chromium-review.googlesource.com/c/chromium/src/+/2198848) easy to read. Bug: 1079169 Change-Id: I84bd1033cb84e6779225445f8b6992af8d9cacd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200559Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#772018}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b41316cd4c22..0d4647dffe2f 2020-05-26 tommi@webrtc.org Remove send_crit_, bitrate_crit_ and last_bandwidth_bps_crit_ locks. 2020-05-26 handellm@webrtc.org P2PTransportChannel::OnCandidateResolved: fix resolver leak. 2020-05-26 handellm@webrtc.org PhysicalSocketServer: remove heap-based epoll_event handling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:905542 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I68db2898fbd250bb1d1a718a1dbb7ed4ce00aa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772017}
-
Kurt Horimoto authored
This selector is triggered by overlay UI dismissal, which may occur after the active WebState is set to nullptr. Bug: 1085676 Change-Id: I62cde04911b19ae95b34e26e554c9c53dbed8260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213736 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#772016}
-
Ender authored
This reverts commit 8097a7d7. Reason for revert: we're now ready to enable this feature by default. Original change's description: > Revert "Enable Local-history ZPS for signed-out users by default." > > This reverts commit 43b20143. > > Reason for revert: we will be doing staged rollout and this cl would go live May 19 > > Original change's description: > > Enable Local-history ZPS for signed-out users by default. > > > > This change enables on-device history ZPS suggestions for users > > who are not signed in to Chrome on Android. > > > > Bug: 956837 > > Change-Id: I689960538b1087eac9355ba0b20da7310f5e3daa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132864 > > Commit-Queue: Ender <ender@google.com> > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755854} > > TBR=tommycli@chromium.org,ender@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 956837 > Change-Id: I5c199dd5fb814eb58a09b3dc20f5df23da17616b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176651 > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#764864} TBR=tommycli@chromium.org,jdonnelly@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 956837 Change-Id: I5711f95e7c28fe978626e919c52eb6f2d0b98c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215454Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#772015}
-
Alexey Baskakov authored
We should commit ScopedRegistryUpdate before calling the notification. Bug: 1069605 Change-Id: I161fa70218531b194a49c8c344a87bfd2f1005e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215396 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#772014}
-
Sammie Quon authored
When dragging a snapped / maximized window to a new display, and then snapping / maximizing it there, the restore bounds need to be parented to the new display. When snapping a window, we could have just converted the existing screen bounds to parent bounds, but it seemed better to just use parent bounds for the drag details data (screen is not required) and WindowState::SetRestoreBoundsInParent does conversion for us. Test: ash_unittests WorkspaceWindowResizerTest.MultiDisplayRestoreBounds Bug: 1084728 Change-Id: I631aa25b1b15d9c0141784f3469eb18cf8e59ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212972 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#772013}
-
Oriol Brufau authored
It used to be the case that setting 'grid-template-columns: inherit' and 'grid-template-rows: inherit' would also inherit 'grid-template-areas'. This got fixed as a side-effect of r747669, adding a test now. Bug: 966090, 1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-009.html Change-Id: I27865cd8e0533f2ba4380c94c0a51e2ef0decea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215858Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#772012}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a33a68071b63..934b9996ee4d 2020-05-26 reed@google.com try drawing underline with rect instead of line/path 2020-05-26 csmartdalton@google.com Don't test GPU configs on hittestpath 2020-05-26 johnstiles@google.com Improve doc comments for SkTArray. 2020-05-26 herb@google.com Make callback std::function 2020-05-26 nifong@google.com Wide color gamut support and working example. 2020-05-26 herb@google.com Revert "generate vertex data in onPrepare" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ib3a75f49bc9894b970e63291f18814b7eda23f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772011}
-
tby authored
The settings backend can return several results with the same canonical ID, but different display names. We want control over which of the duplicates is selected for display when this happens, so this CL does manual deduping rather than rely on the launcher's built-in version. See comment in DeduplicateResults for how we choose which result to use. Bug: 1068851 Change-Id: I92b3ca164dd2344ba35dc1b13c7701c2935b5fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213659Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#772010}
-
Chong Gu authored
Should add ~10 minutes of bot time and ~1 minute run time to each run. Bug: 1058255,1075803,1084174 Change-Id: I0f3cd12216cb7645ecdc79baaf5e9715e3b0c10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216600Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#772009}
-
Ben Pastene authored
With crbug.com/834134, the cache will auto-evict old items. So there's no need to clobber every time. Bug: 834134 Change-Id: Idec34923ff9c6a30ddc633ab212d22a96bf3282f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212507Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#772008}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I711695c3e8c21c86f798b24885fd07ee123463f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212011Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772007}
-
Maksim Ivanov authored
Add sequence checks that prevent incorrect (cross-thread) usage of CloudPolicyService. Bug: 727645 Change-Id: I41718cb9117e8e7acd03302416f585e398d6009a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214551 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772006}
-
Joel Fernandes authored
The prctl in upstream kernel keeps changing as new prctls are added. Numbers 57 and 58 are already taken. Let us choose 0x200 (512) to be safe. While the core-scheduling patchset is making great upstream progress, the prctl(2) interface to use it will take time upstream and we might have to carry it in product kernels for a while. Let us change it to 0x200 to keep products working. We can always change it to the final one later. BUG=b:152605392 Signed-off-by:
Joel Fernandes <joelaf@google.com> Change-Id: I15d7a534cab35678b017991ac67bae54128b43a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213330Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#772005}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd68d8279234..be61a7c024b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com,mpearson@google.com Change-Id: I7718178abd6b9153be31e8e8b27ba8a10bf07c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216756Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772004}
-
Harley Li authored
Originally the condition check catches the case where 'sources' is absent in the invoking target, but doesn't catch the case where the list is empty. The comment given in the code says we need to ensure the list contains at least one source to avoid building an empty static lib. Change-Id: Iaafda906bf177d95d8908498b042f15c28cbd271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215581Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Harley Li <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772003}
-
Ender authored
This reverts commit 74affe26. Reason for revert: we're now ready to enable this feature by default. Original change's description: > Revert "Disable Instant Extended limit by default for Android." > > This reverts commit 3b71610c. > > Reason for revert: we will be doing staged rollout. this cl would go live may 19, which is too early. > > Original change's description: > > Disable Instant Extended limit by default for Android. > > > > This change effectively increases number of search results > > on Android devices from default (3). > > > > Bug: 964049 > > Change-Id: I46887f88e3f76801d24f7dfdf928397e6a3ae66f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132858 > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Commit-Queue: Ender <ender@google.com> > > Cr-Commit-Position: refs/heads/master@{#755543} > > TBR=tommycli@chromium.org,ender@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 964049 > Change-Id: I9102a3849018f366b98044921ae711eb8321bbb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176653 > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#764863} TBR=tommycli@chromium.org,jdonnelly@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964049 Change-Id: I4d8bf3f3a879d7a040a37aa72bf7d2c82c9106e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216790Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#772002}
-
Sigurdur Asgeirsson authored
Bug: 1080672 Change-Id: I2e7bc7428ff0448844517862751ced5cc250d902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204438 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#772001}
-
Brian Sheedy authored
Shuffles around some GPU expectations that are expected to be permanent to target the GPU instead of the board. TBR=ynovikov@chromium.org Bug: 1080401, 1080408, 1080411, 1080360 Change-Id: Id89e1df197db93b8600c4dc10e45cc8447de5e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216631 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772000}
-
Kurt Horimoto authored
This is required to test overlay functionality during a dismissal animation. Bug: 1065564 Change-Id: I39aac0fe2f21a45524300fce5cf8d4c6e2bbb2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213728 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#771999}
-
Kelvin Jiang authored
For one of the subtests, an xhr request which matches a rule was sent before the event listener for OnRuleMatchedDebug was registered. The fix involves waiting for a round trip between the extension and browser to complete after the listener has been added for the request to be sent, which prevents the race condition causing the flake. Bug: 1029233 Change-Id: I1e1c011159dfa9c463612b4f837ce9ce4316a234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209601Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771998}
-
Rune Lillesveen authored
We use a preferred color-scheme of light for screens. When we decided to not use dark for printing we chose no-preference, but content depends on color-scheme to either be light or dark since that is the case for screen media. This matches what both Firefox and Safari does. Bug: 1086441 Change-Id: I1b10c76068ca9cfebf0d991c342b15f99185698e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216770Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771997}
-
Sasha McIntosh authored
In cases where a single character in a display name is non-printable, we use an empty string for the display name. This change instead replaces a non-printable char with a space. Added test case for a string with non-printable char. Note that the display_id is generated from the display name, so this is also updated in the test. Change-Id: I8092bf10bdf5c93b450a0bf84b18c5aaae157452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212701 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#771996}
-
Becca Hughes authored
Adds a fix so that Media History does not record background or muted watchtime since they are not useful to us (we only want foreground unmuted). BUG=1086511 Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771995}
-
John Abd-El-Malek authored
Currently they were using URLLoaderInterceptor to serve the data. In case of cors-exempt headers this doesn't go through the networking logic to merge them if that's allowed. This also brings the tests closer to production. Bug: 1085309 Change-Id: Idc09d2d0d398d98c8a1fcaacecfdeac40c9116e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216594Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#771994}
-
Akihiro Ota authored
options page. Bug: 1009897 Change-Id: I32a2cda728933bf4e4e5d475a7f6b84dfe7b312b AX-Relnotes: Add a link to the TTS settings page in the ChromeVox Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213888Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#771993}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/af27e58ea40a..1a97f7367f83 2020-05-26 primiano@google.com Merge "Site: fix typo in home page" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iab4f44125ddd5ed0acf99948e5d01ad78de5be7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771992}
-
Sam Bowen authored
Bug: 1081515 Change-Id: Id60a43f4a9d3093992670676627a05baac258b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210795 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771991}
-
David Tseng authored
R=akihiroota@chromium.org AX-Relnotes: n/a Change-Id: I6c8fbed7b56365a55be0acd76fda586aee272c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212820Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#771990}
-
Vladimir Levin authored
This patch changes the behavior of computed style z-index to comply with spec: it reports the value as specified instead of changing it to auto if the style does not induce a stacking context. Note that since z-index only applies on positioned elements, and grid and flex children, this patch introduces an EffectiveZIndex() which is set to 0 if the z-index does not apply. This is so that code relying on z-index will behave as it did before. However, ZIndex() now reflects the value that was specified. R=futhark@chromium.org, pdr@chromium.org Fixed: 1023232, 375982 Change-Id: Ib11467a9818b746c72bebbb167223f1bb41a5f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212391 Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771989}
-
Bo Liu authored
Some N bots are also causing failures from Activities not being destroyed, just more flakily than on L. Expand the check in LifetimeAssertRule to all versions. Bug: 1081250 Change-Id: I3d8330988b8aca47b66084d9bc43b82d0a53b240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216535Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771988}
-
Anders Hartvoll Ruud authored
Bug: 1085994 Change-Id: Ied0e00fa9e67850860ed0126269533396834b66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215814Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#771987}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b302be3..79156e7a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5034b3968ecdddfee6f04a194ba578bfbc5aecb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216730Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771986}
-
Ken Rockot authored
Implements a test for backward-compatibility between any two versions of a mojom enum definition. This will be used to enforce stability checks once a [Stable] attribute is introduced. Bug: 1070663 Change-Id: I84c3051337adeb10a8cef0eadd0708548215d0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212890Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#771985}
-
Oriol Brufau authored
GridTemplateAreas::ApplyInherit wasn't setting ImplicitNamedGridRowLines nor ImplicitNamedGridColumnLines inherited from the parent, so grid items referencing these lines were placed into the implicid grid. The patch also makes sure to set them in GridTemplateAreas::ApplyInitial and GridTemplateAreas::ApplyValue for a 'none' keyword. It seems these weren't causing noticeable problems, though. BUG=1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-008.html Change-Id: If92e771d51450dea3f7fa12deaec6ce9dd7639d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214960Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#771984}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2be61a1df411..f203902ee8b7 2020-05-26 iannucci@chromium.org [lucicfg] Update to 1.14.3. 2020-05-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-05-26 vadimsh@chromium.org [luci-auth] Update to the latest version. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015181,chromium:1082960 Tbr: agable@chromium.org Change-Id: I62037de04c61d66cedc22e52155a1cb0dce5aaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771983}
-
Avi Drissman authored
If the clipboard contains data that has been marked by its originator as confidential, don't offer it for "Paste and Search" and don't offer it as a zero-prefix search suggestion. This directly wires into the iOS zero-prefix search code, and adds an expandable function to ui::Clipboard, implementing it for the Mac. If there is a convention for other platforms, it can be implemented via this mechanism. Bug: 1067542, 1084244, 1071828 Change-Id: I064a0629c35b686e14772cec123a3fc1eec5487c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213286Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771982}
-
Raphael Kubo da Costa authored
Its implementation is identical to that of Sensor::activated(), so stick to the latter. Change-Id: I598e889fa91ec8deca3ac2a16203e0343b5b9c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214386 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#771981}
-
Mark Schillaci authored
This CL adds the indices of a user's text selection start and end positions to the AccessibilityNodeInfo object for that node on Android. Until now this information has only been conveyed through the ToIndex and FromIndex indices of AccessibilityRecord. As per ARC++ request, we will now communicate the indices in both the AccessibilityRecord and the AccessibilityNodeInfo object for the given node. This CL also cleans up some of the native code implementation of building the AccessibilityNodeInfo objects. We have refactored the code to no longer have KitKat specific methods since we have dropped support for that OS. Bug: 1059680 AX-Relnotes: N/A Change-Id: I3ce1629271e976a9ef323097ee0bf86233d44aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101306Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#771980}
-
Matt Mueller authored
This was used by NSS cert verifier OCSP requests (which are no longer a thing) and DNS over HTTPS requests (which now use the the same context as the request). Bug: 1044698 Change-Id: I3b5472f60d3fd0d2ba6037184718d3c030c43419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204678Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#771979}
-