GitLab

This CL converts blink::WebString to std::string in WebMediaPlayerImpl and WebMediaPlayerAndroid so that internal chromium classes don't need to deal with blink::WebString anymore.

Changes about logging:
- Use base::string16 so that if non-ascii parameters can be shown correctly.
- Move logging to public methods so that parameters can be logged before being converted to ASCII.

BUG=252065
TEST=KeySystemsTest updated.
R=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/170783010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252160 0039d316-1c4b-4281-b951-d872f2087c98

> Implement inline signin with iframe
> 
> =+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
> This is a dup of https://codereview.chromium.org/130963006/ since I cannot
> upload to that issue.  The only change is to address Xiyuan's two comments
> in patchset 3 of that CL.
> =+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
> 
> Inline signin chrome://chrome-signin is currently implemented using webview embedded in webUI, which breaks a couple of features in webUI and has serious accessbility issues. Since webview will be reimplemented based on OOPIF in the near future, and all the issues we have today will no longer apply, thus it is not worth the effort to fix them as they are throw away work. Instead, as suggested by John and prototyped in https://codereview.chromium.org/141363006/, we decide to switch to iframe instead. A few issues worth to mention,
> 
> 1. The iframe shares the same renderer as the embedder webUI, and thus could be potentially exposed to dangerous webUI privileges. John suggested a fix by assigning a unique storage partition ID to the inline signin page. As a result the inline signin and its embedded web content should never share the same renderer with other webUI pages.
> 
> 2. webview provides a direct API to inject script and to monitor requests/responses, which is not (directly) available with iframe. The CL works around the issue using content script and background script, quite similar to what CrOS is doing for SAML flow today. Thus it is also the first step towards unifying SAML flows on CrOS and desktop.
> 
> 3. with webview approach, we used to have a unique temporary partition for each instance of inline signin, in order to make sure multiple instances do not interfere with each other. This is more difficult with the iframe approach, since the partition ID is hardcoded in a quite low layer. In this CL, all inline signin pages share the same persistent partition, which means we have to handle the case when user loads the sign in page with a dirty cookie jar, and thus the newly connected user may not be stored in the primary session. The CL solves the issue by reading 'session_index' from 'google-accounts-signin' header.
> 
> BUG=338127
> 
> Review URL: https://codereview.chromium.org/134263005

TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/173193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344943

Review URL: https://codereview.chromium.org/172263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252157 0039d316-1c4b-4281-b951-d872f2087c98

The tests have changed significantly since they were first disabled. Add a
WaitForStop or two for good measure, but leave them as-is for the most part.
They can be disabled again if they still flake. Merge their custom prerender
loader into the main one; it's mostly the same.

In addition, for better test coverage, add a new test which asserts on events
received when a <link rel=prerender> is added for an existing prerender after
that prerender has loaded. Significantly rework the prerender events logic
to allow the test framework to wait on an event being received in the loader.

Fix implementation of set_loader_query_and_fragment to not produce URLs with
two ?s.

Original Review URL: https://codereview.chromium.org/142013004

BUG=167340, 128841

Review URL: https://codereview.chromium.org/166273007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252156 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344909
TEST=Manual - follow steps in the bug.

Review URL: https://codereview.chromium.org/172243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252155 0039d316-1c4b-4281-b951-d872f2087c98

This fixes and re-enables all the host driven sync tests.

NOTRY=true
BUG=329757,309997,311091

Review URL: https://codereview.chromium.org/168833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252154 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252151 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ganetsky@chromium.org
BUG=303491

Review URL: https://codereview.chromium.org/171233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252150 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> cd src/components
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235
R=joi@chromium.org

Review URL: https://codereview.chromium.org/171793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252149 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343570
TEST=None

Review URL: https://codereview.chromium.org/170863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/170283013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252146 0039d316-1c4b-4281-b951-d872f2087c98

This is needed because there are cases when the bounds of the LegacyRenderWidgetHostHWND window and its parent
are the same. This also necessiates adding handlers for WM_NCXXX messages and forwarding them to the parent.

BUG=344775
R=cpu@chromium.org, cpu
TBR=jam

Review URL: https://codereview.chromium.org/169203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252145 0039d316-1c4b-4281-b951-d872f2087c98

In the second and third test of TestNextActionsBeginsMainFrameIfNeeded,
they test when commit is requested. But, both tests doesn't set commit is needed.
Also, third test should check whether next action is BEGIN_MAIN_FRAME or not.

R=brianderson@chromium.org
BUG=NONE
TEST=cc_unittests --gtest_filter=*.TestNextActionBeginsMainFrameIfNeeded

Review URL: https://codereview.chromium.org/170283008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252144 0039d316-1c4b-4281-b951-d872f2087c98

Adding in full DCC content_providers.json

Also slightly improving redirects.

Note that this starts off with patch https://codereview.chromium.org/148663007/.

Just made sense to deliver the content from this patch with restored navigation.

NOTRY=true

Review URL: https://codereview.chromium.org/171353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252143 0039d316-1c4b-4281-b951-d872f2087c98

35 is a centered cube number, a pentagonal number and a pentatope number.
35 is a highly cototient number, since there are more solutions to the equation x - φ(x) = 35 than there are for any other integers below it except 1.
There are 35 free hexominoes, the polyominoes made from six squares.
In science, 35 is the atomic number of bromine

Review URL: https://codereview.chromium.org/166273016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252136 0039d316-1c4b-4281-b951-d872f2087c98

With this change, it will be much easier to make changes to the UX (since
the dialogs will be easier to manage) and the set of JavaScript includes
will be guaranteed to match the gyp target.

This change also auto-generates the wcs_sandbox.html file.

BUG=
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/146903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252135 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Convert Google Now's Authentication Manager to use Promises (https://codereview.chromium.org/162273002/)

Reason for revert:
Promise.catch may not always be called back, breaking an assumption about the task tracking system.

Original issue's description:
> Convert Google Now's Authentication Manager to use Promises
> 
> BUG=164227
> R=rgustafson@chromium.org, skare@chromium.org, vadimt@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252109

TBR=skare@chromium.org,rgustafson@chromium.org,vadimt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=164227

Review URL: https://codereview.chromium.org/171713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=rnk@chromium.org

Review URL: https://codereview.chromium.org/171423010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252132 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252131 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 167304:167430
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167430&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/165393015

TBR=acolwell@chromium.org

Review URL: https://codereview.chromium.org/165443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252130 0039d316-1c4b-4281-b951-d872f2087c98

The cricket::VideoCapturer no longer makes a copy of the frame from the camera. As a result we can't just do a shallow copy as the underlying buffer maybe invalid after the function returns. Instead we now have to make a copy in video_source_handler before return.

TEST=updated unit test
BUG=344957
R=perkj@chromium.org, wjia@chromium.org

Review URL: https://codereview.chromium.org/172843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252129 0039d316-1c4b-4281-b951-d872f2087c98

Still more to do, but incremental change is less scary.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/172953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252128 0039d316-1c4b-4281-b951-d872f2087c98

The extensions were being removed before testing, but since only md and html
are considered in the clean urls, the path canonalizer redirects (302) to
the URL with extension. But a 302 of a changed template file is considered a
test fail. Examples that would fail the presubmit tests are images, CSSs,
redirect.json, etc.

BUG=343614
NOTRY=true
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/172573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252127 0039d316-1c4b-4281-b951-d872f2087c98

The platform verification dialog communicates to the user the origin of
the request.  Normally this is a web origin but for extensions or v2
apps the web origin is ugly and the extension / app name is better.

BUG=chromium:344723
TEST=manual

Review URL: https://codereview.chromium.org/171483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252126 0039d316-1c4b-4281-b951-d872f2087c98

In the review process of cr/160513002 I wound up losing reports of bytes from non-prerender resources.  This fixes that.  It also updates the max bin size of profile bytes since there could be lots of requests between prerenders.

BUG=334602

Review URL: https://codereview.chromium.org/163963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252125 0039d316-1c4b-4281-b951-d872f2087c98

This avoids destroying contexts on the main thread that are bound to
the compositor thread as this causes DCHECKs to fire and is a bad thing.

The renderer already does this, as it has been threaded much longer on
more platforms so we noticed it. Recently noticed this in browser tests
in the UI compositor too.

This also updates the Mojo DemoContextFactory to match the behaviour of
GpuProcessTransportFactory wrt the offscreen compositor context creation
and destruction.

R=jamesr, piman
BUG=344016

Review URL: https://codereview.chromium.org/167843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252124 0039d316-1c4b-4281-b951-d872f2087c98

Use a map of privet tokens in PrivetURLFetcher that persists between
instantiations. This should cut down on spurious /privet/info calls in cases
where spurious calls may cause performance issues (i.e. repeated frequent calls)

BUG=

Review URL: https://codereview.chromium.org/166373006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252123 0039d316-1c4b-4281-b951-d872f2087c98

The only other change was to delete two TODOs regarding style adjustments.

BUG=245025
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/171503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329265

Review URL: https://codereview.chromium.org/150573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252121 0039d316-1c4b-4281-b951-d872f2087c98

The histogram was added in https://codereview.chromium.org/159143007/.

R=jar@chromium.org,rch@chromium.org
BUG=none
TEST=none
NOTRY=true

Review URL: https://codereview.chromium.org/171453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252120 0039d316-1c4b-4281-b951-d872f2087c98

This uses the new IRT construction API.

This will allow references to PPAPI to be removed from src/untrusted/irt
in the NaCl repo.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787
TEST=browser_tests

Review URL: https://codereview.chromium.org/171093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252119 0039d316-1c4b-4281-b951-d872f2087c98

A few perf tests were writing results against the same measurement name making it impossible to distinguish and compare measurements. This patch adds modifier strings to make the measurments clear.

BUG=343684

Review URL: https://codereview.chromium.org/167753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252118 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252117 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167430&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/165393015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252116 0039d316-1c4b-4281-b951-d872f2087c98

The test no longer ran correctly due to a change in the exception message since it was disabled. This CL updates the test to run correctly again, makes it more robust against timing issues, and re-enables it.

BUG=306702

Review URL: https://codereview.chromium.org/138913020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252114 0039d316-1c4b-4281-b951-d872f2087c98

This prevents libspeechd from hanging in getline() indefinitely, which may lock other threads that are trying to fflush all the open files.

BUG=333003
R=dtseng@chromium.org,dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/172103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252113 0039d316-1c4b-4281-b951-d872f2087c98

This CL logically reverts r206742 "Split InputMethodWin into InputMethodIMM32 and InputMethodTSF".
That was a tentative solution during the Aura transition.

BUG=330735, 344209
TEST=manually done on Windows 7

Review URL: https://codereview.chromium.org/166063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252112 0039d316-1c4b-4281-b951-d872f2087c98

This metric was added to update_engine to track how the
install-date-days variable is calculated.

BUG=chromium:336838
TEST=Validated the xml, pretty print succeeded.

Review URL: https://codereview.chromium.org/166483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
R=rgustafson@chromium.org, skare@chromium.org, vadimt@chromium.org

Review URL: https://codereview.chromium.org/162273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252109 0039d316-1c4b-4281-b951-d872f2087c98

This change modifies PpapiDispatcher to inherit IPC::Listener and IPC::Sender
instead of ProxyChannel directly. This cleans up the class hierarchy a bit.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/172103008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252108 0039d316-1c4b-4281-b951-d872f2087c98