- 29 Jul, 2019 40 commits
-
-
Leo Zhang authored
We are going to experiment 2 decoder new features: - fst for non-english - hmm decoder And removed unused flag "imeservice" Bug: 937152 Change-Id: I91b2ed114b9e6d330a0d2baf278a235199eeee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722165 Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#681738}
-
Kenichi Ishibashi authored
Before this CL WebContentSettingsClient was indirectly passed to WorkerOrWorkletGlobalScope via WorkerContentSettingsClient. This was an unnecessary abstraction. We can just pass WebContentSettingsClient as a part of GlobalScopeCreationParams and keep it in WorkerOrWorkletGlobalScope. This eliminates creating a GarbageCollected object. This CL doesn't have behavioral changes. Bug: 988335 Change-Id: If740aebdb33aa0bffd1ed8c9659d3a0c92c8e20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722464Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#681737}
-
Rakina Zata Amni authored
Add timeout expectation for http/tests/devtools/elements/shadow/elements-panel-shadow-selection-on-refresh-3.js No-try: true No-presubmit: true No-Tree-Checks: true Bug: 988170 Change-Id: I0d164fc704bfc04541f59a6db2a7da7ac712befe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724109Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#681736}
-
Rakina Zata Amni authored
This reverts commit 1f56d90b. Reason for revert: Causes build failures on *-archive-rel, for example: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel Original change's description: > Move IPAddressSpace from blink::mojom:: to network::mojom:: > > We'll eventually need to access this from the network stack in order to > decide whether to block requests. This patch just moves the value from > its existing home in Blink to a new abode in the network service. It's > mostly the result of the following command: > > ``` > git gs IPAddressSpace -l | xargs -L1 sed -i '' \ > -e 's/third_party\/blink\/public\/mojom\/net\/ip_/services\/network\/public\/mojom\/ip_/g' \ > -e 's/\([ \(<{]\)mojom::IPAddressSpace/\1network::mojom::IPAddressSpace/g' \ > -e 's/blink::mojom::IPAddressSpace/network::mojom::IPAddressSpace/g' \ > -e 's/blink.mojom.IPAddressSpace/network.mojom.IPAddressSpace/g' > ``` > > Bug: 986744 > Change-Id: I5afebde58ccf2108db4ed7d32a4ee6484aab625e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718329 > Commit-Queue: Mike West <mkwst@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681729} TBR=kinuko@chromium.org,mmenke@chromium.org,tsepez@chromium.org,mkwst@chromium.org Change-Id: Ie5e043de160c1d327eb1575bc79efa788a71c3bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724149Reviewed-by:
-
Dominic Farolino authored
There are no blink::ResourceFetcher::PrepareRequest (this is where SetReferrer is called) crashes after build 77.0.3855.0, which is when the crash fix landed. We can remove the debugging info now and make more progress on the overall goal of the original issue. R=kinuko@chromium.org, yhirano@chromium.org Bug: 863769 Change-Id: Id4f3f4042d690cfda30d48160a963d6ec4ae1616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722164Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Omer Katz authored
I added a worklist for registering ephemeron callbacks. ThreadHeap previously used a HashMap for that. The HashMap remains since it is also used to verify callbacks are consistent. MarkingVisitor adds entries to the worklist instead of the HashMap. ThreadHeap then reads from the worklist to the HashMap, invoking callbacks as it goes. Bug: 986235 Change-Id: Ie716281ba216a083146bff7a78abe06621befcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718371Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681733}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I2af748891280364d954e3d8198e9b95d76a74602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700865 Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#681732}
-
Omer Katz authored
The pre-finalizer was used to unregister the Scrollbar from the theme. The only implementation of the UnregisterScrollbar method that did anything was that of ScrollbarThemeMac, which removed the scrollbar from a HashSet and a HashMap. Both data-structures actually held weak members, so the gc can automatically remove the ScrollBar from the data-structures and the pre-finalizer is not needed. The method UnregisterScrollbar was only called from the pre-finalizer, so I removed it as well. Bug: 981414 Change-Id: Ief15a9df658a12568de9fabdabd2950419835b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720774Reviewed-by:
-
Martin Robinson authored
AXNodeRange can include the node that we are currently calculating spelling attributes for, so we should be careful to avoid infinite recursion here. Bug: 987675 Change-Id: If3a85191e70edb87f26166fe0e043d58715ae494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720869Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#681730}
-
Mike West authored
We'll eventually need to access this from the network stack in order to decide whether to block requests. This patch just moves the value from its existing home in Blink to a new abode in the network service. It's mostly the result of the following command: ``` git gs IPAddressSpace -l | xargs -L1 sed -i '' \ -e 's/third_party\/blink\/public\/mojom\/net\/ip_/services\/network\/public\/mojom\/ip_/g' \ -e 's/\([ \(<{]\)mojom::IPAddressSpace/\1network::mojom::IPAddressSpace/g' \ -e 's/blink::mojom::IPAddressSpace/network::mojom::IPAddressSpace/g' \ -e 's/blink.mojom.IPAddressSpace/network.mojom.IPAddressSpace/g' ``` Bug: 986744 Change-Id: I5afebde58ccf2108db4ed7d32a4ee6484aab625e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718329 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Maksim Sisov authored
The Wayland spec says that explicit grab of popups can be set on mouse press, keyboard press or touch DOWN event. However, Chromium reacts (creates windows, opens windows and etc) on touch UP events, which results in closed popups by a Wayland compositor. Thus, stop using explicit grab if a parent window (which was the source of the event) is not touch focused, but keyboard or mouse pointer focused. Last, there is a bug in gnome/mutter, which results in crashing entire wayland session if a popup is not explicitly grabbed and unmapped. Thus, just continue using explicit grabs with it to avoid crashing. In this case, only context menus work in this environment. Bug: 973015 Change-Id: I149b4f91378305f984c72d13161cadd29e7f7753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715079 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#681728}
-
Alexandre Courbot authored
With the V4L2SVDA ported to V4L2Queue, we don't need these old methods anymore and can remove them. At the same time, the release callback argument of the new constructor methods was never used, so remove it as well. Bug: 987852 Test: video_decode_accelerator_unittest passes on Minnie. Test: video_decode_accelerator_tests passes on Minnie. Change-Id: I7f54d3adbfc5a9b8149872b43a4507efbbcefdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720235 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#681727}
-
Alexey Baskakov authored
More cleanup CLs to follow. Bug: 973288 Change-Id: Ibe24dfee03f3428850866c5025de4b7e4136b406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722134Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#681726}
-
Piotr Pawliczek authored
The internal structure of BulkPrinterCalculator called Restrictions was destroyed by posting to an internal TaskRunner a Delete task. Unfortunately, during cleaning after a unittest the internal TaskRunner didn't accept any new tasks, what resulted in memory leak. This patch solved this problem by replacing deletion through posted Delete task by synchronized reference counting. BUG=chromium:977617 TEST=on my workstation Change-Id: I0bf94005fadeec4627978c7fbbc82238d58c3fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718771 Commit-Queue: Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#681725}
-
Koji Ishii authored
This patch changes Element::LocalNameForSelectorMatching() to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII is mandated by the spec: https://www.w3.org/TR/selectors-4/#case-sensitive Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. Bug: 627682 Change-Id: I49bdbbae645a287bf6dacdcb0a6481f7eb93c022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720642 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681724}
-
Rakina Zata Amni authored
Disable flaky SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/play:media:soundcloud:2018 TBR=perezju@chromium.org Bug: 987858 Change-Id: I7dbd4dc300f38c9aacad4a214a6618c8120e0dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722578Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d00c75153395..d188f3a9613d git log d00c75153395..d188f3a9613d --date=short --no-merges --format='%ad %ae %s' 2019-07-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fab397e5acde..a96b79f90940 (15 commits) Created with: gclient setdep -r src/third_party/skia@d188f3a9613d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: I7c7c05ae0f5977b8fe9ffc488a3132c7411b2089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681722}
-
Vaclav Brozek authored
As discussed in https://crrev.com/c/1698401 and recorded in the design doc [1], CSVPassword needs to stop being copyable and moveable to prevent some ways of use-after-free. This CL just removes the respective constructors (including the default one) and operator=. It also stops marking the (now only) 2-argument constructor as explicit, because the implicit construction will later be needed in CSVPasswordIterator (see the discussion on the other CL and [1]). [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: I2e1aea9b7fa9d4fbdb76cb12f13ee82a6ff87651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722533 Auto-Submit: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#681721}
-
Takuto Ikuta authored
This is followup for https://chromium-review.googlesource.com/c/chromium/src/+/1714485 to fix presubmit error like https://ci.chromium.org/p/chromium/builders/try/chromium_presubmit/536124 Change-Id: I911370e31c3e3fe9675ca91c903ef147a3d69c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723510 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#681720}
-
Yutaka Hirano authored
This is a reland of 1ccc5eee Original change's description: > Unify allow_credentials and credentials_mode on network::ResourceRequest > > Remove allow_credentials, map allow_credentials: false to > credentials_mode: kOmit and map allow_credentials: true to > credentials_mode: kInclude. > > network::URLLoader cannot handle kSameOrigin. This CL doesn't change > that. CORSURLLoader translates the value to either kOmit or kInclude. > > This works correctly even when OOR-CORS is disabled because in that > case load flags are set in the renderer. One caveat is we will not > be able to remove the load flags until we remove the blink-side CORS > code (M78? M79?) with this change. > > This CL removes a validity check for credentials related settings in > CorsURLLoaderFactory. Originally the check was introduced to check the > inconsistency between credentials_mode and load flags. After that > allow_credentials was introduced, and at > https://crrev.com/c/chromium/src/+/1443976 the logic was changed to > check the inconsistency between credentials_mode and allow_credentials. > Now they are merged and we don't need the check. > > Bug: 799935 > Change-Id: Ic05b2d41456d91fd3f48416a3a3e8fc98e235756 > Tbr: bsimonnet@chromium.org, dimich@chromium.org, groby@chromium.org, markusheintz@chromium.org, olka@chromium.org, satorux@chromium.org, tbansal@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695341 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Greg Levin <glevin@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Michael Martis <martis@chromium.org> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681698} TBR=sky@chromium.org,horo@chromium.org,mpearson@chromium.org,davidben@chromium.org,thakis@chromium.org,toyoshim@chromium.org,nyquist@chromium.org,markusheintz@chromium.org,vasilii@chromium.org,jrummell@chromium.org,asvitkine@chromium.org,groby@chromium.org,bsimonnet@chromium.org,noel@chromium.org,rsorokin@chromium.org,glevin@chromium.org,yhirano@chromium.org,dimich@chromium.org,mmenke@chromium.org,nhiroki@chromium.org,sdefresne@chromium.org,tsepez@chromium.org,treib@chromium.org,estark@chromium.org,tbansal@chromium.org,gogerald@chromium.org,mattreynolds@chromium.org,wychen@chromium.org,olka@chromium.org,satorux@chromium.org,rbpotter@chromium.org,pnoland@chromium.org,fhorschig@chromium.org,martis@chromium.org,kmilka@chromium.org,jselover@chromium.org,nicolaso@chromium.org,mcarlen@chromium.org Bug: 799935 Change-Id: Iec8067b3fed29bd6845077f5dc9c564d6640b6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722274Reviewed-by:
-
John Abd-El-Malek authored
Bug: 934009, 818445 Change-Id: I56554d416137100e31b1d225abcd9312524e4c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722569 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/642b6ad99ffc..7fc868349143 git log 642b6ad99ffc..7fc868349143 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 johnkslang@users.noreply.github.com Merge pull request #1813 from jeffbolznv/compositeconstruct Created with: gclient setdep -r src/third_party/glslang/src@7fc868349143 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I6f6cb1399c57555a026a3a5f030a45a54a78da0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723297Reviewed-by:
-
Alexandre Courbot authored
Port the V4L2SVDA outpu queue to V4L2Queue, in order to reduce the amount of code in this messy class and make it overall more secure. With both the input and output queue ported, we can now make use of the new V4L2DecodeSurface constructors and remove some more members. Bug: 987852 Test: video_decode_accelerator_unittest passes on Minnie. Test: video_decode_accelerator_tests passes on Minnie. Change-Id: I300bbbfbafb8c86ad89d23c45e7702dca0876660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720234 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Bug: 973324 Change-Id: I34739c8808443f2657a83e90d72db60436ccd6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715497 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
See the issue for more details. It doesn't look this needs to live on IO thread, this patch moves all the code cache code onto UI thread so that security check can become easier. (Alternatively we can only move CodeCacheHost to UI thread but leave everything else on IO thread or on a sequenced task runner. e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1705540) Bug: 985681 Change-Id: I8db4728a15205dcb82f6b4307f11ae7313e90831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712949 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#681714}
-
Yutaka Hirano authored
Now the extensions module for websocket is running on the UI thread, and we can assume WebSocketConnectorImpl::ConnectCalledByContentBrowserClient is called on the thread. Bug: 985681 Change-Id: I1df31dc3c8d219afd4c0576f859b9e7345dece16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722793 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Alan Cutter authored
Bug: 988292 Change-Id: If4911cb53528913b6cccf5c4db9784e4e04c3d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722362 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#681712}
-
rajendrant authored
Change-Id: Ic6e9f1ab01521538b4142fae8348777c9770107c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722197Reviewed-by:
-
Alan Cutter authored
This CL alters the DCHECK in ProfileDestroyer::DestroyProfileWhenAppropriate() to check that no render processes are lying around after Profile destruction rather than after the NOTIFICATION_PROFILE_DESTROYED notification. This change allows objects living off Profile to clean up their WebContents in their destructor rather than needing a special shutting down phase. Using destructors to clean up resources is more idiomatic C++ and avoids having to encode additional "shutting down" states. With this change we can move PendingAppManager::Shutdown() and InstallManager::Shutdown() into their respective destructors. The DCHECK is tested by PendingBookmarkAppManagerBrowserTest.ShutdownWithPendingInstallation. Bug: 876176 Change-Id: I2e048f60c61c06da16decefb8214eeefdd0162cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610268 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#681710}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02f345f54364..d00c75153395 git log 02f345f54364..d00c75153395 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ec3039253ab8..3575550a711b (1 commits) Created with: gclient setdep -r src/third_party/skia@d00c75153395 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:None Change-Id: Icf73f235f18a613954246d096e51ac26f58fef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723296Reviewed-by:
-
Maksim Sisov authored
When context menus are created (with right-click or long touch press), WaylandWindow must take a focused window as a parent for that context aka popup window. It has always been so for mouse clicks, but not for touches. Now, GetCurrentFocusedWindow returns either a window with pointer focus or touch focus. Also fix unittests and their expectations Bug: 973015 Change-Id: I3c268f3956d57fd673c5e7a8646a30fdd4c921a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715078 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Alexandre Courbot authored
Port the V4L2SVDA input queue to V4L2Queue, in order to reduce the amount of code in this messy class and make it overall more secure. Porting of the output queue is done in a follow-up CL to ease review ; therefore, there is a temporary new member in InputRecord that will go away with the next CL. Bug: 987852 Test: video_decode_accelerator_unittest passes on Minnie. Test: video_decode_accelerator_tests passes on Minnie. Change-Id: I99b724928030a908751fa0348c1c9d130972a62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720233 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
-
Noel Gordon authored
This reverts commit 1ccc5eee. Reason for revert: causing compile failures on the linux-chromeos-google-rel builder. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/5042 Original change's description: > Unify allow_credentials and credentials_mode on network::ResourceRequest > > Remove allow_credentials, map allow_credentials: false to > credentials_mode: kOmit and map allow_credentials: true to > credentials_mode: kInclude. > > network::URLLoader cannot handle kSameOrigin. This CL doesn't change > that. CORSURLLoader translates the value to either kOmit or kInclude. > > This works correctly even when OOR-CORS is disabled because in that > case load flags are set in the renderer. One caveat is we will not > be able to remove the load flags until we remove the blink-side CORS > code (M78? M79?) with this change. > > This CL removes a validity check for credentials related settings in > CorsURLLoaderFactory. Originally the check was introduced to check the > inconsistency between credentials_mode and load flags. After that > allow_credentials was introduced, and at > https://crrev.com/c/chromium/src/+/1443976 the logic was changed to > check the inconsistency between credentials_mode and allow_credentials. > Now they are merged and we don't need the check. > > Bug: 799935 > Change-Id: Ic05b2d41456d91fd3f48416a3a3e8fc98e235756 > Tbr: bsimonnet@chromium.org, dimich@chromium.org, groby@chromium.org, markusheintz@chromium.org, olka@chromium.org, satorux@chromium.org, tbansal@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695341 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Greg Levin <glevin@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Michael Martis <martis@chromium.org> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681698} TBR=sky@chromium.org,horo@chromium.org,mpearson@chromium.org,davidben@chromium.org,thakis@chromium.org,toyoshim@chromium.org,nyquist@chromium.org,markusheintz@chromium.org,vasilii@chromium.org,jrummell@chromium.org,asvitkine@chromium.org,groby@chromium.org,bsimonnet@chromium.org,rsorokin@chromium.org,glevin@chromium.org,yhirano@chromium.org,dimich@chromium.org,mmenke@chromium.org,nhiroki@chromium.org,sdefresne@chromium.org,tsepez@chromium.org,treib@chromium.org,estark@chromium.org,tbansal@chromium.org,gogerald@chromium.org,mattreynolds@chromium.org,wychen@chromium.org,olka@chromium.org,satorux@chromium.org,rbpotter@chromium.org,pnoland@chromium.org,fhorschig@chromium.org,martis@chromium.org,kmilka@chromium.org,jselover@chromium.org,nicolaso@chromium.org,mcarlen@chromium.org Change-Id: I60b04dc48cd24370db18211d2870fae2f598c9d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724029Reviewed-by:
-
Noel Gordon authored
Tbr: rakina@ No-try: true No-presubmit: true Bug: 988246 Change-Id: I9abf3f2a634efb57c035f99f7d4b2dcf7a0dea3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722954Reviewed-by:
-
Minggang Wang authored
This CL moves the content::URLLoaderThrottle used to interrupt the request/response into blink. After this CL, we have to override blink::URLLoaderThrottle to implement different throttles. See more at https://docs.google.com/document/d/18TVbhZ4MnGTCHYqeQtqz59SdTHP7CFqVyHWYbcD_d5A/edit?usp=sharing BUG=860403 Change-Id: I7c287de0495e171b37586165003ef4e204c321de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701135 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/42f813401bdf..642b6ad99ffc git log 42f813401bdf..642b6ad99ffc --date=short --no-merges --format='%ad %ae %s' 2019-07-29 johnkslang@users.noreply.github.com Merge pull request #1844 from alelenv/ast_print_fix Created with: gclient setdep -r src/third_party/glslang/src@642b6ad99ffc The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: Ife674f702b772d956588ffa77ad8e42838b54265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723640Reviewed-by:
-
Alexandre Courbot authored
V4L2WritableBufferRef::PrepareQueueBuffer() does not take ownership of its argument, not does it modify it. So change it to take a const reference instead. On top of being semantically correct, this change also makes it easier to port the V4L2SVDA to V4L2Queue. Bug: 987852 Test: video_decode_accelerator_unittest passes on Minnie. Test: video_decode_accelerator_tests passes on Minnie. Change-Id: I85e17448535db91a42c52a0fd4e7bb1de2ff1efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720232 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Jyun-jhe Chou authored
The unittest parses the argument from wrong index. TEST: Run the unittest on device. Bug: None Change-Id: I75787acd1141aec9690f5ccdd935b8eb189ed14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722361Reviewed-by:
-
rajendrant authored
This CL marks automatic lazyload support as experimental. Restrict to data saver feature is also marked experimental, since that is the likely launch behavior. Bug: 987870 Change-Id: Ia62276460de24b903222905a87b238f4feb31652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720991Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I5d00970aa025dfed5bbba0c6ac9a51274f5ef16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723832Reviewed-by:
-
