- 30 Aug, 2018 40 commits
-
-
Mohsen Izadi authored
This CL moves portions of GpuProcessHost that implement viz::mojom::GpuHost out of content into //components/viz/host/ as GpuHostImpl. GpuHostImpl also owns GpuServicePtr, so parts of GpuProcessHost that work directly with GPU service are also moved. Whenever needed, GpuHostImpl accesses content through its Delegate interface implemented by GpuProcessHost. This is mostly needed to access content::GpuDataManager. BUG=709332 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5f27805aff16fe7db753c4700dbab5bf5ee0812d Reviewed-on: https://chromium-review.googlesource.com/1180658Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587741}
-
Jan Wilken Doerrie authored
This change adds work arounds for platform limitations on Windows to the FidoCableDiscovery. In particular, multiple EIDs are not supported. Bug: 837008 Change-Id: Ic84fac8abef076697ea73c191a43a22045986bcf Reviewed-on: https://chromium-review.googlesource.com/1197365Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#587740}
-
Esmael El-Moslimany authored
Bug: 875461 Change-Id: I4198baa1461241de0f869cb63fb688a74ba5e337 Reviewed-on: https://chromium-review.googlesource.com/1194338Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#587739}
-
Troy Hildebrandt authored
Adds the ability to record CPU frequency on Android devices, viewable in the Chrome trace viewer. Records the CPU frequency on a per-cluster basis, meaning for a Pixel/Pixel 2 we have two separate trace counters for CPU0-3, and CPU4-7. The sampler is a TraceLog::EnabledStateObserver, so on Android devices it will start and stop when tracing is enabled and disabled. Bug:873303 Change-Id: I1702fa184f16c53f200667528bb88e96957b0e65 Reviewed-on: https://chromium-review.googlesource.com/1123029 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#587738}
-
Christopher Thompson authored
This adds the DownloadConnectionSecurity of the download and a boolean for whether the final download URL is a different host than the originating URL to the existing Download.Started UKM. This also refactors out the logic for checking the DownloadConnectionSecurity into a new public function (CheckDownloadConnectionSecurity) in download_stats.h and exposes the underlying DownloadConnectionSecurity enum. This will help us identify sites that have a lot of downloads over HTTP (or go over HTTP in their redirect chain) for outreach efforts. Bug: 839986 Change-Id: I9a1bb78b8c62547e322ec1b85b5acfaa7acc813a Reviewed-on: https://chromium-review.googlesource.com/1195854 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587737}
-
Dale Curtis authored
8-bit YUV is no longer stored in 16-bit components with recent libaom builds. So we don't need this hack anymore. I've also cleaned up some TODOs and code structure. BUG=867613 TEST=unittests still pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7093240e4475ff4367e5f49681c0172e7ad11152 Reviewed-on: https://chromium-review.googlesource.com/1178938Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#587736}
-
Nathan Parker authored
Bug: 849781 Change-Id: I09a37db757ea0a53c2e9bdddd6c0fdb23250ae6f Reviewed-on: https://chromium-review.googlesource.com/1180725 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#587735}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e70aff80976e..678f5418d36f git log e70aff80976e..678f5418d36f --date=short --no-merges --format='%ad %ae %s' 2018-08-30 tsepez@chromium.org Fix lifetime issue in CCodec_ProgressiveDecoder. Created with: gclient setdep -r src/third_party/pdfium@678f5418d36f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:879025 TBR=dsinclair@chromium.org Change-Id: Ib8c406eeae805bdb9a4e27c0fbe551a3a2368759 Reviewed-on: https://chromium-review.googlesource.com/1197287Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587734}
-
Philip Rogers authored
PaintPropertyNodeTest.InitialStateAndReset had an expectation that the initial root paint property state was changed. This could fail if the test was run after another test that modified the root node's state. This patch initializes the root node state to be unchanged. Bug: 879017 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If30731871ac8bffb66f8b3a387510e7e2d6fea56 Reviewed-on: https://chromium-review.googlesource.com/1196824Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587733}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/browser/ui/ntp. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=justincohen@chromium.org Bug: 874080 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5e564d5d5fe57d7c17d06d6e3e79a1b1f609054d Reviewed-on: https://chromium-review.googlesource.com/1191677Reviewed-by:Justin Cohen <justincohen@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587732}
-
Frank Tang authored
date-proto-generic-invocation has an errorneous expectation. When a fix for crbug.com/v8/7961 was landed, that led to a test failure. This CL marks the test for Skip and fix the expectation manually. See https://test-results.appspot.com/data/layout_results/linux-blink-gen-property-trees/350/layout-test-results/results.html Once the fix for bug v8:7961 [1] is landed and rolled to Chromium, the Skip line can be dropped. [1] https://chromium-review.googlesource.com/c/v8/v8/+/1195539 Bug: v8:7961 Change-Id: I904d31dcb37fc1742aef15aa65302c7545a29015 Reviewed-on: https://chromium-review.googlesource.com/1196032Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587731}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2807b42c18d..59cbc10725c5 git log e2807b42c18d..59cbc10725c5 --date=short --no-merges --format='%ad %ae %s' 2018-08-30 xixuan@chromium.org cbuildbot: Move reef-chrome-pfq to skylab. Created with: gclient setdep -r src/third_party/chromite@59cbc10725c5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I23906d937ad4b6accba7aafed57237a792322365 Reviewed-on: https://chromium-review.googlesource.com/1197285Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587730}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/80aa5592d9dd..5fdc38cf171b git log 80aa5592d9dd..5fdc38cf171b --date=short --no-merges --format='%ad %ae %s' 2018-08-30 tobine@google.com Add jsoncpp as third_party dep 2018-08-30 oetuaho@nvidia.com Implement TexStorage3DMultisample on the GL backend Created with: gclient setdep -r src/third_party/angle@5fdc38cf171b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Id1cc1edfdfd8f211fb6332a203ca4a7b8feda691 Reviewed-on: https://chromium-review.googlesource.com/1197282Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587729}
-
Tanja Gornak authored
This CL creates new InvalidatorRegistrar. New InvalidatorRegistrar depends on ObjectId as little as possible. New InvalidatorRegistrar will be used on follow-up CL. https://chromium-review.googlesource.com/c/chromium/src/+/1194032/5 Bug: 878446, 801985 Change-Id: I9f34d78a1eeb8d28a42ed0e90ee8701fba83192e Reviewed-on: https://chromium-review.googlesource.com/1193887 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#587728}
-
Sunny Sachanandani authored
Add CommandBufferTaskExecutor::Sequence to encapsulate execution of command buffer tasks. Sequences are backed by Scheduler sequences for GpuInProcessThreadService which is used for viz OOP-D, and tests. DeferredGpuCommandService, which is used for Android Webview, implements sequences which post tasks to a global task queue. Add missing sequence checks to InProcessCommandBuffer and clean up related code. Change TestInProcessContextProvider to initialize context in BindToCurrentThread() to satisfy thread checks, and fix tests to call that. Bug: 778753 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iab37f051e80fa725cf746a90f5df6dcdd994c300 Reviewed-on: https://chromium-review.googlesource.com/1157874 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#587727}
-
Mike Wittman authored
Renames targets to better reflect what they provide. Removes the :metrics dep from the target for child processes to avoid including unnecessary browser-process-only code in those processes. Breaks the direct dependency of CallStackProfileBuilder on :metrics by introducing a receiver callback abstraction. Bug: 878509 Change-Id: I03a590f31be8c9641c9f375d8dbc0f8bc254b7d4 Reviewed-on: https://chromium-review.googlesource.com/1195808 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#587726}
-
Tom Anderson authored
R=sky Change-Id: I7fe86da5c95c92b95c62745d5b2f49fd7e2a68ef Reviewed-on: https://chromium-review.googlesource.com/1195089 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chcunningham authored
The wrapper was used to provide references to SigninManager while the transition to IdentityManager was ongoing. The ancestor of this CL* will complete that transition, so we can delete this wrapper. *https://chromium-review.googlesource.com/c/chromium/src/+/1175911 Bug: 809031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I359d2beebdf76d6620ec46b5bc58748ebb61e544 Reviewed-on: https://chromium-review.googlesource.com/1175916 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#587724}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/printing/cloud_print. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 874080 Change-Id: I6aea7df223626bd1ad2a2e6659a19920fd90cb2b Reviewed-on: https://chromium-review.googlesource.com/1191226Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587723}
-
Michael Giuffrida authored
And show a toast when the user presses the Assistant key. manually in Demo Mode Bug: 878989 Test: unit_tests (ChromeArcUtilTest.IsAssistantAllowedForProfile_DemoMode), Change-Id: I31c70c66d777f91357af8f0ee0191262a9f17090 Reviewed-on: https://chromium-review.googlesource.com/1196039Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587722}
-
Henrik Grunell authored
Bug: b/112920125 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iff889d9ab31c8b5b5a43f8c4b835ef6e70ef6044 Reviewed-on: https://chromium-review.googlesource.com/1190702Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#587721}
-
erikchen authored
Change-Id: I364ee289fc329d2fc3636ca63d8c80d83af5fe2d Reviewed-on: https://chromium-review.googlesource.com/1196963Reviewed-by:
Alexander Yashkin <a-v-y@yandex-team.ru> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587720}
-
Victor Miura authored
Tests enabled on Mobile: - css_opacity_plus_n_layers_0 - css_opacity_plus_n_layers_75 - css_opacity_plus_n_layers_99 - js_opacity_plus_n_layers_0 - js_opacity_plus_n_layers_75 - js_opacity_plus_n_layers_99 - js_paint_plus_n_layers_0 - js_paint_plus_n_layers_75 - js_paint_plus_n_layers_99 - infinite_scroll_element_n_layers_0 - infinite_scroll_element_n_layers_75 - infinite_scroll_element_n_layers_99 - infinite_scroll_root_n_layers_0 - infinite_scroll_root_n_layers_75 - infinite_scroll_root_n_layers_99 Tests enabled on Desktop: - css_opacity_plus_n_layers_99 - js_opacity_plus_n_layers_99 - js_paint_plus_n_layers_99 - infinite_scroll_element_n_layers_99 - infinite_scroll_root_n_layers_99 BUG=878951 Change-Id: Iac2cb8d55424ef47e7f33de375540dee7cbc43c3 Reviewed-on: https://chromium-review.googlesource.com/1192690 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#587719}
-
Scott Violet authored
I'm doing this as a precursor to having the WindowTarget know the Window it's associated with. We could certainly support non-WindowTargeters, but I don't think that really buys us anything. BUG=878836 TEST=covered by tests Change-Id: Iabe32319ba28796d4b90e967617bc4f95ff5581e Reviewed-on: https://chromium-review.googlesource.com/1195666Reviewed-by:
-
Kai Ninomiya authored
This allows the WebGPU dummy command handler in the GPU process to be invoked via JavaScript (with --enable-unsafe-webgpu). webgpu.getAdapter({}).createDevice({}).dummy(); The dummy method and command will be removed when we add real functionality, but right now this lets us prove out the full pipeline. Bug: 877147 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I93cfe918749258a532a6cf978b799891f359c51a Reviewed-on: https://chromium-review.googlesource.com/1186129 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#587717}
-
Balazs Engedy authored
Bug: 849323 Change-Id: I45aa37db4cdd396b8eac174e0a82a2a11abacb4c Reviewed-on: https://chromium-review.googlesource.com/1196526Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587716}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb32668137d0..eabc276ceacd git log cb32668137d0..eabc276ceacd --date=short --no-merges --format='%ad %ae %s' 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@eabc276ceacd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I78fe04a26adac3584dce50b3b1b34aa8ed2aed8e Reviewed-on: https://chromium-review.googlesource.com/1196688Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587715}
-
Moe Ahmadi authored
This change splits the string resource used for local save and upstreaming (originally introduced in crrev.com/c/1099178) into two resources with the same string in order to allow string experiments for the upstream infobar. Bug: 852427 Change-Id: I859f29a9f06ba412299b21bc3fa096ce5da9e6c3 Reviewed-on: https://chromium-review.googlesource.com/1196825Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587714}
-
Patrick Monette authored
Bug: 846953 Change-Id: Id9e80e045a598ae59617ebdd5b4d08a2eba961bf Reviewed-on: https://chromium-review.googlesource.com/1153448Reviewed-by:
-
Balazs Engedy authored
Bug: 849323 Change-Id: I2383118ba5f8032f0443c315972c890683a71f81 Reviewed-on: https://chromium-review.googlesource.com/1197366Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587712}
-
Francois Doray authored
Today, WebContents::GetVisibility() returns HIDDEN for a tab that is in a minimized window shown in the Alt-Tab view on ChromeOS. This is because content::WebContents::GetVisibility() indicates the visibility of the aura::Window, and isn't affected by the mirroring functionnality used by the Alt-Tab view. Unfortunately, the fact that WebContents::GetVisibility() returns HIDDEN makes TabManager think that the tab is eligible for freezing and discarding (freezing or discarding a tab in Alt-Tab breaks the live view functionnality). TabManager could check by itself whether the WebContents IsBeingCaptured(), but instead of requiring that every call to WebContents::GetVisibility() be accompanied to a check to IsBeingCaptured(), we believe it's better to return VISIBLE from GetVisibility() when a tab is displayed in Alt-Tab view. Bug: 876103 Change-Id: I01c07858bcae3038577bac1408c67eb72fe08e0c Reviewed-on: https://chromium-review.googlesource.com/1191862Reviewed-by:
-
Che-yu Wu authored
The new quarantine feature for chrome cleanup tool needs a finch switch to control it. It adds "--quarantine" into the command line when launching the cleaner if the switch is enabled. It will be only enabled on the cleaner. So only adds switch to the cleaner, but not to the reporter. Default is disabled. Bug: crbug.com/878794 Change-Id: Ibb6f7bf76c36fbaf6106ede1ee9b6049cb2c5d2e Reviewed-on: https://chromium-review.googlesource.com/1194404Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Che-yu Wu <cheyuw@google.com> Cr-Commit-Position: refs/heads/master@{#587710}
-
bsheedy authored
Switches all the waterfalls using Mac Retina devices on Chrome-GPU to only trigger tests on devices with 10.13.6 instead of both 10.13.6 and 10.13.5 now that all devices have been upgraded to the newer OS vesion. Bug: 868032 Change-Id: I58448310621430fae7cec763acedc190a6c29b17 Reviewed-on: https://chromium-review.googlesource.com/1197329Reviewed-by:
-
spqchan authored
Bug: 867518 Change-Id: I9749e8932758a893225368b0042cd4439ee11de1 Reviewed-on: https://chromium-review.googlesource.com/1195673 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#587708}
-
agrieve authored
This reverts commit b81f63ce. Reason for revert: retrace bug now fixed Original change's description: > android: disable deobfuscation in tests. > > Deobfuscation appears to be hanging in ways that cause it to peg > bots' CPUs and kill test runs. This CL temporarily disables it as > a mitigation. > > Bug: 876539 > Change-Id: I6dced1a4c80e630bb701a17eaa8322450661adc5 > Reviewed-on: https://chromium-review.googlesource.com/1185294 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585190} Bug: 876539 Change-Id: If6c19b7345e769d51d1580980aca8e3967319a97 Reviewed-on: https://chromium-review.googlesource.com/1195432Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#587707}
-
John Rummell authored
Now that Media Licenses are included with cookies and other site data on the basic tab, move Media Licenses up to just below cookies on the advanced tab. This is for Android only. BUG=877999 TEST=tested locally Change-Id: I55223d51178610125ce83ce357c539ed93656050 Reviewed-on: https://chromium-review.googlesource.com/1196040Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#587706}
-
Robert Sesek authored
Previously, browser test binaries (e.g. browser_tests, interactive_ui_tests, etc.) set up paths so that child processes would use Chromium Helper.app, which matches the production process launching path. However this prevents the child process from linking in test-only code, because it is a distinct binary from the main test executable that acts as the browser process. This change makes it so that the child process binary is the same as the main test binary, which matches how other platforms behave. Bug: 877992 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic04f0d47726be89d953ea227b8a104dc7bb88c0f Reviewed-on: https://chromium-review.googlesource.com/1193969 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#587705}
-
Yi Su authored
FindBar on iPhone has swithced to autolayout. This CL lets FindBar on iPad use autolayout as well so that the FindBar won't be dismissed and reshowed when iPad rotates. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie5ef497c711e2cdfed1721c2468579ecb1eec17a Reviewed-on: https://chromium-review.googlesource.com/1193954Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587704}
-
Mike Klein authored
We're doing some clean up and would like to retract SkColorSpaceXform from Skia's public API. It's obsolete now that you can either, 1) just use Skia's drawing pipeline or readPixels()/writePixels() for most of its functionality; or 2) use the much more flexible skcms interface for fancy features. In the case of ui/gfx/color_transform, I decided to go with skcms because it can naturally consume and produce the 3-float TriStim format this code wants to use. The old SkColorSpaceXform required two extra transformations and an allocation, where skcms can do everything in place natively. Using draws or readPixels()/writePixels() would have required us to keep those extra transforms, as they don't (yet?) support RGB_fff pixels. Change-Id: I70f64c3ad72ebe227ed7a2a1dd7391863a8737e3 Reviewed-on: https://chromium-review.googlesource.com/1196375Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#587703}
-
David Davidović authored
Add a feature that controls whether scrypt key derivation should be used when a user sets a new custom passphrase. If the feature is disabled, PBKDF2 will be used (i.e. old behavior). Bug: 877933 Change-Id: I2009c8d8cfc7cef57743fbf8f3c9a6ec48ef07a4 Reviewed-on: https://chromium-review.googlesource.com/1193855 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#587702}
-
