GitLab

If a user has an args.gn which specifies an argument which isn't
actually used in the build, gn will output a warning on stdout (instead
of stderr) but otherwise continue as normal. Then gen_fuzzer_owners.py
in GetSourcesFromDeps will add a number of 'sources' which are actually
lines from the warning message. This leads to difficult to diagnose
errors later on.

Since there is no means to suppress this warning nor move it to stderr,
this change adds '--fail-on-unused-args' to the gn command so that the
owner finding will fail earlier and and more obviously.

Change-Id: I617fe3b500ada13323b77bb18c8e40b256144833
Reviewed-on: https://chromium-review.googlesource.com/c/1286731Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600466}

In https://crrev.com/600111 we added logic to automatically stop
truncation when logging on android. This patch removes a workaround that
avoided truncation in LayerTreeHostImpl.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3f9547a5d9efb5a3f9c0123019d2eb8307daa6a6
Reviewed-on: https://chromium-review.googlesource.com/c/1286353Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600465}

It fuzzes PDFium's core/fxcrt/xml code, which is in non-XFA builds.

Change-Id: I95e53ca24f4a6e298d88315dbb8e013cf6d7e06f
Reviewed-on: https://chromium-review.googlesource.com/c/1286429Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600464}

In order to invoke common platform tasks (send attention sequence
and lock workstation), CRD currently relies on injecting key events
on the client and picking them up on the host.  There is a listener
which tracks the current key events and then calls the platform API
once it sees the trigger.

The problem with this approach is if there is a stuck key (i.e. we
fail to send a key up event) then this functionality is broken.
While we should fix bugs which cause lost key events, we should also
look for ways to prevent issues like that from affecting other
features.

My change allows the client to send a single message to invoke an
action like LockWorkstation() or SendSAS() which will then be
executed in the user's session.  The change is targeted at the
Windows multi-process architecture but I've used interfaces to
allow for other platforms to use it (similar to how InputInjection
and the other event protos are used) if we decide to implement
it in the future.

This CL sets up the plumbing to get the request from the network
process to the desktop process on Windows.  There will be a
follow-up CL which adds the WebRTC data channel and ClientSession
integration.

Bug: 892434

Change-Id: Iedfe8c4778fbaacacc68754c6d24e7fd485b0407
Reviewed-on: https://chromium-review.googlesource.com/c/1266100Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600463}

It seems this is stable recently with the current filter.
Let's run under the main waterfall.

BUG=883523
TEST=none

Change-Id: Ia14281c1e5a276c5057ae7653547086347c3ee0c
Reviewed-on: https://chromium-review.googlesource.com/c/1285055Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600462}

Change-Id: Ibcdfdca10c62b1d7327526483582a6022d57bd11
Reviewed-on: https://chromium-review.googlesource.com/c/1286734Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#600461}

This CL fixes NavigationContext::IsRendererInitiated for reloads and
WebStatePolicyDecider::RequestInfo::transition_type for
browser-initiated navigation.

Bug: 676129, 725239
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I608b208d204bc055fcfd6c34dd7bd2a04b9c232a
Reviewed-on: https://chromium-review.googlesource.com/c/1282448
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600460}

Fix for error during creating chrome_public_apk:

In file included from gen/chrome/browser/browser_jumbo_17.cc:42:
./../../chrome/browser/android/explore_sites/image_helper.cc:22:11: error: redefinition of 'kFaviconsPerCategoryImage'
const int kFaviconsPerCategoryImage = 4;
          ^
./../../chrome/browser/android/explore_sites/explore_sites_service_impl.cc:27:11: note: previous definition is here
const int kFaviconsPerCategoryImage = 4;
          ^
1 error generated.

Example compilation settings:

target_os="android"
target_cpu="arm"
enable_nacl=false
symbol_level=0
remove_webcore_debug_symbols=true
is_debug=false
dcheck_always_on=false
is_component_build=false
use_jumbo_build=true

BUG=895593

Change-Id: Ic9eaae0239fd4ab53a357df7dff2143b0cc921c4
Reviewed-on: https://chromium-review.googlesource.com/c/1285056Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#600459}

Bug: 873178
Change-Id: I03f3a4dcc4798e8d1c1705c65cc4c7efde37a00b
Reviewed-on: https://chromium-review.googlesource.com/c/1278845
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600458}

We have touchpad pinch on Windows and CrOS in addition to Mac (and Linux
shares all the necessary code to run the test). So we no longer restrict
this test to running on Mac.

Bug: None
Change-Id: Iaa3715b2a5de9c5264b22b282e1a9bca48ea4385
Reviewed-on: https://chromium-review.googlesource.com/c/1286871Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600457}

Fix suggested by Tiger in crrev.com/c/1240503.

Change-Id: Id7881a60bcc62bf0526c82e80b469db03e350044
Reviewed-on: https://chromium-review.googlesource.com/c/1286929Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600456}

scheduler/util/thread_type.h was deleted in January but the
reference to it in BUILD.gn remained. Now that seems to make
the isolate step in trybots sad.

Bug: 776416
Change-Id: Iff685c54def879a8c5a53c9893f1c7eef4c9c13c
Reviewed-on: https://chromium-review.googlesource.com/c/1286851
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600455}

Blob URLs are ephemeral, so it doesn't make much sense to allow
redirecting to them.

See comments on crrev.com/c/1277785 for more info.

Change-Id: Iae31dc04f1ad4042d2b6861e05ca53699a3a31a6
Reviewed-on: https://chromium-review.googlesource.com/c/1278132Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600454}

We should drop the drag window into overview if it has been dragged
further than half from the top of the work area to the top of the drop
target. The old logic consider the drag distance based on the top of the
display is not correct. Since the top of the display is not always
equals to the top of the work area. e.g, enable dock magnifier will put
a magnifier window in the top area of the display which will change the
work area.

Bug: 866680
Change-Id: I8b31c68501a36ed7fd82650a93145475f8c84e5c
Reviewed-on: https://chromium-review.googlesource.com/c/1285353
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600453}

Remove SetAcceleratedCompositingEnabled() from WebSettings as it is
not something toggled by content.

Change the default for Page (and Settings) to disable compositing, as a
Page on its own can not be composited. Creators of Page no longer need
to disable compositing on it.

Change WebViewImpl to opt-in instead of opt-out of compositing.
WebViewImpl is always composited (except in weird cases) and it sets
up compositing with a WebLayerTreeView etc. It thus also knows it
should SetAcceleratedCompositingEnabled(true) on the Page.

Also change WebPagePopupImpl to opt-in to compositing always, as it
has its own Page, and no strange non-compositing cases.

Unit tests that went to test behaviour in blink core that depend on
compositing being enabled, and which create a Page directly instead
of a WebView, will enable compositing on the Page explicitly.

R=dcheng@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide8a2058837b6889b36affb581669d03489f9c98
Bug: 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1279148
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600452}

Trying to have only one account. :)

Bug: None
Change-Id: Ic526651531f14df5041d38d5fe6f55a72ae61822
Reviewed-on: https://chromium-review.googlesource.com/c/1286933Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600451}

I suspect that creating the loader and starting the load
immediate will make the problem go away.

Bug: 895582
Change-Id: I85d1710c279fa4bda624f653df83ea154c0b7858
Reviewed-on: https://chromium-review.googlesource.com/c/1284698Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600450}

VizHitTestDrawQuad was enabled by default but there were two bugs; the
bug on all platforms is fixed
https://bugs.chromium.org/p/chromium/issues/detail?id=880122 but the
one on cros is not; re-enabling it by default for all non-cros
platforms.

Bug: 804888
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic4c033c2a01c91d7135480c694ce2cde23f1434b
Reviewed-on: https://chromium-review.googlesource.com/c/1285084Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600449}

In chasing isolate step errors in trybots, this is removing some
dangling references from a BUILD.gn file (though it seems to be
a never-ending sequence of problems so whatever started generating
the isolate step errors should probably be reverted).

Bug: 781655
Change-Id: I09f530fa4a1e1cf3e1c0f15125eb8d9886f1038b
Reviewed-on: https://chromium-review.googlesource.com/c/1286818Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#600448}

Modified third_party build file to include Fullscreen Shell protocol,
allowing use of the protocol for EXO eventually.

Bug: b/74068068
Test: Compiled ChromeOS and verified it builds.
Change-Id: If785b9736679be2e18be5521e173888ab6ea6a6f
Reviewed-on: https://chromium-review.googlesource.com/c/1281175Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#600447}

Bug: 889998
Change-Id: Ief9fe4dd17d8eb11d0b968a008cc22b377c2fcf2
Reviewed-on: https://chromium-review.googlesource.com/c/1284049Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600446}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce15ef5cc47b..cb047393e8c6


Created with:
  gclient setdep -r src-internal@cb047393e8c6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:803846,chromium:884294
TBR=mmoss@chromium.org

Change-Id: I41c517668f1277fa5084519ba7340d43f51e0ea9
Reviewed-on: https://chromium-review.googlesource.com/c/1286697Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600445}

This reverts commit b54f7c7f.

Reason for revert: breaking the tree

Original change's description:
> [Cronet] Create a sample app for native api.
> 
> Bug: 786559
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
> Reviewed-on: https://chromium-review.googlesource.com/c/1274426
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Commit-Queue: Misha Efimov <mef@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600438}

TBR=pauljensen@chromium.org,mef@chromium.org

Change-Id: I3cc86a29982f4479a3260ec2522847416fe6547b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/c/1286935Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600444}

https://skia.googlesource.com/skia.git/+log/7bae65d0070c..f20c3493eb57


git log 7bae65d0070c..f20c3493eb57 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 kjlubick@google.com [canvaskit] Remove DAA and SAA from gpu build


Created with:
  gclient setdep -r src/third_party/skia@f20c3493eb57

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: I8e1c75d81236b3015b917b9fd8e8336cee3b1d8e
Reviewed-on: https://chromium-review.googlesource.com/c/1286696Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600443}

Always use 32dp padding in the one column layout. It looks odd on some
devices when 72dp padding is used.

BUG=896204

Change-Id: I6deddf3b35609b45fd29ba2c79293cfea2594708
Reviewed-on: https://chromium-review.googlesource.com/c/1286877Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600442}

A follow-up to https://crrev.com/c/1230042.

Change-Id: I7b786f41db42332c5addbd40b5a61a90e2764694
Reviewed-on: https://chromium-review.googlesource.com/c/1283750Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com>
Cr-Commit-Position: refs/heads/master@{#600441}

https://webrtc.googlesource.com/src.git/+log/5a464d3ee56a..fab9129e9427


git log 5a464d3ee56a..fab9129e9427 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 philipel@webrtc.org Get frame type, width and height from the generic descriptor.
2018-10-17 minyue@webrtc.org Adding NetEq buffer full metric to UMA.
2018-10-17 terelius@webrtc.org Change verification of stream configs in RTC event log unittest.


Created with:
  gclient setdep -r src/third_party/webrtc@fab9129e9427

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9a81d2224016b31534a15b05d32d904f2ff2e93f
Reviewed-on: https://chromium-review.googlesource.com/c/1286694Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600440}

It's currently using the SigninManager to retrieve the primary
(authenticated) account's email. Migrated to the IdentityManager API
so it could eventually make use of the identity service.

Bug: 890774
Change-Id: I92e1ddafaa8270a5fdd4b154de85a4be1f8a4168
Reviewed-on: https://chromium-review.googlesource.com/c/1286138Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#600439}

Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
Reviewed-on: https://chromium-review.googlesource.com/c/1274426Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600438}

TBR=msramek@chromium.org
BUG=894572

Change-Id: Ib9e4b0f6ec7376e727d43ae9a5b397f1e196087a
Reviewed-on: https://chromium-review.googlesource.com/c/1286351Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600437}

Initialization is usually done by previous tests, CWVAutofillProfileTest
will always fail on second try.

Bug: 895811
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ice37db622b6416fb8ce09688090fb5af9f1eda59
Reviewed-on: https://chromium-review.googlesource.com/c/1283017Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600436}

This CL changes the OmiboxTextField. Now the fonts aren't passed in the
constructor. Instead they are configured internally.

Bug: 892145
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2e8caa8c2cba4b276cfd2189f4a865fd70d4496b
Reviewed-on: https://chromium-review.googlesource.com/c/1286657Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600435}

This reverts commit 77787bcb.

Turned out this variable was unnecessary.

Bug: angleproject:2892
Change-Id: I4ecdca72733c7d283dd4a479ea53ac97aeeb61b2
Reviewed-on: https://chromium-review.googlesource.com/c/1285631Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600434}

Both ios-device and ios-device-xcode-clang seem to have disk space issues. This
is an attempt to reduce the disk space required for compilation on bots.

Bug: 895761
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iea34c089b780ecb9231ab2fc9031ae9f89ab998f
Reviewed-on: https://chromium-review.googlesource.com/c/1285770Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600433}

Specifically for the system-tray related files.

Bug: none
Change-Id: Ie0341b20c1406d358ed890e5df434e5dbc838d32
Reviewed-on: https://chromium-review.googlesource.com/c/1286816Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600432}

Bug: 891908
Change-Id: I16e0cdded27728d419f3889ed087613401f2c183
Reviewed-on: https://chromium-review.googlesource.com/c/1286774Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600431}

When the policy doesn't exist, an "OnExternalDataCleared" call could
be fired to notify clients, in case they still keep the old data from
a previous policy. It should be a no-op for clients that do not store
policy data.

Bug: 889108
Change-Id: I6061f3be1b650f026ea88f8d353b710fb0b3b16d
Reviewed-on: https://chromium-review.googlesource.com/c/1266695Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600430}

This reverts commit 10306935.

Reason for revert: Undoing speculative revert
The CL was not the culprit

Original change's description:
> Revert "Files app: Select My files when there are no volumes"
> 
> This reverts commit 6f65bd26.
> 
> Reason for revert: Speculative revert
> Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
> on Linux ChromiumOS MSan
> 
> Note: resolved conflicts with ES6 refactoring, therefore running tests...
> 
> Bug: 896219
> 
> Original change's description:
> > Files app: Select My files when there are no volumes
> >
> > Make Files app select "My files" when there are no available volumes,
> > this to allow Files app to behave properly when volumes subsequently
> > become available.
> >
> > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> > non-null |displayRoot| before trying to change to |displayRoot|. This
> > fixes the error "Cannot read property 'getParent' of null" when Drive
> > volume becomes available before the (default) Downloads volume/root.
> >
> > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> > DriveFsTestVolume can re-mount itself.
> >
> > Changes since revert:
> > 1. Add a new function |getVolumesCount| to return the number of volumes
> > available in the background page.
> > 2. Add the new function above to wait for background page to have all
> > volumes before un-mounting and wait it to unmount all volumes.
> > 3. Change some logs from error to warn because errors are expected and
> > handled when initializing volumes that are unmounting/unmounted in the
> > backend.
> > 4. Change selector used to click on Drive to actually wait for
> > "My Drive" to be available.
> > 5. A bit of more info in some logs around volume initialization.
> >
> > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> > Bug: 893161, 884967, 894799
> > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> > Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> > Reviewed-by: Noel Gordon <noel@chromium.org>
> > Reviewed-by: Sam McNally <sammc@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600282}
> 
> TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org
> 
> Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
> Bug: 893161, 884967, 894799
> Reviewed-on: https://chromium-review.googlesource.com/c/1286146
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600376}

TBR=noel@chromium.org,sammc@chromium.org,cfroussios@chromium.org,lucmult@chromium.org

Change-Id: I388a94fe12c7d40ac7ea779353c3b220bd5b5952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896219, 893161, 884967, 894799
Reviewed-on: https://chromium-review.googlesource.com/c/1286853Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600429}

Bug: 885244,893396
Change-Id: I4ab6c6890af83483514edd41f1e7d2aeb38e4a4a
Reviewed-on: https://chromium-review.googlesource.com/c/1286814Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600428}

The button itself was implemented by http://crrev.com/c2cff202 and this
patch implementes the implementation to show the settings page.

Bug: 864964
Test: manual
Change-Id: Iabe8ab1c20b66ee8b2f6f3161a9587f195236c70
Reviewed-on: https://chromium-review.googlesource.com/c/1258667
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600427}