- 30 Oct, 2019 40 commits
-
-
Tarun Bansal authored
Remove gcm_channel_status_request from list of traffic tags throttled when WebRTC calls are active. gcm_channel_status_request is not related to fetching of finch variations seed (which was the original intent). Bug: 1005841 Change-Id: I25506fc832198471251206c33599837eca4f48a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885229Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711031}
-
Moe Ahmadi authored
Bug: 1018433 Change-Id: I6d7bc590e8cb4d16b7589628744077dfc92c7605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888376 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711030}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b43d98bf6484..48823c28549d git log b43d98bf6484..48823c28549d --date=short --no-merges --format='%ad %ae %s' 2019-10-30 jbudorick@chromium.org Revert "Add more git tracing." Created with: gclient setdep -r src/third_party/depot_tools@48823c28549d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I384d57ec204bab50837d83ad78d50d9a1431831d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711029}
-
Yuwei Huang authored
The "Send Feedback" button in the app no longer works and according to the logs it seems we need to add gsf.permission.READ_GSERVICES permission to the Android manifest. I can't build and test the official build locally so I'd like to check this in frst then verify it on the nightly build. Bug: 1019866 Change-Id: Iac01e9db420d95a8c8a7aa952ad9d2ab1ac9b6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891464 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#711028}
-
Frank Tang authored
ICU 65-1 release note http://site.icu-project.org/download/65 CLDR 36 release blog http://blog.unicode.org/2019/10/unicode-cldr-version-36-languagelocale.html Most of the test expectation change is due to CLDR 36 update of Grapheme Cluster for Indic languages See the following for related changes in ICU 65.1 in this area: https://unicode-org.atlassian.net/browse/CLDR-10994 https://unicode-org.atlassian.net/browse/ICU-13637 https://github.com/unicode-org/cldr/blob/master/common/properties/segments/readme.txt Bug: chromium:1014272, chromium:1017047 Change-Id: I9fc6d4620bf2a4c189940d06d8c79893502db3dd Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866059Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711027}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the browser process and the assistant service from ChromeOS for the Assistant, AssistantController and the AppListEventSubscriber mojo interfaces to the new mojo types. Bug: 955171 Change-Id: Id57a7b0c80bd7985fff98929d0370af00becf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883517Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#711026}
-
Robert Kaplow authored
Remove some stale includes for already deleted metrics. Bug: 1016906 Change-Id: I8d6c33953df5caf367a33b9a0260b5a36d6ab754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876787Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#711025}
-
Sasha McIntosh authored
Restructure memory dump metrics to avoid double counting memory. Affected metrics: Memory.Experimental.Gpu2.Small.ServiceTransferCache Memory.Experimental.Gpu2.Small.ServiceTransferCache.AvgImageSize Memory.Experimental.Gpu2.Small.ServiceDiscardableManager Memory.Experimental.Gpu2.Small.ServiceDiscardableManager.AvgImageSize Bug: 963619 Change-Id: Ia1ae23ce99d351807eb1e3f9727882ec2257a153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888095Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711024}
-
Roberto Carrillo authored
We are currently getting 6 out of 10 shards timing out with ~ 75% - 95% progress. R=agable,martiniss,liaoyuke Bug: 1017486 Change-Id: I5281a459dd87b27f406abbb3cbac3b27aae54544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889397 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711023}
-
Xiaohan Wang authored
RAPPOR is being deprecated and media code has migrated to use UKM. So remove all RAPPOR reporting in media. Bug: 1016906 Change-Id: Ifff3c8f40793972f99c8f585410615319e072a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875653Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711022}
-
Anastasia Helfinstein authored
go/cros-switch-navigation Bug: 1011630 Change-Id: I27d974be1c549f176c9ccd2c4d1814b02e5498c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876867 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#711021}
-
Nick Burris authored
Scroll anchoring should not anchor to a node that is behind scroll padding. Bug: 1010002 Change-Id: Icbd89fb85ea2c97a6de635930a9896f6a87b8f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887745Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#711020}
-
Vladimir Levin authored
This patch adds more tests for img (layout replaced) with intrinsic-size specified, since the coverage was lacking. R=chrishtr@chromium.org Bug: 1016470 Change-Id: Ief95a39d6f351923f51644893d54a7dd435c5c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890009 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Sky Malice authored
This reverts commit e1aacdeb. Reason for revert: chromium-internal-arm-builder's generate_build_files is broken by this, see https://ci.chromium.org/p/chrome/builders/ci/chromium-internal-arm-builder/7799 Original change's description: > Reland: Rename gl_test to gpu_tests > > This is to make the name reflect that there aren't just OpenGL tests in > this executable now, there are WebGPU / Dawn tests too. > > TBR=zmo@chromium.org > > Bug: 1017035 > Change-Id: I5f0f04a2082533eda1cd6c474c85214e2195304d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888936 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710854} TBR=zmo@chromium.org,cwallez@chromium.org,jbudorick@chromium.org Change-Id: Id0dcd22a2246be1f4a1507f336e8f63eddb03557 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891469Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711018}
-
Caleb Rouleau authored
Note that this will have no impact on what is currently running on the waterfall because all benchmarks are labeled as abridged: False right now. This change is now possible because: 1. Pinpoint was taught to use the --run-full-story-set flag by https://chromium-review.googlesource.com/c/catapult/+/1874451 2. benchmark_smoke_unittest.py was fixed: https://chromium-review.googlesource.com/c/chromium/src/+/1874821 Note that system_health_smoke_test.py is fixed as part of this change. I tested this fix by running /run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:game and seeing that the stories, a mix of health_check stories and stories without the health_check tag were all run. Bug: 965158 Change-Id: I42ca28543155536da62d9b02d9bf31d8eb311ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687783 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#711017}
-
Dave Tapuska authored
As outlined in https://docs.google.com/document/d/1QO99UstlPTY8eK4Lnc9qcNq3wQYTBDBsRZu6nGC4XG4/edit Create a RemoteFrameHost mojo interface in blink so blink can talk directly to the browser without going through the content/renderer layer. Since there aren't any other mojo interfaces requested on the remote frame in blink this required a bunch of AssociatedInterfaceProvider plumbing to be added. This change also moves the first message over SetInheritedEffectiveTouchAction. BUG=1008432 Change-Id: I9ec0e55e90805c732abb2fb9447ff8724d16c439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874055Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#711016}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4d322b9e167e..1c93b3dec290 git log 4d322b9e167e..1c93b3dec290 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 dproy@chromium.org Switch back test runner from chromium to chrome Created with: gclient setdep -r src/third_party/catapult@1c93b3dec290 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1015942 Change-Id: I83401fb5a383cd9e47a7a3709015cb75d8829f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890596Reviewed-by:
-
Xida Chen authored
This reverts commit 420ab929. Reason for revert: Caused failure, because OOP-R didn't handle off-thread paint worklet yet. Original change's description: > Ship off-thread Paint Worklet > > All the blockers for this feature has been removed, and it is ready to > be shipped. > > Note that normally the "enable-threaded-compositing" is not enabled > when running the layout test, and off-thread paint worklet layout tests > are meaningless without the compositor thread. So this CL makes the > layout tests running on the main thread, which means we need to keep > the virtual/threaded/external/wpt/css/css-paint-api/ tests. > > Bug: 829967 > Change-Id: Ie7bd45e09c01729c238c1e3b8fb38e717e84e70e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869332 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709230} TBR=haraken@chromium.org,xidachen@chromium.org,smcgruer@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829967 Change-Id: I68adbc32698a588f33d36fd592d5b6f68e53a8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891144Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711014}
-
Clark DuVall authored
This is a reland of e26a5125 This conflicted with http://crrev.com/c/1888389 and caused a compile error. Original change's description: > [WebLayer] Fix crash when top controls view has 0 height > > This happens because the adapter and layer for the top controls is only > created once height and width are > 0. We were assuming this had already > been created in setTopControlsOffset(). > > Change-Id: Idf104f9d5c951c1fa8719fa30661dceae59b4887 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890492 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710897} TBR=sky@chromium.org Change-Id: I482a241fcb43fe2bff3ec8f315cfed5ee266e828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890959Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711013}
-
gogerald authored
Bug: 1019777 Change-Id: I9e7a2520b588dd0c993fff3a95386d37cee077fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890793Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#711012}
-
Tomasz Wiszkowski authored
When navigating to a webpage and then back to NTP using home button, pressing fakebox to activate omnibox input reports context as NTP, rather than NTP with fakebox/realbox as starting focus, though this does not seem to be 100% the case, either. This change ensures that plain NTP also triggers ZPS suggestions when users navigate to NTP page by pressing the home button, and have the On-Focus suggestions set to a non-default value (fixes possible flakiness for test team) Bug: 1004925 Change-Id: Id2930ad1651f23a3710d1e3124bd291a81e7bc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890497Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#711011}
-
Wenbin Zhang authored
[Benchmarking] Updated the dimension to ensure homogeneous fleets: updating device OS for Android Go and Android pixel2 In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the device_os for the following Android builders. The available bots under the old/new dimension values can be found in the links. - android-go-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=gpu&c=os&c=status&c=synthetic_product_name&d=desc&f=device_os_flavor%3Agoogle&f=device_type%3Agobo&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf&s=synthetic_product_name - android-go_webview-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=os&c=pool&c=status&c=synthetic_product_name&d=asc&f=device_os_flavor%3Agoogle&f=device_type%3Agobo&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf-webview&s=synthetic_product_name - android-pixel2_webview-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=device_os_flavor%3Agoogle&f=device_type%3Awalleye&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf-webview&s=device_type - android-pixel2-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=device_os_flavor%3Agoogle&f=device_type%3Awalleye&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf&s=synthetic_product_name Bug: chromium:996830 Change-Id: I97b40110ff6a0c86ac200f245ebc39c79787a33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889948Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#711010}
-
Nathan Zabriskie authored
As part of the OOPR-Canvas2D project this CL changes IsGpuContextLost() to query RasterInterface instead of the current GLES2Interface. This is done with the goal of removing all references to the GLES2Interface in Canvas2D code so that we can fully transition to RasterInterface for oop-r. Change-Id: Ib740d7f3554493e31429dd60e42198095a4c746b Bug: 1018898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877109Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Dana Fried authored
Unfortunately, a side-effect of the capture code we're currently using is that it triggers an instantaneous loss and then regaining of mouse hover over the current controls; this results in capture starting and stopping again in a tight loop. This change allows existing capture to continue until the first time a result comes in and either (a) the page is done loading [which is existing behavior] or (b) we've stopped observing the thumbnail. It prevents a momentary shakeup in whehter the thumbnail is being observed from locking the browser into the tight loop described above. We still want to follow up and determine *why* (and on what platforms - it might just be Windows) starting capture causes mouse hover to be lost; if we can't fix the signal we may have to debounce it in the hover card system to prevent unintended visual results. Bug: 1019303 Change-Id: Iec0cba64398891d589d3cbe6d7abeab0e1e230b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891142 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#711008}
-
Simeon Anfinrud authored
With this, you can make the compiler ensure, statically, that the methods of your class always run on the same sequence. This is vastly safer than runtime checks like SequenceChecker since it will fail to compile if you violate the requirement. (It wouldn't be C++ if there weren't hacky ways around this, but any attempt to trick the compiler into allowing a sequence violation should look pretty obvious to reviewers.) To use this, declare a struct that inherits from StaticSequence. This struct will automatically declare a Key class that can only be constructed inside the StaticSequence's PostTask function. To force users to go through that StaticSequence's PostTask() to call your method, simply declare a reference to the Key object as the last parameter to the method. This also includes a wrapper template called Sequenced, similar to base::SequenceBound, but with the TaskRunner known at compile time rather than runtime. This can be used to add an extra level of safety over runtime checks like DCHECK_CALLED_ON_VALID_SEQUENCE or TaskRunner::RunsTasksInCurrentThread. This wrapper ensures the wrapped object is destroyed on the correct sequence, essentially turning any sequence-affine object to a thread-safe object. This will be made even more useful once base::PostTask() returns a base::Promise, as it will work with methods that return values as well as void methods. Bug: None Test: cast_base_unittests Change-Id: Ic408e343bc084c19c4c6f9e983b343b98502daf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863549Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711007}
-
Kai Ninomiya authored
This workaround was added for Linux set-top boxes with Mali-400. However, the workaround is not needed on Android devices with Mali-400 (probably due to using a completely different driver). The disable_gl_rgb_format code path is poorly tested and had at least one bug, so reduce the workaround to only apply to Linux. Bug: 1018528, 449150 Change-Id: Ic2f5248a8ff943edab90c24577ea94601693a32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891139Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711006}
-
https://crrev.com/c/1881978Ce Chen authored
the flaky unittest. Here we simplify unittests, especially "TestIncognito" by only checking return value of OnDeviceHeadProvider::IsOnDeviceHeadProviderAllowed. This unittest in the previous change was too heavy that it fired mulitple async calls and might eventually caused data race in ScopedFeatureList on some platforms: http://screenshot/8x1yJO66CjU. Non test cc files are the same as previous CL. Bug: 925072 Change-Id: I1e4c1666ceb7c24a599f5539d0ace90f0fc98b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888691 Commit-Queue: Ce Chen <cch@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#711005}
-
Dave Tapuska authored
Move FrameMsg_DidUpdateOrigin to a RemoteFrame mojo interface. Addded DecodeURLEscapeSequences to the mojo deserialization of a url.mojom.Origin when converting to a blink::SecurityOrigin. Change https://crrev.com/5f709c23e66 added a change to the legacy IPC path but the relevant change wasn't in the mojo path. So adjusting this message to go through mojo causes the test case to fail so fix the decoding appropriately to match the legacy path. BUG=1008432 Change-Id: I63b4a47e37e5740a4712f921c87292dcb15ca8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874197Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/924dad3b22c2..5da6f444eff6 git log 924dad3b22c2..5da6f444eff6 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 jmadill@chromium.org Fix error string commas. Created with: gclient setdep -r src/third_party/angle@5da6f444eff6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I522c66f5a999fbc378734b447eb5653ab57fc950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890594Reviewed-by:
-
Akihiro Ota authored
Adds ChromeVox jump commands to go to the next or previous paragraph. Bug: 1002101 Change-Id: I9bfd6462cb2875a9867c6b0939f0700a277148ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850756Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#711002}
-
Kai Ninomiya authored
On Android Mali-400 devices (and probably Linux Mali-400 devices, for which this workaround was originally added), the alpha channel (allocated due to disable_gl_rgb_format) was not cleared in CreateColorBuffer. This caused flickering of any WebGL backbuffer with {alpha:false,premultipliedAlpha:false}. Bug: 1018528 Change-Id: I35b9cf24c6a5e46cf902dd815b942d56b62c1c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891137Reviewed-by: -
dpapad authored
Typos (missing "]" bracket) were introduced at r709022 and r709160. Bug: 1019576 Change-Id: I0950c8f466f5a1a825cb92435ba969585bedce71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890502 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711000}
-
Ted Choc authored
Ran locally w/o retry 20 times for each of these tests and did not see any issue. This also removes WaitForIdleSync calls by replacing them with CriteriaHelpers to hope avoid a constant source of flakes. This also switches to opening about:blank instead of the NTP on launch since it is much faster to load. BUG=147960 Change-Id: Ia6f0cd0cdb1b872bbbcda5572a15bc183844edc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890982Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710999}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a9ac8a51fdb3..c7a8df8b1cdb git log a9ac8a51fdb3..c7a8df8b1cdb --date=short --no-merges --format='%ad %ae %s' 2019-10-30 herb@google.com Swap SkPackedGlyphID bitfields around 2019-10-30 benjaminwagner@google.com [docs] Add skolo-builder to swarmingbots.md 2019-10-30 mtklein@google.com quick switch to disable SkVM JIT 2019-10-30 mtklein@google.com assume no color filters in SkVMBlitter 2019-10-30 mtklein@google.com clean up unorm8 helpers 2019-10-30 herb@google.com Faster remote glyph cache 2019-10-30 brianosman@google.com YUV Cleanup: Trim comments, derive Cr/Cb from Kr/Kb 2019-10-30 herb@google.com Use shifts for all fields in SkPackedGlyphID 2019-10-30 csmartdalton@google.com Rename sampleVariablesSupport() to sampleMaskSupport() Created with: gclient setdep -r src/third_party/skia@c7a8df8b1cdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:881505 Change-Id: Ibf34217fae3cca1d2c996982243b53552a5df0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890595Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3abb07fb77e6..0e8fabd71826 git log 3abb07fb77e6..0e8fabd71826 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 vapier@chromium.org config_stages_unittest: use a tempdir for chromite Created with: gclient setdep -r src/third_party/chromite@0e8fabd71826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib1c0603fe83adfc4493a76ba0d97f76730d790d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891378Reviewed-by:
-
Jasper Chapman-Black authored
This prevents double-counting the size contribution of symbols with aliases: rather than each of N aliases having size S, they will each have PSS S/N. Bug: 1011921 Change-Id: I3add28981d543a5b56dd2e77f1bbeb3ee44ddd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891141 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710996}
-
Oriol Brufau authored
Only the following properties apply to a ::marker pseudo-element: - all font properties - `color` - `text-combine-upright`, `unicode-bidi`, and `direction` - `content` Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo BUG=457718 TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html The test has 2 failures because font-synthesis and font-variant-position have not been implemented yet. Change-Id: I9f82e13bdd14a06a84ee55e352cd5a2c64d6fb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891310Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e15140656112..6a18fa927208 Created with: gclient setdep -r src-internal@6a18fa927208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:990387 Change-Id: Iedd9d752195e39f910b4088b360b0e94158cfe4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891376Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710994}
-
John Budorick authored
Bug: 1019719 Change-Id: I389a5e8c355ecd3343cfeb3efa6aeef245aa7a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890980 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#710993}
-
Alice Boxhall authored
This reverts commit 04962c50. Reason for revert: Unfortunately this seems to have caused a build failure: https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/6760 Original change's description: > [Android][Signin] Fix bookmark signin promo dismiss tests > > This CL fixes the bookmark signin promo tests when the promo is > dismissed in different scenarios. > > Bug: 789531 > Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Alice Wang <aliceywang@chromium.org> > Auto-Submit: Alice Wang <aliceywang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710784} TBR=twellington@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org Change-Id: I40ad228bbccd446455106c5278392cbde11834b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890456Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710992}
-
