Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 03 Dec, 2018 4 commits
    • Noel Gordon's avatar
      Closure compile file_operation_handler_unittest · 0bb6b2a8
      Noel Gordon authored 
       - remove file_operation_handler_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - document, add Closure @type's, and auto-format the unittest
 - fix Closure compile errors

No change in test behavior, no new tests.

Bug: 910774
Change-Id: Ie91e8ac6951821af05cd5c8482b7be7ae2c3b04f
Reviewed-on: https://chromium-review.googlesource.com/c/1356726
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarSam McNally <sammc@chromium.org>
Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612990}
      0bb6b2a8
    • calamity's avatar
      Revert "Enable Crashpad for Android" · 5b3c3ff0
      calamity authored 
      This reverts commit 66b2e0f1.

Reason for revert: Breaks compile
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5134

Original change's description:
> Enable Crashpad for Android
> 
> Overview:
> This CL disables Breakpad for Chrome, Content Shell, WebView, and
> Chromecast on Android and replaces it with Crashpad. When a crash
> signal is received, the browser forks+execs a Crashpad handler process
> either for itself or on behalf of a crashing child to create a crash
> dump.
> 
> components/crash/
>   - Remove CrashDumpManager. Minidump creation is handled entirely by
>     Crashpad.
>   - Remove OnChildStart from ChildExitObserver as it is no longer
>     necessary.
>   - ChildExitObserver observers CrashHandlerHost to be notified when
>     child processes receive crash signals.
>   - De-duplicate calls to ChildExitObserver::Client::OnChildExit when
>     NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent.
> 
> components/minidump_uploader/
>   - Uploaders expect crash reports to already be MIME encoded since
>     Breakpad was doing that in a signal handler call-back.
>     CrashFileManager now automatically calls into native code to do
>     the encoding and write to a directory of crash reports whenever it
>     checks for reports without logcats.
> 
> chrome/app/*.{cc,h}
> chrome/browser/*.cc
> content/shell/app/*.{cc,h}
> content/shell/browser/*.cc
>   - Initialize Crashpad instead of Breakpad, with minor cleanup and
>     adjustment for changes to CrashDumpObserver.
> 
> chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
>   - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED,
>     CLOSED} and signals sent to ChildExitObserver instead of a crash
>     dump.
> 
> android_webview/
>   - AwBrowserTerminator now observes child process crashes via
>     ChildExitObserver rather than its own pipe.
>   - Crashpad always produces minidumps, and not microdumps.
>   - Disabling Crashpad is not yet supported.
> 
> chromecast/
>   - There are now two directories that crash report uploaders should
>     be aware of: "Crashpad" contains a database of raw minidumps
>     produced by Crashpad, and "Crash Reports" contains MIME encoded
>     minidumps. MIME encoding is performed by a CrashReportMimeWriter
>     in CastCrashUploader.java:checkForCrashDumps().
> 
> Bug: crashpad:30
> Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
> Change-Id: I0efa451585f60287853c47f860f09ced581c8958
> Reviewed-on: https://chromium-review.googlesource.com/c/989401
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612987}

TBR=yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org,jam@chromium.org,wnwen@chromium.org,torne@chromium.org,halliwell@chromium.org,tobiasjs@chromium.org,rsesek@chromium.org,sanfin@chromium.org,jperaza@chromium.org,mark@chromium.org

Change-Id: I602251d05a6f89aa8f1a7c40c50d7b413fb514d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crashpad:30
Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Reviewed-on: https://chromium-review.googlesource.com/c/1358103Reviewed-by: default avatarcalamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612989}
      5b3c3ff0
    • Noel Gordon's avatar
      Closure compile: add missing ui BUILD.gn extern dependencies · c057542b
      Noel Gordon authored 
       - banners.js depends on type {chrome.echoPrivate}
   - add externs deps: externs/chrome_echo_private.js
 - combobutton.js and files_menu.js depend on type {PaperRipple}
   - add externs deps: externs/paper_elements.js
 - providers_menu.js depends on type {MenuItemUpdateEvent}
   - add externs deps: externs/menu_item_update_event.js
 - search_box.js depends on type {SearchItem}
   - add externs deps: externs/search_item.js
 - suggest_apps_dialog.js depends on {chrome.webstoreWidgetPrivate}
   - add externs deps: externs/chrome_webstore_widget_private.js

No change in test behavior, no new tests.

Bug: 910975
Change-Id: Ib38947f6f6717b9767be6ec4472b1bbd16ac384a
Reviewed-on: https://chromium-review.googlesource.com/c/1356734Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612988}
      c057542b
    • Joshua Peraza's avatar
      Enable Crashpad for Android · 66b2e0f1
      Joshua Peraza authored 
      Overview:
This CL disables Breakpad for Chrome, Content Shell, WebView, and
Chromecast on Android and replaces it with Crashpad. When a crash
signal is received, the browser forks+execs a Crashpad handler process
either for itself or on behalf of a crashing child to create a crash
dump.

components/crash/
  - Remove CrashDumpManager. Minidump creation is handled entirely by
    Crashpad.
  - Remove OnChildStart from ChildExitObserver as it is no longer
    necessary.
  - ChildExitObserver observers CrashHandlerHost to be notified when
    child processes receive crash signals.
  - De-duplicate calls to ChildExitObserver::Client::OnChildExit when
    NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent.

components/minidump_uploader/
  - Uploaders expect crash reports to already be MIME encoded since
    Breakpad was doing that in a signal handler call-back.
    CrashFileManager now automatically calls into native code to do
    the encoding and write to a directory of crash reports whenever it
    checks for reports without logcats.

chrome/app/*.{cc,h}
chrome/browser/*.cc
content/shell/app/*.{cc,h}
content/shell/browser/*.cc
  - Initialize Crashpad instead of Breakpad, with minor cleanup and
    adjustment for changes to CrashDumpObserver.

chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
  - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED,
    CLOSED} and signals sent to ChildExitObserver instead of a crash
    dump.

android_webview/
  - AwBrowserTerminator now observes child process crashes via
    ChildExitObserver rather than its own pipe.
  - Crashpad always produces minidumps, and not microdumps.
  - Disabling Crashpad is not yet supported.

chromecast/
  - There are now two directories that crash report uploaders should
    be aware of: "Crashpad" contains a database of raw minidumps
    produced by Crashpad, and "Crash Reports" contains MIME encoded
    minidumps. MIME encoding is performed by a CrashReportMimeWriter
    in CastCrashUploader.java:checkForCrashDumps().

Bug: crashpad:30
Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: I0efa451585f60287853c47f860f09ced581c8958
Reviewed-on: https://chromium-review.googlesource.com/c/989401
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: default avatarTobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Reviewed-by: default avatarLuke Halliwell <halliwell@chromium.org>
Reviewed-by: default avatarSimeon Anfinrud <sanfin@chromium.org>
Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612987}
      66b2e0f1
  3. 02 Dec, 2018 32 commits
  5. 01 Dec, 2018 4 commits