- 25 Jul, 2018 40 commits
-
-
Scott Haseley authored
Tab helpers are attached to prerender web contents, and as a result TabLoadTracker counts these web contentses as tabs. This CL adds additional tracking of non-UI tabs and adds Get*TabUiCount() methods that exclude non-UI tabs from counts. This CL also modifies CoreTabHelperDelegates to notify TabLoadTracker when tab contents are swapped. In that case, non-UI tabs are promoted to UI tabs. Bug: 861800 Change-Id: I3666b17634efd1445cd24cade8514fee06ad2c92 Reviewed-on: https://chromium-review.googlesource.com/1134504Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#577886}
-
Stefan Zager authored
This is an updated version of this previously-reverted patch: https://codereview.chromium.org/150733002/ ... along with some fixes to the treatment of left-hand scrollbars in the layout code (the need for which was revealed by test failures). BUG=250514 R=skobes@chromium.org,eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd2aa1b4d40aad1272c392366fdbde81a6830478 Reviewed-on: https://chromium-review.googlesource.com/1141332Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#577885}
-
Leonard Grey authored
Bug: 858944, 835983 Change-Id: Ia7908a1a199a1e537bf7ba7668116e018cbd4e61 Reviewed-on: https://chromium-review.googlesource.com/1144138Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#577884}
-
danakj authored
Any SharedBitmapIds registered with a CompositorFrameSink should be considered as destroyed by the renderer when the CompositorFrameSink is lost, as the renderer will treat them as so and will not report when they are deleted, and will re-register anything it wishes to reuse. This makes RenderWidgetHostImpl::RequestCompositorFrameSink() report all |owned_bitmaps_| as being deleted to the ServerSharedBitmapManager so that the same bitmaps are not re-registered, and bitmaps that are not reused are not leaked. R=piman@chromium.org Bug: 862584 Change-Id: I39fcbe49559f9d32eab3a52310b136f65a5f92ab Reviewed-on: https://chromium-review.googlesource.com/1148812Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#577883}
-
Xida Chen authored
The test: virtual/paint-touchaction-rects/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html was marked flaky yesterday and a new bug was filed. There was actually an existing bug for this flaky test. This CL changes the bug number. No behavior change should be introduced. TBR=imcheng@chromium.org Bug: None Change-Id: Id37d6c075cda4a50a8b49d3dc71d78caeee65506 Reviewed-on: https://chromium-review.googlesource.com/1149988Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577882}
-
Peter K. Lee authored
Bug: 866927 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I25d41139da731ae998ac82e1643c8b261cf7b886 Reviewed-on: https://chromium-review.googlesource.com/1149700Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#577881}
-
Farah Charab authored
Provides support for fencing and throttling. Change-Id: I44d9e027fbf7e78deef1b8205c918a0eebfab503 Reviewed-on: https://chromium-review.googlesource.com/1146802Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577880}
-
Thomas Tangl authored
The number of settings-toggle-button elements on the personalization_options.html page changed with https://chromium-review.googlesource.com/c/chromium/src/+/1145315. This CL updates the test that checks this number. Bug: 867410 Change-Id: Ie4cca8a3305b1c8677a4e9a599ec531ff6fcab78 Reviewed-on: https://chromium-review.googlesource.com/1150157Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#577879}
-
Dmitry Gozman authored
This patch only removes unused includes and DEPS entries. Bug: none Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1c3c1456fbc6263ec7a93608fd7675a2a20eccb1 Reviewed-on: https://chromium-review.googlesource.com/1149417Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577878}
-
stkhapugin@chromium.org authored
Adds a default leading image to the omnibox to be used when it's being focused (before the first update of the leading image). There are two images: for the empty textfield (magnifying glass) and the non-empty textfield (default favicon). Bug: 865000 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib9869c3b87f81041ec8a13b0ac220a3b93aa521e Reviewed-on: https://chromium-review.googlesource.com/1146926Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577877}
-
Friedrich Horschig authored
This CL adds an image view to all usernames in the passwords accessory sheet which separates username/password groups visually. It also indicates the origin of the credentials. The icons are loaded by origin on the native side. If icons are requested multiple times, they will be grouped by origin and result in only one request to the FaviconService. Already requested icons are cached - when one of these is requested, the callback will return synchronously instead of async. Bug: 853748 Change-Id: Ia97c5c62710daf709d7ee19d732d2e226ac7634f Reviewed-on: https://chromium-review.googlesource.com/1138319Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577876}
-
Yannic Bonenberger authored
This CL delays the execution of update() for an increasing amount of time if the calling worker doesn't control a client. The delay is reset every time a controller is added to the worker, or an event is dispatched. postMessage from service workers, |install| and |activate| don't reset the delay. Bug: 805496 Change-Id: I9c25ba4315ce6a915634ecdf6405db8774c40929 Reviewed-on: https://chromium-review.googlesource.com/900763 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577875}
-
Elodie Banel authored
Darkening anything under a 4.5 contrast ratio. Bug: 859651 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b56ca36d89e6d62a9104aaddf14e12f7c4b8e0a Reviewed-on: https://chromium-review.googlesource.com/1150159Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#577874}
-
tzik authored
The first reference to ConnectivityCheckerImpl used to made by base::Bind implicitly in the constructor. The reference is moved to a task runner, and released when the resulting callback object is destroyed. However, the posted task may be immediately destroyed if the PostTask failed, or the posted task may run soon before the constructor finished. That implies, `new ConnectivityCheckerImpl` may return a stale pointer. This CL adds a static constructor to ConnectivityCheckerImpl, and moves the setup code that touches ref count out of the ctor. Bug: 866456 Change-Id: I5ea6f7cf80175abb63f6318e454075f2678ff45d Reviewed-on: https://chromium-review.googlesource.com/1149437Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577873}
-
Jan Krcal authored
No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletMetadataSyncableService. This CL fixes a few omissions from an analogous CL 1147223: - ios specific code for getting the controller delegate, - getting the delegate in ProfileSyncComponentsFactoryImpl. Bug: 853688 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibfef1455df0d1a94aa56d34a8c838a9ac43fa5f4 Reviewed-on: https://chromium-review.googlesource.com/1148575Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577872}
-
Javier Ernesto Flores Robles authored
Removes autofill dependency from passwords. This was not used and removing it prevent a dependency cycle in a following CL, where manual fill uses some parts from this component. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I576ac73b8d31dfb112d65af034caab807016e3a8 Reviewed-on: https://chromium-review.googlesource.com/1148880Reviewed-by:
-
Philip Jägenstedt authored
The existing kHTMLLinkElementDisabled counter is poisoned by the reflected IDL attribute, as pointed out by bz: https://github.com/whatwg/html/issues/3840#issuecomment-407275073 Change-Id: Ic4917290475f1ad6d9baba06620a485b78edac59 Reviewed-on: https://chromium-review.googlesource.com/1148203Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#577870}
-
Farah Charab authored
Sequence manager fuzzer test is causing an overflow when posting tasks with big delays and durations. This patch fixes that. Bug: 863345 Change-Id: Ie2709c4fe2eff9d668946de7fb33f10812eb0262 Reviewed-on: https://chromium-review.googlesource.com/1146928Reviewed-by:
-
Aaron Leventhal authored
When focus moves from UI back into content, but the same content element is focused as was previously, an accessibility event must be fired for the caret location change, as it is no longer in the UI. This fix assists screen magnification software that must track the caret location. Bug: 864563 Change-Id: Ie9cc745288c124ddd73a54906c41dc16e07b9ff6 Reviewed-on: https://chromium-review.googlesource.com/1140199Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577868}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/715cc238d24b..b732b81e5520 git log 715cc238d24b..b732b81e5520 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 oprypin@webrtc.org Limit iOS bots to use machines that have 'xcode_version' dimension 2018-07-25 nisse@webrtc.org Add spatial index to EncodedImage, not yet used. 2018-07-25 nisse@webrtc.org Delete obsolete file call/video_config.h. 2018-07-25 titovartem@webrtc.org Move fft to proper third_party directory 2018-07-25 sakal@webrtc.org Move cropAndScaleI420 to JavaI420Buffer. 2018-07-25 buildbot@webrtc.org Roll chromium_revision e56ee1dd..deb63e97 (577600:577752) 2018-07-24 buildbot@webrtc.org Roll chromium_revision 83a1a9ed..e56ee1dd (577482:577600) Created with: gclient setdep -r src/third_party/webrtc@b732b81e5520 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:867367,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5416fe26428055da909e81c0865c1c2f6ffcefc8 Reviewed-on: https://chromium-review.googlesource.com/1150041Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577867}
-
Joshua Peraza authored
03abd1bb3497 mac: Tolerate the new flavor of weird cl_kernels modules on 10.14 98ebb0060b3e Add whitespace file e50ea6032180 Make BuildHandlerArgvStrings() return its result 3af81d7012e4 DEPS: Use gclient's native cipd instead of runhooks c11c8833f78f Add ProcessSnapshotMinidump::ProcessID() 2418cb8fbef8 Make upload report metrics optional 0909bee2e26c linux: Fix broken tests with address sanitizer 2f3a8b8f72dc Add CrashSkippedReason::kPrepareForUploadFailed Change-Id: Iefdaf2365615586fec6f4dcefc4f857e6e166074 Reviewed-on: https://chromium-review.googlesource.com/1148933Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#577866}
-
Reza.Zakerinasab authored
virtual/gpu/fast/canvas/canvas-blending-color-over-image.html timouts. NOTRY=true TBR=fserb@chromium.org BUG: 866850 Change-Id: I100893337485277667c10e788464bac66e2d8868 Reviewed-on: https://chromium-review.googlesource.com/1149992Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577865}
-
Mikel Astiz authored
Prior to this patch, base::PostTaskAndReplyWithResult() required ReplyArgType to expose a default constructor AND and an assigment operator, because the implementation constructed a temporary value first before it was overriden by the task's reply. There's however no fundamental reason to require any of this, since the only consumed value is the one returned by the task, which is guaranteed to run before the reply task, which is the only reader. We do however need some reserved memory to store the result of the task, so we leverage std::unique_ptr which satisfies both needs, and allows a straighforward migration. Note that base::Optional would have been more idiomatic, but it doesn't compile on iOS for certain callers, due to C++ unions being incompatible with iOS reference counting. Change-Id: I8b1946364fe7baa56451a351ee8dc94ca7231c76 Reviewed-on: https://chromium-review.googlesource.com/1146185Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577864}
-
Marcin Wiacek authored
Change-Id: Ia7ebdaec2b425da08aae6a7d2c36ade1e75c3808 Reviewed-on: https://chromium-review.googlesource.com/1146188 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577863}
-
Sylvain Defresne authored
The variable account_info is moved into std::map::emplace() and thus should not be accessed after that method is called as the state after a move is undefined. Current code appears to work because by defining an explicit copy constructor on AccountInfo, the implicit move constructor is not generated by the compiler. This use after move was found after adding an explicit move constructor to AccountInfo that caused a DCHECK to fail (as account_info member std::string are empty after being moved). Bug: none Change-Id: I096d89e40d09a934eb213173f4b491c151433d7b Reviewed-on: https://chromium-review.googlesource.com/1149867 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577862}
-
Georges Khalil authored
This reverts commit 448c3822. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove unused rlz_lib::SendFinancialPing variant > > Another driven-by CL, that removes an unused method. > > TBR=rogerta@chromium.org > > Change-Id: If7853aad29c007bd8aac5784b4994064d89d8e16 > Reviewed-on: https://chromium-review.googlesource.com/1149621 > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#577854} TBR=rogerta@chromium.org,tonikitoo@igalia.com Change-Id: I78570c02309379c4cfff49b3c40bc3378992acad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1150122Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#577861}
-
stkhapugin@chromium.org authored
Adds a flag to the animation orchestrator to ignore all calls when there is an animation in progress. Bug: 866858 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic8990b0c60083723d9e6727538293480cc42b9a6 Reviewed-on: https://chromium-review.googlesource.com/1150143Reviewed-by:
-
Dmitry Gozman authored
There is already a healthy animation -> transforms dependency. To remove the reverse one, we factor out Blend() functions to platform/geometry. Bug: none Change-Id: Iab048cbaec013c6af2701b7ba82a79a83f69341f Reviewed-on: https://chromium-review.googlesource.com/1149335Reviewed-by:
-
Xida Chen authored
When there is a touch ack time out, all the gesture events will be flushed to the touch action filter. This case is already taken care of in the non-iframe case, and this CL handles the iframe case. When we see that a gesture event is flushed due to time out, we set the effective touch action to auto which will allow all the gesture event. A browser test is added to ensure the correctness. This CL is break into few patches: PS#22: The essential fix in line 1190 in the render_widget_host_input_event_router.cc is commented out. When running the newly added browser test, it will hit the DCHECK in touch_action_filter.cc at line 55. PS#23: Uncomment the essential fix in the render_widget_host_input_event_router.cc and remove the DCHECK in touch_action_filter.cc at line 55. Uncomment the temporary fix in touch_action_filter.cc for bug 851664. TBR=creis@chromium.org Bug: 851644 Change-Id: Ic381dd17fa531c1e9f7d649b48dc9f0f0d7d9c21 Reviewed-on: https://chromium-review.googlesource.com/1102729 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577858}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15020ea2cf44..c062b6be5a01 git log 15020ea2cf44..c062b6be5a01 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 benjaminwagner@google.com [infra] Adjust job priorities. (skia) Created with: gclient setdep -r src/third_party/skia@c062b6be5a01 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I5e4fdb0b651fb8136e88b6cd875c863451dfeaaf Reviewed-on: https://chromium-review.googlesource.com/1150040Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577857}
-
Maxim Kolosovskiy authored
This reverts commit 8faf0805. Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103 Original change's description: > fast/events/touch/gesture/* layouttests are using gpu benchmarking. > > Bug: 846424 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 > Reviewed-on: https://chromium-review.googlesource.com/1144230 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577727} TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1150180Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#577856}
-
Sergio Villar Senin authored
The data structure used to store the grid items is currently a matrix, a Vector of Vectors. That's pretty convenient because it's quite easy to use, to implement and also provides O(1) access to grid cells and easy row/column traversals. However the problem is that we need to allocate the whole size of the grid even if we have just a small number of items on it (sparse matrix). We're replacing it by a new data structure based on doubly linked list. We'd be only creating the grid rows/columns/cells required to store the actual grid items inside the grid. The drawback of this new implementation is that O(1) access to individual cells is no longer possible. However that's not the most usual way to access data on the grid, most of the times we simply iterate through tracks. It's also a bit more complex to implement, but the good thing is that it does not require any change in the Grid class API, so the current layout code is unaffected by this change. Last but not least, although this change involves memory saves with sparse grids it does not completely fix the issue of dealing with large grids. That's because the track sizing algorithm is still using Vectors to store the list of tracks, so we have to do large allocations of those. This should be addressed in follow-up patches where content sized empty tracks would be ignored and not allocated by the algorithm. Bug: 688640 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d44914ed976358dcb5ef92cc3ff9df7a720102e Reviewed-on: https://chromium-review.googlesource.com/1104166 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577855}
-
Antonio Gomes authored
Another driven-by CL, that removes an unused method. TBR=rogerta@chromium.org Change-Id: If7853aad29c007bd8aac5784b4994064d89d8e16 Reviewed-on: https://chromium-review.googlesource.com/1149621Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#577854}
-
Antonio Gomes authored
rlz_lib::SetURLRequestContext does not need to be called explicitly since URLRequestRAII's ctor call it, and an instance of it is already being constructed. This is a driven-by preparation for crbug.com/844989. TBR=rogerta@chromium.org BUG=844989 Change-Id: Ib7e2e0809c4e1e65c386e02008fdce877b829b08 Reviewed-on: https://chromium-review.googlesource.com/1149620Reviewed-by:
-
Yutaka Hirano authored
Per RFC7230 empty header field is valid, but HttpResponseHeaders::GetNormalizedHeader sometimes ignores empty values. This CL fixes the issue. Bug: 866787, 736308 Change-Id: I227e18e413740e345d557e2c24a25e45e68b0ae8 Reviewed-on: https://chromium-review.googlesource.com/1148091Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#577852}
-
Kent Tamura authored
*.h for RAILModeObserver implementors can avoid including large web_thread_scheduler.h by this CL. This CL reduces the pre-processed size of platform/heap/handle.h from 3.07MB to 1.59MB Bug: 242216 Change-Id: I95fef4e3e0dcafe5c4f5ee1f6ba77c4095a41ca1 Reviewed-on: https://chromium-review.googlesource.com/1149427Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#577851}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same scope and conflict. This commits moves such functions to shared util files, instead of having duplicates. Bug: 867350 Change-Id: I9986d6d653ef71acbf9583e18aa85a8e34f6e6f0 Reviewed-on: https://chromium-review.googlesource.com/1149781Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#577850}
-
Nico Weber authored
TBR=pmonette Bug: 867322 Change-Id: I11743753b408430741588f8a8ef4895cdc33bf45 Reviewed-on: https://chromium-review.googlesource.com/1150085Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef17db9d..58ea46ee Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8063f91121600d4e3a6c3dc659b180a3328f3e6e Reviewed-on: https://chromium-review.googlesource.com/1149983Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577848}
-
Oscar Johansson authored
When building using jumbo, files get merged together and macros may end up in the same scope and conflict. In media/mojo/services/test_mojo_media_client.cc a include resulted in including ui/gl macros, which conflicted with GLES2 macros. This commit solved the issue by removing the include. The include seems to be unnecessary and not used within the file. Bug: 867350 Change-Id: I54f01bcd5d18b4acbaa231a5cf78a8b5e8f719e7 Reviewed-on: https://chromium-review.googlesource.com/1149862Reviewed-by:
-
