- 30 Oct, 2019 40 commits
-
-
Alice Boxhall authored
This reverts commit 3ef63a6b. Reason for revert: Looks like this has caused a crash, e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898135829966943488/+/steps/ash_unittests/0/logs/Deterministic_failure:_OverviewSessionWithHomerviewGestureTest.FadeOutExit__x2f_0__status_CRASH_/0 Original change's description: > Implement transitions to home for homerview feature > > Updates how device transitions to home when home button is tapped and > when user clicks in empty space in overview grid when kHomerviewGesture > feature is enabled. > > When overview is active, it should use kFadeOutExit transition (instead > of slide out) - this also fixes a bug where transform was not cleared on > item windows when bounds were updated without animations (which was > causing item window misplacement when the grid was updated while > minimizing active window before exiting overview). > FadeOutWindowsAndMaybeSlideOnExit is updated to take "slide" as an > argument instead of deducing it depending on the animation type, as > OVERVIEW_ANIMATION_EXIT_TO_HOME_LAUNCHER should slide if and only if > using slide out overview exit transition (the animation can also be used > by fade out exit). > > When clicking home with a window active, the top window is minimized > using transform to home screen (the same used during drag from shelf), > while the rest of the windows are minimized with no animations. To make > this easier, WindowTransformToHomeScreenAnimation is moved to a separate > file, and is updated to better handle windows whose origin is not in the > screen origin (which is useful for transforming top windows in split > view). > > Is split view, the top windows are transformed to home screen as the > split view ends. If overview session is active together with split view, > the overview session is ended immediately to avoid showing overview just > after ending split view (during duration of the exit transition). > > BUG=1005366 > > Change-Id: Ic23893866700f5e5580f4445915d815f188e8c0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885972 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710953} TBR=xiyuan@chromium.org,tbarzic@chromium.org,xdai@chromium.org Change-Id: Id4020082bc736ec6fc9306fc26c5a7a237cb4c54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890392Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711045}
-
Findit authored
This reverts commit 433bbd52. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711038 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzM2JiZDUyMTA0MmRjOTcyMmQ2ZDg2Nzk0MzNjODE0MGRmOWQwNGMM Sample Failed Build: https://ci.chromium.org/b/8898131381528610928 Sample Failed Step: compile Original change's description: > Remove HomeLauncherGestureHandlerObserver > > HomeLauncherGestureHandler currently has two observers: > * AppListControllerImpl, which is also a HomeScreenDelegate > implementation (on which HomeScreenGestureHandler already > depends, so additional observer interface just > obscures/complicates this dependency) > * HomeLauncherStateWaiter which is used by interactive UI/perf tests > to wait for launcher animations to complete > > For the former case, moving the observer methods to HomeScreenDelegate > interface will work fine. > For latter case, the test waiter can register a callback with > AppListControllerImpl to be run when the home launcher animations are > complete - the same way it's done by LauncherStateWaiter, an equivalent > test waiter used in clamshell mode (or for waiting for non-visibility > app list state transitions) > > Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652 > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711038} Change-Id: I449d4c15018c05c09953d445a50d1c1dc6f7c1a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890735 Cr-Commit-Position: refs/heads/master@{#711044}
-
Jiawei Li authored
Set the new QueryableData JS bindings feature on. Bug: internal b/138623432 Test: E2E manually test Change-Id: Ia1a3e4f650aeabee3aae90f9e764a63c2d9213b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891738 Auto-Submit: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#711043}
-
Toby Huang authored
Add reminders to mark the crbug as "started" before starting development work and to mark the crbug as "fixed" after landing the CL. Bug: None Change-Id: Id79ff0843679c368773b10d22ea9d72e4b1691d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891730Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711042}
-
Ken MacKay authored
Merge-With: eureka-internal/330177 Bug: internal b/127963522 Bug: internal b/138938216 Change-Id: Ia8b0a705f5ebe8d9b637af85ed537e0c7ac3e0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888114 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711041}
-
Sasha McIntosh authored
Land the JPEG YUV decoding feature behind a flag without affecting testing. Tests will be updated and rebaselined in a follow-up cl. Bug: 919627 Change-Id: I9debcf08e8eca02bebe53ec0f218843cd28da1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887273 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#711040}
-
Kalvin Lee authored
This change adds localization strings for JIS B* papers. Bug: 1017279 Change-Id: I369a016002f29ccbecdf18a9593611fed6084e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891118Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711039}
-
Toni Barzic authored
HomeLauncherGestureHandler currently has two observers: * AppListControllerImpl, which is also a HomeScreenDelegate implementation (on which HomeScreenGestureHandler already depends, so additional observer interface just obscures/complicates this dependency) * HomeLauncherStateWaiter which is used by interactive UI/perf tests to wait for launcher animations to complete For the former case, moving the observer methods to HomeScreenDelegate interface will work fine. For latter case, the test waiter can register a callback with AppListControllerImpl to be run when the home launcher animations are complete - the same way it's done by LauncherStateWaiter, an equivalent test waiter used in clamshell mode (or for waiting for non-visibility app list state transitions) Change-Id: Ia333bedab2b8683d35da2d00030cf40df2c619f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888652Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#711038}
-
David Benjamin authored
Found with _LIBCPP_DEBUG=0. Bug: 923166 Change-Id: Ifdb0be8031bc95f05ff3d67876407569bac0e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891235 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#711037}
-
Natalie Chouinard authored
Migrate Update Menu Item preferences to use PrefServiceBridge generic methods, making use of the prefs.h enums. Bug: 1016957 Change-Id: I3b37e1251e5c51d0bc08e4cfd0ae05245c2d052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885103 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#711036}
-
Sammie Quon authored
I didn't find out the exact cause, but something about the ARC app was updating the backdrop many times during the course of a swipe, and was probably creating a new one which did not have an transform or opacity changes. This happens for regular windows as well, so instead, pause updates during a home launcher drag. Test: manual Bug: 1018125 Change-Id: I1d933921f8c17410fb6a8c81f96c94e93fc59955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884578Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711035}
-
Yun Liu authored
'network_service_out_of_process_chrome_public_test_apk' and 'network_service_webview_instrumentation_test_apk' also need to excluded.. They will build 'chrome_public_test_apk' and 'webview_instrumentation_test_apk' targets. Bug: 985574 Change-Id: I31dd9baf7446b8e60ced7047006f99d1fcc85818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891122 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711034}
-
Dan S authored
This reverts commit b3c71165. Reason for revert: <INSERT REASONING HERE> This CL's test breaks on linux-chromeos-google-rel because it relies on a string that is only built in the non-official builds "Chromium". See: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8898136527157394352/+/steps/browser_tests/0/logs/Deterministic_failure:_HotseatShelfAppBrowserTest.EnableChromeVox__status_FAILURE_/0 Original change's description: > Fix the issue of accessibility focus traversal with hotseat > > This CL accomplishes the following things: > > (1) Designate the previous/next focusable widget for navigation widget, > hotseat widget and status area widget. It prevents the accessibility > ring from being trapped in one widget. > > (2) Ensures that the hotseat is shown when the shelf app icon gets > the accessibility focus. > > (3) Implements the test api to facilitate browser tests to access > the shelf widget code. > > Bug: 1010219 > Change-Id: I86dd5cc464430f0a91c8c8a043fcb9fb437d58a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873386 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710986} TBR=xiyuan@chromium.org,andrewxu@chromium.org Change-Id: I9365d9456a9f461aa30ec412754eeed16f02150e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891850Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711033}
-
Reilly Grant authored
This change makes SerialPort an ActiveScriptWrappable so that it can be kept alive for as long as the port connection is open. This prevents the streams created by the port from being closed if a page does not keep a reference to the port itself. Bug: 1017289 Change-Id: I23b4da0c5b27d16901d2d7eb7fd1c622a8404f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888513Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711032}
-
Tarun Bansal authored
Remove gcm_channel_status_request from list of traffic tags throttled when WebRTC calls are active. gcm_channel_status_request is not related to fetching of finch variations seed (which was the original intent). Bug: 1005841 Change-Id: I25506fc832198471251206c33599837eca4f48a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885229Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711031}
-
Moe Ahmadi authored
Bug: 1018433 Change-Id: I6d7bc590e8cb4d16b7589628744077dfc92c7605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888376 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#711030}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b43d98bf6484..48823c28549d git log b43d98bf6484..48823c28549d --date=short --no-merges --format='%ad %ae %s' 2019-10-30 jbudorick@chromium.org Revert "Add more git tracing." Created with: gclient setdep -r src/third_party/depot_tools@48823c28549d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I384d57ec204bab50837d83ad78d50d9a1431831d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711029}
-
Yuwei Huang authored
The "Send Feedback" button in the app no longer works and according to the logs it seems we need to add gsf.permission.READ_GSERVICES permission to the Android manifest. I can't build and test the official build locally so I'd like to check this in frst then verify it on the nightly build. Bug: 1019866 Change-Id: Iac01e9db420d95a8c8a7aa952ad9d2ab1ac9b6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891464 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#711028}
-
Frank Tang authored
ICU 65-1 release note http://site.icu-project.org/download/65 CLDR 36 release blog http://blog.unicode.org/2019/10/unicode-cldr-version-36-languagelocale.html Most of the test expectation change is due to CLDR 36 update of Grapheme Cluster for Indic languages See the following for related changes in ICU 65.1 in this area: https://unicode-org.atlassian.net/browse/CLDR-10994 https://unicode-org.atlassian.net/browse/ICU-13637 https://github.com/unicode-org/cldr/blob/master/common/properties/segments/readme.txt Bug: chromium:1014272, chromium:1017047 Change-Id: I9fc6d4620bf2a4c189940d06d8c79893502db3dd Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866059Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711027}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the browser process and the assistant service from ChromeOS for the Assistant, AssistantController and the AppListEventSubscriber mojo interfaces to the new mojo types. Bug: 955171 Change-Id: Id57a7b0c80bd7985fff98929d0370af00becf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883517Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#711026}
-
Robert Kaplow authored
Remove some stale includes for already deleted metrics. Bug: 1016906 Change-Id: I8d6c33953df5caf367a33b9a0260b5a36d6ab754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876787Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#711025}
-
Sasha McIntosh authored
Restructure memory dump metrics to avoid double counting memory. Affected metrics: Memory.Experimental.Gpu2.Small.ServiceTransferCache Memory.Experimental.Gpu2.Small.ServiceTransferCache.AvgImageSize Memory.Experimental.Gpu2.Small.ServiceDiscardableManager Memory.Experimental.Gpu2.Small.ServiceDiscardableManager.AvgImageSize Bug: 963619 Change-Id: Ia1ae23ce99d351807eb1e3f9727882ec2257a153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888095Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711024}
-
Roberto Carrillo authored
We are currently getting 6 out of 10 shards timing out with ~ 75% - 95% progress. R=agable,martiniss,liaoyuke Bug: 1017486 Change-Id: I5281a459dd87b27f406abbb3cbac3b27aae54544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889397 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711023}
-
Xiaohan Wang authored
RAPPOR is being deprecated and media code has migrated to use UKM. So remove all RAPPOR reporting in media. Bug: 1016906 Change-Id: Ifff3c8f40793972f99c8f585410615319e072a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875653Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711022}
-
Anastasia Helfinstein authored
go/cros-switch-navigation Bug: 1011630 Change-Id: I27d974be1c549f176c9ccd2c4d1814b02e5498c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876867 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#711021}
-
Nick Burris authored
Scroll anchoring should not anchor to a node that is behind scroll padding. Bug: 1010002 Change-Id: Icbd89fb85ea2c97a6de635930a9896f6a87b8f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887745Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#711020}
-
Vladimir Levin authored
This patch adds more tests for img (layout replaced) with intrinsic-size specified, since the coverage was lacking. R=chrishtr@chromium.org Bug: 1016470 Change-Id: Ief95a39d6f351923f51644893d54a7dd435c5c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890009 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711019}
-
Sky Malice authored
This reverts commit e1aacdeb. Reason for revert: chromium-internal-arm-builder's generate_build_files is broken by this, see https://ci.chromium.org/p/chrome/builders/ci/chromium-internal-arm-builder/7799 Original change's description: > Reland: Rename gl_test to gpu_tests > > This is to make the name reflect that there aren't just OpenGL tests in > this executable now, there are WebGPU / Dawn tests too. > > TBR=zmo@chromium.org > > Bug: 1017035 > Change-Id: I5f0f04a2082533eda1cd6c474c85214e2195304d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888936 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710854} TBR=zmo@chromium.org,cwallez@chromium.org,jbudorick@chromium.org Change-Id: Id0dcd22a2246be1f4a1507f336e8f63eddb03557 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891469Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711018}
-
Caleb Rouleau authored
Note that this will have no impact on what is currently running on the waterfall because all benchmarks are labeled as abridged: False right now. This change is now possible because: 1. Pinpoint was taught to use the --run-full-story-set flag by https://chromium-review.googlesource.com/c/catapult/+/1874451 2. benchmark_smoke_unittest.py was fixed: https://chromium-review.googlesource.com/c/chromium/src/+/1874821 Note that system_health_smoke_test.py is fixed as part of this change. I tested this fix by running /run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:game and seeing that the stories, a mix of health_check stories and stories without the health_check tag were all run. Bug: 965158 Change-Id: I42ca28543155536da62d9b02d9bf31d8eb311ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687783 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#711017}
-
Dave Tapuska authored
As outlined in https://docs.google.com/document/d/1QO99UstlPTY8eK4Lnc9qcNq3wQYTBDBsRZu6nGC4XG4/edit Create a RemoteFrameHost mojo interface in blink so blink can talk directly to the browser without going through the content/renderer layer. Since there aren't any other mojo interfaces requested on the remote frame in blink this required a bunch of AssociatedInterfaceProvider plumbing to be added. This change also moves the first message over SetInheritedEffectiveTouchAction. BUG=1008432 Change-Id: I9ec0e55e90805c732abb2fb9447ff8724d16c439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874055Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#711016}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4d322b9e167e..1c93b3dec290 git log 4d322b9e167e..1c93b3dec290 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 dproy@chromium.org Switch back test runner from chromium to chrome Created with: gclient setdep -r src/third_party/catapult@1c93b3dec290 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1015942 Change-Id: I83401fb5a383cd9e47a7a3709015cb75d8829f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890596Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711015}
-
Xida Chen authored
This reverts commit 420ab929. Reason for revert: Caused failure, because OOP-R didn't handle off-thread paint worklet yet. Original change's description: > Ship off-thread Paint Worklet > > All the blockers for this feature has been removed, and it is ready to > be shipped. > > Note that normally the "enable-threaded-compositing" is not enabled > when running the layout test, and off-thread paint worklet layout tests > are meaningless without the compositor thread. So this CL makes the > layout tests running on the main thread, which means we need to keep > the virtual/threaded/external/wpt/css/css-paint-api/ tests. > > Bug: 829967 > Change-Id: Ie7bd45e09c01729c238c1e3b8fb38e717e84e70e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869332 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709230} TBR=haraken@chromium.org,xidachen@chromium.org,smcgruer@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829967 Change-Id: I68adbc32698a588f33d36fd592d5b6f68e53a8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891144Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711014}
-
Clark DuVall authored
This is a reland of e26a5125 This conflicted with http://crrev.com/c/1888389 and caused a compile error. Original change's description: > [WebLayer] Fix crash when top controls view has 0 height > > This happens because the adapter and layer for the top controls is only > created once height and width are > 0. We were assuming this had already > been created in setTopControlsOffset(). > > Change-Id: Idf104f9d5c951c1fa8719fa30661dceae59b4887 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890492 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710897} TBR=sky@chromium.org Change-Id: I482a241fcb43fe2bff3ec8f315cfed5ee266e828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890959Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711013}
-
gogerald authored
Bug: 1019777 Change-Id: I9e7a2520b588dd0c993fff3a95386d37cee077fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890793Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#711012}
-
Tomasz Wiszkowski authored
When navigating to a webpage and then back to NTP using home button, pressing fakebox to activate omnibox input reports context as NTP, rather than NTP with fakebox/realbox as starting focus, though this does not seem to be 100% the case, either. This change ensures that plain NTP also triggers ZPS suggestions when users navigate to NTP page by pressing the home button, and have the On-Focus suggestions set to a non-default value (fixes possible flakiness for test team) Bug: 1004925 Change-Id: Id2930ad1651f23a3710d1e3124bd291a81e7bc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890497Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#711011}
-
Wenbin Zhang authored
[Benchmarking] Updated the dimension to ensure homogeneous fleets: updating device OS for Android Go and Android pixel2 In order to ensure homogeneous fleets, we need to have more specific dimension values when looking for bots. This set of CLs updated some existing dimensions, and added the synthetic_product_name values for dimensions if appropriate. This CL updated the device_os for the following Android builders. The available bots under the old/new dimension values can be found in the links. - android-go-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=gpu&c=os&c=status&c=synthetic_product_name&d=desc&f=device_os_flavor%3Agoogle&f=device_type%3Agobo&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf&s=synthetic_product_name - android-go_webview-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=os&c=pool&c=status&c=synthetic_product_name&d=asc&f=device_os_flavor%3Agoogle&f=device_type%3Agobo&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf-webview&s=synthetic_product_name - android-pixel2_webview-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=device_os_flavor%3Agoogle&f=device_type%3Awalleye&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf-webview&s=device_type - android-pixel2-perf: https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=device_os&c=device_os_flavor&c=device_type&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=device_os_flavor%3Agoogle&f=device_type%3Awalleye&f=device_os%3AO&f=os%3AAndroid&f=pool%3Achrome.tests.perf&s=synthetic_product_name Bug: chromium:996830 Change-Id: I97b40110ff6a0c86ac200f245ebc39c79787a33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889948Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#711010}
-
Nathan Zabriskie authored
As part of the OOPR-Canvas2D project this CL changes IsGpuContextLost() to query RasterInterface instead of the current GLES2Interface. This is done with the goal of removing all references to the GLES2Interface in Canvas2D code so that we can fully transition to RasterInterface for oop-r. Change-Id: Ib740d7f3554493e31429dd60e42198095a4c746b Bug: 1018898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877109Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711009}
-
Dana Fried authored
Unfortunately, a side-effect of the capture code we're currently using is that it triggers an instantaneous loss and then regaining of mouse hover over the current controls; this results in capture starting and stopping again in a tight loop. This change allows existing capture to continue until the first time a result comes in and either (a) the page is done loading [which is existing behavior] or (b) we've stopped observing the thumbnail. It prevents a momentary shakeup in whehter the thumbnail is being observed from locking the browser into the tight loop described above. We still want to follow up and determine *why* (and on what platforms - it might just be Windows) starting capture causes mouse hover to be lost; if we can't fix the signal we may have to debounce it in the hover card system to prevent unintended visual results. Bug: 1019303 Change-Id: Iec0cba64398891d589d3cbe6d7abeab0e1e230b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891142 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#711008}
-
Simeon Anfinrud authored
With this, you can make the compiler ensure, statically, that the methods of your class always run on the same sequence. This is vastly safer than runtime checks like SequenceChecker since it will fail to compile if you violate the requirement. (It wouldn't be C++ if there weren't hacky ways around this, but any attempt to trick the compiler into allowing a sequence violation should look pretty obvious to reviewers.) To use this, declare a struct that inherits from StaticSequence. This struct will automatically declare a Key class that can only be constructed inside the StaticSequence's PostTask function. To force users to go through that StaticSequence's PostTask() to call your method, simply declare a reference to the Key object as the last parameter to the method. This also includes a wrapper template called Sequenced, similar to base::SequenceBound, but with the TaskRunner known at compile time rather than runtime. This can be used to add an extra level of safety over runtime checks like DCHECK_CALLED_ON_VALID_SEQUENCE or TaskRunner::RunsTasksInCurrentThread. This wrapper ensures the wrapped object is destroyed on the correct sequence, essentially turning any sequence-affine object to a thread-safe object. This will be made even more useful once base::PostTask() returns a base::Promise, as it will work with methods that return values as well as void methods. Bug: None Test: cast_base_unittests Change-Id: Ic408e343bc084c19c4c6f9e983b343b98502daf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863549Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711007}
-
Kai Ninomiya authored
This workaround was added for Linux set-top boxes with Mali-400. However, the workaround is not needed on Android devices with Mali-400 (probably due to using a completely different driver). The disable_gl_rgb_format code path is poorly tested and had at least one bug, so reduce the workaround to only apply to Linux. Bug: 1018528, 449150 Change-Id: Ic2f5248a8ff943edab90c24577ea94601693a32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891139Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711006}
-