- 21 Feb, 2020 40 commits
-
-
Martin Šrámek authored
1. Extend the privacy-settings-redesign trial to M84, as we still need it beyond M82. 2. Replace chrome-friendly-settings with chrome-friendly-settings@google.com. Not specifying the email domain assumes @chromium.org address, but this mailinglist uses the @google.com domain. 3. Replace chrome-privacy-core@google.com with chrome-friendly-settings@chromium.org, which is a better fit. Bug: 1032584 Change-Id: I1b8db25bd4bbc584539804b84ccac6540d386715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066837Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#743514}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c58458e633e1..61194f9321a7 git log c58458e633e1..61194f9321a7 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src c357af84c7cb..136207a63495 (3 commits) 2020-02-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 74d3f371f201..f50cc82b3bed (6 commits) 2020-02-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 6112b121e104..a09ab94aa920 (5 commits) Created with: gclient setdep -r src/third_party/angle@61194f9321a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: If8096998bdc1d69879754a20ad155d4a6d3b1223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743513}
-
Michael Lippautz authored
Instead of relying on in-construction bit, use off-the-shelf double-checked-locking for ensuring GCInfo correctness as it is way simpler to reason about. In general, GCInfo are known statically at compilation time which is why we should think about putting them into proper sections. The current problem there is component builds. This reverts parts of https://crrev.com/c/2062440 Change-Id: Id3100b00f44386328ce7b8946d95362a3323e104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066841 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743512}
-
Anders Hartvoll Ruud authored
Let's turn this on for a while to see if any UMA numbers move in Canary. If they don't, we can leave it on. If they do, we still have a few weeks until the next branch point. Change-Id: I9e1432bb31ed1b6960e636df03a061dfd87735c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066786Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#743511}
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ChildAccountFeedbackReporter class. This CL passes profile (i.e., regular or off-the-record profile) object to FeedbackCollector, while the profile always regular profile in current usage. This CL changes the behaviour of code to make it run with correct profile. Bug: 1041781 Change-Id: I3ef75d4250044e81c583868e399598a5f48a988f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066538 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#743510}
-
Himanshu Jaju authored
Chromium crash fix when receiving an ack for WebRtcSignalingFrame in LogSharingMessageAckTime. Change-Id: I905a5c451501fe862a92801a952774b8c977aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066787Reviewed-by:
Richard Knoll <knollr@chromium.org> Auto-Submit: Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#743509}
-
Patrik Höglund authored
Started happning on Win7 tests after https://chromium-review.googlesource.com/c/chromium/src/+/2067307. Bug: None Change-Id: I9a8414e3e2914fdea20671cda2bcf788c2722bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066762Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#743508}
-
Denis Kuznetsov authored
Change-Id: I85d6e2355d4a3200fd52f49517105d9fe85cb33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066922 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743507}
-
Peter Conn authored
This reverts commit 6ca2f09f. Reason for revert: Relanding now that downstream CL (https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2592603) should well and truly have propagated. Original change's description: > Revert "
🛃 Move Client Data header out of ClientManager." > > This reverts commit fd191139. > > Reason for revert: [Sheriff] compile failure https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/157215 > > Original change's description: > >🛃 Move Client Data header out of ClientManager. > > > > Bug: 1040143 > > Change-Id: Ife79cfe1f0c5963bf4c6c7bee0c810e936b0a9a0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062208 > > Commit-Queue: Peter Conn <peconn@chromium.org> > > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743100} > > TBR=mvanouwerkerk@chromium.org,peconn@chromium.org > > Change-Id: I372b18ffaf679ba933129ce5f3ac65bf0ee8b661 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040143 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067717 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743280} TBR=mvanouwerkerk@chromium.org,peconn@chromium.org,eirage@chromium.org Change-Id: I25a6880e0b0537cdd334510fa7ef99f3775c70a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066901Reviewed-by:Peter Conn <peconn@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#743506}
-
Ioana Pandele authored
This CL fixes tests which set up update password cases incorrectly, by providing an empty vector of passwords already saved for the origin. Bug: 1054757 Change-Id: I101eb6fea9be9b8048a0cec1c3530b21f8afb618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062419 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743505}
-
Anton Bikineev authored
This implements the following: 1) Add a per-page flag indicating that the page contains young objects; 2) For minor GC, sweep only pages containing young objects; 3) Don't do compaction for minor GCs. Bug: 1029379 Change-Id: I8b9e1bcdfef121ac766eaf435fa3c7fd6a5f2cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066781 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743504}
-
Anton Bikineev authored
Bug: 1029379 Change-Id: I4642e31fd3f39469ee1f94045228027da736a61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066921Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Aya ElAttar authored
notification and the relaunch deadline is in less than the grace period. Bug: 1044716 Change-Id: I299bb6a62029826b40a7fb739f332bd868bf75c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041600 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743502}
-
Eric Willigers authored
Tests like WebAppPictureInPictureWindowControllerBrowserTest now have a trivial standalone PWA to reference. Requested in https://chromium-review.googlesource.com/c/chromium/src/+/2062123/1/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc#2534 Bug: 2062123 Change-Id: I65451ef09523c669c4e53634d9bcac2a3face288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066408 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#743501}
-
Simon Zünd authored
Tracing web tests dump tracing events that can contain locations in scripts. These locations may be source mapped. Resolving such a location will be asynchronous in the future. This CL prepares all tracing web tests for asynchronous source mapping by adding async/await to the necessary places and waiting for pending live location updates where needed. The PerformanceTestRunner helpers that will be async in the future are: * forAllEvents (since the callback may be async) * printTimelineRecordsWithDetails * printTraceEventPropertiesWithDetails * walkTimelineEventTree(UnderNode) Note: One test is disabled for now, as the test passes an async callback to a test helper that does not support that currently. This test requires the usual 3-way dance. Bug: chromium:1032016 Change-Id: I78d18b0aed922a06ab6e89db517a70119cd9ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064209 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#743500}
-
Andy Paicu authored
.. this are of the code NOTE: Some links are broken until https://chromium-review.googlesource.com/c/chromium/src/+/2063672 lands Change-Id: Id02055506eddb912e7dccc86a435c851338481bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066546 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743499}
-
Jose Lopes authored
Callback called every time the audio buffer needs to be filled: * https://cs.chromium.org/chromium/src/media/base/audio_pull_fifo.h?rcl=177e90911c8bcb0c547c7974acdf4b249fa67062&l=28 Called as part of a while loop: * https://cs.chromium.org/chromium/src/media/base/audio_pull_fifo.cc?rcl=177e90911c8bcb0c547c7974acdf4b249fa67062&l=37 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I98bd69edcd0a3162e1a730d64319f0a85ee61bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047027 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743498}
-
Christian Dullweber authored
These metrics should not expire as they are frequently used. Change-Id: I0ee72093d029aecca4d2d8b77765fe505d85c495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049860Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#743497}
-
Olivier Robin authored
Put the three lists that need to be updated (headers, sources and include_dirs) in toplevel variables. Change-Id: I6f6e0f9b7f8104f7fadc0493b9d316f018f098ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066838 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743496}
-
Hitoshi Yoshida authored
Fixes a compile error with unknown relationship between FeatureContext and ExecutionContext. Bug: 839389 Change-Id: I2dfe882772e6921c56c6a0a70eed4488ca53ca82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068259 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#743495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8adb09deb15b..7f33fcf39e5f Created with: gclient setdep -r src-internal@7f33fcf39e5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I64b70b757b16c26280a2488d6797fddd71e82687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068215Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743494}
-
Jose Lopes authored
According to the documentation, this is a repeating callback, called every time the media server crashes: * https://cs.chromium.org/chromium/src/media/base/android/media_server_crash_listener.h?rcl=06d998f53ecbf18ef4512d8a22f1261ee4ab8c71&l=18 * https://cs.chromium.org/chromium/src/media/base/android/media_server_crash_listener.h?rcl=06d998f53ecbf18ef4512d8a22f1261ee4ab8c71&l=27 * https://cs.chromium.org/chromium/src/media/base/android/media_server_crash_listener.h?rcl=06d998f53ecbf18ef4512d8a22f1261ee4ab8c71&l=38 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I871e908c72a6fc016faa2317bea51ece2e0da947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047247 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743493}
-
Brandon Maslen authored
Recently PermissionPromptBubbleView::CalculatePreferredSize was added to ensure permission prompts do not expand too large when large prompt text is present. While this helped ensure the prompt respected the same max bubble width used elsewhere in Chromium it also caused small prompts to become larger to fill the space. This change updates the CalculatePreferredSized impl to take into account the preferred size of the context along with the max size and use the smaller of the two. Bug: 1054699 Change-Id: Ie3237d50bafd1b19dae9928b8d2c834dc37c9ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067081 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Philipp Hancke authored
which is defined in https://tools.ietf.org/html/rfc5245#section-15.4 BUG=1044521 Change-Id: I21e83e929f4b66a3e58ad6b3420fbf9b39daba25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064912Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#743491}
-
Mugdha Lakhani authored
This is the groundwork for PageInfo UI to be reused for WebLayer. I have moved the following classes from chrome/browser/page_info: CookieControlsView and PageInfoView Some xmls have been moved and I have reused resources wherever possible. The rest is updating deps + BUILD.gn and includes to make the bots happy. Bug: 1052375 Change-Id: Iee4fe717d4423f6f3774453315eb8e935beb0e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062337Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#743490}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7cc8f3b22c1bc98a7e93789ddc24ecc4ec428ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068214Reviewed-by:
-
Fredrik Söderquist authored
This moves the traversal code from SVGResourcesCycleSolver to LayoutSVGResourceContainer. The reason for this is to be able to perform slightly more heterogeneous traversal - i.e not only using SVGResources. The primary use case this is to get rid of the "linked" resource from SVGResources (currently only used by <pattern>s). This also the reason for the split into FindCycleFromSelf() and FindCycleInDescendants() - the former is expected to be overridden by a resource that needs to take special care of some specific reference. (This mechanism could hopefully also be used/extended to handled cycles via <feImage> in filters.) Bug: 1028063 Change-Id: I34c80037516e0059e8b4cb4113fa0f4147d7ec31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066722Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#743488}
-
Frédéric Wang authored
Values of scroll coordinates in non-default writing modes are being changed to align with the CSSOM specification and make them more consistent with other browsers [1]. Existing JS libraries rely on feature detection to deal with these inconsistencies but they all trigger the counter that will be used for finch-based launch: ElementWithLeftwardOrUpwardOverflowDirection_ScrollLeftOrTopSetPositive. This CL adds a new test to demonstrate and check that feature detection can actually be performed without triggering that counter. [1] https://www.chromestatus.com/feature/5759578031521792 Bug: 721759 Change-Id: I1dbac7e8b7ff9fe40c0f45892c327f6b2a0c83e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056946 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
cathie chen <cathiechen@igalia.com> Cr-Commit-Position: refs/heads/master@{#743487}
-
Clemens Backes authored
Remove people that are not on the team any more. Add ecmziegler instead of titzer. R=bcwhite@chromium.org CC=adamk@chromium.org, ecmziegler@chromium.org Bug: 1053285 Change-Id: I0cb208c62a3d16c7d2862005d43140c5c9fc5b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061808 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#743486}
-
Victor Costan authored
AppCacheURLLoaderJob is the only subclass of AppCacheJob. This is a vestige of the Network Service migration, which introduced the AppCacheJob base class with two implementations. This CL merges AppCacheJob and AppCacheURLLoaderJob, and renames the result to AppCacheURLLoader. The new name is more appropriate in a Network Service-only world, and removes the potential for confusion with AppCacheUpdateJob. The following replaces were done mechanically over the entire repository: * AppCacheURLLoaderJob -> AppCacheURLLoader * AppCacheJob -> AppCacheURLLoader * appcache_url_loader_job.h -> appcache_url_loader.h * appcache_job.h -> appcache_url_loader.h * GetDerivedWeakPtr -> GetWeakPtr * appcache_url_loader_job -> appcache_url_loader AppCacheJob::AsURLLoaderJob() was removed, as it became a no-op after the class merger. The mechanical replaces above removed AppCacheURLLoaderJob::GetDerivedWeakPtr(), which became a synonym for GetWeakPtr(). When relevant, job / Job was replaced with loader / Loader in local variable names and method names. This CL does not introduce any functional change. Change-Id: I5a508a8dcb14ec77da05dd345d280ea27fa12fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066298 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#743485}
-
Rushan Suleymanov authored
Each node that has children must be a folder or a permanent node. Bug: 1051614 Change-Id: I6fcabab85d7d2a1ec6e1d824735c509582ca7fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064943 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#743484}
-
Armando Miraglia authored
Fixed: 1053026 Change-Id: Ic324fdb4c406cbbb5b29e2e14b0c173782fb3a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062437 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743483}
-
rajendrant authored
This CL records the coverage when image hints are unavailable: whether the hints fetched within 5 seconds of page navigation and the image URL was found in the hint list or not. UKM privacy review doc: https://docs.google.com/document/d/1u8CbXHHqUvhcFaYGsLAvTbITUmbEukW-FxQPujLHuIo/edit Bug: 1044798 Change-Id: Ifc9f416df1878d3cfc6a8b844f7b2912d2304659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063832 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#743482}
-
Hajime Hoshi authored
Before this CL, the time when the peak CPU usage occurred was measured as the time delta between the navigation start and the time when that happens. This didn't consider the background state and back-forward cache. If the tab was in background for a long time, the measure time was longer than we expected. This CL fixes this by recording the CPU usages only when the tab was not backgrounded in the window. Bug: 1014174 Change-Id: Ib15d8f189b1ce9a0329498da9883d54d54ac8bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050295 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#743481}
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates EphemeralTabCoordinator class. This CL creates a profile object based on isIncognito param to pass the current profile(i.e., regular or off-the-record profile) for TrackerFactory and FaviconLoader,while the profile always regular profile in current usage. This CL changes the behavior of code to make it run with correct profile. Bug: 1041781 Change-Id: Ia412cb5bdf28a269d2b75fac7c8cbf559c36a51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051985 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#743480}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates EditorDialog class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I322a8a21f92a911d85d8f4378c16a0b67c5f0ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064936Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#743479}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 496b728d. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" c07550c4 "Fix ResolvedUnitType() in CSS min/max with both integers and floats" 86c2cff8 "Don't make anchor clicks cancel form submission when href=#" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I93de8f09be7c8fb3afd352618dafa7d0ad25ce2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066580Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743478}
-
Steve Becker authored
Adds an immediate flag to unregister jobs for service worker registrations. When set, the immediate flag enables unregister jobs to run the "Clear Registration" algorithm immediately without waiting for the active worker's controllees to unload. After an immediate clear, the registration's controllees become uncontrolled. The controllees receive the 'controllerchange' event when the navigator.serviceWorker.controller is set to null. This change updates ServiceWorkerContextCore::DeleteForOrigin() to set the immediate unregister job flag to true. All other callers set the immediate flag to false. The storage quota manager uses ServiceWorkerContextCore::DeleteForOrigin() when clearing data for the origin. In addition to evicting origins to free up storage quota, this code path is used by scenarios like the Clear-Site-Data network header and the "clear browsing data" privacy UI setting. The change adds a new function to the ServiceWorkerRegistration class, DeleteAndClearImmediately(), which is used by ServiceWorkerUnregisterJob when the immediate flag is true. DeleteAndClearImmediately() is very similar to the existing function, ClearWhenReady(), but it does not wait to clear the registration when the active worker has controllees. ServiceWorkerContextCore::DeleteForOrigin() is also updated to call DeleteAndClearImmediately() on the origin's uninstalling registrations. Registrations stuck in the uninstalling state are waiting for the active worker's controllees to unload. ServiceWorkerContextCore::DeleteForOrigin() must stop waiting and clear the registration immediately. GetUninstallingRegistrationsForOrigin() is added to the ServiceWorkerRegistry to enable ServiceWorkerContextCore::DeleteForOrigin() to find the uninstalling registrations it needs to clear. For testing, the change adds a new unit test that sets the immediate flag to true in ServiceWorkerJobTest. The change also adds a new service worker WPT test, unregister-immediately.https.html. The new WPT test uses the Clear-Site-Data network header to unregister service workers with the immediate flag set to true. The WPT test adds a test case for each service worker state. For example, one test case uses Clear-Site-Data to clear a registration with a service worker in the 'parsing' state. Other test cases cover the other service worker states like 'installing', 'installed', 'activating' and 'activated'. Additional test cases verify controllee state, which includes verifying what happens to pending fetch events when the controller clears. Bug: 1014114 Change-Id: I3baee1117e6dbd349ec4c98c796d4e1b2bddde96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040533Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743477}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5e4f0910c1bf..4b6120a066eb git log 5e4f0910c1bf..4b6120a066eb --date=short --first-parent --format='%ad %ae %s' 2020-02-21 yangguo@chromium.org Update design review guidelines Created with: gclient setdep -r src/third_party/devtools-frontend/src@4b6120a066eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20e5e1a34e6d475c8bcfd45a25f2ebf6601c0872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068210Reviewed-by:
-
Omer Katz authored
Bug: 1053542 Change-Id: I01dbd7df946770044ac7c824a55c1ebcaf350a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066744Reviewed-by:
-
