- 11 May, 2018 40 commits
-
-
Sergey Ulanov authored
content_shell was trying to create log file in DIR_EXE. This doesn work on platforms where the directory is not writable, particularly on Fuchsia. Updated content_shell to use DIR_TEMP on Fuchsia. Bug: 778467 Change-Id: I03198062e0c067340479209c99056a4e0b460ea4 Reviewed-on: https://chromium-review.googlesource.com/1054785 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#558054}
-
David Benjamin authored
This introduces a wrapper for SignatureVerifier when the public key comes from a certificate. Bug: 795086, 803774 Change-Id: I177e4a2b3ea1b94afbac914c051be9f2b8b67985 Reviewed-on: https://chromium-review.googlesource.com/924349 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#558053}
-
danakj authored
This removes the WebLayerImpl subclass, pushing all the implementation into the base WebLayer class. Then blink can instantiate it directly since it lives in blink/public/platform/ so we don't need to go through WebCompositorSupport anymore. Thus we remove that as well, leaving cc/blink empty and we can remove the directory and all reference to it in DEPS and BUILD files. This makes it easier to reshape WebLayer to be the same as cc::Layer so that we may type-alias it along the path to removing WebLayer. R=chrishtr@chromium.org TBR=jam Bug: 838693 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I77744e2672f239d3d2c14a274e2de4cb658b8f48 Reviewed-on: https://chromium-review.googlesource.com/1055804Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558052}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59e400635dcd..eb85cead4784 $ git log 59e400635..eb85cead4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I43c29d911a065af6922a4e47eec8d3166c42310e Reviewed-on: https://chromium-review.googlesource.com/1056127Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558051}
-
Kyle Horimoto authored
Bug: 824568, 752273 Change-Id: Ie4aac00d5b077c3d1af3114e73447dd52065da75 Reviewed-on: https://chromium-review.googlesource.com/1056213Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#558050}
-
Chris Harrelson authored
Now that <foreignObject> gets a PaintLayer, hit testing no longer works correctly in the presence of a non-rectangular SVG clip path. This is because SVG children elements which are not <foreignObject> cannot have a PaintLayer, and PaintLayer is the only way hit testing currently knows how to account for clip-path. Fix this for "simple" clip-paths by adding a method to perform hit test clipping on the clip paint property tree. It works by checking all clips and clip-paths stored on the clip paint property tree between the local and ancestor points (in this use-case the ancestor is the containing PaintLayer), applying transforms as necessary. Non-"simple" clip paths (defined as SVG clip paths which have more than 42 edges or having text) are not fixed by this CL. The former condition could be handled in the future by adding a ClipPathForHitTesting to ClipPaintPropertyNode which stores the clip-path beyond 42 edges. Bug:833076 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iabbce97d412fe38a4b775739517d28628ef67964 Reviewed-on: https://chromium-review.googlesource.com/1055788 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558049}
-
Steven Holte authored
Change-Id: I5d69a8eb4a09f10a0127a445c971419dd7a79ea4 Reviewed-on: https://chromium-review.googlesource.com/1054384Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#558048}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43ae3f6d..65c09667 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I71107fa42202edfbded30a34a5a52f8699b96af0 Reviewed-on: https://chromium-review.googlesource.com/1055750Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558047}
-
Sandeep Vijayasekar authored
[Chromecast] If enableTouchInput() is called before CastWebContents is started, set enabled in delegate Bug: internal b/77303649 Test: none Change-Id: Ied34147646151de7b44e0b4ff5960e616ff422d9 Reviewed-on: https://chromium-review.googlesource.com/1043276 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558046}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86ad1383c8531e7f1272aa22d4d1e7374ae18ab3 Reviewed-on: https://chromium-review.googlesource.com/1053186Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#558045}
-
Charlie Harrison authored
This histogram is not being used and is not fully functional. This CL was split from crrev.com/c/1055738, and removes UseHistory from StreamSocket and TCPClientSocket. Follow-ups will remove HttpRequestInfo::RequestMotivation and Two StreamSocket methods that are no effectively no-ops. Bug: 629382,842337 Change-Id: Ieff43ffe0a1ede69a517217bcd9f3af15e57e8c1 Reviewed-on: https://chromium-review.googlesource.com/1055761 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558044}
-
Varun Khaneja authored
Works for Windows users only, at the moment. Next: Make it work for Chrome OS users. Bug: 796332 Change-Id: I1a14597851aaa239b15620c1f0444357176345a1 Reviewed-on: https://chromium-review.googlesource.com/1055940Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#558043}
-
Fadi Meawad authored
Only fetch(request, {keepalive: true}) is allowed as it is guaranteed to be delivered even if the renderer gets discarded. Bug: chromium:838684 Change-Id: I2966a7f9365ff8ab97a4a8cfc20b8df8c3e96561 Reviewed-on: https://chromium-review.googlesource.com/1038343Reviewed-by:Nate Chapin <japhet@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558042}
-
Bo Liu authored
Bug: 813232 Change-Id: Ibdddfa25e97f0c5fbf5e737305d16f6dcd70ecd0 Reviewed-on: https://chromium-review.googlesource.com/1055801Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558041}
-
Gabriel Charette authored
[MessageLoopForIO] Rename variables after standardizing MessagePumpForIO::FdWatchController class name. Missed those in associated migration. Alleviates reading confusion I experienced while reviewing https://chromium-review.googlesource.com/c/chromium/src/+/695914 R=fdoray@chromium.org, scottmg@chromium.org Bug: 825327 Change-Id: I2f9befb037d7931ef4471da660c3f9eeb91e8ecd Reviewed-on: https://chromium-review.googlesource.com/1054414Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558040}
-
Qiang Xu authored
changes: In crrev.com/c/930661, chrome changes the bounds locally which is backed by ClientControlledShellSurface without requesting Android for bounds change. This could lead to widget size inconsistent state. Bug: 831035 Test: test coverage Change-Id: I2d3c0fbc6b39f9637ac55d7f0292c2cc8a08c78e Reviewed-on: https://chromium-review.googlesource.com/1010906 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#558039}
-
David Tseng authored
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia1da47333ae15edb2cbeda1b0b7d0db9f30606a9 Reviewed-on: https://chromium-review.googlesource.com/1055654Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#558038}
-
Nate Fischer authored
No expected change to behavior, but this should have a slight performance boost to the support library. Previously, for each method call on a boundary interface, we would iterate over method parameter types and convert each type to the corresponding type visible by delegateLoader. This work is redundant, because we only ever pass pre-L frameworks types (e.g., WebView, String, InvocationHandler) and primitives. This work would not be redundant if we passed BoundaryInterfaces as parameters to some BoundaryInterface methods, however we don't ever intend to do so. Bug: 837820 Test: ./gradlew :webkit:connectedAndroidTest Change-Id: Icd3bfc620a45f9acd437da514ae5a02b3d8a6b02 Reviewed-on: https://chromium-review.googlesource.com/1054122Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558037}
-
Chris Bentzel authored
This histogram is not defined in histograms.xml and is not being used. Bug: 643561 Change-Id: Ib85c40e3f5df88df51caba61f9888e887219ee83 Reviewed-on: https://chromium-review.googlesource.com/1055951Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558036}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: Iaf6f74ab4bc02d95f93f0ffc44ccf20e0d1f0682 Bug: 833912 Reviewed-on: https://chromium-review.googlesource.com/1056153 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558035}
-
Yuri Wiitala authored
Moves/Refactors a lot of test infrastructure that can be re-used in an upcoming change to also test the new browser window capture impl: ContentCaptureDeviceBrowserTestBase: A common base class that sets up a content shell navigated to a test page, whose content can also be changed as test procedures require. FakeVideoCaptureStack: A simple representation of the entire downstream video capture stack that just takes the screen-captured video frames an stores them in a queue for later examination by the tests. FrameTestUtil: Math/Color utilities for analyzing the content in the captured video frames. Bug: 806366 Change-Id: I899db11043944ea5a1206a58b2593a317222fdab Reviewed-on: https://chromium-review.googlesource.com/1006072 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558034}
-
liberato@chromium.org authored
ui::ScopedMakeCurrent can crash during stub destruction, so we skip it if the (shared) context is already current. Bug: 839605 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifaa73ecc84bb335b1e154f38139a41b6ee37cdb9 Reviewed-on: https://chromium-review.googlesource.com/1055879Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558033}
-
Karan Bhatia authored
This CL merges RulesetManager::ShouldBlockRequest and RulesetManager::ShouldRedirectRequest into a single function RulesetManager::EvaluateRequest. This has the following benefits: - Code de-duplication b/w the two functions. - It's more efficient since it reduces duplicate computation. - Provides a more succint RulesetManager API. BUG=696822 Change-Id: Ib724063d94ebb2f79b8b3cee7e082c628337974b Reviewed-on: https://chromium-review.googlesource.com/1053207Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558032}
-
David Black authored
Breaking the currently used struct out into its own AssistantQuery class. Subclasses for AssistantTextQuery and AssistantVoiceQuery. We have a need to know whether the last query was a text query or a voice query and this will also allow for that. Bug: b:79532773 Change-Id: I28ab988d1eb1b816dc500549262225d9aff85daf Reviewed-on: https://chromium-review.googlesource.com/1054339 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558031}
-
Pavel Feldman authored
Change-Id: I368cce61bc3acedadefef6a7cc81ca22ec0327f8 TBR: dcheng for mojo touch Reviewed-on: https://chromium-review.googlesource.com/1055625 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558030}
-
Jeffrey Yasskin authored
BUG=842296 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7af43a396e06bbb662154401a3b90cedbf2477c2 Reviewed-on: https://chromium-review.googlesource.com/1055905Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558029}
-
Nick Harper authored
Change-Id: I17711baacd6f0f10f39da92d98f9941c4b9f87b9 Reviewed-on: https://chromium-review.googlesource.com/1047960Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#558028}
-
Qiang Xu authored
specs: https://screenshot.googleplex.com/zQNSgJP0d7d Bug: 793155 Test: manual Change-Id: Ic431bfd18f79c9c036007dadbbfe9a08a3c236c6 Reviewed-on: https://chromium-review.googlesource.com/1055792Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#558027}
-
chrome://flagsMoe Ahmadi authored
Adds an entry to about flags page in iOS in order to control the feature. Bug: 841758 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id61d8f4a63f0c6a89ec4c643640e1870d58c2ae7 Reviewed-on: https://chromium-review.googlesource.com/1055904 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#558026}
-
Jao-ke Chin-Lee authored
Also clean up migrated builders. BUG=793908,793913,793944 Change-Id: Iabec8c65ebb57182c4ad845072b8c3e9b3c5edac Reviewed-on: https://chromium-review.googlesource.com/1054702Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558025}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fafa09dbe1d3..d1de725e0b53 $ git log fafa09dbe..d1de725e0 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 jbudorick gclient: Prevent unprocessed deps from overriding processed ones in sync output. Created with: roll-dep src/third_party/depot_tools BUG=chromium:842235 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I683786d6e6d03e5abe897cd420bb6299c2b97b2a Reviewed-on: https://chromium-review.googlesource.com/1055823Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558024}
-
chrome://flagsEmily Stark authored
Bug: 839969 Change-Id: Id9a0ceff654f518e0adeeba74ed05dcb7f178bf2 Reviewed-on: https://chromium-review.googlesource.com/1055809Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558023}
-
xlou authored
In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. 1. Added new select label and button "Pages Per Sheet". 2. Added functionality to pass UI settings to the print preview renderer. 3. Added a new constant for N-up printing feature. Design doc for N-up printing feature is here: https://docs.google.com/document/d/1rA91PzWDLh6CFrAupgUwv7XYSIqbSpffEnDEQrpEdEQ/ Bug: 830090 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c9621fcfc8aa9f657960883e6c1ee981905d2bf Reviewed-on: https://chromium-review.googlesource.com/1050933Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shirleen Lou <xlou@chromium.org> Cr-Commit-Position: refs/heads/master@{#558022}
-
Aldo Culquicondor authored
It affects drawing and hit testing. If the quad is completely outside the clip, nothing is sent to the CPU. This is going to be used to implement scrolling. Also, this CL removes the unused copy_rect. Bug: 839488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I07c087f3d7860456587de092797349851c26502a Reviewed-on: https://chromium-review.googlesource.com/1054371 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#558021}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/746c45d5d8b1..7657336de212 $ git log 746c45d5d..7657336de --date=short --no-merges --format='%ad %ae %s' 2018-05-08 mikenichols [chromite] Capture job_name and git timing for ts_mon in cbuildbot runs. 2018-05-10 khmel arc: Retry copying resource in case race condition for android uprev 2018-05-09 achuith cros_run_vm_test: Support for --host-cmd Created with: roll-dep src/third_party/chromite BUG=chromium:829289,chromium:841937,chromium:832374 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7712f93eb43ad2661af0fe11a71a9b228ce916ad Reviewed-on: https://chromium-review.googlesource.com/1055816 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558020}
-
Devlin Cronin authored
Extension permissions can be complicated (especially around permission increases and permission warning generation). Add some documentation to the codebase for reference. Change-Id: If938a093439bd9c784bd735091c745ee7194299c Reviewed-on: https://chromium-review.googlesource.com/1054216 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#558019}
-
Mike Wasserman authored
Call CreateAndParentTopLevelWindow from WindowServiceDelegateImpl. Get the window type like ui/aura/mus/window_tree_client.cc Pass PropertyConverter, etc. args to avoid ash::WindowManager. Check access to possibly null WindowManager[Client], etc. ptrs. Add a unit test, apply properties to windows in test delegates. Bug: 837695 Change-Id: I9f474c4b2701efc110b0738ae56fb5334d2fa641 Reviewed-on: https://chromium-review.googlesource.com/1055658 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#558018}
-
Takumi Fujimoto authored
This CL enables the most basic functionalities: showing and hiding the dialog, showing sinks and their statuses (no throbber support yet), and starting and stopping tab mirroring. The dialog is still behind the ViewsCastDialog feature flag. - MRDialogControllerViews instantiates MRViewsUI and CastDialogView when a dialog is requested, and destroys them when the dialog is closed. - MRViewsUI sends CastDialogModel to CastDialogView whenever sinks or routes are updated. It also sends route requests from CastDialogView to MediaRouter. This CL depends on crrev.com/c/1020231. Bug: 826091 Change-Id: I14ed4811dd7ccdf0144c64b6f079c06d7fc0aa6e Reviewed-on: https://chromium-review.googlesource.com/1037907 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558017}
-
Jay Civelli authored
Adds additional information to the WebContentsObserver ResourceLoadComplete notification that is required by the page load metrics code: - host IP and port for the request - the total bytes count - the raw bytes count Also passing along the RenderFrameHost as part of the callback. Change-Id: I9646221498312800488660d6b1b76abed467031b Reviewed-on: https://chromium-review.googlesource.com/1050927Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558016}
-
Yuly Novikov authored
Bug: 839893 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib50865f70c7038bd6ba69aae675212b9f571b6c3 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1055856Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558015}
-