- 29 Nov, 2016 25 commits
-
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1e916c1c87c8..3950931a913d $ git log 1e916c1c8..3950931a9 --date=short --no-merges --format='%ad %ae %s' 2016-11-28 charliea Add a timeout for acquiring cloud storage pseudo lock 2016-11-28 benjhayden Plumb label, benchmarkStartMs thru ChartJsonConverter. BUG=669088 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2537643002 Cr-Commit-Position: refs/heads/master@{#434807}
-
mthiesse authored
This CL defines a base class for DisplayAndroid, and separates out an implementation for an Android Display backed DisplayAndroidImpl, and a VirtualDisplayAndroid (currently intended for use by Chrome's VRShell and WebVR). Unlike the DisplayAndroidImpl, VirtualDisplayAndroid is mutable to display clients. The display ID for a DisplayAndroid can no longer be assumed to match that of an Android Display. BUG=643480 Review-Url: https://codereview.chromium.org/2523273002 Cr-Commit-Position: refs/heads/master@{#434806}
-
msw authored
Use the common class from base instead. BUG=NONE TEST=Automated R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2528623003 Cr-Commit-Position: refs/heads/master@{#434805}
-
dtapuska authored
When an inputmode is specified it overrides the default text input type. inputmode is behind an experimental web platform flag but it allows the author to configure what virtual keyboard is shown for the various input and content editable fields. BUG=642800 TBR=aelias@chromium.org Review-Url: https://codereview.chromium.org/2523753003 Cr-Commit-Position: refs/heads/master@{#434804}
-
mek authored
BUG=669227 TBR=tsergeant@chromium.org Review-Url: https://codereview.chromium.org/2533103002 Cr-Commit-Position: refs/heads/master@{#434803}
-
patricialor authored
This replaces the idiom "poor man's <???>" with "ad-hoc". BUG=542537 Review-Url: https://codereview.chromium.org/2523973002 Cr-Commit-Position: refs/heads/master@{#434802}
-
bshe authored
BUG=664269 Review-Url: https://codereview.chromium.org/2530923002 Cr-Commit-Position: refs/heads/master@{#434801}
-
erikchen authored
The window is supposed to instantly pop behind and in front of the main browser window. BUG=667511 Review-Url: https://codereview.chromium.org/2532233002 Cr-Commit-Position: refs/heads/master@{#434800}
-
wkorman authored
To improve readability/maintenance. BUG=666800 Review-Url: https://codereview.chromium.org/2532283002 Cr-Commit-Position: refs/heads/master@{#434799}
-
rtoy authored
An ffmpeg roll seems to updated the handling of the pre-roll for the aac test. The difference between the new and old results is that the new has the initial 2048 samples (of zero) removed. BUG=669106 TEST=m4a-short-duration-44khz.html now passes Review-Url: https://codereview.chromium.org/2536843002 Cr-Commit-Position: refs/heads/master@{#434798}
-
Xianzhu Wang authored
This is a partial revert of https://codereview.chromium.org/2524113002/ which is incomplete about SVG text coordinate flipping. We could make it complete, but before we think everything clear, I'd like to revert the part first. At least all existing and new text cases about vertical SVG text pass with this CL. (Putting aside that we reuse InlineBox/LayoutBlockFlow code for SVG text, flipped writing-mode doesn't apply to SVG text because it doesn't have multi-line block direction layout. Vertical-rl and vertical-lr are actually equivalent for SVG text.) BUG=666416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 R=pdr@chromium.org Review URL: https://codereview.chromium.org/2533633002 . Cr-Commit-Position: refs/heads/master@{#434797}
-
pnoland authored
AutocompleteSyncBridge is the USS(unified sync and storage) equivalent of the AutocompleteSyncableService. The goal is for identical functionality, but with reduced memory usage due to unifying the storage of sync metadata and autofill data. R=pavely@chromium.org,isherman@chromium.org,pkasting@chromium.org BUG=666406 Review-Url: https://codereview.chromium.org/2508263003 Cr-Commit-Position: refs/heads/master@{#434796}
-
mattm authored
Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=651965 Review-Url: https://codereview.chromium.org/2513543003 Cr-Commit-Position: refs/heads/master@{#434795}
-
lukasza authored
BUG=669083 NOTRY=true Review-Url: https://codereview.chromium.org/2537613002 Cr-Commit-Position: refs/heads/master@{#434794}
-
kozyatinskiy authored
Expectations will be changed in https://codereview.chromium.org/2534013002/. BUG=chromium:661497 TBR=dgozman@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2536923002 Cr-Commit-Position: refs/heads/master@{#434793}
-
pfeldman authored
BUG=668072 NOTRY=true Review-Url: https://codereview.chromium.org/2540493002 Cr-Commit-Position: refs/heads/master@{#434792}
-
malaykeshav authored
Touch calibration requires atleast 3 pairs of display and touch points along with the total size of the display. This change implements a struct to store the minimum touch calibration associated data and an API for ManagedDisplayInfo to store and retrieve this data when required. Design Doc=go/cros-touch-calibration (Draft) BUG=667921 COMPONENT=Display, Chrome OS, Managed Display Info Review-Url: https://codereview.chromium.org/2521393002 Cr-Commit-Position: refs/heads/master@{#434791}
-
pdr authored
This patch ensures the FrameView paint properties are rebuilt when the window resizes. This fixes a crash if you resized wikipedia. BUG=667946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2524733005 Cr-Commit-Position: refs/heads/master@{#434790}
-
ssid authored
Review-Url: https://codereview.chromium.org/2535853003 Cr-Commit-Position: refs/heads/master@{#434789}
-
bcwhite authored
This will be used by a CL for the "breadcrumbs" project that needs to convert from a raw-memory pointer used by a class that knows nothing about persistent memory, back to a reference. BUG=620813 Review-Url: https://codereview.chromium.org/2534643002 Cr-Commit-Position: refs/heads/master@{#434788}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/c92e26defaa6..3c0f366daafe $ git log c92e26def..3c0f366da --date=short --no-merges --format='%ad %ae %s' 2016-11-28 npm Add some methods in CPDF_ImageRenderer 2016-11-28 npm Fix crash in CFDE_CSSSyntaxParser when parsing empty url 2016-11-28 npm Use unique pointers in CXFA_FMParse BUG=659509 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2528293003 Cr-Commit-Position: refs/heads/master@{#434787}
-
rob authored
BUG=668653 TEST=Manually clicking on the open download folder works, running the test case from the bug report triggers NOTREACHED. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2535483003 Cr-Commit-Position: refs/heads/master@{#434786}
-
jinsukkim authored
Refactoring https://crrev.com/2407303005 missed the action dismissing text handles when exiting action mode. This CL fixes it. BUG=666860, 668456 Review-Url: https://codereview.chromium.org/2523913004 Cr-Commit-Position: refs/heads/master@{#434785}
-
pilgrim authored
As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces first() with front(). There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2470233009 Cr-Commit-Position: refs/heads/master@{#434784}
-
carlosk authored
This change adds more detailed information to tracing and UMA histograms about the reason why a MHTML save operation has failed. This will help us understand why some specific pages consistently fail and better handle these situations. It introduces a new enum, MhtmlSaveStatus, that lists all tracked causes. Part of the reasons are tracked by the browser and the others by the render process but the reporting is centralized in the former. A few tests from MHTMLGenerationTest were also changed to verify the MHTML failures they test for are correctly reported. BUG=645686,655723,655708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2519273002 Cr-Commit-Position: refs/heads/master@{#434783}
-
- 28 Nov, 2016 15 commits
-
-
mattm authored
(Harmonizes under-specified behavior with other platforms.) BUG=410574 Review-Url: https://codereview.chromium.org/2521813002 Cr-Commit-Position: refs/heads/master@{#434782}
-
reillyg authored
This change refactors IndexedDB observations that they are transmitted through the same DatabaseCallbacks Mojo interface as other out-of-band database events. This means we can delete a lot of code that existed specifically to support observers in the Blink public API and remove the last remaining legacy IPC messages from indexed_db_messages.h. Note, indexed_db_messages.h remains after this change because removing it causes a lot of unrelated code churn. BUG=627484 Review-Url: https://codereview.chromium.org/2511403003 Cr-Commit-Position: refs/heads/master@{#434781}
-
mthiesse authored
BUG=667444 Review-Url: https://codereview.chromium.org/2533913003 Cr-Commit-Position: refs/heads/master@{#434780}
-
olivierrobin authored
This is needed for metrics to know the time between read and deletion. BUG=651041 Review-Url: https://codereview.chromium.org/2534903003 Cr-Commit-Position: refs/heads/master@{#434779}
-
jbauman authored
BUG=663019 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2513163002 Cr-Commit-Position: refs/heads/master@{#434778}
-
sigbjornf authored
More than one speech recognition object may exist at the same time, all sharing a single MockWebSpeechRecognizer underneath when running layout tests. Overlapping uses of speech recognizer objects weren't something the mock object was designed to gracefully handle, hence fuzzer inputs would leave the mock object in an invalid state and crash, when they attempted to do so. Rather than try to ignore and prevent overlapping uses from going ahed, we extend MockWebSpeechRecognizer with support for handling them, queueing recognizer context switching tasks that will run upon completion of the currently ongoing sequence of tasks that a speech recognizer object expects. R= BUG=668019 Review-Url: https://codereview.chromium.org/2525933002 Cr-Commit-Position: refs/heads/master@{#434777}
-
thakis authored
No real functional change, but instead of lazy-loading AVFoundation, it's now linked like all the other system frameworks and loaded by the dynamic linker at program startup. While unlikely, this might have an effect on startup time. BUG=579648 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2529493002 Cr-Commit-Position: refs/heads/master@{#434776}
-
rsesek authored
This should no longer be necessary now that the scrollbar animations are no longer driven by NSAnimation (https://codereview.chromium.org/529103002/). BUG=306348,533537 R=avi@chromium.org Review-Url: https://codereview.chromium.org/2509273005 Cr-Commit-Position: refs/heads/master@{#434775}
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2530893003 Cr-Commit-Position: refs/heads/master@{#434774}
-
martijn authored
Adding EmbeddedTestServer handlers after the server has started isn't thread safe. The request handler for "/slow?" gets added to the server when AddDefaultHandlers() is called[1], which already happens in createAndStartServer(), so the additional call here isn't necessary. [1] https://cs.chromium.org/chromium/src/net/test/embedded_test_server/embedded_test_server.cc?sq=package:chromium&dr=C&rcl=1480321223&l=295 BUG=546060 Review-Url: https://codereview.chromium.org/2524153002 Cr-Commit-Position: refs/heads/master@{#434773}
-
sammc authored
BUG=668384 Review-Url: https://codereview.chromium.org/2524293002 Cr-Commit-Position: refs/heads/master@{#434772}
-
bokan authored
There was an edge case here where we might get an arbitrary element as the document.documentElement. In these cases, the element won't get a LayoutObject as LayoutView will refuse to attach to it, but when we replace it a layout will create a non-LayoutBox for it and when RootScroller tries to replace it as the effective root scroller it needs to do some book keeping using the old root scroller. It incorrectly assumed it must be a LayoutBox. This patch now guards against this edge case. BUG=668553 Review-Url: https://codereview.chromium.org/2531343002 Cr-Commit-Position: refs/heads/master@{#434771}
-
chrome://printmkwst authored
We have an experiment running that would disable parser-inserted usage of 'chrome-extension://' URLs unless explicitly whitelisted. This breaks the print preview page, which relies on the PDF extension URLs inside an HTML import. So. This patch adds a mechanism for whitelisting that extension URL for the print preview page. BUG=667224 R=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2528903002 Cr-Commit-Position: refs/heads/master@{#434770}
-
eroman authored
* Path building now can only complete synchronously * Access to trust store is done synchronously * The network dependencies (AIA fetching) will block the thread BUG=649017 Review-Url: https://codereview.chromium.org/2453093004 Cr-Commit-Position: refs/heads/master@{#434769}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bced9de7..dade4fe3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2531373003 Cr-Commit-Position: refs/heads/master@{#434768}
-