- 03 Dec, 2020 40 commits
-
-
My Nguyen authored
We couldn't repro customer's problem, so adding this flag as a workaround for now. Bug: 1144851, 1140667 Change-Id: Idaa4d2b32ab27eeee518bace9704f2849849edb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569139Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833450}
-
Bailey Berro authored
This change adds inflight_routine_id_ as a member rather than it being forwarded along in the callback chain so that it can be used to cancel inflight routine Bug: 1128204 Change-Id: I7135417a52f0dfc75821edcf11edf92fa7410729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558755Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#833449}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f65a003f7f2b..10f76ac226f2 2020-12-03 philipel@webrtc.org Move RtpVp9RefFinder unittests into its own file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie4b983b1e2efd9fedfc7458ae11f1b7e7bd3702b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833448}
-
Brian Sheedy authored
Removes any test expectations for the AMD RX 550 since the builder is being decommissioned. Bug: 1154895, 1132381, angleproject:3354 Change-Id: I60e4800ed616609caffe616320311dcb2ef924ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572139 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#833447}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6237ff2..8c8f17af Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I878e86f480fd194144600b23299e43118a1700f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572158Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833446}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606920808-08f6b2c5c596afe8ed94a12135b915a001611c72.profdata to chrome-win32-master-1606996231-fb1aa25fe6cd29fd31733f8199da138cbb1f5caf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I591da57207ff94c08c1c9e59d8d3fdefe4d83283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571199Reviewed-by:
-
Evan Stade authored
Bug: 1152284 Change-Id: I0a82d34d5bd4151db65495d063ff9cb0c64fb6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570388 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Tommy Li authored
This CL simplifies MergeDataAndStartSyncing() and its child method MergeInSyncTemplateURL() to stop making duplicate "amazon.com_" style engines when two engines share the same keyword. This CL also deletes some no longer used auxiliary methods: 1. UniquifyKeyword() 2. IsLocalTemplateURLBetter() 3. ResolveSyncKeywordConflict() The long explanation is here: go/chrome-search-engines-2020-improvements Bug: 1022775 Change-Id: I2a13f23399d90ab02a5ac90ebd74d4b3f32567d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568357 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#833443}
-
Steven Bennetts authored
This CL: * Marks some unused histograms as obsolete * Updates ownership of some histograms * Updates a few expires_after dates for consistency BUG=1097831 R=chromium-metrics-reviews@google.com Change-Id: Ice2d51014bd4211a0a70c0dd893c33c508cd5c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568597Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#833442}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/chromeos. Bug: 1113033 Change-Id: I37207cd88f3788e42ecdf0ee24f8af0e0d7f395f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572169 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#833441}
-
Kai Ninomiya authored
This rolls to revision 3c2fe38, which is the most recent 'main' branch commit corresponding to the DEPS revision prior to this CL. This minimizes the changes due to the switch; we can roll further later. Bug: 852089 Change-Id: Ie582b359087fd19af44def66309766f10c807452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570207 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#833440}
-
Daniil Lunev authored
Unused since UpdateKeyEx deprecation. Bug: chromium:1150430, b:172344610 Test: CQ Change-Id: I138fc01c6aaa2436c9044f7d8759a8a979a73209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569027 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833439}
-
Daniil Lunev authored
It was used only in UpdateKeyEx workflow, which was removed in [1][2][3] [1]https://chromium-review.googlesource.com/c/chromium/src/+/2550904 [2]https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2566390 [3]https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2565147 Bug: chromium:1150430, b:172344610 Test: build Change-Id: Ifb1de81e552277774eff207492e2b7a099e22697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567086Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#833438}
-
Victor Vianna authored
There are no remaining usages of base::Callback/base::Bind() in this directory since crrev.com/c/2527142. Change-Id: I8c18a0d777939937ba641fe17878f712ae9b1966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572337 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833437}
-
Norman Rosas authored
//components/r… also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: Idf79214ca7fafb82c3808068e46d3b02966fc922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570198 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Avi Drissman authored
With theme control refresh and other projects, many of the Mac theme colors are no longer used. Since getting some of those colors involved using old and deprecated APIs, remove all colors that aren't currently being used. Fixed: 1138531 Change-Id: Ie0fdd628f92104c68536efcac8a5a4c298aae982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572238 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833435}
-
Robert Sesek authored
Bug: 1153883 Change-Id: Ideeb2277b536626c327466c213e573d29e222786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572260Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833434}
-
Ben Pastene authored
crrev.com/i/3444414 allocates the machines for this. Bug: 1140727 Change-Id: Id49c7c2ad4f6c692fef2b1bcbdc87ba50d2ee602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572400Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#833433}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606996231-ba5c68d71497939eb8f18cb3a40e45fa42cfdc85.profdata to chrome-mac-master-1607018334-4ec258faf10b8c54ec4574a66b7b864fdc99dca8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I47d38fb93adb231391c4b9f3b666a93c40c7b524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571749Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606996231-dddb4c2fad470c1e447a44fedd130c4825b70fb9.profdata to chrome-linux-master-1607018334-f670cab7a0d67beb5d9952b6762b75fa44bc4bec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iffb89d489358e5a95a3cf56d29fb6593aa3f2e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572357Reviewed-by:
-
Robert Sesek authored
Bug: 1153883 Change-Id: I91cabcc04d78ad3d3d97bdb55855bedc9eb92114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571805Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833430}
-
Adam Rice authored
On Big Sur, guarded_close_np() has started sometimes returning EPROTOTYPE or ENOTCONN errors. Try calling shutdown() before close as a speculative workaround. BUG=1151048 Change-Id: I99e4a58f1468027402099fd5b0220872f14b1578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561079Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#833429}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I64fda2befe0c943ba5c955ae6eb8bc81f9c659c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572257 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#833428}
-
Nnamdi Theodore Johnson-Kanu authored
- Screenshot are added in follow up CL https://chromium-review.googlesource.com/c/chromium/src/+/2569784/ - Added esim_remove_profile_dialog to internet page to allow for testing. Bug: 1093185 Change-Id: I227c56f1ff1b8cca48d0d674f617966a22ba5bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566711Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#833427}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib93c639ab2d42f42afb381b1ff7a17dc076e71b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571807Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#833426}
-
Evan Stade authored
Unintuitively, it seems this can be called more than once if a close is confirmed by the user but later aborted. Bug: 1152284 Change-Id: I89d45ae0eadf3248fccd983406fe0dc5d050afd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570332Reviewed-by:
-
Bill Carr authored
This change updates the Mojo Renderer OnError method to take in a media::Status object, wrapping a PipelineStatus, in order to pass the error code from the Mojo Renderer Service to the Mojo Renderer. This was a basic missing bit of functionality that will allow Mojo Renderers to communicate a more accurate error state for telemetry & logging purposes. The media::Status object was used as part of a longer term plan to allow passing a render or platform specific error status (such as an OS native status code, e.g. an HRESULT on Windows). A part 2 change will move the Renderer OnError method to replace PipelineStatus with the Status object but preserve the existing PipelineStatus enumeration values & strings for telemetry & logging reporting purposes. Bug: 1146085 Change-Id: I22faa88cb30e86dceda5a2630d416a62fb0e66ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553920Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
-
Jan Krcal authored
This reverts commit c40e539d. Reason for revert: The test is still flaky (with another failure). Original change's description: > [Profile picker] Reenable a previously flaky test > > This CL reenables the CreateSignedInProfileSigninAlreadyExists test > within the ProfilePickerCreationFlowBrowserTest suite. The underlying > bug has been fixed by a previous CL. > > Bug: 1144065 > Change-Id: I7b15ff47f4eb8c3e16214269bc98a7f23bddbf01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563671 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832273} TBR=droger@chromium.org,jkrcal@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144065 Change-Id: If28415db9dbebed1b9eb2ea80df49ad80bd7887b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571698Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833423}
-
Robert Sesek authored
Bug: 1153883 Change-Id: Ic1e2dc39b96c2c5ed1e80c4732e1a2dcee02b675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571801Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833422}
-
Kyra Moed authored
Implement conversion from single PNG to PDF image format when requested by user on scanning UI. Add unit tests to verify functionality. Bug: b:161237869 Change-Id: I94f383980ff284996008755509e63ed6023be1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547303 Commit-Queue: Kyra Moed <kmoed@google.com> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#833421}
-
Jeffrey Young authored
Split informational text view out from main ambient image view. Create new class AmbientInfoView. BUG=none Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I55e96ae26093568cd3bbe4bfb238da2272a217b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566632 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#833420}
-
Min Qin authored
This CL will allow the server to send more trending tiles to the client, and client can cache those tiles to replace existing trending tiles if they are not being interacted after some time. By default, 2 trending tiles will be shown. If a trending tile is shown twice, it will be removed if no activity is recorded. Bug: 1154456 Change-Id: I7bf304b56b86e92ad51446bf82427e24dbd810d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568224Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833419}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..877fbcb69179 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4f0d483e1b7348e3c9873751dd355dbdb4f70c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572163Reviewed-by:
-
Daniel Murphy authored
This change adds a feature to remove the status bar in installed WebApp windows (the small text box that appears in the lower left hand corner of the window). Bug: 1151487 Change-Id: I059a24697c140916571516174bd4a8b6db979254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551673 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833417}
-
Jana Grill authored
Adjust IDS_IOS_ENTERPRISE_MANAGED_SETTING_DESC_WITH_COMPANY_NAME to support FlexOrgs by renaming the domain placeholder to manager and adjusting the description to make it easier for the translators to understand the usage of the text. In the future the placeholder passed to this string for the enterprise name needs to be replaced by the user's managed_by PolicyData field as explained in the ticket, however currently nil is always passed as the enterprise name (see https://osscs.corp.google.com/search?q=%22initWithEnterpriseName:%22). Bug: b:172679683 Test: None Change-Id: Ib636acb7c4ea7da347a00caec2ddfd136a123dcf Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566969Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#833416}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I162df2f95b19ca770048835a8839ffdeea69bc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571754Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833415}
-
Dave Tapuska authored
The code used a view routing ID to access the appropriate WebFrame. It is more appropriate to lookup via the frame token. BUG=1155202 Change-Id: I364525848a2cb37343814216598724040acbf0ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572042Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#833414}
-
Kai Ninomiya authored
Bug: None Change-Id: Id90263faf4aade3b39742cb0db6c5c9109429e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570206 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#833413}
-
Scott Violet authored
Specifically from the context menu and app menu. There are separate options for each one. This is only allowed if a service connection is available as well as the right package. BUG=1154709 TEST=covered by tests Change-Id: If9b67cbb1ffbb629af3ae207b0aec85378e65ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570238 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#833412}
-
adamta authored
Adds parent metrics recorder for common feed metrics shared across Zine and Discover. Allows us to have the same engagement metrics for both Zine and Discover feeds, to compare Apfelstrudel engagement and interactions. Change-Id: Ib94e459b4cd0339d2c066570fbd21379dbffe32b Bug: 1155224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570555 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#833411}
-
