GitLab

Chromium side of the implementation of tracking profile stats (number of profiles, number of signed in profiles) through the Omaha channel for Mac. Design doc: https://docs.google.com/a/google.com/document/d/15Ou8VCYNCZvke8Bw9bF3vYqD67voJBPyx_GBR8ONcCw/edit?disco=AAAAAKU7Zzg (Googler Only)

BUG=409895

Review URL: https://codereview.chromium.org/593243002

Cr-Commit-Position: refs/heads/master@{#318729}

Software rendering isn't supported on the GBM platform. Rather than
allow callers to crash due to nullptr accesses, crash explicitly so we
get more meaningfull crash reports.

BUG=461396

Review URL: https://codereview.chromium.org/958403004

Cr-Commit-Position: refs/heads/master@{#318728}

This CL introduces a new TRACE_EVENT_PHASE for memory dump
and enables the MemoryDumpManager to generate actual trace
events when CreateLocalDumpPoint is invoked.

BUG=458295

Review URL: https://codereview.chromium.org/956413002

Cr-Commit-Position: refs/heads/master@{#318727}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f48b013..696617b

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/965793004

Cr-Commit-Position: refs/heads/master@{#318726}

This adds a target to run jscompile over the unittest files.

The save/restore functions of chromeMocks are removed since they are not
necessary. chromeMocks.reset() is called automatically before each test.

It also fixes most of the errors that jscompile produces. For the unittests
where all the errors have not been fixed, jscompile is disabled for those
files. Cases where errors were not fixed include those that require
refactoring base classes to expose an interface that the corresponding
mock can use -- these are best done is a separate, targetted cl.

Also, the it2me tests are not checked because they will be removed soon.

BUG=

Review URL: https://codereview.chromium.org/959963002

Cr-Commit-Position: refs/heads/master@{#318725}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9345eef..b3310c2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/970943002

Cr-Commit-Position: refs/heads/master@{#318724}

BUG=437508

Review URL: https://codereview.chromium.org/964443002

Cr-Commit-Position: refs/heads/master@{#318723}

BUG=none

Review URL: https://codereview.chromium.org/967213003

Cr-Commit-Position: refs/heads/master@{#318722}

BUG=460998

Committed: https://crrev.com/51c1620185396384cfe6e2f4e3359e57c6431600
Cr-Commit-Position: refs/heads/master@{#318591}

Review URL: https://codereview.chromium.org/964753002

Cr-Commit-Position: refs/heads/master@{#318721}

Current implementation use ContentSettingsPattern::Wildcard()
to reset a setting for the current visiting page, but it does not
work. This should be the embedder URL as geolocation does.

BUG=460733
TEST=manual

Review URL: https://codereview.chromium.org/972733003

Cr-Commit-Position: refs/heads/master@{#318720}

The header include guards should match the file path from root.

These entries were found using a modified version of Eric's
fix-include-guards.py script found attached in
https://code.google.com/p/chromium/issues/detail?id=435361#c7.

BUG=435361
TEST=gn_unittests
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/968193002

Cr-Commit-Position: refs/heads/master@{#318719}

Enhanced bookmark model is the data abstraction layer of enhanced bookmark.

This CL also fixes the bug that add folder returns a wrong bookmarkid.

BUG=458632, 458703

Review URL: https://codereview.chromium.org/929523002

Cr-Commit-Position: refs/heads/master@{#318718}

This will allow the caller to specify an argument to adb public keys to be
written to the device (along with any existing keys already on the device)
during wiping.

BUG=

Review URL: https://codereview.chromium.org/970573002

Cr-Commit-Position: refs/heads/master@{#318717}

All hosts should be using OAuth2 now, so ClientLogin support can
be removed.

BUG=446646,83897

Review URL: https://codereview.chromium.org/959033004

Cr-Commit-Position: refs/heads/master@{#318716}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3da9181..9345eef

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/968933003

Cr-Commit-Position: refs/heads/master@{#318715}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/45ff499..f48b013

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/968163004

Cr-Commit-Position: refs/heads/master@{#318714}

BUG=382562

Review URL: https://codereview.chromium.org/962583003

Cr-Commit-Position: refs/heads/master@{#318713}

+ Reinstate the error code to main content as important for debugging when screen shots are sent
+ Remove the 'Error code:' prefix on the net error for consistency.

Fixes related to browsing scaling:
+ Remove fixed button height to fix cropped button
+ Fix to incorrectly scaled T-rex

Design:
+ Make the faint tick in checkbox have 0 opacity
+ Fix cropped padlock icon

BUG=460116,459510,459126,458484

Review URL: https://codereview.chromium.org/952563003

Cr-Commit-Position: refs/heads/master@{#318712}

Add top_25_smooth.json as archive_data_file for top_25_smooth page set.
top_25_pages page set uses top_25.json.

BUG=418375

Review URL: https://codereview.chromium.org/966283002

Cr-Commit-Position: refs/heads/master@{#318711}

BUG=
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/964413002

Cr-Commit-Position: refs/heads/master@{#318710}

The call to WebViewImpl::setVisibilityState updates Blink's Page state
correctly, but was not notifying the WebFrameWidget's LayerTreeHost.

This patch calls a newly added method in WebFrameWidget that resolves
some rendering issues.

BUG=450674

Review URL: https://codereview.chromium.org/958973002

Cr-Commit-Position: refs/heads/master@{#318709}

DisplayController::UpdateMouseLocationAfterDisplayChange() is now called during
startup:
- In Ozone once a channel to the GPU has been established
- In X11 as a result of
  DisplayChangeObserver::OnTouchscreenDeviceConfigurationChanged()

Moving the mouse on startup:
- Causes side effects such as mouse hover
- Causes a mouse event to be generated which causes
  CompoundEventFilter::SetCursorVisibilityOnEvent() to show the
  mouse cursor.

This CL makes DisplayController::UpdateMouseLocationAfterDisplayChange() move the
mouse only if necessary.

BUG=450860
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/902123002

Cr-Commit-Position: refs/heads/master@{#318708}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2ea3d3a..45ff499

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/964423002

Cr-Commit-Position: refs/heads/master@{#318707}

BUG=393668

Review URL: https://codereview.chromium.org/965813003

Cr-Commit-Position: refs/heads/master@{#318706}

BUG=428729

Review URL: https://codereview.chromium.org/966913003

Cr-Commit-Position: refs/heads/master@{#318705}

This CL adds two more Android instrumentation tests for Web Notifications,
which verify that the "tag" property on a notification will replace any
previous notification being shown, and a test verifying that activating
the notification will invoke the Service Worker, closing the notification.

BUG=462251

Review URL: https://codereview.chromium.org/958993002

Cr-Commit-Position: refs/heads/master@{#318704}

It was never really taken into use (it was meant to be used by external tools
but we never figured out how they should interact w/ Telemetry) and it's out of
date.

BUG=274456
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/962673002

Cr-Commit-Position: refs/heads/master@{#318703}

BUG=463111

Review URL: https://codereview.chromium.org/968973002

Cr-Commit-Position: refs/heads/master@{#318702}

Update the list of included unit tests on iOS to list all the components
that are built on iOS (based on the list in components/components.gyp).
Use an exclusion to remove all tests that depends on //content.

Sort the list of gypi files included by components.gyp.

BUG=462585

Review URL: https://codereview.chromium.org/963683003

Cr-Commit-Position: refs/heads/master@{#318701}

UmaSessionStats is primarily for tracking metrics pertaining to the
length of a user-session in chrome (from start/resume to pause) but
also tracks some usage during the session.

BUG=428903

Review URL: https://codereview.chromium.org/962293002

Cr-Commit-Position: refs/heads/master@{#318700}

BUG=460949
R=primiano@chromium.org

Review URL: https://codereview.chromium.org/972673002

Cr-Commit-Position: refs/heads/master@{#318699}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/db873d8..3da9181

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/971743002

Cr-Commit-Position: refs/heads/master@{#318698}

BUG=461282

Committed: https://crrev.com/c3a3f671f8e0c5777c6bc825f21d61c6bcafbec3
Cr-Commit-Position: refs/heads/master@{#318666}

Review URL: https://codereview.chromium.org/952853002

Cr-Commit-Position: refs/heads/master@{#318697}

This achieves a couple of goals:
1) Upstreams MemoryUma
2) Pulls it up from ChromeTabbedActivity (internal) to
AsyncInitializationActivity. This ensures that other activities (e.g.
DocumentActivity) also report memory warnings.
3) Instantiate MemoryUma!! This was broken in
https://chrome-internal-review.googlesource.com/161577 so low-memory
warnings haven't been reported since M35! :(

BUG=428903

Review URL: https://codereview.chromium.org/961323003

Cr-Commit-Position: refs/heads/master@{#318696}

HELLO_IMPLEMENTATION was a typo in the no-win condition.

The correct is to check if HELLO_SHARED_IMPLEMENTATION was defined,
as that is what is defined by //tools/gn/example:hello_shared target.

BUG=None
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/966333006

Cr-Commit-Position: refs/heads/master@{#318695}

This can be landed once the interface change has been made in WebRTC and rolled into Chromium (see here: https://webrtc-codereview.appspot.com/40139004/).

BUG=webrtc:2822

Review URL: https://codereview.chromium.org/875483002

Cr-Commit-Position: refs/heads/master@{#318694}

BUG=461854
TEST=manual

Review URL: https://codereview.chromium.org/971733002

Cr-Commit-Position: refs/heads/master@{#318693}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d06ecdb..2ea3d3a

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/963493003

Cr-Commit-Position: refs/heads/master@{#318692}

BUG=459678
R=noyau@chromium.org

Review URL: https://codereview.chromium.org/972683002

Cr-Commit-Position: refs/heads/master@{#318691}

When using multiple BrowserState (think saving and incognito), each one
has a different path to stored data on iOS. In order to avoid confusion
with chrome Profile change the name of the method returning the path of
a BrowserState to GetStatePath().

BUG=None

Review URL: https://codereview.chromium.org/964403002

Cr-Commit-Position: refs/heads/master@{#318690}