GitLab

V8 must not be executed on the default task runner. This CL replaces
that with a per-frame task runner.

Bug: 870606
Change-Id: I9c3844692235baad411a83ed50a7c6402e0a3b8f
Reviewed-on: https://chromium-review.googlesource.com/c/1312444Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610007}

This CL is reupload of CL:1329797 which was reverted in CL:1343260 due to test flakiness.

The test flakiness comes from waiting of "https://www.google.com/..." URLs to be loaded.
Replacing these URLs with local URLs generated by EmbeddedTestServer fixed the problem.

Bug: 906834
Bug: 889916
Change-Id: I3e9981b4a4ca5a0bd64dff217e44bfd89ca10b9c
Reviewed-on: https://chromium-review.googlesource.com/c/1344132Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610006}

This reverts commit cf14fec1.

Reason for revert: Unexpected 3.5 MiB increase of private RAM usage

BUG=907092
TBR=agrieve@chromium.org, pasko@chromium.org

Original change's description:
> android: build: Enable RELR packed relocations for libchrome.so
> 
> NOTE: This is a reland of [1], but this one does not touch
> libchromefortest.so which is used on Android N+ during testing,
> and could not be loaded by the system linker when using RELR
> relocations.
> 
> This optimization cannot be applied to libmonochrome.so, unfortunately,
> because only Android P and above support these at the system linker
> level.
> 
> [1] https://chromium-review.googlesource.com/c/1304487
> 
> BUG=895194
> R=​agrieve@chromium.org,torne@chromium.org,pasko@chromium.org,pcc@chromium.org
> 
> Change-Id: If50f607d2e9abbff5ae0c140da342af7b8c78858
> Reviewed-on: https://chromium-review.googlesource.com/c/1317630
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: David Turner <digit@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609142}

TBR=pasko@chromium.org,digit@chromium.org,torne@chromium.org,pcc@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 895194
Change-Id: Ib796a90aca376042d8b91f2a388060c3738bb096
Reviewed-on: https://chromium-review.googlesource.com/c/1346090Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610005}

When details are empty and no UI update is needed we should return.

Bug: 806868
Change-Id: Ibc644b11f135d9fab082b942f8939257b9933b1e
Reviewed-on: https://chromium-review.googlesource.com/c/1345078Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Lukasz Suder <lsuder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610004}

CL:1345374 removed metrics / analytics use from ImportHistory and with
those gone, we can now 1) remove them from import_history_unittest and
2) remove metrics from the import history js_library BUILD deps.

No change in test behavior, no new tests.

Bug: 905934
Change-Id: I706beb0fa5c61fdb55b46a8d2072a9de1016fa40
Reviewed-on: https://chromium-review.googlesource.com/c/1346189Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610003}

Bug: 845472
Change-Id: Id077ed820ad559e00da61d96bf82f890333d9c86
Reviewed-on: https://chromium-review.googlesource.com/c/1341523
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610002}

drag state

Only allow frames who are ancestors of the drag_src_ to reset a drag_src_

Created layout test to show previous lack of dragend when moving iframe in dom
as a result of dragging
Created layout test to verify lack of regression when frames containing drag
source are moved/detached

Fix memory leak from reverted CL https://crrev.com/c/1265818

Bug: 737691, 903705, 903933
Change-Id: I308680446662d6548587ae2d7dd2c139b09ee581
Reviewed-on: https://chromium-review.googlesource.com/c/1336440
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610001}

If a delayed task is posted from a non-main thread and task queue time
recording is enabled, we attempt to grab the "any thread" lock twice,
leading to a deadlock. This patch reduces the scope of the lock to avoid
the problem.

Original fix from Alexander Timin <altimin@chromium.org>.

Bug: 891670
Change-Id: I5af0c2016a12b061c523b8b51c16ff23a8f3a41f
Reviewed-on: https://chromium-review.googlesource.com/c/1344144Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610000}

This is a minimal fix - move the generation of the track (which
causes onnegotiationneeded) to before we set the expectation that
no event will be fired.

Bug: chromium:905563
Change-Id: I879f6eb6130d719d7eaad71fed85044b690f0cb9
Reviewed-on: https://chromium-review.googlesource.com/c/1346030Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609999}

This is the first step of those that will allow us remove the dependency
from SigninManager::IsAllowedUsername() in the long run, as part of our
effort to migrate parts of the code base to the Identity service.

Note that this free function will be in the |identity| namespace even
if it's actually declared & defined in signin_manager.[h|cc] for now,
which should be ok since this is just a temporary situation until we
get to a state where SigninManager is not used by any consumers outside
//services/identity, at which point we'd simply move it to the public
C++ API in there. We can't do it now, though, because doing so would
create a dependency cycle as //components/signin would have to depend
on //services/identity (which in turn depends on //components/signin).

Bug: 906081
Change-Id: I0ec5817661c0cfd27c7a08ef67eae389beff1230
Reviewed-on: https://chromium-review.googlesource.com/c/1344145Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#609998}

https://webrtc.googlesource.com/src.git/+log/38332cdcb107..66eedce30a82


git log 38332cdcb107..66eedce30a82 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7d53bc24..16e6b253 (609559:609893)
2018-11-20 ssilkin@webrtc.org Increase buffer level threshold in VP8/9 tests.
2018-11-20 nisse@webrtc.org Delete unneeded includes of common_types.h and gn deps on webrtc_common.


Created with:
  gclient setdep -r src/third_party/webrtc@66eedce30a82

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I02cbbfbd8c6c62a834cd93d5e70504b8777e40b1
Reviewed-on: https://chromium-review.googlesource.com/c/1345730Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609997}

Using wpt-import in Chromium 871f84f2.
With Chromium commits locally applied on WPT:
3629f6dc "Refine wpt/service-workers/service-worker/clients-get.https.html"
02c7f5d5 "Revert "Add referrer-policy module worker tests""
396a0004 "[BlinkGenPropertyTrees] Filter effects should be clipped"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I7bc81554c3ce6e05f6939858d10c97b4f01075b3
Reviewed-on: https://chromium-review.googlesource.com/c/1344833
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609996}

This CL allow propagating is_from_expiration bool to TypedURLSyncBridge.
It is important for keeping sync data (in history DB) with sync metadata
consistent. This bool will be used in a follow-up CL.

Bug: 851869
Change-Id: I96bec4ecc86f9357a82b7abf4ca7ee8320ef998d
Reviewed-on: https://chromium-review.googlesource.com/c/1343005
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609995}

This provides support for the Contacts Picker API,

 https://github.com/beverloo/contact-api
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/brKChSa9_d0

allowing contact details to be shared with a web page.

A skeleton select() function is implemented (returns a
DOMException).

BUG: 860467

Change-Id: I7cf4c147271179c0f59a7cd455d88b1b570c9891
Reviewed-on: https://chromium-review.googlesource.com/c/1326501
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609994}

This is intended to make it easier to detect if an RTCPeerConnection is used
together with getUserMedia() or getDisplayMedia() for real-time audio/video.

Bug: 906029
Change-Id: I440fc93567bd9a490047c2bcf3bf5641a4ff3dfa
Reviewed-on: https://chromium-review.googlesource.com/c/1344101Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609993}

Bug: 878388
Change-Id: I1326cc2cc851efcb8ec4e873f0c6aa62710d30cf
Reviewed-on: https://chromium-review.googlesource.com/c/1344056Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609992}

On Windows, malloc() (in Chrome) never returns nullptr, instead triggering an
OOM. Explicitly using UncheckedMalloc() to get nullptr in case of allocation
failure.

Bug: 905777
Change-Id: I56bf677710b606cc6ca69073f4cc2d34c4ef19dd
Reviewed-on: https://chromium-review.googlesource.com/c/1344064Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609991}

Some CE default styles might not have RuleSets, this CL adds some
null checks.

Bug: 895512

Change-Id: I02e0f5070c36c72e8d03ed950d96783506f05c5a
Reviewed-on: https://chromium-review.googlesource.com/c/1343585
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609990}

Since we are exposing /storage instead of /var/run/arc/media/removable
inside ARC++ container, we should also request scan through /storage so
that MediaScanner is not confused.

BUG=b:69078137
TEST=Manually verified. Google Photos doesn't show duplicate device
anymore (before, it shows one for /storage and one for
/var/run/arc/media/removable).

Change-Id: I93e9f029068110983d6033348acb9f2e85fd5f89
Reviewed-on: https://chromium-review.googlesource.com/c/1329820Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Risan <risan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609989}

- Fixed build failure of win_rel target.
- Made tests chromeos-only for now.

> This reverts commit 493db4b2.

> Reason for revert: Compile error on win-rel builder.
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/6451

> Original change's description:
> > media/gpu/test: Initial version of the Test Video player.
> >
> > The test video player is created to improve the way VDA (video decode
> > accelerator) tests are created, and to allow more control of the test flow.
> >
> > This is an early prototype, that only supports playing a video from start to
> > finish. More complex tests and their required functionality will be added soon.
> >
> > TEST=ran new VDA tests on eve and kevin
> >
> > BUG=879065
> >
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> > Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba
> > Reviewed-on: https://chromium-review.googlesource.com/c/1179484
> > Commit-Queue: David Staessens <dstaessens@chromium.org>

BUG=879065

Change-Id: Ibc17303776b2378470b50da88948bc6907732411
Reviewed-on: https://chromium-review.googlesource.com/c/1345670
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609988}

Bug: internal b/112463440.
Change-Id: I6c652d45c1e5b6343f04932a9afe0b9731546207
Reviewed-on: https://chromium-review.googlesource.com/c/1344059
Commit-Queue: Jan Lamecki <jachor@google.com>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609987}

Bug: 769508
Change-Id: I32e58b403f2f0e279091b7209aedaa69c4e9b5cb
Reviewed-on: https://chromium-review.googlesource.com/c/1345010Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609986}

MediaLicense deletion was added in crrev.com/c/1213242 but due to a
confusion about the purpose of SiteDataDeleteHelper, it didn't work
correctly. This CL correctly implements MediaLicense deletion when
a site is reset from Settings > SiteSettings > AllSites > [Site].

Tested manually by adding a LOG statement to OriginMatcher in
website_preference_bridge.cc and testing that offline content stored
from https://shaka-player-demo.appspot.com/demo/ triggers the LOG
statement when resetting a site.

Bug: 883701
Change-Id: I28b93c44daea757084dc5b6e667a2d36bc00b70f
Reviewed-on: https://chromium-review.googlesource.com/c/1337623Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609985}

BUG=901345

Change-Id: I90afa3439fedc68032ab69158d2ecfae2ba52884
Reviewed-on: https://chromium-review.googlesource.com/c/1343088
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609984}

To prepare for closure compilation of this unit_test file, clean-up to
make upcoming closure changes easier to understand.

  - update and fix obvious closure @type errors, etc
  - remove '|undefined' from variables new-ed in Setup()
  - define undefined variables, remove unused variables
  - importer.SyncFileEntryProvider is not defined in Files
    app, nor in the code-base or the web: remove it.

No change in test behavior, no new tests.

Bug: 905934
Change-Id: Idab68cc2257286e2278cdce361a84fc2176c51cc
Reviewed-on: https://chromium-review.googlesource.com/c/1345690
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609983}

It will soon be necessary to add more flags to CSSParserLocalContext in
order to parse custom properties via the CustomProperty class. Those flags
are not interesting to non-custom call sites, so it's more convenient if
CSSParserLocalContext is a class with reasonable defaults that can be
overridden.

Change-Id: I078d8faa4cbce5de8db24b60e0817625d7deae5f
Reviewed-on: https://chromium-review.googlesource.com/c/1341914
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609982}

BUG=898958
R=pkasting@chromium.org

Change-Id: Ib5790e607c4b0d500e39cfea7dd240596dee27ca
Reviewed-on: https://chromium-review.googlesource.com/c/1333372
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609981}

Only fill credit cards on HTTPS, and passwords on HTTPS and password
fields. Show an alert to the user otherwise.

Bug: 905652, 878388, 845472
Change-Id: I51e0f07757dc4f7f1e002b88b83a2d2eeea071b5
Reviewed-on: https://chromium-review.googlesource.com/c/1340259
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609980}

Autofill's ParsePhoneNumber parses strings to extract valid phone
numbers. This is a considerable effort (including regex matching) and
a potential attack surface for malicious inputs.

Phone numbers are not arbitrarily long, so exceedingly large inputs
for ParsePhoneNumber signal an error or an attack. They are also
expensive to parse.

Thus, this CL introduces an upper bound on the input length, and the
parser will refuse inputs exceeding this bound.

As a side effect, the autofill_phone_number_i18n_fuzzer will stop
timing out on large inputs.

The CL also wraps the phone number unittest in the anonymous
namespace: This is to prevent potential name clashes for the newly
introduced GenerateTooLongString helper method, but is in general
a good thing to do in unittests, which are never meant to be
exported beyond their own file.

Bug: 901675
Change-Id: Ie3b069f846288ccd7f11fbce98c54669a55f980f
Reviewed-on: https://chromium-review.googlesource.com/c/1343007
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609979}

Rapidly clicking on the new folder button in the files app acting as a
save-as dialog can cause multiple flows through that process (from
pressing the button through to completing the rename) to run
concurrently. This can cause some strange effects:
- reporting that the directory already exists, despite the name
  intending to be unique;
- getting stuck a state renaming a newly-created directory that hasn't
  been rendered into the file list, causing the app to be effectively
  unresponsive.

Avoid these problems by disallowing execution of the new-folder command
while another is in progress.

Bug: 632270
Change-Id: I48eb43197403bf85ac78e42a6361c972499b008c
Reviewed-on: https://chromium-review.googlesource.com/c/1345687Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609978}

The TimeDomain introduced by http://crrev.com/c/1324391 needs to
know if the current RunLoop should quit when idle because if so
it needs to stop advancing mock time.  We do this by plumbing a flag
through to MaybeFastForwardToNextTask.

Bug: 863341, 891670
Change-Id: I71d8240fa5c6e7088cafacba57a31ec15abfe695
Reviewed-on: https://chromium-review.googlesource.com/c/1337336
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609977}

This CL has 2 changes as below
- Change DOMWindowEventHandlers to WindowEventHandlers.
- Makes WindowEventHandlers a static-only class by [1]

[1] https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/blink/renderer/bindings/IDLExtendedAttributes.md#ImplementedAs_i_m_s_a

Bug: none
Change-Id: Iac78712e3567ffb4f43d1f1c493719f7d1613f65
Reviewed-on: https://chromium-review.googlesource.com/c/1343595
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609976}

ChromeOS was creating multiple BackgroundFetchDelegate clients, and
overwriting the client initiating the fetches.

The fix was to check that we are not overwriting the client. This fixes
our problems in the short term, and a longer term fix is planned in
crbug.com/907075.

The fix works on ChromeOS head, as well as 71 (tested via manually
merging the change).

Bug: 907038
Change-Id: Ic1d5bc9f55b22359aa592c71f49d8ab5ed90de5e
Reviewed-on: https://chromium-review.googlesource.com/c/1344030
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609975}

This is a reland of c5612605

Original change's description:
> Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234
>
> Bug: 875037
> Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3
> Reviewed-on: https://chromium-review.googlesource.com/c/1339339
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608783}

TBR=hans

Bug: 875037
Change-Id: Iac24d9ec462cd4d5720d78a52b7f867be3ab2ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1344198
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609974}

Also refactors GetSessionKeyFromRequestHeaders to be static and return a
bool to indicate success, setting a passed pointer to the parsed session
key.

This is needed to support Lite Page Redirect pingbacks, in order to
get the DRP session id and page id that were used on a navigation.

Bug: 864665
Change-Id: Iefa1d6e39b58a0b71dbc1976ef1a0a2ba4712e73
Reviewed-on: https://chromium-review.googlesource.com/c/1345424
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609973}

As a follow up to r609674 this change adds NavigateToManagePasswordsPage
to PasswordManagerClient in order to remove the dependency on
ChromeAutofillClient. In addition, this change inlines
password_manager_util::UserTriggeredShowAllSavedPasswordsFromContextMenu

Bug: 904821
Change-Id: Ib66e5c20e8babcf84de3e07a0c031cf9e700e43d
Reviewed-on: https://chromium-review.googlesource.com/c/1344031
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609972}

TBR=lukasza@chromium.org

Bug: 907402
Change-Id: I939381e79f68c912b70207c9412b42d65e74f3a3
Reviewed-on: https://chromium-review.googlesource.com/c/1345077Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609971}

MockEntry.deleteRecursively added to help debugging in browser.

Bug: 571355
Change-Id: I74422501b0e69380d8d5ff05c796ef1d42c68992
Reviewed-on: https://chromium-review.googlesource.com/c/1345951
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609970}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e47ac15d93b8..a85a4b01ee72


git log e47ac15d93b8..a85a4b01ee72 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 jbudorick@chromium.org Don't fetch flash when fetching android_internal. (reland)
2018-11-21 tandrii@chromium.org git cl: remove Rietveld implementation entirely.
2018-11-21 tandrii@chromium.org git cl: remove Rietveld import and things it depends on.
2018-11-21 tandrii@chromium.org git cl: get rid of Rietveld's upload.py import.
2018-11-20 vadimsh@chromium.org Revert "[vpython] Roll to pick up user differentiation of cached envs."
2018-11-20 iannucci@chromium.org [vpython] Roll to pick up user differentiation of cached envs.
2018-11-20 jbudorick@chromium.org Revert "Don't fetch flash when fetching android_internal."
2018-11-20 abenner@google.com Enable python formatting by default if yapf file provided
2018-11-20 jbudorick@chromium.org Don't fetch flash when fetching android_internal.


Created with:
  gclient setdep -r src/third_party/depot_tools@a85a4b01ee72

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:856278,chromium:869227,chromium:869227,chromium:856278,chromium:846432,chromium:856278
TBR=agable@chromium.org

Change-Id: Ifc45e8c4dda5ca7c283310fc840910250a778ffd
Reviewed-on: https://chromium-review.googlesource.com/c/1345394Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609969}

Debug builds of Android were crashing because of misaligned read/writes
of float variables in PaintOpWriter::WriteSimple and the accompanying
reader.

Fix this by rounding up all WriteSimples to align the size they write
to 4 bytes.  This is just a spot fix, but fixes most of the alignment
issues on a few checked pages.  If we wanted to move to DCHECKing
the alignment, this would probably need more work.

This continues to avoid calling AlignMemory in Write/ReadSimple, as that
appears to cause about 30% slowdown in serializing/deserializing speed
in the cc_perftests --gtest_filter=PaintOp* tests.

Bug: 905665
Change-Id: Ib6db27d7cafe22b40b96f841dc2df54c1b6a4f1c
Reviewed-on: https://chromium-review.googlesource.com/c/1343565
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609968}