- 22 Jun, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f01c24ff435e..5741a5ba7f36 git log f01c24ff435e..5741a5ba7f36 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 050ef946947a..bf8fd5b5fb68 (1 commits) 2018-06-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3237f75953c1..5bdf8bd1cf56 (6 commits) 2018-06-22 fmalita@chromium.org [skottie] Ensure static split-position properties are committed Created with: gclient setdep -r src/third_party/skia@5741a5ba7f36 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Icc1d9b3426fbe2f3940e4a339118d118873a7783 Reviewed-on: https://chromium-review.googlesource.com/1111564Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569534}
-
Devlin Cronin authored
Bug: 521905 Change-Id: I7a2435279975c2f76961afe8176d4e4c0118f501 Reviewed-on: https://chromium-review.googlesource.com/1110659Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569533}
-
Aleks Totic authored
Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5a0dd12b81fd300b42bfae0c7a5432ffadd6fb39 Reviewed-on: https://chromium-review.googlesource.com/1110488Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569532}
-
spqchan authored
Move browser_window_touch_bar.h/mm to chrome/browser/ui so it can also be used by MacViews. Introduced browser_window_touch_bar_delegate.h so that it can serve as a bridge between BrowserWindowTouchBar and NativeWidgetMacNSWindow. BrowserFrameMac will create BrowserWindowTouchBar and pass the NSTouchBar to NativeWidgetMacNSWindow. Bug: 841714 Change-Id: I059e8cb2f91bc6fad73393cfb1a59802398bccc9 Reviewed-on: https://chromium-review.googlesource.com/1106599 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#569531}
-
Giovanni Ortuño Urquidi authored
Changes strings to use R"(...)" to avoid escaping quotes in schemas. Bug: 850009 Change-Id: Icbb0b8640fa9b9abb5373a834b5b3051ce3f5e4e Reviewed-on: https://chromium-review.googlesource.com/1109313Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#569530}
-
Xiaohan Wang authored
The new name is much shorter without losing any critical info. TBR=jrummell@chromium.org Bug: 854943 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie0804fbc57233f42667be2b9f87a1adcf98ed865 Reviewed-on: https://chromium-review.googlesource.com/1108886Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569529}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bf4e675. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19950 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I20c9da8adc9c730fc27d397d506db40bd62a3733 Reviewed-on: https://chromium-review.googlesource.com/1111465 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569528}
-
Jialiu Lin authored
Since this feature requires configuring enterprise policy settings to function, Finch roll out is not necessary. We'll roll it out in M69. This CL enables this feature by default. The feature const and feature control code will be removed shortly after we get launch approval. Bug: 853286 Change-Id: I15d15cf03a4010b67009bcf951119fb1f7f30f86 Reviewed-on: https://chromium-review.googlesource.com/1110340 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569527}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3237f75953c1..3cacf69b56aa git log 3237f75953c1..3cacf69b56aa --date=short --no-merges --format='%ad %ae %s' 2018-06-21 geofflang@chromium.org Pass all context creation parameters to DisplayImpl::createContext. 2018-06-21 geofflang@chromium.org WGL: Support unvirtualized contexts and unsafe multithreading. 2018-06-21 lucferron@chromium.org Vulkan: enable the rest of dEQP tests in fbo.render.* 2018-06-21 rafael.cintron@microsoft.com Replace reinterpret_cast with safer or no cast 2018-06-21 lucferron@chromium.org Vulkan: Mask the alpha channel for draw when needed 2018-06-21 oetuaho@nvidia.com Use ImmutableString instead of TString in QualifierTypes 2018-06-21 jmadill@chromium.org Vulkan: Add struct sampler parsing. 2018-06-21 jmadill@chromium.org Vulkan: Handle embedded struct uniforms. Created with: gclient setdep -r src/third_party/angle@3cacf69b56aa The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib4b71baddbc660df9608d870ea06cb8687608b25 Reviewed-on: https://chromium-review.googlesource.com/1111497Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569526}
-
Darren Shen authored
TBR=dtrainor@chromium.org Bug: 855219, 855168, 855167, 854241 Change-Id: I555f125d6d581e4f7d0361e61bc6a3d2963d37a1 Reviewed-on: https://chromium-review.googlesource.com/1111483Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569525}
-
Katie D authored
Flake reported at https://chromium-review.googlesource.com/c/chromium/src/+/1108379 TBR=dtseng@chromium.org,hcarmona@chromium.org Bug:855283 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I16ae126ab06a8f1fdfc4c9683adc62d64e08ca72 Reviewed-on: https://chromium-review.googlesource.com/1111322Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569524}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/09098853e107..120b2e4f2660 git log 09098853e107..120b2e4f2660 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 mmoss@google.com Add gerrit retries for HTTP 409 Conflict responses. Created with: gclient setdep -r src/third_party/depot_tools@120b2e4f2660 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:crbug.com/854886,chromium:b/110032771 TBR=agable@chromium.org Change-Id: Ibe261470e3d865973c8cd914c99734d68fda50b3 Reviewed-on: https://chromium-review.googlesource.com/1111537Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569523}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6cdcc08b72f65655b13625b8b9f8924014d533a4 Reviewed-on: https://chromium-review.googlesource.com/1111602Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569522}
-
Noel Gordon authored
- order MapStringToTargetVolume if tests in the same order as the enum TargetVolume defines the related volume. - commentry: clarify some comments, correct spelling errors. Bug: 836254 Change-Id: I01bc9df93631c9f7cfa9ae9e72ef117067a6f76c Reviewed-on: https://chromium-review.googlesource.com/1109802Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569521}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a75f465f541..dccc282b3734 git log 7a75f465f541..dccc282b3734 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 nednguyen@google.com Fix --exact-test-filter commandline flag 2018-06-21 bpastene@chromium.org Add google_compute_engine and boto wheels to catapult's vpython spec. 2018-06-21 benjhayden@chromium.org Dashboard wall and cpu timing context managers and decorators 2018-06-21 benjhayden@chromium.org Fix warning message in api AlertsHandler. 2018-06-21 dproy@chromium.org Do not compute TTI without ResourceLoad 2018-06-21 benjhayden@chromium.org Simplify test suites in Descriptor. 2018-06-21 benjhayden@chromium.org Add default bin boundaries for timeInMsAutoFormat. Created with: gclient setdep -r src/third_party/catapult@dccc282b3734 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:533481,chromium:854747 TBR=sullivan@chromium.org Change-Id: Ib873439eb396ed90b253f1e4a922a4df26ff76ba Reviewed-on: https://chromium-review.googlesource.com/1111498Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569520}
-
Kyle Milka authored
Add error strings for various errors that can occur while using NTP custom backgrounds and custom links. Bug: 851217 Change-Id: I4cd68efedfb12fbf89150c8ee72aeaa859f7ec15 Reviewed-on: https://chromium-review.googlesource.com/1102001 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569519}
-
Mounir Lamouri authored
Bug: 846490 Change-Id: Ibbae79a3658c26f0d3260d4b9e480c456c4716e6 Reviewed-on: https://chromium-review.googlesource.com/1101650Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569518}
-
Helen Li authored
Add test coverage for whitelist matching code. Change-Id: I74cb692518ca1e14d5d534ac4c49f6a07734d716 Reviewed-on: https://chromium-review.googlesource.com/1110558Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#569517}
-
David Bokan authored
To see logs start chrome/content_shell with: --vmodule=layer_tree_host=3 Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1b03c2f11e0a05fa7588c8e31837e12488fc7b15 Reviewed-on: https://chromium-review.googlesource.com/1107263Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569516}
-
Donna Wu authored
This CL changes MtpDeviceManager from forwarding to MediaTransferProtocolManagerImpl to directly having the implementations of the latter in the methods that previously forwarded. As MediaTransferProtocolManagerImpl was previously an implementation detail hidden in media_transfer_protocol_manager.cc, the relevant parts of the MediaTransferProtocolManagerImpl declaration are moved from that cc file to mtp_device_manager.h, while the relevant parts of the impl are inlined into the corresponding MtpDeviceManager method implementations in mtp_device_manager.cc. BUG=769630 Change-Id: Ia3ce06a69b8b4574b666711c2d8811d71101f579 Reviewed-on: https://chromium-review.googlesource.com/1096656 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569515}
-
Kunihiko Sakamoto authored
This will be used by SignedExchangeHandler to verify that certificates for signed exchanges have the testCanSignHttpExchanges extension. Bug: 851778 Change-Id: Ib32a00246da5176b3077e7fcf70ad283a8511b98 Reviewed-on: https://chromium-review.googlesource.com/1103430 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569514}
-
Christopher Cameron authored
This is a race between navigation and surfaces on their way to the browser. Here is the way that things work when the test passes: 1. Renderer process navigates a. Renderer calls RenderFrameImpl::DidCommitNavigationInternal - This will go more-or-less directly to the browser process b. Renderer calls SubmitCompositorFrame with the current surface id - This goes off to the viz process, and eventually will land back in the browser 2. The browser process gets the message from [1.a.] a. Comes in as RWHI::DidNavigate b. Calls RWHV::DidNavigate - This will skip allocating a new surface id, because this is the first navigation c. STARTS the NewContentRenderTimeout (at the end of RHWI::DidNavigate) 3. The browser process gets notified of the frame sent in [1.b.] a. Comes in as DelegatedFrameHost::OnFirstSurfaceActivation b. STOPS the NewContentRenderTimeout (in RHWI::DidReceiveFirstFrameAfterNavigation). So we stop the timer, and so we don't evict our frame. But notice how we're relying on [1.a.] arriving at the browser before [1.b.], even though they take completely independent routes? What ends up happening to us when we get a flake is: 1. Renderer process navigates a. Renderer calls RenderFrameImpl::DidCommitNavigationInternal b. Renderer calls SubmitCompositorFrame with the current surface id 2. The browser process gets notified of the frame sent in [1.b.] a. Comes in as DelegatedFrameHost::OnFirstSurfaceActivation b. In RHWI::DidReceiveFirstFrameAfterNavigation, we don't stop the NewContentRenderTimeout, because we never started it. 3. The browser process gets the message from [1.a.] a. Comes in as RWHI::DidNavigate b. Calls RWHV::DidNavigate - This will skip allocating a new surface id, because this is the first navigation c. STARTS the new NewContentRenderTimeout (at the end of RHWI::DidNavigate) We'll never hit OnFirstSurfaceActivation for this surface id again (because we already hit it), and so the timeout will always fire. The fix is to change RHWI::DidNavigate to only start the timer when RWHV::DidNavigate changes the surface id. Two reasons: - If we didn't change the surface id, it was because this was the first navigation, and so we don't need to clear the frame. - If we allocate a new surface id, then that will kick the renderer to trigger OnFirstSurfaceActivation that will tell us to stop the timer (and if we don't allocate a new id, we won't necessarily hit OnFirstSurfaceActivation, and we won't stop the timer). R=samans, kbr TBR=piman (for content/ OWNERship) Bug: 853651 Change-Id: I25a8fbf5f6b618b64d764546056fd342e8fc50f9 Reviewed-on: https://chromium-review.googlesource.com/1109448Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569513}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9457546761a4..f01c24ff435e git log 9457546761a4..f01c24ff435e --date=short --no-merges --format='%ad %ae %s' 2018-06-22 rmistry@google.com Whitespace change to trigger flutter roller Created with: gclient setdep -r src/third_party/skia@f01c24ff435e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I6509ba4d27c5015dca156dc42614d61f32a088d2 Reviewed-on: https://chromium-review.googlesource.com/1111437Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569512}
-
Nikunj Bhagat authored
Bug: 842370 Change-Id: I5ecc2536c6f205c2d6974c555a46e227488d26e3 Reviewed-on: https://chromium-review.googlesource.com/1108551Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569511}
-
Stephen Martinis authored
This argument is passed when the test is being retried. Parse and ignore it so the retry without patch logic works correctly. Also fixes the json test result output for the test, so that if the test fails, it's marked as unexpected. Also moves the wrapper script into //testing/scripts, which is where wrapper scripts are supposed to live. Bug: 533481 Change-Id: I4409be32a84c885d677ae90791a51c847d0c7e1f Reviewed-on: https://chromium-review.googlesource.com/1107054 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569510}
-
Tetsui Ohkubo authored
Do not distrub button and notifier settings should be hidden when a user is not logged in / locked. TEST=QuietModeFeaturePodControllerTest BUG=853622 Change-Id: If9f9bf923814c8b45c6ddf9dd4109f44ca1ff617 Reviewed-on: https://chromium-review.googlesource.com/1107530 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#569509}
-
Moe Ahmadi authored
- Replaces the credit card save infobar icon with a new one with smaller intrinsic padding so it can be better aligned with the title text. - Also adjusts the line height of the labels in the infobar. - New PNGs are pngcrushed. TBR=mathp Bug: 854246 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0425e43e3d44b058df3badd7dd1fa8d16d5787e6 Reviewed-on: https://chromium-review.googlesource.com/1111013 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569508}
-
Patti authored
This is a reland of e2cac39f Original change's description: > Settings: Content settings can now be reset for a group of origins in All Sites. > > Add a three-dot / overflow menu to groups of origins in All Sites. This overflow > menu allows the entire list of origins to have all their content settings reset > in one go. This will be preceded with a confirmation dialog. > > Manual test - With #enable-site-settings turned on, change a content setting via > Page Info > Site settings on both https://permission.site and > http://permission.site. Navigate to chrome://settings/content/all and see that > both sites are listed under 'permission.site'. Verify there is an overflow menu > on this entry and that inside the overflow menu, there is a 'Reset permissions' > option. Clicking this should bring up a reset permission dialog and confirming > the dialog should remove this entry from All Sites. > > Bug: 835712, 717468 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 > Reviewed-on: https://chromium-review.googlesource.com/1098577 > Commit-Queue: Patti <patricialor@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568742} Bug: 835712, 717468 Change-Id: I6560d10b31602038daa03f57fc67b6a878794d5a Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1109537 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#569507}
-
Ned Nguyen authored
This is to debug why the actual shard runtime is so different from predicted shard's runtime Change-Id: I025de62a10729d17790bb22650dfa61423daf7ce TBR=eyaich@chromium.org Change-Id: I025de62a10729d17790bb22650dfa61423daf7ce Reviewed-on: https://chromium-review.googlesource.com/1110554Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569506}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4099daa97b38..09098853e107 git log 4099daa97b38..09098853e107 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 vadimsh@chromium.org Demote linux-386 to "best effort support", just like e.g. linux-ppc64. 2018-06-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-21 ehmaldonado@chromium.org gclient: Make gclient respect unmanaged dependencies when syncing. 2018-06-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-21 vadimsh@chromium.org Stop checking CIPD packages exist on linux-386. 2018-06-21 ahassani@google.com cpplint: Pull in upstream changes 2018-06-21 tandrii@chromium.org bot_update: default to non-shallow checkouts. 2018-06-21 iannucci@chromium.org Fix minor regression in git_upstream_diff. Created with: gclient setdep -r src/third_party/depot_tools@09098853e107 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854300,chromium:853032,chromium:854300,chromium:852898,chromium:855137 TBR=agable@chromium.org Change-Id: Id8a265a396d0d7fdbdad58688673e2acb30a3446 Reviewed-on: https://chromium-review.googlesource.com/1111137Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569505}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/c3b8d611c12f..de23348fef6f $ git log c3b8d611c..de23348fe --date=short --no-merges --format='%ad %ae %s' 2018-06-21 dalecurtis Update patches file for cherry-pick from upstream. 2018-06-12 modmaker-at-google.com avformat/mov: Add check for per-sample IV size. Created with: roll-dep src/third_party/ffmpeg BUG=853416 TBR=liberato Change-Id: I8794e0e7151258f0ad7d599803a0aeb90efa2917 Reviewed-on: https://chromium-review.googlesource.com/1111267Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569504}
-
Chong Zhang authored
This CL: 1. Allows chrome to add policy headers for navigations and redirects via content API. 2. Removes the old |PolicyHeaderIOHelper| codepath and moves policy header tests to a new location. 3. Adds a move constructor/assignment for |net::HttpRequestHeaders|. Bug: 832749,845683 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I713ed30da33ba5feb5f437f8927b173c2f84d91a Reviewed-on: https://chromium-review.googlesource.com/1100393 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569503}
-
David Tseng authored
Change-Id: If274eda790046a53dffb0f4d3724aaaa1904699f Reviewed-on: https://chromium-review.googlesource.com/1096422 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569502}
-
Jeremy Roman authored
Change-Id: Ic5dde187984e827fde4dba21b1df3ef399c6a56f Reviewed-on: https://chromium-review.googlesource.com/1110941Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569501}
-
Matt Falkenhagen authored
These are only flaky on OOPIF (site-per-process), and there are existing flaky expectations for the non-OOR-CORS tests. I'm not sure why the OOR-CORS tests regressed recently, but since it's an experimental feature and the non-OOR-CORS tests are also flaky I'll leave it for OOR-CORS or OOPIF team to look. Bug: 854630, 834185 Change-Id: I93db44e01e96adb0d0f715061b66f0f7ec3f2862 TBR: dgrogan NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1111479Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#569500}
-
Tetsui Ohkubo authored
Changing focus of a view may cause UnifiedSystemTrayBubble to destruct. (See stack trace of https://crbug.com/853434#c6) At the point UnifiedSystemTrayBubble is deleted, the widget is still not deleted, so we should explicitly check if the widget is closing. TEST=manual BUG=853434 Change-Id: I2d4a146393ad6d0a39d5c8b78ea3c3623d04b91e Reviewed-on: https://chromium-review.googlesource.com/1107036Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569499}
-
Ned Nguyen authored
Add --exact-test-filter flag to telemetry unittest script when --isolated-script-test-filter is passed to trampoline script Bug: chromium:533481 Change-Id: Ib2716c4f7fa62df15b4b53b29bb11dc4d55e984b Reviewed-on: https://chromium-review.googlesource.com/1110598Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#569498}
-
Sunny authored
According to HTML document parsing spec[1], there is no special procedure for <template> tag when in "in frameset" insertion mode. Besides, in "in template" insertion mode, the parser should not process <frameset> tag by changing insertion mode to "in frameset" mode. Around 18 failed tests should be passed after this change. For standalone html5lib tests in LayoutTests/html5lib, template.dat is updated to match the correct behavior. [1] https://html.spec.whatwg.org/multipage/parsing.html BUG=829668 Change-Id: Id25e6ab9ce47042a8e86a30aa2827f529f24f463 Reviewed-on: https://chromium-review.googlesource.com/1108191Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#569497}
-
Aidan Wolter authored
In order to bind to interfaces, the MultizoneAudioDecoder needs the service_manager::connector from the parent service. Bug: 110480251 Test: Build, run multizone Change-Id: Ibd11f2ef05f6712d10a13748349e24fa13e8a63e Reviewed-on: https://chromium-review.googlesource.com/1110657Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569496}
-
Tetsui Ohkubo authored
The tooltip text for UserAvatarButon was set but not visible, because can_process_event_within_subtree for its child view was true. TEST=manual BUG=853710 Change-Id: I081a96628b1ab77e4ca57ef7d5900777a864b297 Reviewed-on: https://chromium-review.googlesource.com/1107432Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569495}
-