- 28 May, 2020 40 commits
-
-
Sreeja Kamishetty authored
!RenderFrameHostImpl::is_active() is used to check if the RenderFrameHost is either in the BackForwardCache or in pending deletion state. For cases when RenderFrameHost IPC handler or navigation related events starts with: if (!is_active()) return; This is problematic because ignoring the IPCs when the page is in the BackForwardCache might break the page. To avoid this, we evict the document from cache along with ignoring such calls to prevent discrepancies between the renderer and browser process once the page is restored from cache. This CL adds IsInactiveAndDisallowReactivation() method which returns true when RFH is either in pending deletion or in BackForwardCache and evicts the document from cache if it is called from BackForwardCache. This is part of effort to remove all |is_active()| occurrences and replace with the most appropriate method so that we don’t break pages and avoid unexpected behavior when a page is in BackForwardCache. For more information on inactive frame and back-forward cache please refer to: https://docs.google.com/document/d/1Q8vbcj0kQRukab_seqTJXVYDgpqLzWMOW_XnM6XitGk/edit?usp=sharing Detailed list of investigations for each is_active usage is presented in this spreadsheet: https://docs.google.com/spreadsheets/d/1TTzZ5r0m7nHBS_TkrEAdcFGs0M2iXO_tS0-lJmbQ3EY/edit?usp=sharing BUG=1073449 Change-Id: I82be7e38b3162e9bcd216c4376cf69b92101826e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183194Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#772514}
-
Ben Pastene authored
This reverts commit 3a8d37c3. Reason for revert: blocking uprevs; crbug.com/1087179 Original change's description: > chromeos: Add only the current SDK version's items to a test's data. > > Instead of adding every version of a given item, this will add only the > current version's. This is a bit tricky since individual versions of an > item are keyed by symlink. And since isolate doesn't follow symlinks, > we have to follow them ourselves. > > Bug: 1027382 > Change-Id: I6b3ea4ec15de3804e99fd6af768daac64f490d5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931155 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771959} TBR=thakis@chromium.org,dpranke@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027382, 1087179 Change-Id: Ie097ba50d36d7eba3865d5cee1775afd5d605354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219315Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#772513}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/64cadfcf..47bf5f46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iba86646d79f94ac9acf8a388c379ca3b10d8a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217874Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772512}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590609462-0a980a885be44e446b55c280ee660f43e0ab11a0.profdata to chrome-mac-master-1590623692-0f578bc687b2561083fd54c973f9fd861443060a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3872e1740efd3b54198c5730aadb065d95c7b5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218657Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772511}
-
Kai Ninomiya authored
Bug: 1084377 Bug: 1087130, 1087131 Change-Id: Iebd8bc4b8eaecbb379ae32bba374199662b6f274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218486 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772510}
-
Moe Ahmadi authored
Previously every <ntp-realbox-match> element listened for the entity images and favicons becoming available from the browser and picked up the entity image or the favicon that applied to them. This CL moves the listener for entity images and favicons up in the hierarchy to <ntp-realbox-dropdown>. This eliminates the race condition between <ntp-realbox-match> elements being up-to-date in the DOM and the entity images and favicons becoming available from the browser. This CL also adds tracking for BitmapFetcherService requests and cancels out of date requests in order to reduce chances of the service rejecting new ones. Signed-off-by:
Moe Ahmadi <mahmadi@chromium.org> Bug: 1086755 Change-Id: I1c9c07265f20abe93b40fedf1f49139eccc4492c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216883Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772509}
-
Jian Li authored
Bug: 1044139 Change-Id: I1952a1ab6f09dfe4c946dc3d81a5223262cc872f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219029Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772508}
-
Christopher Lam authored
Bug: 1018654 Change-Id: Idec68bbbcf642f7048d06490de765d423218a61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217511Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#772507}
-
charleszhao authored
Bug: 1012936 Change-Id: Ib5e6e015f19472573038da0b08d3488abb349c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210073Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772506}
-
Etienne Bergeron authored
This CL is fixing two issues related to text direction in RenderText. 1) There was no invalidation after appending text. Initially setting a direction neutral codepoint and calling GetTextDirection force the caching the neutral direction. After appending a strong codepoint, the direction may change. Thus, cached direction must be cleared. 2) GetTextDirection(...) was applied on layout text, and on display text. After eliding, they may not have the same direction. Also, if an external API call GetTextDirection(text) with the original text, the incorrect value was cached. This CL proposed to cache text_direction_ and display_text_direction_ separately. Bug: 1025561 Change-Id: I612c8d57ff14c11d1e0dcbf046fc6ab095cfb995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218566 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772505}
-
Kenichi Ishibashi authored
To figure out what an appropriate way to reduce OOM crashes. Bug: 848194 Change-Id: Ic74d6a496b5a8a38c2211f21622e527a3871acd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215800 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772504}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9129f940933f..f58d7039ba44 2020-05-27 chrche@microsoft.com Add customization to collect scripts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id08aff0c0b4c36ec6fbf4ab696f7fe303bc92873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218655Reviewed-by:
-
Alexey Baskakov authored
We should always return kBrowser to run not locally installed app as a tab. Bug: 1086369 Change-Id: I041190811ebd17aaca67790f50af9223cc45c991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217677Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#772502}
-
Joey Scarr authored
This is to enable the bot to be sheriffed. Bug: 1086320 Change-Id: I0e379f7b168ce3d13874a399d953c251bede8a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215763Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#772501}
-
Becca Hughes authored
This is a reland of b7d9656d TBR=dalecurtis@chromium.org Original change's description: > [Media History] Do not record background or muted watchtime > > Adds a fix so that Media History does not record > background or muted watchtime since they are not > useful to us (we only want foreground unmuted). > > BUG=1086511 > > Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771995} Bug: 1086511 Change-Id: I8bc4c8a4d73df513e8a1c48f772c7af9de256faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219109 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772500}
-
Mustafa Emre Acer authored
SafeBrowsing Delayed Warnings experiment can block a download if the current page has a delayed warning. In that case, this CL prints a message to the console. Bug: 1081317 Change-Id: Ib11dd687ef66eba1dc42e02f1929067f714bb4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215450Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772499}
-
Ken Rockot authored
Implements a test for backward-compatibility between any two versions of a mojom interface definition. Bug: 1070663 Change-Id: I832d7ecaf6d8b2c778eb9f1378f183c027585d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216910Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772498}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cdaf0be1f4ce..6e7ddb698ba0 2020-05-27 agable@chromium.org Remove agable from depot_tools OWNERS and TODOs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3e2023130e6d295798d20e14df6a4e153e569b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218650Reviewed-by:
-
Moe Ahmadi authored
The crash in crbug/1086848 is likely due to the page method calls being handled before |autocomplete_controller_| is initialized. The page calls StopAutocomplete when the realbox loses focus. |autocomplete_controller_| *should* have been created when the realbox got focus in the first place. However, there may be edge cases around autofocus that could cause the realbox to get focus without QueryAutocomplete being called. Bug: 1086848 Change-Id: I4cc2f429a7420c6ba7f8dc66062e17fba8d40664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219105Reviewed-by:
-
Brian Sheedy authored
Adds "os", "os_version", and "os_version_detail_string" to the the JSON data that is uploaded to Gold when an image is compared. This will make it easier to tell what bot produced an image. Also adds "driver_version". Example output is "win", "win10", "10.0.18362", and "26.21.14.3102" respectively. Bug: 1086751 Change-Id: I8a722db102808502a8100d700942a8348d2b5c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218479 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772495}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. This CL is thus a no-op. These changes are required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This CL was uploaded by git cl split. R=djacobo@chromium.org Bug: 1026641, 968047 Change-Id: I0009714cea5659d154e7f278b18499e41ff745fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219169 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772494}
-
Vasiliy Telezhnikov authored
This CL handles adds handling of few more cases: * Small videos have bad matrix. We get small sizes likely because decoding errors * Shrink amount other than 1.0. This is best guess approach as there is no way knowing what shrink amount was used. * Empty matrix case (when either of scales is zero). Shouldn't happen outside of small size case. This CL also add fallback to visible_size if coded_size/visible_rect seem wrong or matrix was broken and adds DumpWithoutCrashing for that case. Bug: 1081695, 1086624, 1076564 Change-Id: Ife0b70bc85b9249fa2805df1db59733ac8cdbd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216731 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772493}
-
Trent Begin authored
Bug: chromium:1084295 Change-Id: Ia6f53b3f49a2472180e20f80fc189187fdda2c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218575Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772492}
-
Yuichiro Hanada authored
This CL will prevent normal apps and web pages from intercepting the key. Bug: b:156526777 Change-Id: Id51309805f6478f9e8e3647241c2b4649bd0011c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212102Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#772491}
-
Giovanni Ortuño Urquidi authored
Adds some simple tests to ensure imported constants and constants specified in terms of other constants have the correct values. The CL used to do more, but https://crrev.com/c/2204846 made it all redundant. Bug: 1002798,1008761 Change-Id: I2de4b945848c8b4ad358fbcd296189c8d989cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839752Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#772490}
-
My Nguyen authored
Add the function based on design doc at http://go/e14s-autocorrect-window. Bug: 1068807 Test: Will add later in browsertest for the api Change-Id: I7e9c65af3598cbb6e0e3077d193f5a1f6555816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166228 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#772489}
-
Filip Gorski authored
Bug: 1075602 Change-Id: I37e8037ab6c362bd388c595fe278bdee34ebdf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198546 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#772488}
-
Yury Semikhatsky authored
Bug: 1085150 Change-Id: I4c69b33a89708ac2c7e3d9edf5d1ad3066facc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218485 Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772487}
-
Nazih Almalki authored
Ack a pending surface early the client's scheduler to schedule frames for future surface changes This case happens when screen rotation takes place while there is an active frame when this takes place it has a unique signature of 2 consecutive submit frame requests with clients_needs_begin_frame_ is set (high) and 1st frame is not a new surface and 2nd frame is a new surface. Bug: 1060058 Change-Id: I7020d10aade334e7fda20749217747cea2a2c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190049 Commit-Queue: Nazih Almalki <nalmalki@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#772486}
-
Rouslan Solomakhin authored
Before this patch, the C++ payment app interface omitted app identifiers, minimal UI fields, and deduplication fields that are used on Android. It also required each individual app implementation to convert from PaymentDetails to PaymentRequestDetailsUpdate mojo struct, although Android performed the conversion in a central place and passed the Update struct to the payment app. These discrepancies prevented using a C++ payment app in Java (through a JNI wrapper). This patch adds the ID, minimal UI, and deduplication fields to the C++ payment app interface, implements the minimal UI and deduplication fields in the C++ service worker payment app, as well as changes the UpdateWith() method to accept a PaymentRequestDetailsUpdate mojo struct. After this patch, using a C++ payment app in Java (through a JNI wrapper) is easier. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I39146a08fcd74fe9a883c67107c8fc8cbc17a400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217847Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772485}
-
Rahul Arakeri authored
This CL allows the root scroller to be overscrolled beyond the scroll bounds. The OverscrollBounceController drives this. The basic principle here is: the scroll deltas on GSU are fed into a hyperbolic tangent function (ranging [0, 2]). This tells how far the scroller bounds can be "stretched" when the user overscrolls. See OverscrollBounceDistance for details. Animating the bounce back is not in the scope of this CL. Bug: 1058071 Change-Id: I3023c69078ffc6dff0ecfe3554d699ea3b9d1553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198596 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772484}
-
David Black authored
Currently AssistantZeroStateView's only child is the pre-existing greeting label. Moving forward, AssistantZeroStateView will conditionally show a richer view in lieu of greeting label. The changes in this CL should not be perceivable to the end user. Bug: b:157510546 Change-Id: I9e813a3d04a9ee9c734c9f5e2ff6913fd18b0ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213925 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#772483}
-
Andrey Kosyakov authored
Upstream fix: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2216940 Bug: 1085228 Change-Id: I641542cd65f18a573a291a7e3f0feebce7b69ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216708 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772482}
-
Rachel Wong authored
Currently, privacy_info_view is a launcher notice about Assistant privacy. This CL separates privacy_info_view into two classes: 1) privacy_info_view.*, a parent class for privacy notices in the launcher; 2) assistant/assistant_privacy_info_view.*, which contains all the Assistant-specific methods and strings. This allows us to create a new privacy notice for Suggested Content, which uses the same parent view but has its own methods and strings. This CL should not make any functionality changes. Bug: 1079169 Change-Id: I28324a9196ef2643e5fdcef122c13a8113ee2603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198848Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
This change allows most tests to operate without having the QueryTile Processor initialized if these don't care about its presence. Bug: 982818 Change-Id: I6fe6c0bba9fb83d99bcad9e93c84a831df2da8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219149 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772480}
-
David Black authored
Copy and paste error caused Assistant MicView to never register to observe AssistantInteractionModel events in recent refactoring. Bug: b:157579976 Change-Id: I992387d69ccfafccd8842070563269b65f974aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218673Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If0eb3cf6c9a7c659b00269b77edf93116aa29990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219230Reviewed-by:
-
Kurt Catti-Schmidt authored
Per https://chromium-review.googlesource.com/c/chromium/src/+/2163429, this change moves GridNG files to their own directory. This will help organize subsequent changes where we will be introducing classes specific to GridNG. There should be no behavioral changes associated with this PR. Bug: 1045599 Change-Id: I50c2c98a7903904bf80663801a80ed1874bb0f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218616 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#772477}
-
Zach Trudo authored
Bug: b/157188195 Change-Id: I70b45ca1dc44f48d08638b9f23a4eaaae73052b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212796 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772476}
-
Xianzhu Wang authored
I changed the filter in crrev.com/c/2202974 to treat results like [ Failure Crash ] as unexpected flaky if the expectation is like [ Failure Timeout ], but it had a bug that containsAll couldn't deal with the differences of the failure keys in actual and expected result (e.g. actual TEXT vs expected FAILURE). Change-Id: Iacd547a242277ad8b39645a2c2130c1d8670bf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218530Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772475}
-
