- 24 Aug, 2020 40 commits
-
-
Chris Lu authored
When an animated dismissal is triggered while the user is interacting with the banner, the dismissal animation is wonky. Since a cancel indicates the removal of that Overlay request in a non-user generated manner, it should be ok to just have it removed from the hierarchy. Bug: 1120706 Change-Id: I3172724ba8121e67838a03ca1b41065b9091654a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372809 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#801145}
-
John Chen authored
Change-Id: I366350f45ee519bf1410fbe198d90b5f64814d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372919 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#801144}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e4565c2. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" e221ccf9 "Quota: Add tentative to WPT name." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I6c8b6739d98afd7469e32abb6ddb9710671c92a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373011Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801143}
-
Adam Langley authored
It's annoying that one cannot just call size() on a std::array in a compile-time context. Instead std::tuple_size and std::remove_reference is needed. While std::array is used quite a lot in Chromium, std::tuple_size is not. I assume that people are either not writing assertions, using run-time [D]CHECKs, or using static_assert with constants that are also used as std::array lengths. None the less, I cannot point at a body of std::tuple_size in the code base that would be cleaned up by this, so the case for adding a #define is not that strong. *I* would certainly use it in static_asserts though! (And would change [D]CHECKs into static asserts.) Maybe others would too. A #define isn't as nice as a constexpr function, but the latter doesn't work as nicely at the call site. Consider the obvious: template<typename T, size_t N> constexpr size_t std_array_size(const std::array<T, N>&) { return N; } That works, but not for references, where the compiler objects that the reference “is not a constant expression”, even though the value is never used. Other non-define functions can work if preferred, but are worse at the callsite. For example: template<typename T> constexpr size_t std_array_size() { return std::tuple_size<typename std::remove_reference<T>::type>::value; } But that has the callsite pattern: static_assert(base::std_array_size<decltype(array)>() == kFoo); This this change uses base::span::extent to define a macro, EXTENT, that works for any type that base::make_span recognises, including std::array. Change-Id: Id4688117b5a558e022448ad901fa3d4995182826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364136Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#801142}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /ui/gfx/canvas_skia.cc This CL was uploaded by git cl split. R=danakj@chromium.org Bug: 1110266 Change-Id: I791bd924bc12bc017b8708ecfa8b7ac33d32b005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370735 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801141}
-
Matt Wolenetz authored
BUG=1120822 TBR=wychen@chromium.org,pmonette@chromium.org Change-Id: I974e9ff6e2d6029de826c488a97d28c0f1add788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372735Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801140}
-
John Chen authored
Configure new tester android-pixel4a_power-perf on main perf waterfall to run power.mobile benchmark. Bug: 1106954 Change-Id: Iac7af6f97c108d9a148cbb038dc94b6e5a2fea85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368454Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801139}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I53068eafa480eae583c1ae880fa49a7b2f6827d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372592 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801138}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/490961030b55..149a3b758125 2020-08-24 sokcevic@google.com Warn when non-inclusive parameters are used If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098560 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Iefb2dd79c17909511e963a90d4521f1289d511ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801137}
-
David Black authored
Holding space items will be persisted to profile prefs. Note that we don't persist Downloads as those have a separate persistence storage. Also note that we don't yet persist images. Ideally, we shouldn't need to. Known deficiences: - Doesn't yet restore downloads - Doesn't yet restore images Bug: 1119496 Change-Id: I74f929c8bb802a15e6771dc58ea68ec20380fe26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367701Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#801136}
-
John Lee authored
Bug: 1098534 Change-Id: Ie3ef928071d1e5c542d9ba1e8496652c94916b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367807Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#801135}
-
Ryan Hansberry authored
Subsequent CLs will use Nearby's bluetooth::mojom::Adapter to scan for and register BLE advertisements. Note that incoming and outgoing BLE GATT connections are not supported by Nearby Chrome at the moment and the respective methods on BleMedium are left as no-ops. See go/nearby-chrome-bt for more details. Bug: b:154845685 Change-Id: I31537b957129a7cac6272b5f9eed3157a2e6dfa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364032Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#801134}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/ui/blocked_content This CL was uploaded by git cl split. R=csharrison@chromium.org Bug: 1110266 Change-Id: I3aa4df135631af02b22232f4a1c9cdbd360c67cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371259 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#801133}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/metrics/oom This CL was uploaded by git cl split. R=csharrison@chromium.org Bug: 1110266 Change-Id: I09612099e3d071042a3f2765e5976f0b3c001b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371252 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/browser/conversions This CL was uploaded by git cl split. R=csharrison@chromium.org Bug: 1110266 Change-Id: I42bb363056e26229c924208094657ac22ddc3873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371288 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
-
Jeff Yoon authored
This is a reland of 297abb5a. Added the xctest argument for iOS unit tests such that they are triggered using the correct test runner. Original change's description: > [ios] noncq to run tests on 14.0 simulators > > ios-simulator-noncq to compile with xc12b5 as well. > Running iOS 14.0 simulators for our test suites on xc12b5. > > Change-Id: I7ca5f763174c296278401ae3563894a4f5210379 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367792 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800739} Change-Id: Ieb214a3e7788a551258470c1fb076e6603343384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370165 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#801130}
-
Theresa authored
This reverts commit 3fce1e3f. Reason for revert: Bad interaction with another revert causing compilation failure. Original change's description: > Android: Re-enable 14 useful lint warnings > > Many of these lint warnings were turned off because it was difficult to > fix all of them when they were introduced (usually via a lint update) > and fix incoming new errors at the same time. > > Adding existing issues to the baseline and enabling for new code. > > Bug: 1116130,807734,671170,831774,635567 > Bug: 1069186,804427 > Fixed: 807734,635567,804427 > Change-Id: Id955384003a6928ea5ad3efe635a84515663b17b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369576 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801073} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I543e84fefdce54d2f5f189007ac82faa8d6f4976 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116130 Bug: 807734 Bug: 671170 Bug: 831774 Bug: 635567 Bug: 1069186 Bug: 804427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373282Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#801129}
-
Bettina authored
Create a Chrome flag for client side detection on Android so it's easier to manage without using a command line flag. Bug: 1108080 Change-Id: I2ffbdcb708dac89c0539039b7d06ba5e4aa4f58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363222Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#801128}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /content/shell This CL was uploaded by git cl split. R=danakj@chromium.org Bug: 1110266 Change-Id: I9e9c506a2dcafdb6d83ccc0c8d163349ef9eae46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370297 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
-
Maggie Chen authored
Set kRestartFactorFinch and kInitFactorFinch to 4 for Android. This will set the initialization and restart timeout to 60 seconds (4*15 seconds) for kGpuWatchdogV2NewTimeout finch on Android. For kGpuChannelTimeoutInSeconds in the browser process on Android, use the timeout constant from the watchdog instead of a hard-coded value. Bug: 1120145 Change-Id: I32e39c5b005a9957cf1d4fff58c4aabcb3964397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282782Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801126}
-
Jinsuk Kim authored
The crash at OverlaySceneLayer destructor comes apparently from ui::WindowAndroid being in the destroyed state while its ::RemoveObserver method is called. It makes OverlaySceneLayer destructor not the appropriate place to call it, since the destruction order of the objects are not clear. This CL changes the place where WindowAndroidObserver is added or deleted i.e. when WindowAndroid's compositor is attached or detached. WindowAndroid is guaranteed to be available when these observer event is invoked, so it's safe to do the operation. Bug: 1120832 Change-Id: Ib43c420f4d5af51fca4377e92d46a408d41e86f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371384Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#801125}
-
Nate Chapin authored
FrameLoaderStateMachine has 3 states. The first is for creating the initial empty document. However, several places that check for this state don't need to. Also, the usage in DocumentLoader can be replaced by checking equivalent internal state. This leaves just two places it is checked in FrameLoader itself. Instead of having the initial empty document be part of FrameLoaderStateMachine, create a new private FrameLoader enum for tracking its lifetime transitions (uninitialized->initialized->detached). With this state removed, FrameLoaderStateMachine is effectively a boolean for whether we're displaying the initial empty document or not. Replace this with an is_initial_empty_document_ boolean on Document. This boolean still needs a way to be forced to false in certain cases (i.e, internally during document.open(), and externally for consistency during cross process navigation). Change-Id: I7fa0a830f70fed81de13ed633d9686ee16a75161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354208 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801124}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1597658380-benchmark-86.0.4239.0-r1 to 86-4183.59-1598262024-benchmark-86.0.4240.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I74c6b6effad7860008c63eacbf4c7ed77702a89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372778Reviewed-by:
-
Chris Cunningham authored
Callers may destruct the broker in response to the callback, so its unsafe to make additional changes to broker state after the callback fires. Bug: 1120924, 1120431, 1121015 Change-Id: I72a42106b0d432ba7d3bd2170f3d31175b7955eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370713 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#801122}
-
Anders Hartvoll Ruud authored
Before StyleCascade, we used to store CSSVariableData objects in need of var()-resolution on ComputedStyle, and the resolve those CSSVariableData objects "in place". There was also a performance optimization which utilized flags which told us whether or not there was any CSSVariableData object in need of resolution somewhere in Style[Non]InheritedVariables. The flags can now be removed, since all CSSVariableData objects are now resolved in StyleCascade _before_ storage on ComputedStyle. Change-Id: Ia176691bb02f6da4e3eb322b4984acf707654e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372143Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#801121}
-
Yann Dago authored
Bug: 243833 Change-Id: Id3844f7fcd7e36176be6223b0088762b3a67290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347002Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#801120}
-
Mohsen Izadi authored
According to DisableLatencyRecoveryDesktop Finch experiment, disabling CC latency recovery, as it is implemented now, causes some large improvements in smoothness while having smaller regressions in latency metrics. Therefore, we are disabling it on desktop platforms to match Clank. Document analyzing the Finch experiment results: https://docs.google.com/document/d/1u2Lv3l698NRZjmMfj4lDe8_nHpZuaEmN_nSlPK9h1w0/edit?usp=sharing Bug: 993895 Change-Id: I06ae1060829773d4eea65c46b422cddd722597b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365392Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801119}
-
Justin Cohen authored
NOTRY=true Bug: 1121305 Change-Id: I6dc5444a949cf4d71a0d611612f9a950b580fe18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373013 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
John Williams authored
The Presentation API is invoked when the user clicks the Cast button in a web page. This change only takes effect when the GlobalMediaControlsOverlayControls and GlobalMediaControlsCastStartStop features are both enabled. Bug: 1107160, b/161612085 Change-Id: I086d8e4928a80e0a2b0f247d9a62a573e024f254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317087 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801117}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/test/nacl This CL was uploaded by git cl split. R=mseaborn@chromium.org Bug: 1110266 Change-Id: Id5873d48ebdcbe98564b6b5c47015f4ad5f8985e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371284 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#801116}
-
Chris Cunningham authored
Bug: 1120745 Change-Id: I88e11996a22f1aef2bf53d967e9cf728b517dc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370182 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#801115}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.59-1597659923-benchmark-86.0.4239.0-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic282d2ae47c6c801cd97c0d89d48f3ffd0ab5368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372914Reviewed-by:
-
Daniel Libby authored
Changes to the window segments happens in the content layer as part of the visual properties cascade. As such the current machinery to compute and update the associated CSS environment variables is not triggered in scenarios like page reload. Instead of setting the variables on each frame, update the root environment variables instance, which is used by child DocumentStyleEnvironmentVariables instances when resolving. Bug: 1121068 Change-Id: I0a46b41957c04708f4bd255b87a00c154477d893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371684Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801113}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.59-1597657121-benchmark-86.0.4239.0-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic2b4001d08ff8e57c4c37b8e3e66e1bf88c1dc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373124Reviewed-by:
-
Aleks Totic authored
Implementation of the intrinsic logical width cache for TablesNG. When tables are collapsed, change in border/table structure can invalidate adjacent cells. Because efficiently computing adjacency in tables is an open problem, we cannot just SetIntrinsicLogicalWidthsDirty on all afffected cells. Instead, cells cache borders used for intrinsic computation, and use this value to invalidate the cache. Bug: 958381 Change-Id: I394d6160ee44eb206a7f9b16320ae7ee46d21c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368239 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#801111}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87d42e5d12b3..36b86aff6b71 2020-08-24 jvanverth@google.com Revert "Remove ARC from Metal backend" 2020-08-24 rmistry@google.com Add documentation for 'Suggested Reviewers' button. 2020-08-24 jvanverth@google.com Remove ARC from Metal backend 2020-08-24 bungeman@google.com Fix SkBitmap::allocPixels logging 2020-08-24 rmistry@google.com Rename RecreateSKPs_Canary to RecreateSKPs_DryRun 2020-08-24 ethannicholas@google.com Fixed SkSL visitor to match previous node counts 2020-08-24 bungeman@google.com Move fontmgr_bounds labels to tight bounds 2020-08-24 johnstiles@google.com Factor out `validate` into separate method. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I2ed4022cb0ca9c6af7579793855401cef1a00ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372774Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008240800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/WmaW9qZKgz71XJS-eJaYWm5I75Joraecva9PEaQvP0wC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I8ac9d7745a55ca2696cef80db978b8bfa08eb1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372862Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801109}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I317f2a753ea73e2693993e581cedfa98dab580f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372731Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#801108}
-
Ken Rockot authored
There are (effectively rare) edge cases where SequenceLocalSyncEventWatcher usage results in sequence's event staying signaled despite having no more registered clients to notify. This leaves the thread stuck in a state where any pending sync wait will effectively busy-loop until it gets a reply rather than blocking as intended. This CL fixes the edge cases to ensure that the event in question is always properly reset when appropriate. Fixed: 11202650 Change-Id: Ib8542f6945b92d0fbfcc232143aba8bcf48f23a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369676Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#801107}
-
Claude van der Merwe authored
These files have <if> statements which were included in os_settings_rollup.js because the preprocess="true" argument was omitted. Bug: 1045266 Change-Id: Ic458b7847262989f2ec8f681d8ac4110ef99259a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372587 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801106}
-
