GitLab

The Fuchsia build is initially trying to get a headless build
up and running, so ui/gfx/font is unnecessary currently, other
than to link.

Bug: 750946
Change-Id: I39607a4dd78d73049d1c33c53e907fdfb7f3cf9c
Reviewed-on: https://chromium-review.googlesource.com/596838
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491437}

Fuchsia is initially trying to get a headless build up and
running so a full Screen implementation is unnecessary, other
than to be able to link.

Bug: 750946, 743296
Change-Id: Ib6333a304deacbd22d3f1b1f3af8fc9ca063bb15
Reviewed-on: https://chromium-review.googlesource.com/596949
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491436}

Change-Id: Ibe8ccc0be09764fe4aca158dd9fec026bd7b4ce2
Reviewed-on: https://chromium-review.googlesource.com/592414Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491435}

Normalizing of password form action is done in 2 different cases with different code:
 1.On Load, in Obj-C code in password_controller.mm
 2.On fill in JS in password_controller.js

That's bad, as any duplicating code, because in some cases it generates different canonical actions (for example when the action is empty). This CL unifying canonical action calculation. As a model for canonical action calculation GetCanonicalActionForForm from Desktop/Android implementation is taken.

Bug: 710438, 708602
Change-Id: I1ea879c60d01cf02bed6ea9715089221971ff4a0
Reviewed-on: https://chromium-review.googlesource.com/596031
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491434}

By passing ScriptElementBase/ScriptLoader instead of Element.
This CL shouldn't change the behavior.

Bug: 686281
Change-Id: I903482390623d18bcff9b6358dc9ee12e1ef7495
Reviewed-on: https://chromium-review.googlesource.com/564144Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491433}

SingleThreadTaskRunner is still required, but we should not need a
specific BrowserThread.

This is part of the task scheduler migration effort.

BUG=None

Change-Id: I23dfba4f9acd51176d8df18f6269090494808a69
Reviewed-on: https://chromium-review.googlesource.com/594719Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491432}

Use 1 second reporting chunks for main thread load instead of 1 minute.
Increase metric version from 3 to 4.

R=rkaplow@chromium.org

Change-Id: I7faf6ee875a97c9c6545a23760828f4d5dcfbc4b
Reviewed-on: https://chromium-review.googlesource.com/583616
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491431}

This code was literally unusued.

Bug: 746054
Change-Id: I65b7a748818ee074b48745c0a4f9260e8fd6c852
Reviewed-on: https://chromium-review.googlesource.com/596916Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491430}

The print Earl Grey tests were disabled on iOS11 because Earl Grey is
unable to interact with the share menu. This CL fixes the test in
iOS 11 by going through the dispatcher to open the print view
controller instead of through the share menu. Also, iOS 11 changed the
print view controller's accessibility labels, so use an accessibility
id (which is unchanged) to verify that the print view
controller opened.

Bug: 747441
Change-Id: I809d089b50c294cc2ac5a9c92bcfefc1da41f8c5
Reviewed-on: https://chromium-review.googlesource.com/597429Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491429}

Previously, the NotificationPresenter was being explicitly destroyed before the NotificationRemover, causing a segfault. This CL corrects that bug.

Bug: 751192
Change-Id: I397c1a7d96ddf9a8721ae96716952055ee4e0c75
Reviewed-on: https://chromium-review.googlesource.com/596502
Commit-Queue: Leslie Watkins <lesliewatkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491428}

Currently the Pack Extensions dialog just crashes or silently fails when an error or warning is raised.
This CL implements an alert system that is in parity with the old extensions page.

Bug: 741900
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6e85b6da179495f20b0c0122a0592607f892d8f9
Reviewed-on: https://chromium-review.googlesource.com/587971
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491427}

Remove a line missed when removing enable-pointer-event
flag. Related cl:

https: //codereview.chromium.org/2921923002
Bug: 687976
Change-Id: I1d129b05fce79a565ff9a92493d2e16c2d383cf8
Reviewed-on: https://chromium-review.googlesource.com/596689Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491426}

R=brettw@chromium.org

Change-Id: I049857e9eb094d60e153074b361dab7146a13623
Reviewed-on: https://chromium-review.googlesource.com/596968
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491425}

Simple guard to prevent tasks with pid 0 from being killable.
If a user tries to kill a task with pid 0 there is a crash.
By doing a simple check to see if the pid is 0 we prevent this. A pid
should also only be 0 for a short period of time in certain race
conditions.

Bug: 749459
Change-Id: Iba63b63d6606dbf403cbae3bf2fef4c882f395c5
Reviewed-on: https://chromium-review.googlesource.com/594308Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Charles Burnell <cburn@google.com>
Cr-Commit-Position: refs/heads/master@{#491424}

Currently we have

  CastSocket::OnOpenCallBack 
    = base::OnceCallback<void(int channel_id, ChannelError error_state)>. 

We need to call 

  CastSocket* socket = cast_socket_service_->GetSocket(channel_id); 

to get socket object in callback function, which seems unnecessary.

Make CastSocket::OnOpenCallback take CastSocket* parameter instead. Callback is invoked 
by CastSocket object with 'this' pointer. Since CastSocket only runs on the IO thread, so
do callback functions, no post task is involved, raw pointer seems safe.

Resolve code review comments for: https://chromium-review.googlesource.com/c/575247

Bug: 749762
Change-Id: Iaab109774fa2c67d99a7fa5afffdf2315b32fd59
Reviewed-on: https://chromium-review.googlesource.com/590588
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491423}

PasswordStore uses SKIP_ON_SHUTDOWN for background sequence. That means that PasswordStore::DestroyOnBackgroundThread() can be skipped. In this case PasswordStore::* may be destroyed on the UI thread.
It's not a problem for PasswordSyncableService. We just need to remove the check in the destructor.
PasswordReuseDetector has this check implicitly via base::CancelableTaskTracker. Thus, we can just leak the object.

Bug: 741660
Change-Id: Ic49cb068733c159bca55e8d76eb58f70793f5fbe
Reviewed-on: https://chromium-review.googlesource.com/598008Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491422}

https://pdfium.googlesource.com/pdfium.git/+log/33dd830890d3..aea80dcc0abc

$ git log 33dd83089..aea80dcc0 --date=short --no-merges --format='%ad %ae %s'
2017-08-01 hnakashima Remove CFX_ByteTextBuf from cpdfsdk_interform.cpp and others.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iae59aa9c663dd1b04b1ccb2bdd7e3b9d23b802ae
Reviewed-on: https://chromium-review.googlesource.com/598315
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491421}

RenderProcessHosts. This is useful because it will track processes that
are otherwise not included in the current task manager. An example of
this is the NTP which has a service worker that lives beyond navigating
away from the NTP. With this you can accurately see when the
termination of the RenderProcessHost that is running this service
worker.

This version is requires the commandline flag of "--task-manager-show-extra-renderers" to be used.

BUG=716609

Review-Url: https://codereview.chromium.org/2988453002
Cr-Commit-Position: refs/heads/master@{#491420}

The current implementation of animated avatar didn't consider small
pods, resulting in the listed bug.

Also sets a timeout for switch animation.

Bug: 751343, 721647
Change-Id: I5b9cafc737c082865d33520cfafca2963554be4f
Reviewed-on: https://chromium-review.googlesource.com/597051Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491419}

- the RendererAccessibility layer already queues up events
- this interferes with scoping of user actions i.e. a posted task is no longer on the same call stack and is no longer identified as an action
- cleans up some ChromeVox assumptions
- extend ChromeVox read all to sync selection as it goes and enable it to work inside of editables

Test: navigate with ChromeVox in a text field; perform a read from here
Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2df30c907e01fba4760271ee0a3e86b031342f9b
Reviewed-on: https://chromium-review.googlesource.com/592514Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491418}

Always calls SetNew right after creating SharedQuadstate to set all the
values on SharedQuadState. This is to help catch all cases when
switching to use id in later CLs.

R=danakj@chromium.org

Bug: 739429
Change-Id: I029f73d2ff3b261ce12da65ba7eb49b6323f37c1
Reviewed-on: https://chromium-review.googlesource.com/596768
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491417}

Without being a system notifier, 
MultiUserNotificationBlockerChromeOS::ShouldShowNotification()
returns false, preventing Tether notifications from
displaying. It's appropriate to consider Tether a system 
notifier given that it is baked into the system tray and 
Settings.

Bug: 747639, 672263
Change-Id: I0f0d9a4ce3da7c62b148af979c611eaca6682053
Reviewed-on: https://chromium-review.googlesource.com/596833
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491416}

The WebTextfieldTouchBarController observes the
autofill popup window to display the autofill items.

This CL makes sure that it stops observing the old
popup before it observes a new one.

Bug: 750570
Change-Id: I8298a83f3cd1fae7363f6a3d16d9a15f24342cb7
Reviewed-on: https://chromium-review.googlesource.com/596915Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491415}

R=dmazzoni@chromium.org

Bug: 
Change-Id: I6663a127e00f45975961e5cacf48c6be32facccf
Reviewed-on: https://chromium-review.googlesource.com/596749Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491414}

It seems to have stopped working recently; this fixes it.

Also, fix a pylint presubmit failure that looks like it started
with crrev.com/465016

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I277083b181fed4f5491f11e551175f37ba9b38a3
Reviewed-on: https://chromium-review.googlesource.com/598115Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491413}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0327c967ed7f..65e2bf234545

$ git log 0327c967e..65e2bf234 --date=short --no-merges --format='%ad %ae %s'
2017-08-02 loloangela Fixed errors related to bad-builtin

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I00c7faab4ae659bf428fb3aa4936d617df072c90
Reviewed-on: https://chromium-review.googlesource.com/598311
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491412}

Bug: 730036
Change-Id: If226169d647db5adc8714f70cef3de683591e9b2
Reviewed-on: https://chromium-review.googlesource.com/597729Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491411}

This reverts commit d1bc5d0b.

Reason for revert: Introduces new C++ static initializers. See crbug.com/751735

Original change's description:
> Make downloads work when history database fails to initialize.
> 
> Previously all download calls will be stuck when history database fails
> to initialize.
> 
> This CL assigns 1 as the first id when history database failed to load,
> all downloads in this browser session will not be persisted to history
> database.
> 
> Bug: 736511
> Change-Id: If4db04ca518633a7dd999f45629e60e97fc78b1a
> Reviewed-on: https://chromium-review.googlesource.com/587327
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Xing Liu <xingliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490540}

TBR=rkaplow@chromium.org,dtrainor@chromium.org,xingliu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 736511, 751735
Change-Id: Ifa73c694e919bda82eb37ea88020cf6b0ba89751
Reviewed-on: https://chromium-review.googlesource.com/598347Reviewed-by: F . <zpeng@chromium.org>
Commit-Queue: F . <zpeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491410}

Set up the GTest and Mocha-based a11y testing framework for Chrome WebUI
by defining an accessibility_browsertest.js file for a11y test fixtures
and including this file in the BUILD.gn.

The passwords section now fires an event when the settings section has
expanded--an event that is responded to in the added a11y test.

The tests are disabled in debug mode and memory sanitizer mode due to
timeout.

Bug: 737739
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8715e83778409802849db38d90fef387db203f9b
Reviewed-on: https://chromium-review.googlesource.com/592156
Commit-Queue: Tina Quach <quacht@google.com>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491409}

This reverts commit f5345de1.

Reason for revert: Breaks bots which run layout_tests
not via swarming: https://crbug.com/751421

Original change's description:
> Bump macOS SDK to 10.12.
> 
> Bug: 669240
> Change-Id: I97cf582b97fac7aec2aa92bbdda02f5c17482c1d
> Reviewed-on: https://chromium-review.googlesource.com/570459
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491060}

TBR=thakis@chromium.org,erikchen@chromium.org

Change-Id: I3b30bd3e18fa60f736078ed889a6c574b15c6467
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 669240, 751421
Reviewed-on: https://chromium-review.googlesource.com/598449
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491408}

In order to enable clang-cl's printf format string mismatch checking we
need to fix a few dozen existing errors. These are mostly places where
DWORD (unsigned long) is printed with %X or %u - an 'l' is needed.

R=thakis@chromium.org
BUG=751171

Change-Id: Ieb1aeeedb14c5725b51d460fc34c418abcafe68f
Reviewed-on: https://chromium-review.googlesource.com/596612Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491407}

TBR=afakhry@chromium.org,creis@chromium.org

Bug: 
Change-Id: Ife874db9ed1b7fa2e6251e12ce1bf7fcb348d675
Reviewed-on: https://chromium-review.googlesource.com/595868
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491406}

Bug: 730036
Change-Id: I206502ba68ab413650d732d8e50424d60841b3b3
Reviewed-on: https://chromium-review.googlesource.com/598267Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491405}

Split off from https://chromium-review.googlesource.com/c/584857
so that the other non-mechanical cleanup work wouldn't be lost if
this gets reverted.  See that CL for signoff.

Change-Id: Ic75adc756990d3182aba8a323021f328b8419754
Reviewed-on: https://chromium-review.googlesource.com/596070Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491404}

Successful PFQ run:
https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/4672

Bug: none
Change-Id: Ib07f0953b79311882212ab873a2af524ee8d7157
Reviewed-on: https://chromium-review.googlesource.com/594207
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491403}

As part of Project Ribbon, separate the parsing logic for these CSS
properties from the parser into an API:
- block-size
- inline-size
- min-block-size
- min-inline-size
- -webkit-min-logical-width
- -webkit-min-logical-height
- -webkit-logical-width
- -webkit-logical-height

Bug: 668012
Signed-off-by: Rob Buis <rob.buis@samsung.com>
Change-Id: I1689c5df226f0dd0adf660705ba80c5ed4c7bd9e
Reviewed-on: https://chromium-review.googlesource.com/589607Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491402}

Bug: 750867
Change-Id: I5d2a8093123ba7cd60010f5597c5fbaf3a193188
Reviewed-on: https://chromium-review.googlesource.com/594937Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491401}

This flag prevents the collection of gpu info on the multi-process path,
but not on the in-process path. This change makes the in-process path
consistent with the multi-process path.

This is needed by Cast for Android Things, which doesn't always have an
implementation of EGL, so crashes when loading gpu info.

Bug: None
Test: CQ
Change-Id: Ic700fe28c4c3b5af10cf860e76f43facba25d86d
Reviewed-on: https://chromium-review.googlesource.com/596329Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Thoren Paulson <thoren@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491400}

Change-Id: I9d66473203995ff21d915b17cffa42c44f84a000
Reviewed-on: https://chromium-review.googlesource.com/598108
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491399}

Fix flacky tests in SBNavigationObserverBrowserTest is caused by the
non-deterministic iframe navigation order. This CL add checks to both
possible orders.

Bug: 739716,736354
Change-Id: I0b256d492500b8f2872485235eb0b826dae6c827
Reviewed-on: https://chromium-review.googlesource.com/594711Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491398}