GitLab

Over the last week (or so) a couple of CLs had to be reverted because developers had not tested win_aura, specifically:
 1. The default trybot rules don't include win_aura in enough cases
 2. The CQ did not build win_aura

BUG=141701
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10831242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150950 0039d316-1c4b-4281-b951-d872f2087c98

Includes a unit test to exercise this functionality.

BUG=138384
TEST=Ensure that Chrome makes an HTTP request to the Variations server when it receives an auto update.


Review URL: https://chromiumcodereview.appspot.com/10790116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150949 0039d316-1c4b-4281-b951-d872f2087c98

in the gpu process crashes.

BUG=none
R=apatrick
Review URL: https://chromiumcodereview.appspot.com/10837196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139965

Review URL: https://chromiumcodereview.appspot.com/10823187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150946 0039d316-1c4b-4281-b951-d872f2087c98

Add --local-server-port option that allows CNS to serve files from different server port.
This allows us to serve files from an available local Apache port.


BUG=140594


Review URL: https://chromiumcodereview.appspot.com/10824173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:11070

Review URL: https://chromiumcodereview.appspot.com/10834249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10855089
Patch from Armand Navabi <navabi@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138775
TEST=Visual


Review URL: https://chromiumcodereview.appspot.com/10827253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150939 0039d316-1c4b-4281-b951-d872f2087c98

Refactor CPM events to have a single JSON event for all extension-related
events; change EVENT_UNLOAD to EVENT_DISABLE (easier to understand, inline with
EVENT_ENABLE); clean up PerformanceMonitor::Observe.

BUG=130212

Review URL: https://chromiumcodereview.appspot.com/10837003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140417
TEST=units, out/Debug/chrome --disable-seccomp-sandbox --parallel-auth --login-manager --login-profile=user --log-level=0 --enable-logging=stderr --no-first-run --user-data-dir=/tmp/user --in-chrome-auth --scroll-pixels=3 --enable-smooth-scrolling --force-compositing-mode --force-device-scale-factor=2 --load-2x-resources

Review URL: https://chromiumcodereview.appspot.com/10829166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150937 0039d316-1c4b-4281-b951-d872f2087c98

This affect startup sequences only. 

BUG=134430
TEST=The dialog on win8 should appear without the main window.  If the user chooses not to make Chrome default, it should continue to desktop Chrome. 


Review URL: https://chromiumcodereview.appspot.com/10696093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150936 0039d316-1c4b-4281-b951-d872f2087c98

This resolves an issue where we were calling GetEntropySource too early before MetricsService::Start was called. Instead of checking the reporting_active member in MetricsService, we instead just check if the criteria for metrics reporting is allowed or not, ahead of time.

BUG=141628


Review URL: https://chromiumcodereview.appspot.com/10830241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150934 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10855038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110228

Review URL: https://chromiumcodereview.appspot.com/10825280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150929 0039d316-1c4b-4281-b951-d872f2087c98

related to how a flag was persisted.

BUG=141081,141643


Review URL: https://chromiumcodereview.appspot.com/10854069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=New test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150420

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150725

Review URL: https://chromiumcodereview.appspot.com/10825210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150927 0039d316-1c4b-4281-b951-d872f2087c98

The NaCL SDK builds this code with -Wswitch-enum -Werror so
this is failing to build.

Perhaps in light if this its best to just remove the default
case?

BUG=


Review URL: https://chromiumcodereview.appspot.com/10855056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150926 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the annotator required launching the script differently.

BUG=none
TEST=nacl mono buildbots

Review URL: https://chromiumcodereview.appspot.com/10829266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150925 0039d316-1c4b-4281-b951-d872f2087c98

The UI string should reflect the true nature of the date. The date is in fact when the Chrome OS image is built, not when it is installed on the device.

BUG=132561
TEST=locally verified on lumpy.


Review URL: https://chromiumcodereview.appspot.com/10824214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150924 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10826237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150923 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to round-trip from PepperPluginInfo to WebPluginInfo and back. This happens in the component updater when it registers Flash.

BUG=138902


Review URL: https://chromiumcodereview.appspot.com/10831224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150922 0039d316-1c4b-4281-b951-d872f2087c98

IPConfig interface.

BUG=chromium-os:33223,chromium:129052
TEST=built and tested with another in-process CL that will use it.


Review URL: https://chromiumcodereview.appspot.com/10824242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150921 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10834248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150920 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141503
TEST=Remove non-touch resource paks, no missing resources in renderers when touch optimized layout is used.

Review URL: https://chromiumcodereview.appspot.com/10827256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125937

Review URL: https://chromiumcodereview.appspot.com/10831240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150918 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10854063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150917 0039d316-1c4b-4281-b951-d872f2087c98

This removes dependency on ui::TouchEvent interface, and cleans up some parts of
the code.

BUG=125937

Review URL: https://chromiumcodereview.appspot.com/10832230

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125937

Review URL: https://chromiumcodereview.appspot.com/10829262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150915 0039d316-1c4b-4281-b951-d872f2087c98

We do some relatively minor changes to our policies and adopt
a baseline on which the GPU and Flash policies are now based.

We allow a few more syscalls than we used to to make our sandbox
more robust against library updates or rarely exercised codepaths.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10837156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150914 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10855076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150913 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10829258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150912 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the error was work_area in screen coordinates was passed to CalculateAttachedSizes while bounds is in |window()->parent()|'s coordinates.

BUG=139231
TEST=Set the 2nd display on left, open two windows and use multi window resizer on debug build, and check crash does not occur.

Review URL: https://chromiumcodereview.appspot.com/10836157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150911 0039d316-1c4b-4281-b951-d872f2087c98

Previously, I thought width was used in layout in render_text_linux.cc,
but it turns out that the width that's passed in to SetupPangoLayout()
gets cleared right after. So the width of the display rect does not
actually affect layout and thus does not need to cause the layout to
be reset.

BUG=137064
TEST=No behavior change.

Review URL: https://chromiumcodereview.appspot.com/10829261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150908 0039d316-1c4b-4281-b951-d872f2087c98

The original name was a misnomer. Looking at the code, the function
moves an entry from the root directory to another directory.

Along the way, remove if (!callback.is_null()) and PostTask() from
this and related functions.

BUG=126634, 139446
TEST=copying and moving of files on Drive work as before

Review URL: https://chromiumcodereview.appspot.com/10828238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150907 0039d316-1c4b-4281-b951-d872f2087c98

As titled, switches everything over to using the AudioBus
class instead of const std::vector<float*>.  Allows removal
of lots of crufty allocations and memsets.

BUG=114700
TEST=unit tests, layout tests, try bots.  Nothing should change.


Review URL: https://chromiumcodereview.appspot.com/10823175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150906 0039d316-1c4b-4281-b951-d872f2087c98

This applies the mmap workaround to all "Chrome" builds, since we're
also seeing the error on Chrome continuous branch builders, which aren't
marked as "Official" builds.

Review URL: https://chromiumcodereview.appspot.com/10823264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150905 0039d316-1c4b-4281-b951-d872f2087c98

This tool checks all third-party code used on Android, for the purposes of the Android WebView build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10816041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150904 0039d316-1c4b-4281-b951-d872f2087c98

The code paths have been different for quite some time without any new suppressions filed. In addition to that, I've landed a few patches that improve the thread safety of code in question!

BUG=46642,107181
TBR=timurrrr

Review URL: https://chromiumcodereview.appspot.com/10830250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150903 0039d316-1c4b-4281-b951-d872f2087c98