- 25 Jul, 2018 40 commits
-
-
Sahel Sharify authored
This reverts commit e459c6e9. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "fast/events/touch/gesture/* layouttests are using gpu benchmarking." > > This reverts commit cb66764a. > > Reason for revert: I re-wrote the flaky test. > > Original change's description: > > Revert "fast/events/touch/gesture/* layouttests are using gpu benchmarking." > > > > This reverts commit 8faf0805. > > > > Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103 > > > > Original change's description: > > > fast/events/touch/gesture/* layouttests are using gpu benchmarking. > > > > > > Bug: 846424 > > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 > > > Reviewed-on: https://chromium-review.googlesource.com/1144230 > > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#577727} > > > > TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org > > > > Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 846424 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Reviewed-on: https://chromium-review.googlesource.com/1150180 > > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577856} > > TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org > > Change-Id: I3b9fcc55c7449028646d5d83958c73ed8f878312 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846424 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1150240 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577897} TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I41e015730a5df25f74d991f011aa15376bfd70d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1150123Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577899}
-
Anita Woodruff authored
- Turns out these tests were failing because notification permissions were switched from info bars to modals a while ago and these tests were never updated. Bug: 853405 Change-Id: Ia663240507a7fa674f96170c4fdcbfdc9c028ec9 Reviewed-on: https://chromium-review.googlesource.com/1145309 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#577898}
-
Sahel Sharify authored
This reverts commit cb66764a. Reason for revert: I re-wrote the flaky test. Original change's description: > Revert "fast/events/touch/gesture/* layouttests are using gpu benchmarking." > > This reverts commit 8faf0805. > > Reason for revert: caused webkit layout tests failures. the first failure https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/22103 > > Original change's description: > > fast/events/touch/gesture/* layouttests are using gpu benchmarking. > > > > Bug: 846424 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2 > > Reviewed-on: https://chromium-review.googlesource.com/1144230 > > Commit-Queue: Sahel Sharify <sahel@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#577727} > > TBR=lanwei@chromium.org,nzolghadr@chromium.org,sahel@chromium.org > > Change-Id: I85c026c58b4a70626fe9c323c152b4ff92b455a0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 846424 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1150180 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577856} TBR=lanwei@chromium.org,kolos@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I3b9fcc55c7449028646d5d83958c73ed8f878312 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1150240Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b732b81e5520..e095b819400f git log b732b81e5520..e095b819400f --date=short --no-merges --format='%ad %ae %s' 2018-07-25 titovartem@webrtc.org Move g711 to proper third_party directory Created with: gclient setdep -r src/third_party/webrtc@e095b819400f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I138d9ee7e1f891ff0feb8cbd7eb1cce64dc3b7b6 Reviewed-on: https://chromium-review.googlesource.com/1150043Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577896}
-
Rohit Rao authored
We were changing to a bold weight font in collectionView:cellForRowAtIndexPath:. This was causing the text to reflow onto three lines instead of two, but the collection view didn't know that it needed to recompute cell heights, causing a rendering issue. This CL works around the issue by leaving the font at a normal weight, so that no text reflow occurs. BUG=864495 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3ec847752dbddad8460d27f4d051952bc46fa54f Reviewed-on: https://chromium-review.googlesource.com/1147144Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577895}
-
Stephen McGruer authored
It is possible for HTMLMarqueeElement::GetAnimationParameters to return a negative duration - this occurs when the <marquee> has no size but its 'mover' does. In this case we should not attempt to animate as this will just throw in TimingInput::Update (as a negative duration is invalid). Bug: 866289 Change-Id: Ifa0c2d2e8c717284670f7bddf8d350c174094f57 Reviewed-on: https://chromium-review.googlesource.com/1148887Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577894}
-
David 'Digit' Turner authored
The following CL contains a small fix required to ensure that it is possible to build app bundle for official Chrome builds, which require placeholders native libraries for older Android releases. BUG=820459 R=benmason@chromium.org,tiborg@chromium.org TBR=agrieve@chromium.org Change-Id: I1fa5999c808b11c248c854f6c5131c54996d9959 Reviewed-on: https://chromium-review.googlesource.com/1150173Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#577893}
-
Christopher Grant authored
These checks are not run automatically as many targets fail, but VR shouldn't fail. BUG= R=vollick Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0db508b58f9c02c85559fad4c32fd45659ee736d Reviewed-on: https://chromium-review.googlesource.com/1148980Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#577892}
-
Justin Novosad authored
This change removes the now useless copied reference that is retained by HTMLCanvas. This was useful back when the code used SkBitmap, which did not have copy-on-write semantics. BUG=753483 TBR=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibc047653cbe39f1a13f99f2f2fa16743ba1d3c05 Reviewed-on: https://chromium-review.googlesource.com/1148893 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#577891}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. Bug: 846456 Change-Id: I0739a803ff80c38df73632f62298f83bb90d28f8 Reviewed-on: https://chromium-review.googlesource.com/1095974Reviewed-by:
-
Ella Ge authored
When pointer is locked, we still need to check ShouldGenerateAppCommand and set event handled so that won't generate unnecessary navigate appcommand when kExtendedMouseButtons is enabled. This causes unable to preventDefault on mouse back/forward buttons to prevent navigation while pointer is locked. Bug: 852709 Change-Id: I5f75a68e36037210c38310f8d83825c5efdf311e Reviewed-on: https://chromium-review.googlesource.com/1148886 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#577889}
-
Tanja Gornak authored
The response format has changed. The CL implements the change on the client. * renaming "private_topic_name" property to "privateTopicName" Bug: 863816, 801985 Change-Id: I7e65b095c3764f73e928a0fa0a2fb5da461eb223 Reviewed-on: https://chromium-review.googlesource.com/1146725Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#577888}
-
Robert Flack authored
LayerTreeHostImpl::ScrollLayerTo and LayerTreeHostImpl::GetScrollOffsetForLayer looked up the cc::LayerImpl from the active tree by layer_id, however the caller knows the element id and this allows us to more directly look up the scroll node and ask the scroll tree directly. This moves us towards not needing layer ids in cc. Bug: 865973 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic279a95592071bbd93cd4c239a5a738b6041d292 Reviewed-on: https://chromium-review.googlesource.com/1145130Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577887}
-
Scott Haseley authored
Tab helpers are attached to prerender web contents, and as a result TabLoadTracker counts these web contentses as tabs. This CL adds additional tracking of non-UI tabs and adds Get*TabUiCount() methods that exclude non-UI tabs from counts. This CL also modifies CoreTabHelperDelegates to notify TabLoadTracker when tab contents are swapped. In that case, non-UI tabs are promoted to UI tabs. Bug: 861800 Change-Id: I3666b17634efd1445cd24cade8514fee06ad2c92 Reviewed-on: https://chromium-review.googlesource.com/1134504Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Stefan Zager authored
This is an updated version of this previously-reverted patch: https://codereview.chromium.org/150733002/ ... along with some fixes to the treatment of left-hand scrollbars in the layout code (the need for which was revealed by test failures). BUG=250514 R=skobes@chromium.org,eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icd2aa1b4d40aad1272c392366fdbde81a6830478 Reviewed-on: https://chromium-review.googlesource.com/1141332Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#577885}
-
Leonard Grey authored
Bug: 858944, 835983 Change-Id: Ia7908a1a199a1e537bf7ba7668116e018cbd4e61 Reviewed-on: https://chromium-review.googlesource.com/1144138Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
danakj authored
Any SharedBitmapIds registered with a CompositorFrameSink should be considered as destroyed by the renderer when the CompositorFrameSink is lost, as the renderer will treat them as so and will not report when they are deleted, and will re-register anything it wishes to reuse. This makes RenderWidgetHostImpl::RequestCompositorFrameSink() report all |owned_bitmaps_| as being deleted to the ServerSharedBitmapManager so that the same bitmaps are not re-registered, and bitmaps that are not reused are not leaked. R=piman@chromium.org Bug: 862584 Change-Id: I39fcbe49559f9d32eab3a52310b136f65a5f92ab Reviewed-on: https://chromium-review.googlesource.com/1148812Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#577883}
-
Xida Chen authored
The test: virtual/paint-touchaction-rects/fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html was marked flaky yesterday and a new bug was filed. There was actually an existing bug for this flaky test. This CL changes the bug number. No behavior change should be introduced. TBR=imcheng@chromium.org Bug: None Change-Id: Id37d6c075cda4a50a8b49d3dc71d78caeee65506 Reviewed-on: https://chromium-review.googlesource.com/1149988Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577882}
-
Peter K. Lee authored
Bug: 866927 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I25d41139da731ae998ac82e1643c8b261cf7b886 Reviewed-on: https://chromium-review.googlesource.com/1149700Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#577881}
-
Farah Charab authored
Provides support for fencing and throttling. Change-Id: I44d9e027fbf7e78deef1b8205c918a0eebfab503 Reviewed-on: https://chromium-review.googlesource.com/1146802Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577880}
-
Thomas Tangl authored
The number of settings-toggle-button elements on the personalization_options.html page changed with https://chromium-review.googlesource.com/c/chromium/src/+/1145315. This CL updates the test that checks this number. Bug: 867410 Change-Id: Ie4cca8a3305b1c8677a4e9a599ec531ff6fcab78 Reviewed-on: https://chromium-review.googlesource.com/1150157Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#577879}
-
Dmitry Gozman authored
This patch only removes unused includes and DEPS entries. Bug: none Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1c3c1456fbc6263ec7a93608fd7675a2a20eccb1 Reviewed-on: https://chromium-review.googlesource.com/1149417Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a default leading image to the omnibox to be used when it's being focused (before the first update of the leading image). There are two images: for the empty textfield (magnifying glass) and the non-empty textfield (default favicon). Bug: 865000 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib9869c3b87f81041ec8a13b0ac220a3b93aa521e Reviewed-on: https://chromium-review.googlesource.com/1146926Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577877}
-
Friedrich Horschig authored
This CL adds an image view to all usernames in the passwords accessory sheet which separates username/password groups visually. It also indicates the origin of the credentials. The icons are loaded by origin on the native side. If icons are requested multiple times, they will be grouped by origin and result in only one request to the FaviconService. Already requested icons are cached - when one of these is requested, the callback will return synchronously instead of async. Bug: 853748 Change-Id: Ia97c5c62710daf709d7ee19d732d2e226ac7634f Reviewed-on: https://chromium-review.googlesource.com/1138319Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#577876}
-
Yannic Bonenberger authored
This CL delays the execution of update() for an increasing amount of time if the calling worker doesn't control a client. The delay is reset every time a controller is added to the worker, or an event is dispatched. postMessage from service workers, |install| and |activate| don't reset the delay. Bug: 805496 Change-Id: I9c25ba4315ce6a915634ecdf6405db8774c40929 Reviewed-on: https://chromium-review.googlesource.com/900763 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577875}
-
Elodie Banel authored
Darkening anything under a 4.5 contrast ratio. Bug: 859651 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b56ca36d89e6d62a9104aaddf14e12f7c4b8e0a Reviewed-on: https://chromium-review.googlesource.com/1150159Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#577874}
-
tzik authored
The first reference to ConnectivityCheckerImpl used to made by base::Bind implicitly in the constructor. The reference is moved to a task runner, and released when the resulting callback object is destroyed. However, the posted task may be immediately destroyed if the PostTask failed, or the posted task may run soon before the constructor finished. That implies, `new ConnectivityCheckerImpl` may return a stale pointer. This CL adds a static constructor to ConnectivityCheckerImpl, and moves the setup code that touches ref count out of the ctor. Bug: 866456 Change-Id: I5ea6f7cf80175abb63f6318e454075f2678ff45d Reviewed-on: https://chromium-review.googlesource.com/1149437Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577873}
-
Jan Krcal authored
No actual implementation included, just the basic skeleton files and classes, the required plumbing and the associated feature toggle. Follow-up patches will introduce the actual implementation, to ultimately replace AutofillWalletMetadataSyncableService. This CL fixes a few omissions from an analogous CL 1147223: - ios specific code for getting the controller delegate, - getting the delegate in ProfileSyncComponentsFactoryImpl. Bug: 853688 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibfef1455df0d1a94aa56d34a8c838a9ac43fa5f4 Reviewed-on: https://chromium-review.googlesource.com/1148575Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577872}
-
Javier Ernesto Flores Robles authored
Removes autofill dependency from passwords. This was not used and removing it prevent a dependency cycle in a following CL, where manual fill uses some parts from this component. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I576ac73b8d31dfb112d65af034caab807016e3a8 Reviewed-on: https://chromium-review.googlesource.com/1148880Reviewed-by:
-
Philip Jägenstedt authored
The existing kHTMLLinkElementDisabled counter is poisoned by the reflected IDL attribute, as pointed out by bz: https://github.com/whatwg/html/issues/3840#issuecomment-407275073 Change-Id: Ic4917290475f1ad6d9baba06620a485b78edac59 Reviewed-on: https://chromium-review.googlesource.com/1148203Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#577870}
-
Farah Charab authored
Sequence manager fuzzer test is causing an overflow when posting tasks with big delays and durations. This patch fixes that. Bug: 863345 Change-Id: Ie2709c4fe2eff9d668946de7fb33f10812eb0262 Reviewed-on: https://chromium-review.googlesource.com/1146928Reviewed-by:
-
Aaron Leventhal authored
When focus moves from UI back into content, but the same content element is focused as was previously, an accessibility event must be fired for the caret location change, as it is no longer in the UI. This fix assists screen magnification software that must track the caret location. Bug: 864563 Change-Id: Ie9cc745288c124ddd73a54906c41dc16e07b9ff6 Reviewed-on: https://chromium-review.googlesource.com/1140199Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577868}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/715cc238d24b..b732b81e5520 git log 715cc238d24b..b732b81e5520 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 oprypin@webrtc.org Limit iOS bots to use machines that have 'xcode_version' dimension 2018-07-25 nisse@webrtc.org Add spatial index to EncodedImage, not yet used. 2018-07-25 nisse@webrtc.org Delete obsolete file call/video_config.h. 2018-07-25 titovartem@webrtc.org Move fft to proper third_party directory 2018-07-25 sakal@webrtc.org Move cropAndScaleI420 to JavaI420Buffer. 2018-07-25 buildbot@webrtc.org Roll chromium_revision e56ee1dd..deb63e97 (577600:577752) 2018-07-24 buildbot@webrtc.org Roll chromium_revision 83a1a9ed..e56ee1dd (577482:577600) Created with: gclient setdep -r src/third_party/webrtc@b732b81e5520 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:867367,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5416fe26428055da909e81c0865c1c2f6ffcefc8 Reviewed-on: https://chromium-review.googlesource.com/1150041Reviewed-by:
-
Joshua Peraza authored
03abd1bb3497 mac: Tolerate the new flavor of weird cl_kernels modules on 10.14 98ebb0060b3e Add whitespace file e50ea6032180 Make BuildHandlerArgvStrings() return its result 3af81d7012e4 DEPS: Use gclient's native cipd instead of runhooks c11c8833f78f Add ProcessSnapshotMinidump::ProcessID() 2418cb8fbef8 Make upload report metrics optional 0909bee2e26c linux: Fix broken tests with address sanitizer 2f3a8b8f72dc Add CrashSkippedReason::kPrepareForUploadFailed Change-Id: Iefdaf2365615586fec6f4dcefc4f857e6e166074 Reviewed-on: https://chromium-review.googlesource.com/1148933Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#577866}
-
Reza.Zakerinasab authored
virtual/gpu/fast/canvas/canvas-blending-color-over-image.html timouts. NOTRY=true TBR=fserb@chromium.org BUG: 866850 Change-Id: I100893337485277667c10e788464bac66e2d8868 Reviewed-on: https://chromium-review.googlesource.com/1149992Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577865}
-
Mikel Astiz authored
Prior to this patch, base::PostTaskAndReplyWithResult() required ReplyArgType to expose a default constructor AND and an assigment operator, because the implementation constructed a temporary value first before it was overriden by the task's reply. There's however no fundamental reason to require any of this, since the only consumed value is the one returned by the task, which is guaranteed to run before the reply task, which is the only reader. We do however need some reserved memory to store the result of the task, so we leverage std::unique_ptr which satisfies both needs, and allows a straighforward migration. Note that base::Optional would have been more idiomatic, but it doesn't compile on iOS for certain callers, due to C++ unions being incompatible with iOS reference counting. Change-Id: I8b1946364fe7baa56451a351ee8dc94ca7231c76 Reviewed-on: https://chromium-review.googlesource.com/1146185Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577864}
-
Marcin Wiacek authored
Change-Id: Ia7ebdaec2b425da08aae6a7d2c36ade1e75c3808 Reviewed-on: https://chromium-review.googlesource.com/1146188 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577863}
-
Sylvain Defresne authored
The variable account_info is moved into std::map::emplace() and thus should not be accessed after that method is called as the state after a move is undefined. Current code appears to work because by defining an explicit copy constructor on AccountInfo, the implicit move constructor is not generated by the compiler. This use after move was found after adding an explicit move constructor to AccountInfo that caused a DCHECK to fail (as account_info member std::string are empty after being moved). Bug: none Change-Id: I096d89e40d09a934eb213173f4b491c151433d7b Reviewed-on: https://chromium-review.googlesource.com/1149867 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577862}
-
Georges Khalil authored
This reverts commit 448c3822. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove unused rlz_lib::SendFinancialPing variant > > Another driven-by CL, that removes an unused method. > > TBR=rogerta@chromium.org > > Change-Id: If7853aad29c007bd8aac5784b4994064d89d8e16 > Reviewed-on: https://chromium-review.googlesource.com/1149621 > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#577854} TBR=rogerta@chromium.org,tonikitoo@igalia.com Change-Id: I78570c02309379c4cfff49b3c40bc3378992acad No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1150122Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#577861}
-
stkhapugin@chromium.org authored
Adds a flag to the animation orchestrator to ignore all calls when there is an animation in progress. Bug: 866858 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic8990b0c60083723d9e6727538293480cc42b9a6 Reviewed-on: https://chromium-review.googlesource.com/1150143Reviewed-by:
-
