GitLab

Adds GYP targets that dictate which tests should be run on the
builders, and scripts to generate lists of the targets and commands
to run (with filters or other options as needed).

R=lcwu@chromium.org,gusfernandez@chromium.org
BUG=409163

Review URL: https://codereview.chromium.org/719353005

Cr-Commit-Position: refs/heads/master@{#304963}

BUG=434478

Review URL: https://codereview.chromium.org/726373005

Cr-Commit-Position: refs/heads/master@{#304962}

We currently use a mixture of ints and uint16s for port numbers.  This triggers a variety of "value possibly truncated" warnings on MSVC (currently disabled) wherever we implicitly truncate.  Fix this by using uint16 consistently through more functions.  (Using int consistently would be more problematic as the majority of third-party/system APIs that use port numbers use 16-bit types for them.)

By far the majority of these changes are fallout from changing IPEndPoint, which is widely used; it'd be difficult to split this CL up into smaller pieces :(

Note that I didn't use uint16_t to avoid introducing inconsistencies between existing uint16 usage and new uint16_t usage.  Conversion of everything to uint16_t can happen later.

This CL was reviewed and approved in pieces in the following CLs:
https://codereview.chromium.org/716223002/
https://codereview.chromium.org/717263003/
https://codereview.chromium.org/717373002/
https://codereview.chromium.org/718273002/
https://codereview.chromium.org/722503002/
Committing as TBR to the original reviewers.

BUG=81439
TEST=none
TBR=gunsch,cpu,jhawkins,davidben,jyasskin,mmenke

Review URL: https://codereview.chromium.org/655063002

Cr-Commit-Position: refs/heads/master@{#304961}

Change from setting QUIC's ack timer to 0ms when any handshake packet is
received to setting it when the handshake is confirmed on the client
side.

Merge internal change: 80306847
https://codereview.chromium.org/742823005/

Preparation for Chrome experiment to enable bandwidth resumption.
Protected behind FLAGS_quic_enable_bandwidth_resumption_experiment

Once this CL is in, I intend to add a Chrome experiment to add the
connection option kBWRE to a small percentage of connections to test the
effect of turning on BW resumption.

If a client provides a previously cached bandwidth estimate (that is
recent, and from the same serving region), then set initial CWND based
on this data.

Behavior change only when both the flag is true, and the Chrome
experiment adds the connection option to client handshakes.

A followup CL (78446219) will add varz to track the distribution of
resulting initial CWNDs.

Merge internal change: 80239310
https://codereview.chromium.org/737153002/

Changes QUIC's SentPacketManager to pass in HAS_RETRANSMITTABLE_DATA to
the SendAlgorithm for FEC packets, so that the SendAlgorithm can count
FEC packets towards congestion control.

Merge internal change: 80171666
https://codereview.chromium.org/731863007/

Record the last packet send time before we start sending the packet

Problem:

Every time QuicConnection sends a new packet, it records the time that
the packet was sent.  It passes this information to the
QuicSentPacketManager, which ultimately stores the information in the
TransmissionInfo.sent_time for the packet.

Later, when the QuicSentPacketManager receives an ack for the packet,
it retrieves its TransmissionInfo and takes a sample of the current
RTT as follows:

rtt_sample = ack_receive_time - transmission_info.sent_time

Previously, QuicConnection was recording the packet "sent_time" as the
time that WritePacket completes.  The problem with this approach is
that the write itself may pause the thread or take a long time.  In
this case, transmission_info.sent_time will be artificially inflated.
When that inflated value is subtracted from the ack time, as above, it
will cause the current RTT sample to become artificially small.

An artificially small RTT will affect our current estimate of the min
RTT, which we currently cannot recover from.  The min_rtt will be
pinned to the aberrant value.

Solution:

Changed the code to record the sent_time as the time that the write
begins.  The drawback of this approach is that any extra send time
will be temporarily factored into our smoothed-RTT calculations.  The
advantage is that it will prevent artificially small RTTs from setting
the min_rtt forever.

Added a corresponding test, which exercises this scenario by
artificially advancing the clock during the write.

Change QUIC to record send timestamp prior to write. Protected by
FLAGS_quic_record_send_time_before_write.

Merge internal change: 80138676
https://codereview.chromium.org/740793002/

Remove a QUIC LOG(DFATAL) that validly occurs when two packets are
queued.

This may occur when the internal server is write blocked when an two
packet REJ is written.

Merge internal change: 80124025
https://codereview.chromium.org/736053002/

Tighten up a QUIC LOG(DFATAL) for packets expected to have a non-zero
nack count.

If the packet is never sent, it never gets nacked, but that wasn't taken
into account.

Merge internal change: 80120917
https://codereview.chromium.org/735353002/

Use override instead of virtual..override in ./net/quic/... and
./net/tools/quic/...

C++11 in Chromium!

$ find .../quic/ \( -iname \*.h -o -iname \*.cc \) -print -exec clang_tidy {} -checks='-*,misc-use-override' -fix \;

Merge internal change: 80111599
https://codereview.chromium.org/741773002/

Log the SNI and UAID fields in handshake messages as quoted strings.

Merge internal change: 80005106
https://codereview.chromium.org/735933002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/744433003

Cr-Commit-Position: refs/heads/master@{#304960}

The failure seems to have been triggered from the recent
gtest update.  The exact revision seems to be:
https://code.google.com/p/googletest/source/detail?r=693

The issue only effects builds made with our older
gcc 4.4 toolchain. Neither asan nor valgrind report any
issues with the linux run of this test, and PNaCl build
also passes just fine so I'm assuming is a compiler bug
in the older toolchain.

The fix I found was to use "const char*" over "char []"
for local string constants.  In fact just adding a const
alone and leaving the [] syntax also fixes the issue.

Most likely there is an underlying compiler bug that
still needs to be addressed.

BUG=434821

Review URL: https://codereview.chromium.org/740023002

Cr-Commit-Position: refs/heads/master@{#304959}

We don't need this anymore, because the list sub-commands in run_benchmark
will stay where it is.

R=tonyg@chromium.org,dtu@chromium.org
BUG=421276

Review URL: https://codereview.chromium.org/731253003

Cr-Commit-Position: refs/heads/master@{#304958}

R=lcwu@chromium.org,damienv@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/741823004

Cr-Commit-Position: refs/heads/master@{#304957}

In preparation for lucid sleep, we will be putting all chrome renderers
that do not host GCM extensions into a special freezer cgroup.  All
processes in this cgroup will be frozen when the system suspends and
will not be thawed until the system has fully resumed.

The code to freeze and thaw the cgroup has existed for a while.  This
code actually starts putting processes into the cgroup.

Additionally, to deal with potential races that may occur with other
suspend observers that interact with renderers, the RendererFreezer is
no longer a PowerManagerClient::Observer but is instead a
PowerManagerClient::RenderProcessManagerDelegate.  This guarantees that
the RendererFreezer's suspend related methods will be called only after
all observers have reported ready and before observers are notified that
the suspend has completed.  Any race conditions that still exist now
need to be fixed in the observer that is causing it.

BUG=364339

Review URL: https://codereview.chromium.org/738993002

Cr-Commit-Position: refs/heads/master@{#304956}

R=lcwu@chromium.org,gfhuang@chromium.org
BUG=336640

Review URL: https://codereview.chromium.org/731933005

Cr-Commit-Position: refs/heads/master@{#304955}

This is a minimum change to allow easy cherrypicking to m40.  Much
more code needs to be removed to completely rid the menu of this.

BUG=434608

Review URL: https://codereview.chromium.org/740093002

Cr-Commit-Position: refs/heads/master@{#304954}

BUG=433380

Review URL: https://codereview.chromium.org/734843002

Cr-Commit-Position: refs/heads/master@{#304953}

Revert of Revert of [Base] Use variadic template in callback_list.h (wave 1) (patchset #1 id:1 of https://codereview.chromium.org/663083005/)

Reason for revert:
We now don't support building with MSVC Express any more. Do shout if this change causes problems for your compiler, though.

This is part of http://crbug.com/433164

Original issue's description:
> Revert of [Base] Use variadic template in callback_list.h (wave 1) (patchset #1 id:1 of https://codereview.chromium.org/618573002/)
>
> Reason for revert:
> Breaking compilation on windows with MSVC Express.
>
> Original issue's description:
> > [Base] Use variadic template in callback_list.h
> >
> > Replace pump.py generated base/callback_list.h with variadic template version.
> >
> > BUG=None
> >
> > Committed: https://crrev.com/a28756fae426023c53542f08c1bf80397a28f677
> > Cr-Commit-Position: refs/heads/master@{#298529}
>
> TBR=ajwong@chromium.org,tzik@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=None
>
> Committed: https://crrev.com/69e698364a0a82a806fc5a4994c5f2040d1ff083
> Cr-Commit-Position: refs/heads/master@{#300487}

TBR=ajwong@chromium.org,tzik@chromium.org,lfg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/744503002

Cr-Commit-Position: refs/heads/master@{#304952}

BUG=434231
TEST=Verified on clapper device.

Review URL: https://codereview.chromium.org/738613003

Cr-Commit-Position: refs/heads/master@{#304951}

This is the second half of the new APIs.

BUG=429052
TEST=bots
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/735173003

Cr-Commit-Position: refs/heads/master@{#304950}

I don't see any page_cycler regression locally so I'll try
to enable this on trunk as the nex step.
This change doesn't turn this on Windows to keep the scope of
possible trouble small.

BUG=377980
R=viettrungluu@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/664413003

Cr-Commit-Position: refs/heads/master@{#304949}

Replace pump.py generated base/callback.h with variadic template version.

BUG=433164

Review URL: https://codereview.chromium.org/610423003

Cr-Commit-Position: refs/heads/master@{#304948}

The warning has been fixed in sqlite upstream 3 years ago, but apparently we
haven't updated sqlite to a version that has this 3 year old commit.

BUG=340757,82385
R=shess@chromium.org

Review URL: https://codereview.chromium.org/742783005

Cr-Commit-Position: refs/heads/master@{#304947}

This includes ExtensionsClient and ExtensionsBrowserClient.

BUG=none
TEST=app_shell_unittests

Review URL: https://codereview.chromium.org/717233003

Cr-Commit-Position: refs/heads/master@{#304946}

Only new change:
fed7b07  Update clang warning flags. by Nico Weber - 42 minutes ago master

BUG=82385

Review URL: https://codereview.chromium.org/738063003

Cr-Commit-Position: refs/heads/master@{#304945}

When Init fails, further Save/Load calls should just fail (and not
crash). This makes the underlying LevelDB properly handle the Init failed case
and adds tests for that.

Adds LevelDB::InitWithOptions to make it easy to have the Init fail in tests.

Review URL: https://codereview.chromium.org/735823004

Cr-Commit-Position: refs/heads/master@{#304944}

Media source codec names will appear in chrome://media-internals
and be recorded by the PipelineStatus histogram.

BUG=431447

Review URL: https://codereview.chromium.org/743483002

Cr-Commit-Position: refs/heads/master@{#304943}

This CL adds browser_tests which run on nacl_helper in Non-SFI mode
to the nacl_helper_nonsfi, too.
As nacl_helper in Non-SFI mode is in prod, the existing tests are
kept as is, and duplicated for the nacl_helper_nonsfi rather than
switching.
Along with the change, PPAPIPrivateNaClPNaClNonSfiTest.FILEIO_Private is fixed. (The fixture was wrong).

BUG=358465
TEST=Ran trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32

Review URL: https://codereview.chromium.org/724323002

Cr-Commit-Position: refs/heads/master@{#304942}

1. Consolidated ApiTestsAudio (and api_tests_audio.*) into ApiTests (and api_tests.*).
2. Removed checks for WinXP, since the real problem is likely this: http://crbug.com/177163
3. Removed duplication.
4. Minor comment clean-ups/additions.

BUG=294431,326319

Review URL: https://codereview.chromium.org/734853003

Cr-Commit-Position: refs/heads/master@{#304941}

The downstream cleanup CL is https://chrome-internal-review.googlesource.com/#/c/184696/ .

BUG=428823

Review URL: https://codereview.chromium.org/739073002

Cr-Commit-Position: refs/heads/master@{#304940}

Currently we support both audio and video. Updated some names and comments to
better reflect this.

BUG=410451
TEST=Naming and comment change only.
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/742943002

Cr-Commit-Position: refs/heads/master@{#304939}

The default message size limit 4MB is too small for Chrome IPC.

TEST=Layout Tests with a flag on
BUG=377980
R=viettrungluu@chromium.org, jam@chromium.org, nasko@chromium.org

Review URL: https://codereview.chromium.org/741813002

Cr-Commit-Position: refs/heads/master@{#304938}

Review URL: https://codereview.chromium.org/714413006

Cr-Commit-Position: refs/heads/master@{#304937}

This class must be deleted on the main thread.

BUG=356540

Review URL: https://codereview.chromium.org/738193002

Cr-Commit-Position: refs/heads/master@{#304936}

Revert of Attempt #4 to convert telemetry to the typ framework. (patchset #2 id:20001 of https://codereview.chromium.org/743463003/)

Reason for revert:
Sorry, this broke the bot:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16871

Original issue's description:
> Attempt #4 to convert telemetry to the typ framework.
>
> This switches telemetry to use the typ python testing framework,
> which should allow us to run tests in parallel.
>
> The prior attempt was foiled by tools/chrome_proxy not having been
> updated; this attempt includes that change.
>
> R=dtu@chromium.org
> BUG=388256
> =
>
> Committed: https://crrev.com/9af6a9ac4b74e30551554793991a1e99db82aa66
> Cr-Commit-Position: refs/heads/master@{#304878}

TBR=dtu@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=388256

Review URL: https://codereview.chromium.org/730183003

Cr-Commit-Position: refs/heads/master@{#304935}

"test" and "debug" automatically run install, as they required running install before being usable anyways - running them with outdated versions installed did not work.  This makes the standard build then run workflow from other platforms work for cronet as well.

Also add "build-test" and "build-debug" commands, for added convenience.

BUG=none

Review URL: https://codereview.chromium.org/740783002

Cr-Commit-Position: refs/heads/master@{#304934}

Following macros are conflicted with khronos header.
GL_COMMANDS_ISSUED_CHROMIUM
GL_GET_ERROR_QUERY_CHROMIUM
GL_LATENCY_QUERY_CHROMIUM
GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM
GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM

The hex code of them is changed to 0x600_ which is unused range.

In addition, make build_gles2_cmd_buffer.py detect the collision.

Review URL: https://codereview.chromium.org/715983004

Cr-Commit-Position: refs/heads/master@{#304933}

Revert of Fix regression in chrome_proxy tests caused by switching to typ. (patchset #1 id:1 of https://codereview.chromium.org/741823003/)

Reason for revert:
Sorry, this quick-fix didn't work:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16872

Original issue's description:
> Fix regression in chrome_proxy tests caused by switching to typ.
>
> When I switched telemetry to use typ in #304878, I missed that
> the chrome_proxy tests depended on the perf package as well.
>
> TBR=dtu@chromium.org, tonyg@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=388256
>
> Committed: https://crrev.com/0bb7170445d0eb1be8a2215b7446c66e95345cc8
> Cr-Commit-Position: refs/heads/master@{#304901}

TBR=dtu@chromium.org,tonyg@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=388256

Review URL: https://codereview.chromium.org/738163003

Cr-Commit-Position: refs/heads/master@{#304932}

Modify pull-to-refresh drag movement, as well as the initial activation
animation, to more closely align with the default Android platform
effect.

BUG=428429

Review URL: https://codereview.chromium.org/733273004

Cr-Commit-Position: refs/heads/master@{#304931}

zip::ZipReader::OpenFromPlatformFile.

zip::ZipFiles and zip::ZipReader::OpenFromPlatformFile do not want to
take ownership of the passed-in file. On POSIX, dup the file descriptor
to pass to fopen, so that that we can safely fclose the result. On
Windows, stop closing the file handle. Fix consumers of these functions
that assumed ownership was being passed to instead close the file
themselves.

BUG=430959

Review URL: https://codereview.chromium.org/683913009

Cr-Commit-Position: refs/heads/master@{#304930}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/725243005

Cr-Commit-Position: refs/heads/master@{#304929}

Add unit tests.

BUG=423954

Committed: https://crrev.com/79602d53643589ef1ce19cb115b1c91df4d5789f
Cr-Commit-Position: refs/heads/master@{#304448}

Review URL: https://codereview.chromium.org/729833002

Cr-Commit-Position: refs/heads/master@{#304928}

Provides a method _ForEachCpu which runs a specified operation on
each CPU file on the device. It is efficient, as all of the commands
are executed using a single shell script on the device (as it was
already done for some of the methods); and now also more robust, as we
get the exit status of each individual command run.

BUG=433056

Review URL: https://codereview.chromium.org/732473003

Cr-Commit-Position: refs/heads/master@{#304927}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/04ddf89..ac1383d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=humper@google.com

Review URL: https://codereview.chromium.org/740803002

Cr-Commit-Position: refs/heads/master@{#304926}

kCodecPCM_ALAW has been added to media/base/audio_decoder_config.h, but not to histograms.xml

BUG=none

Review URL: https://codereview.chromium.org/730983004

Cr-Commit-Position: refs/heads/master@{#304925}

Height and color of Separator now can be specified during creation

R=sky@chromium.org
BUG=434395

Review URL: https://codereview.chromium.org/736613002

Cr-Commit-Position: refs/heads/master@{#304924}