- 22 Feb, 2019 40 commits
-
-
Miyoung Shin authored
- unsigned short -> int32_t for code consistency. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I787179e2cfdcae7e3fdd01c43ec0f4f5c2d44c2b Reviewed-on: https://chromium-review.googlesource.com/c/1478311Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634465}
-
Pedro Amaral authored
Added a null check before trying to destroy the TabThemeColorProvider in ChromeActivity. Bug: 934183 Change-Id: If1a9de3664adc24d669f6208eb337e2837d38138 Reviewed-on: https://chromium-review.googlesource.com/c/1480723Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#634464}
-
bsheedy authored
Previously, the XR tests automatically ran JavaScript in the first tab opened in the browser. With this change, they will now automatically run in whatever the currently visible/active tab is. For most cases, this doesn't actually matter since there's only one tab open, but the new behavior is both more intuitive and more common. Also drive-by changes the more verbose way of opening Incognito tabs to the newer helper method in the test framework. Bug: 931420 Change-Id: I9e78aa0663bc432e4eb22f2461329aa82b017d91 Reviewed-on: https://chromium-review.googlesource.com/c/1479390Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634463}
-
Alex Clarke authored
This leak was introduced by https://crrev.com/c/1462801/ where there was a confusion between MessageLoop and MessageLoopBase (surprisingly the former owns the latter). This patch fixes the leak and generally clarifies ownership. We still need to change base::Thread::Options::task_environment to be a std::unique_ptr but that's a larger refactor. Change-Id: Ic5380df2fb9dca5cb0818ce8e8b90e05192c6e9d BUG: 933925, 934088, 933014, 932857 Reviewed-on: https://chromium-review.googlesource.com/c/1480462 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#634462}
-
Dominic Mazzoni authored
Bug: 934145 Change-Id: I3d98f29a60bd8093b026c9f22d1c05964201b18c Reviewed-on: https://chromium-review.googlesource.com/c/1481133 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634461}
-
Nate Fischer authored
This implements CookieManager#setCookie for the network service code path, plumbing SetCanonicalCookie through AwCookieManagerWrapper. Along with this change, this re-implements #setCookie for the legacy code path, to use SetCanonicalCookieAsync instead of SetCookieWithOptionsAsync (to share code between the new and old code paths). This splits apart a test, which I found to be useful when debugging (since the "good URL" and "bad URL" case are actually quite different). This removes a bunch of tests from the test filter, and adds in new breakages (mainly due to #hasCookies() not being implemented yet). This also updates some TODOs, to point at finer-grained crbugs I've filed since the last CL. Bug: 933460, 931641, 902641, 933462, 893580 Test: run_webview_instrumentation_test_apk -f=CookieManagerTest#* \ Test: --enable-features=NetworkService,NetworkServiceInProcess Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I3f29a209aa9a442d273b8673c01848801f298ee8 Reviewed-on: https://chromium-review.googlesource.com/c/1478470Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634460}
-
Johann authored
BUG=chromium:911658 R=dalecurtis@chromium.org Change-Id: I14ba3e2ec67b2cfb0349507dfbf65480ef1b08ba Reviewed-on: https://chromium-review.googlesource.com/c/1481119Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#634459}
-
Maggie Cai authored
Currently there are some display issues for rtl ui direction in All Sites. This CL fixes the issues. BUG=835712 Change-Id: Id752009d822dc9cbab2d6fe47d1b4d6a59fea75b Reviewed-on: https://chromium-review.googlesource.com/c/1477621 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#634458}
-
Ryan Hansberry authored
The |authToken_| property needed to be explicitly bound. Bug: 933974 Change-Id: I7b0ec1d2d4750460f437137f8441ff1413a3345d Reviewed-on: https://chromium-review.googlesource.com/c/1481090Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#634457}
-
Yuwei Huang authored
This CL enables no_chromium_code and disables chromium_code on gRPC's fuzzer targets, so that we can later add the -Wextra-semi flag. R=thakis Bug: 926235,933949 Change-Id: I2b887774087992981a2eef69015ed529906015a9 Reviewed-on: https://chromium-review.googlesource.com/c/1481601 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634456}
-
Eric Orth authored
Also: *Update deprecation comments on legacy API methods now that they are untested. *Added a new-API test for changing priority. Support was added a while back, but I must've forgotten to add a test. *Some minor TODO cleanups for tests that already exist. Will not commit this until confirming all non-test usage of the legacy API is gone (should just be waiting for crrev.com/c/1446780 to land). Bug: 922699 Change-Id: Ia5afe66883baaf3b321f3195e1fd4ff109e00ddf Reviewed-on: https://chromium-review.googlesource.com/c/1479750Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#634455}
-
Jinsuk Kim authored
ba412ea Fix -Wextra-semi warnings. 3e65e9d Use `uint32` instead of `uint` d4931c4 Fix unittest 3404a63 Merge pull request #9 from Baklap4/fix/warnings 5299bca Fixed warnings, removed unused variables / code Test=gclient sync, make Bug: 926235 Change-Id: Ibd9b7ded766be6c7b16f6b62c3140af624b5f715 Reviewed-on: https://chromium-review.googlesource.com/c/1481280Reviewed-by:
-
Jay Harris authored
Previously, the accessibility text for saturated badges (e.g. 99+ for badge values greater than 99) was the full number (e.g. 125). Accessibility recommended that we update the text to match what is displayed on the badge, as the consistency can be helpful to those with low vision. Bug: 719176 Change-Id: Ide81d0dd6f51b0ac2571944db05bd64c00682d90 Reviewed-on: https://chromium-review.googlesource.com/c/1480290Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#634453}
-
Tanya Gupta authored
Created a JNI layer (SendTabToSelfAndroidBridge) for SendTabToSelfBridge. SendTabToSelfAndroidBridge is called from SendTabToSelfShareActivity where it lives for the duration of the Activity. Bug: 921767 Change-Id: Ibf8da3fb1d192cb4c79b19dc0a0a98b66c49c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/1449211 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#634452}
-
Jun Mukai authored
The bug report looks like WindowTree calls CancelDragLoop with nullptr. This means GetWindowByTransportId returns nullptr -- I guess the window is gone during the drag&drop loop. Other methods in WindowTree (e.g. PerformDragDrop and PerformWindowMove) check this validity, so this CL adds the same validation on CancelDragDrop. Bug: 934260 Test: none Change-Id: I99fcc370b95ed49deee3ff031ed262ff6b52a655 Reviewed-on: https://chromium-review.googlesource.com/c/1481857 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#634451}
-
Kelvin Jiang authored
Bug: 932768 Change-Id: I5ac7d615ff5dfd84d94c1171dbe0176c3742aa58 Reviewed-on: https://chromium-review.googlesource.com/c/1478107 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634450}
-
Yuwei Huang authored
wrap_memcpy.cc wraps the system memcpy function and breaks the Android trybots. We are not using old libc so I don't think we need to build this file. R=rsesek, joedow Bug: 934522 Change-Id: Iba0d4ef7727b24f7f23c68bab9aa5fb00cb3f277 Reviewed-on: https://chromium-review.googlesource.com/c/1481993 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#634449}
-
David Tseng authored
Change-Id: Id5bc5e4ad89882a10342b23a68db10d8b9872d4a Reviewed-on: https://chromium-review.googlesource.com/c/1481905Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634448}
-
Anand K. Mistry authored
Some fileManagerPrivate APIs use a subclass of ChromeAsyncExtensionFunction to time and log long-running API calls. To help migrate off ChromeAsyncExtensionFunction, create another subclass that inherits from UIThreadExtensionFunction directly. BUG=934541 Change-Id: I1e715ca6a063ac186f73d45ce1eaa1fbf9825263 Reviewed-on: https://chromium-review.googlesource.com/c/1481131 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634447}
-
Fabrice de Gans-Riberi authored
This is the first part of a mass renaming of files and associated classes for consistency. All the files under //fuchsia/engine are parts of the Fuchsia WebEngine and not the WebRunner. The renaming is done in 2 parts to preserve git history across the file renames. Bug: 922635 Change-Id: I8432bd4c5d787569cc2fc5820c04a971120ca636 Reviewed-on: https://chromium-review.googlesource.com/c/1479416Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#634446}
-
David Benjamin authored
In the network service path, the extensions onAuthRequired hook is implemented up in LoginHandler, rather than deep in the NetworkDelegate. This causes it to inherit the login prompt deduplication logic, which results in strange behavior for an extension. Fix this by only deduplicating after the extension stuff is resolved, matching the pre-network-service behavior. This also fixes the test that was disabled in issue #928465. (Mostly. That test is still making some *slightly* incorrect timing assumptions, but this no longer makes the issue net-svc-specific, so remove the test suppression and add a TODO to the effect.) Also add a regression test. In doing so, generalize retval_function to control when the callback is called, and fix a bug around finding the right retval_function to use. Bug: 931479, 928465 Change-Id: I0431b115f64f145ed4201b8944e86b56994ec1fd Reviewed-on: https://chromium-review.googlesource.com/c/1469289 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634445}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bb7f07652a6..3d86ff86d744 git log 9bb7f07652a6..3d86ff86d744 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 scroggo@google.com Remove SK_SUPPORT_LEGACY_ANDROID_CODEC_COLORSPACE 2019-02-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-21 egdaniel@google.com Return correct GrBackendFormat when ycbcr conversion is valid. 2019-02-21 reed@google.com add gm for aa gamma 2019-02-21 mtklein@google.com remove linear sRGB singleton 2019-02-21 bsalomon@google.com SK_API SkExecutor Created with: gclient setdep -r src/third_party/skia@3d86ff86d744 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123377741 TBR=jvanverth@chromium.org Change-Id: Ic7e0b31cfa892d56fd67d05b3c6c34e216399a5f Reviewed-on: https://chromium-review.googlesource.com/c/1480987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634444}
-
Wez authored
This reverts commit 7da3d9df. Reason for revert: Looks like my review comments raced with Kevin's LGTM and landing - sorry. :( Reverting since I'm asking for a FIDL change, so once we push this we can't fix it up without more soft-transitioning. Original change's description: > [Fuchsia] Update some FIDL APIs to be extensible. > > This creates chromium.web.CreateContextParams2 and > chromium.web.LoadUrlParams2 as FIDL tables, which are extensible. All > the call sites for the previous APIs are also updated. The original > APIs will be removed in a future CL when all out-of-tree callers for > them will have been updated. > > Bug: 931831 > Change-Id: I15ba10012734daa57cdb6034bbaade1253715e0c > Reviewed-on: https://chromium-review.googlesource.com/c/1476184 > Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634435} TBR=wez@chromium.org,kmarshall@chromium.org,fdegans@chromium.org Change-Id: If592b2fb73941e57af5b253d8e040e18f6559771 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931831 Reviewed-on: https://chromium-review.googlesource.com/c/1480728Reviewed-by:
-
Robbie McElrath authored
This test times out when the network connection type is already at its expected starting value before the test checks. Change-Id: I034dc25c883247bbf1ee11fadf8c1c7f24b11941 Reviewed-on: https://chromium-review.googlesource.com/c/1481808 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634442}
-
Joel Hockey authored
We can't be sure at any given time that the VM has not restarted and that a non-persistent share is still shared. So we will not register them as shared. If we happen to take an action on the file more than once, there is little harm to (re)attempt to share the path. Bug: 925973 Change-Id: Ie3a4b4a3009c5846cd31754c2b642f2a369cebb4 Reviewed-on: https://chromium-review.googlesource.com/c/1481183 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#634441}
-
Hector Carmona authored
Bug: 934440 Change-Id: I3242df2f77fb92e289942e4967a4cb5c06092e19 Reviewed-on: https://chromium-review.googlesource.com/c/1481855Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#634440}
-
Boris Sazonov authored
This CL fixes a crash on older Android devices that occurs when SyncAndServicesPreferences settings page is shown. This was introduced in https://crrev.com/c/1459616 by specifying a vector drawable as an icon for a Preference row. As vector resources on older Android versions require Support Library to work, the drawable has to be set in the code. Bug: 934363 Change-Id: I7113e383b94ab911ad2f4da46c6b2f81a71a428c Reviewed-on: https://chromium-review.googlesource.com/c/1481324 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Daniel Rubery authored
This reverts commit 8010592e. This CL explicitly initializes the file and directory count, so that we don't have undefined behavior when sending the results by IPC. Bug: 926586 Change-Id: Ic6ac4da2741de0085191536049cf4a543667dbfe TBR: meacer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1481892 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634438}
-
Zhenyao Mo authored
Whether we run built-in pages or run with URL of external sites, after this CL, tests go down the same path. 1) For built-in pages and crosvideo site, we run requestFullscreen on the parent node of the video. 2) For other sites, we try to locate a fullscreen button and click it. Both option 1) and 2) require user_gesture bit to be set to work. BUG=867155 TEST=bots, manual R=magchen@chromium.org Change-Id: I17ff6f8b425a74a0639085ea2051d6a0851804dc Reviewed-on: https://chromium-review.googlesource.com/c/1480973 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634437}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/42800babca08..45d4beab9980 git log 42800babca08..45d4beab9980 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 crouleau@chromium.org Use the correct path for zipping. 2019-02-21 pasko@chromium.org android_platform_backend: use crashpad_stackwalk 2019-02-21 crouleau@chromium.org Remove Keystone from Telemetry reference build binaries before upload. 2019-02-21 benjhayden@chromium.org Hide empty tag-filter. 2019-02-21 benjhayden@chromium.org Add missing import in spa/timeseries-descriptor.html 2019-02-21 benjhayden@chromium.org Add missing import to spa/cp-loading.html. 2019-02-21 sadrul@chromium.org speed: Use gzip compression for trace data. 2019-02-21 skyostil@chromium.org android_startup_metric: Add more diagnostic measurements 2019-02-21 sadrul@chromium.org speed: Look only for the appropriate devices/browsers. Created with: gclient setdep -r src/third_party/catapult@45d4beab9980 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:932615,chromium:925453,chromium:932615,chromium:918193,chromium:918193,chromium:918193,chromium:932409,chromium:863341,chromium:932409 TBR=sullivan@chromium.org Change-Id: I0bd463804070b70b882580ccaedd288de280a4bc Reviewed-on: https://chromium-review.googlesource.com/c/1481069Reviewed-by:
-
Fabrice de Gans-Riberi authored
This creates chromium.web.CreateContextParams2 and chromium.web.LoadUrlParams2 as FIDL tables, which are extensible. All the call sites for the previous APIs are also updated. The original APIs will be removed in a future CL when all out-of-tree callers for them will have been updated. Bug: 931831 Change-Id: I15ba10012734daa57cdb6034bbaade1253715e0c Reviewed-on: https://chromium-review.googlesource.com/c/1476184 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634435}
-
Chris Lu authored
Creates FindInPageManagerTest to test FindInPageManager and FindInPageManagerDelegate. Bug: 919685 Change-Id: Ia9b680582677f984dd9b775155f8f21b0285b768 Reviewed-on: https://chromium-review.googlesource.com/c/1448912 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634434}
-
Johannes Henkel authored
In |step5|, |text| ends with a UTF16 low surrogate, so text is invalid Unicode, and this is as designed, since the Javascript console must be able to deal with invalid Unicode as Javascript allows unbalanced surrogate characters. Unfortunately, the test only asserted the number of UTF16 characters, not the actual characters preserved. Now we assert that |text| ends with a particular character, '\uD835' which is a low surrogate, the exact same one that was second to last in the original input |str| in TestRunner.evaluateInPagePromise(...) above. The test will thus fail if somehow this invalid UTF16 payload runs through a UTF8 transcoder and back, as such transcoders have no way to preserve unbalanced surrogate pairs - they will typically replace them with a mark for "invalid character", so then what comes back in |text| is valid UTF16, which won't have a hanging low surrogate. Change-Id: I0efedc84f6eb4f6570714e67e49ee44ffa309a7f Reviewed-on: https://chromium-review.googlesource.com/c/1481952 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#634433}
-
Lukasz Anforowicz authored
This is a reland of https://crrev.com/c/1441277 that - Trims the test down in a speculative attempt to avoid test flakiness (I verified that the test still fails without the corresponding changes in TranslateHelper::Translate) - Adds logging statements to the test, to help in case trimming of the test doesn't address the flakiness. The original CL description follows below. Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457 Tbr: John Abd-El-Malek <jam@chromium.org> Tbr: Daniel Cheng <dcheng@chromium.org> Change-Id: If03198d98a3c78031718eecb21ec1ae39db5530f Reviewed-on: https://chromium-review.googlesource.com/c/1481535Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#634432}
-
Jimmy Gong authored
- Implements Net::NetworkChangeNotifier::NetworkChangeObserver to SmbService. - Optimizes the workflow of host name resolution by calling on host discovery whenever a network change is discovered, rather than only running host discovery on an error returned by StartReadDirectory. Bug: 922273 Test: manual end to end Change-Id: I6544c169fb1aa91ebd7d19fe22d854930ae4a928 Reviewed-on: https://chromium-review.googlesource.com/c/1464651 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#634431}
-
Tatiana Buldina authored
Change-Id: I85c051d9d71ae9eb1cd6a3d6d64de9017239bb9b Reviewed-on: https://chromium-review.googlesource.com/c/1479305Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#634430}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/962c222aa3be..ee4fa0785090 git log 962c222aa3be..ee4fa0785090 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 timvp@google.com Reland "Create Container ANGLE APK" Created with: gclient setdep -r src/third_party/angle@ee4fa0785090 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I71ef244c526a9b8bae430e72b7467b1c0b7ee111 Reviewed-on: https://chromium-review.googlesource.com/c/1481000Reviewed-by:
-
tby authored
See here for context: https://docs.google.com/document/d/1GTQ3vvrszK4I1pDzmTFb6krmUzAXox0V9ZIqIi_GH1E/edit?usp=sharing We are expanding Roselle to re-rank the results returned when the user enters a query. However, these results include Arc app shortcuts as well as apps themselves, so they need to be ranked. This CL gives the shortcut search provider access to the Roselle model, for future use in training/ranking. Bug: 931149 Change-Id: I826be986a98d870de21ecd9c88f5a266c5d0308e Reviewed-on: https://chromium-review.googlesource.com/c/1478570 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634428}
-
Xianda Sun authored
Bug: 874919 Change-Id: Ie4f550e1dcc98e5f8375ab13ade31de4143dc0ab Reviewed-on: https://chromium-review.googlesource.com/c/1474331Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#634427}
-
Giovanni Ortuño Urquidi authored
Install events are recorded regardless of the install result so move the call to record them before the FinalizeInstall call. Bug: 915043 Change-Id: I5b43e697137471a195fa9909706ce567ac43e56f Reviewed-on: https://chromium-review.googlesource.com/c/1481148Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#634426}
-
