GitLab

BUG=204944
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23462008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221686 0039d316-1c4b-4281-b951-d872f2087c98

The fixture of ID is needed not only for WAPI -> DriveAPI
but also for WAPI -> FakeDriveService.

BUG=285614

Review URL: https://chromiumcodereview.appspot.com/23670006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221685 0039d316-1c4b-4281-b951-d872f2087c98

This adds the output device id to places where we already have an input device id.
On windows we now support a non-default device id in the WASAPI implementation.

BUG=276894
R=henrika@chromium.org

Review URL: https://codereview.chromium.org/23466008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221684 0039d316-1c4b-4281-b951-d872f2087c98

These were removed from skia and aren't used here in Chromium, so lets remove
them now.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23548012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221681 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284998
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23462023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221679 0039d316-1c4b-4281-b951-d872f2087c98

Following long discussion at https://chromiumcodereview.appspot.com/23129027/
it's better to keep infrastructure team dealing with all reviews in here.

BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23814005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221677 0039d316-1c4b-4281-b951-d872f2087c98

This adds "Hide <app>" to the app menu that is shown when an app window
has focus. This also enables the Cmd+H shortcut. 

This also adds an IPC message to instruct the shim to hide.

This also adds a command ID for Hide and a corresponding tag to
MainMenu.xib.

BUG=168080, 276052
TEST=Start an app.
Press Cmd+H or select Hide from the main menu. The app should hide.
Clicking the app's dock icon, or Cmd+Tab to the app should show it again.

Review URL: https://chromiumcodereview.appspot.com/23514021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221676 0039d316-1c4b-4281-b951-d872f2087c98

Suppression the problems on the build bots: There were two reasons why that CL broke the build tree. One is the size bloating, which was solved by https://codereview.chromium.org/23460018. The other is compiling error on ARM, and this was also solved by updating CLD2 (https://chromiumcodereview.appspot.com/23606017/). 

--

Use Finch to compare the performances of CLD1 and CLD2

Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.

By this CL, each platform will have the below status:

Linux:    Use both CLD1 and CLD2 (and use Finch).
Mac OS X: Use both CLD1 and CLD2 (and use Finch).
Windows:  Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
iOS:      Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
Android:  Still use only CLD1. (The same reason as iOS)

So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)

BUG=240647

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221380

Review URL: https://chromiumcodereview.appspot.com/22867032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221675 0039d316-1c4b-4281-b951-d872f2087c98

> Switch to doing user-resizing via system for panels on Mac
> 
> We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems.
> 
> Also removed EnableResizeByMouse which is not really used in our code.
> 
> BUG=282652,282657
> TEST=manual test by user-resizing panels
> 
> Review URL: https://chromiumcodereview.appspot.com/23918002

TBR=jianli@chromium.org

Review URL: https://codereview.chromium.org/23922003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284400

Review URL: https://chromiumcodereview.appspot.com/23935004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221673 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes an 'autocomplete-suggest' element which wasn't fixed in the previous patch(r220270) and adds some comment.

BUG=280928
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23465011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221672 0039d316-1c4b-4281-b951-d872f2087c98

* Add a method to populate database with initial data.
* Add a test for it.

BUG=240165

Review URL: https://chromiumcodereview.appspot.com/23582013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178304
TEST=FileSystem{,Dir}URLRequestJobTest.*
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23494028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221670 0039d316-1c4b-4281-b951-d872f2087c98

Sending a (TRIM_MEMORY_COMPLETE) memory pressure signal to free some
memory (v8,sqlite,image decoding caches) when the last WebView instance
is destroyed.

BUG=284362
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23888003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221669 0039d316-1c4b-4281-b951-d872f2087c98

> Initial chrome.mdns API.
> Currently just implements the API layer which allows adding a listener and defines a manifest key to specify mdns service types to watch.
> 
> BUG=280900
> TBR=erg
> 
> Review URL: https://chromiumcodereview.appspot.com/23437015

TBR=justinlin@chromium.org

Review URL: https://codereview.chromium.org/23945003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221668 0039d316-1c4b-4281-b951-d872f2087c98

R=danakj

Review URL: https://chromiumcodereview.appspot.com/24015002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285402
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23684031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221666 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221665 0039d316-1c4b-4281-b951-d872f2087c98

This change also contains chrome-side changes to
handle the renaming of the PNaCl toolchain folder
within the NaCl SDK.

This pulls in the following Native Client changes:

r12099: (shcherbina) Add custom tempfile prefix to old validator targeted tests.
r12100: (stichnot) Fix and harden error reporting in the report parser.
r12101: (stichnot) Exclude ms_struct_pack_layout.
r12102: (ncbray) Enable validation caching on ARM.
r12103: (petarj) [MIPS] Enable validator tests
r12104: (halyavin) Fix copy paste error in the log message.
r12105: (khim) Support precise toolchain trybots/buildbots
r12106: (kschimpf) Update pnacl llvm revisions
r12107: (stichnot) Fix breakage when running the LLVM regression tests.
r12108: (jvoung) Handle unicode as strings instead of lists in the pnacl driver env setmany.
r12109: (khim) Fix precise64 toolchain bots
r12110: (jvoung) Turn off allow_double again, for callingconv test on arm-nacl-gcc.
r12111: (kschimpf) Update pnacl llvm revisions.
r12112: (bradnelson) Temporarily remove breakpad from DEPS in order to move it.
r12114: (bradnelson) Clobbering the breakpad directory.
r12115: (petarj) [MIPS] Fix expectations for mips_test_read_only_regs
r12116: (sbc) Roll newlib toolchains in TOOL_REVISIONS.
r12117: (petarj) [MIPS] Remove unneeded checks for TLS register
r12118: (bradnelson) Pull in all of breakpad for crash dump testing.
r12119: (sbc) Rename PNaCl toolchain folder within the SDK.

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://chromiumcodereview.appspot.com/23576014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221664 0039d316-1c4b-4281-b951-d872f2087c98

Jinja2 (used in Blink scripts in Source/core and Source/bindings) has
been updated to 2.7.1 (from existing 2.6); see changelog.
http://jinja.pocoo.org/docs/changelog/

The specific new features in this release that are useful are:
* keep_trailing_newline
* lstrip_blocks
...which make it easier to control whitespace, making templates easier to read.
(Specifically it lets us easily indent control blocks.)
* selectattr (allows filtering lists in template, simplifying Python code)

In the Changelog these are referred to as:
Added support for keeping the trailing newline in templates.
Added finer grained support for stripping whitespace on the left side of blocks.
Added map, select, reject, selectattr and rejectattr filters.

BTW, 2.7 is the first Jinja2 major release in 2 years;
2.7.1 is a bugfix release:
2.7   2013-05-20
2.7.1 2013-08-07

This upgrade introduces a new dependency (on Windows), due to the safe string class being factored out into a separate library.
Thus depends on separate CL:
Add MarkupSafe library to third_party (dependency for Jinja2 2.7)
https://codereview.chromium.org/23445019/
This has been committed as r221578:
https://src.chromium.org/viewvc/chrome?view=rev&revision=221578

TBR=cpu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23506004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221663 0039d316-1c4b-4281-b951-d872f2087c98

I missed to apply ChildProcessSecurityPolicy to receive side. Blink
needs additional sysex filter per MIDIAccess object.

BUG=163795
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221662 0039d316-1c4b-4281-b951-d872f2087c98

This change removes the code to conditionally fetch scope information,
which sometimes would sometimes display the scopes at the wrong time.

ExtensionInstallPrompt never needs to fetch or approve OAuth scopes
itself. The Identity API passes in a list when necessary, and also
takes care of all grants.

BUG=277117

Review URL: https://chromiumcodereview.appspot.com/23978007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221661 0039d316-1c4b-4281-b951-d872f2087c98

IBusEngineServiceDaemonlessImpl.  This CL deletes IBusEngineServiceImpl which is
no longer used.

BUG=275262

Review URL: https://chromiumcodereview.appspot.com/23766008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221660 0039d316-1c4b-4281-b951-d872f2087c98

* Base name duplication is handled and should be tested in ResourceMetadata.
* OpenFile's behavior can be tested in OpenFileOperation.

Along the way did some clean up.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23606018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=273827

Review URL: https://chromiumcodereview.appspot.com/23961002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221658 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221657 0039d316-1c4b-4281-b951-d872f2087c98

Updated usrsctp to latest version (to 8603) with fixes upstream. Fixed usrsctp gyp file; removed overides. 

usrsctp update = 8554:8603

Review URL: https://chromiumcodereview.appspot.com/23960004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221656 0039d316-1c4b-4281-b951-d872f2087c98

When the user opts to "Manage billing details" and changes the default payment
instrument (credit card) or shipping address, select the new default in the
requestAutocomplete dialog UI.

BUG=266010
TEST=unit_tests
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23930002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221655 0039d316-1c4b-4281-b951-d872f2087c98

Wrote proper documentation for PP_VARTYPE_ARRAY and PP_VARTYPE_DICTIONARY. These
previously said that they are not currently supported, but they are.

For PP_VARTYPE_STRING, added note that AddRef and Release must be used.

Review URL: https://chromiumcodereview.appspot.com/23757014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221654 0039d316-1c4b-4281-b951-d872f2087c98

> Re-enable TouchCursorInTextfieldTest with some fixes and logs
> 
> Re-enabled TouchEditableImplAuraTest.TouchCursorInTextfieldTest with two
> fixes:
>  - Changed focus_textfield() in touch_seleciton.html to collapse
>    selection after focus, since nothing should be selected after
>    focusing the textfield.
>  - Added a wait between dragging the handle and getting the cursor
>    position in the test to be sure that the cursor position is updated
>    completely.
> Also, added some logs in the test so that if it failed again, more data
> is available for investigation.
> 
> BUG=235991
> 
> Review URL: https://chromiumcodereview.appspot.com/23823004

TBR=mohsen@chromium.org

Review URL: https://codereview.chromium.org/24032002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221653 0039d316-1c4b-4281-b951-d872f2087c98

Include two of our internal scripts (event_bindings and schemaUtil) as sources
for runtime errors.  Add tests for same.

BUG=21734

Review URL: https://chromiumcodereview.appspot.com/23923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221652 0039d316-1c4b-4281-b951-d872f2087c98

We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems.

Also removed EnableResizeByMouse which is not really used in our code.

BUG=282652,282657
TEST=manual test by user-resizing panels

Review URL: https://chromiumcodereview.appspot.com/23918002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221651 0039d316-1c4b-4281-b951-d872f2087c98

This is remaining part of r221334, because during its code review,
VolumeManager was actively being changed so that it was kept as is to avoid
conflict.

BUG=273386
TEST=Ran unit_tests

Review URL: https://chromiumcodereview.appspot.com/23892008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221650 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221649 0039d316-1c4b-4281-b951-d872f2087c98

September 2013 invalidation client release

- Add support for OAuth2 to Android network channel

BUG=264503

Review URL: https://chromiumcodereview.appspot.com/23603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221648 0039d316-1c4b-4281-b951-d872f2087c98

Folder shortcut is launched, since we no longer need to switch the feature.

BUG=none
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/24026002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221647 0039d316-1c4b-4281-b951-d872f2087c98

CWS widget team requested to pass the access token by the 'initialize' message.

BUG=none
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23494024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221646 0039d316-1c4b-4281-b951-d872f2087c98

r186536 made it so focus focus changes while capture held are
ignored. Problem is we enter this scenario when activating a
window. In particular the window has capture, then we activate it but
the activation is ignored because it has capture. In this case we need
to allow the focus change else events are completely dropped.

BUG=277593
TEST=covered by tests
R=ananta@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23892006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221645 0039d316-1c4b-4281-b951-d872f2087c98

From the bug report and the other relevant bug 236392 reported by ASan,
The problem arises when ReadData() had some errors or completed, and then freed
the NetworkStats, but later the callback of the Write() is started on the freed
object. This most likely happened when the initial ReadData() had some errors.
So I did two modifications.
1. For the first time when ReadData is called, I checked the return value.
Only if it is ERR_IO_PENDING, it continues to Send requests.
2. The Write() callback is on a WeakPtr. If the NetworkStats object is freed,
the callback will be a no-op.

BUG=273917

Review URL: https://chromiumcodereview.appspot.com/23875004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221644 0039d316-1c4b-4281-b951-d872f2087c98