- 17 Jan, 2020 40 commits
-
-
Leonard Grey authored
This reverts commit 561bf1af. Reason for revert: Strongly suspect this is causing failures on the debug builders: [29058:775:0117/070736.663833:ERROR:CONSOLE(49)] "Mocha test failed: PersonalizationOptionsTests_AllBuilds signinAllowedToggle Error: Uncaught TypeError: Cannot read property 'PRIVACY_CHROME_SIGN_IN' of undefined (chrome://settings/privacy_page/personalization_options.js:102) r732804 was reverted earlier for the same reasons, but there are still failures coming from the settings code, albeit less Original change's description: > More Settings Page Interaction UMA > > Move the settings enum and the call to uma to a separate browser proxy. > > Add UMA to all site settings subpage interactions and new toggles moved to the main settings card > > Bug: 1032584 > Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651 > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732785} TBR=dbeam@chromium.org,harrisonsean@chromium.org Change-Id: Id4ee78d89487ecf7e6d1935088d02b29de89c7c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007829Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#732870}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ba0d9547be17..c33c078292af git log ba0d9547be17..c33c078292af --date=short --first-parent --format='%ad %ae %s' 2020-01-17 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-16 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@c33c078292af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I3357d7fc30c68f16a5561a8f9979abd2b3e51019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007849Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732869}
-
Rouslan Solomakhin authored
Card class (debit, prepaid, credit, unknown) where used only for "supportedTypes" field of Payment Request, which has been removed. Bug: 981907 Change-Id: I4348f6d2e09975a3e5e4ec9aa5a0407916269a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005091Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732868}
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/264997 Change-Id: Ibd6ce3367d8df772ef2ea8d83b1779428f82ab0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007509Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#732867}
-
sandromaggi authored
Before this change, the WebContents were read from the model. After this change they are passed directly, coming from the Client. Bug: b/144681042 Change-Id: I0588d89c7a00d5baa8cd4d96797d881395dd2fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002617 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732866}
-
Mikhail Khokhlov authored
This will allow running TBMv3 metrics on Windows. Bug: 990304 Change-Id: Id53fe61c931b36b386e6feea461447657ca24f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005008 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Deepanjan Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732865}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9da16439..b7cd486d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifac5aa9f23b67382f51ba47f869178d1cc8dbe1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007610Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732864}
-
Michael van Ouwerkerk authored
Bug: 1042707 Change-Id: I6243c8dc6fd151738aac5c23e90968ab53f7e6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002627Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732863}
-
arthursonzogni authored
The goal is to merge all the ContentSecurityPolicy structure defined in both content:: and network::mojom. This patch substitute the content:: ones by the network::mojom ones for IPCs. See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: I43256dc304628ed715ba3b8206450cde0b2755aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000640 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#732862}
-
Anna Malova authored
Bug: 989667 Change-Id: Ie1b407aaea377736f87f07560ad04b83f9fba901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942268 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#732861}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by me. Bug: 1041419 Change-Id: I4dc096337fe543a8ff2d027d95323f521989000f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007768Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732860}
-
Rouslan Solomakhin authored
Before this patch, a service worker on Android that declared support for "interledger", "basic-card", and one URL-based payment method would receive a "canmakepayment" event from a Payment Request for "interledger". This patch skips sending "canmakepayment" to the service worker on Android if the Payment Request is only for standardized payment methods. After this patch, "canmakepayment" events are sent only for URL-based payment methods (that have been explicitly verified). Bug: 1040994 Change-Id: I3d908e6b6e628b3ca7290adfed394a7be6041f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994305Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732859}
-
Stepan Khapugin authored
Moves AppNavigation protocol implementation to SceneController. Bug: none Change-Id: I41732781203fae618ce5b5651a1f3be47576a816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002521Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732858}
-
Owen Min authored
The callback will be invoked when the notification is closed. It also returns whether the notification is closed by user action or not. Bug: 1006899 Change-Id: I339fc43e32c1ab101957867a9d871b479fa9d060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003339Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732857}
-
dalyk authored
This is a reland of 778c2799 Tests that rely on configuring secure mode now either use the managed pref store or temporarily mark the environment as "not managed" to prevent the mode from being downgraded to off. Original change's description: > Have DNS prober diagnose secure DNS config issues. > > When the current DNS config is in secure mode, the corresponding DNS > runner will also use secure mode as well as the preconfigured DoH > servers. There is no change to the behavior when the current config > is in automatic mode. > > A new probe error code, DNS_PROBE_FINISHED_BAD_SECURE_CONFIG, is > returned in secure mode in cases where DNS_PROBE_FINISHED_BAD_CONFIG > would have previously been returned. > > Bug: 1037931 > Change-Id: I253963e86b309790e38959cda2c2e014ddceb9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981014 > Commit-Queue: Katharine Daly <dalyk@google.com> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730553} Bug: 1037931 Change-Id: I910080c0bc3cf759d04b060bd955fd86f29db156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998918Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#732856}
-
Marc Treib authored
In some situations, PerUserTopicSubscriptionManager should (or should not!) invalidate an existing access token. This CL adds tests for this behavior, which also required some changes to the identity test code, to expose which access tokens were invalidated. Bug: 1020117 Change-Id: Iaef29cdcf3072064b476432ee3fc6bdcb8040388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003136Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#732855}
-
Alexander Hendrich authored
This CL allows all login screen extension to specify a custom content security policy in their manifest. Bug: none Change-Id: I043e21c72c00326ffecb1b6b318249379a0aece5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000917Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#732854}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d58b643f10f5..9b1ec5f072a5 git log d58b643f10f5..9b1ec5f072a5 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7b91502cd7f..41f6150edb16 (20 commits) 2020-01-17 fmalita@chromium.org [skottie] Add custom props rendering GM Created with: gclient setdep -r src/third_party/skia@9b1ec5f072a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I20673c95f4ae9555fe8f7740a47ead5265624fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007594Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc8279d66c81..c9f42ad909c0 git log fc8279d66c81..c9f42ad909c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 srte@webrtc.org Simplifies transport overhead mechanism in Scenario test framework. 2020-01-17 saza@webrtc.org Remove unused AEC delay offset API 2020-01-17 hbos@webrtc.org ResourceAdaptationModule HasInputVideo+DegradationPreference setters. 2020-01-17 peah@webrtc.org Reland "Replace the ExperimentalAgc config with the new config format" Created with: gclient setdep -r src/third_party/webrtc@c9f42ad909c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5157cea9673dd5979c29787204e5678963040bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007591Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8b49e5d8. With Chromium commits locally applied on WPT: 62f8d5f0 "Enable Scroll To Text by default" 363313c0 "Sort the registrations returned by getRegistrations() by registration ID." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ifff3aaace72b7afbaa5430e3d6495ef52f911f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007609Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732851}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d4405431bad0..c6d670ac06ee git log d4405431bad0..c6d670ac06ee --date=short --first-parent --format='%ad %ae %s' 2020-01-17 khokhlov@google.com [Telemetry] Set a clock snapshot on Android Created with: gclient setdep -r src/third_party/catapult@c6d670ac06ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:990304 Tbr: rmhasan@google.com Change-Id: I590f9426897f503ff42cb28223df035304c6d926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007593Reviewed-by:
-
Jit Yao Yap authored
Currently, |login_screen_ui::UiHandler| only closes the login screen UI window when the extension is uninstalled, and not when it is unloaded. When an extension is updated, the old instance is unloaded and not uninstalled. This means when an update occurs when the old instance has a window open, this window will not be closed, and the new instance will not be able to open another window. This CL updates |UiHandler| to also close the window when the extension is unloaded. Bug: 957573 Change-Id: If586fa5cc83fca20d971e85080389d013b854e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002610 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#732849}
-
Yifan Luo authored
This CL separates 'require-trusted-types-for' from 'trusted-typs' Content Security Policy directive, which currently has only one injection sink 'script'. https://w3c.github.io/webappsec-trusted-types/dist/spec/#require-trusted-types-for-csp-directive Bug: 1030257 Change-Id: I1c241c5b6be318aa195323178cf974df138d5788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993351 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#732848}
-
Koji Ishii authored
This CHECK was added to investigate the dirty layout found at crbug.com/965976 <crrev.com/c/1626349>. This patch turns this to NOTREACHED to mitigate users. Bug: 1038735 Change-Id: Id544874fd5ec3c0805bd28fb615b8378351fd276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006832Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732847}
-
Maksim Ivanov authored
Improve variables naming and comments. Bug: 1012892 Change-Id: I72aa8b832711041bc71f0aff3742306beaeb7ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003177Reviewed-by:
-
anina koehler authored
There is a device policy for setting the Chrome OS release channel. The update daemon reads and honors this policy. Chrome does not need to get involved. It still tries though, calling GetUpdateEngineClient::SetChannel, which produces a spurious error message as the method is no longer meant to be used in an enterprise context. Bug: 991109 Change-Id: Ia5007581b91846eaecb9f270de09a790f41cc9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007630Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ce9f521465e1..b46e6c2fa626 git log ce9f521465e1..b46e6c2fa626 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 5fc197dc7669..2cb1db08e5f1 (2 commits) 2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src ab883b9d257e..41a96d15fd99 (5 commits) 2020-01-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 4792a6854238..b6ac1e60cd3a (3 commits) Created with: gclient setdep -r src/third_party/angle@b46e6c2fa626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: Ifbd397d33f9bf08a6f652c0c93b03db1a3c7fcaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007589Reviewed-by:
-
Kurt Horimoto authored
This is a reland of 19619799 Original change's description: > [iOS] Roll MDC to dc9529ad1077730cb7a57b05b77c9260d027b6d4 > > Bug: 1034144 > Change-Id: I8f69bae933c264839a60f4ce7c9cb6ac04249895 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003391 > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732628} Bug: 1034144 Change-Id: I5d8888ab30a9ae60018f547808575588d0ccb6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007628Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#732843}
-
Bo Liu authored
Do this by changing the default implementation to true for OS_ANDROID. This also allows removing the android webview override. Bug: 1038894 Change-Id: I1be3c680a32116bc8867958d85f89ad5302a525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006208 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732842}
-
Koji Ishii authored
Following bot results are included. 990 991 992 994 995 996 997 1000 1002 1003 1004 1005 1006 1007 1008 1009 1011 91 lines were removed and 16 lines were deflaked by consecutive results since 991. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Id5ed79b5a9ca348c5113f1d1caa9311538cb2446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002553Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#732841}
-
Maksim Ivanov authored
This fix part 1/2 for the bug with the bad spinner being displayed after the end of the SAML login. This fixes a race between multiple pieces of code changing screen-gaia-signin's |isLoadingUiShown_|. These races led to the "please wait" spinner not being shown in some cases. In particular, one race condition was between (a) setting this flag to true after the successful authentication (done by onAuthCompleted_()) and (b) setting it to false when the authenticator completely loads a third-party page (done by onAuthReady_()). Before this. CL, the flag could stay "false" after the SAML authentication, due to "(b)" happening after "(a)" (after fully loading the Gaia's /programmatic_auth_chromeos page). The fix is to get rid of direct overwrites of the |isLoadingUiShown_| property from different places, and instead make it computed from a few variables that track independent states. Bug: 1024253 Test: perform SAML login on a slow device, verify that after less than a second the "Please wait" spinner is shown Change-Id: I8a9d3dbb859ca4c4bf87e0f9b595ae9410d7937b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000627Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#732840}
-
Jan Wilken Dörrie authored
This reverts commit bc295819. Reason for revert: Breaks browser_tests on Mac10.13 Tests (dbg): https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/16788 Original change's description: > [SyncSteup]: Change Sync everything to a radio behaviour. > > As part of friendly settings, this CL implements changing |sync > everything| from check box to radio button. The motivation behind this > work is to clarify to users the difference between |Sync everything| > checked and |Sync everything| unchecked but all single data types > checked. > > Screenshot: > http://screen/TuwQcMx3dmk > > Bug: 1035421 > Change-Id: I4f9db188a6b324d18c5d17a5dfca6b9d70e0b1ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995328 > Commit-Queue: Monica Basta <msalama@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732804} TBR=dbeam@chromium.org,msalama@chromium.org Change-Id: Ifddfa0873d756f23059b90b5ce95743091c0d048 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007213Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732839}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07335b60..9da16439 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb59252fe95c6717d58ae45ba115c250139bf2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007608Reviewed-by:
-
Raymond Toy authored
The HRTF response size can some times be smaller than the FFT size. This can happen if the FFT size has a lower limit, such as for PFFFT which clamps the size to the lower bound. To account for this, create a new HRTF response that is zero-padded to the FFT size. Manually tested against repro cases from the bugs; ASAN issue no longer reproduces. Bug: 1032000, 1041411 Change-Id: Ic2136a92a6e1bf4f2f78f434b065c21dc1b72b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003571Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732837}
-
Rob Buis authored
Update some title descriptions and provide a proper stylesheet resource for link-dnsprefetch-in-css.html. Bug: 456173 Change-Id: I06d2982ded73d6be1e1c9a829c764e3e4a4dfc90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002871Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#732836}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b39daad9ba0c..d8628858c150 git log b39daad9ba0c..d8628858c150 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d8628858c150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1fa6de85ff6d26faf48ca050ab970915a7d18464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007588Reviewed-by:
-
Ehimare Okoyomon authored
Moved the strings used both in the new tab page and desktop site settings page to NTP string file, in order to be able to add more 3P cookie controls consistency between desktop and android. Bug: 1040091 Change-Id: I3953c6003e57db53b7459662534f6a9e77af0d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005068Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#732834}
-
Clemens Arbesser authored
This change makes above classes independent of SelectPopup, which will allow reuse of those widgets in other parts of Chrome. Specifically, they will be used in autofill_assistant for the selection of time slots and similar information. This is a refactoring only; there are no user-facing changes. Bug: b/147577012 Change-Id: Id2d981345640ecf3b201ad4b64e0b5e2c3145426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002620 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#732833}
-
Rouslan Solomakhin authored
Chrome status: https://chromestatus.com/feature/5709702556024832 Intent to remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5gxzhdS1KNs/Fs-Bvz4iAQAJ This patch also cleans up the card type (i.e., prepaid, debit, credit, unknown) from Chrome, because it was only ever used for "supportedTypes" parameter of "basic-card" payment method name. Bug: 981907 Change-Id: Ib0e89a0b68217565cc5e4a97310d0055d74d08c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980751 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732832}
-
arthursonzogni authored
Merge: - content::CSPDisposition - blink::ContentSecurityPolicyDisposition - blink::WebContentSecurityPolicyDisposition Along the way, mojoifying it into network::mojom::CSPDisposition. deleted files: - content/common/content_security_policy/csp_disposition_enum.h - third_party/blink/public/platform/web_content_security_policy.h See UnifyCSP: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao Bug: 1021462 Change-Id: Ic7a018978ae525d66172e70aa88accb878621b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002570 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
